evb_rk3399: add usb ohci definations
PATCH 1/1 evb_rk3399: add usb ohci definations
Problem: not possible to use CONFIG_USB_OHCI_HCD=y and CONFIG_USB_OHCI_GENERIC=y options without CONFIG_USB_OHCI_NEW and CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS definations
Add missed definations.
--- include/configs/evb_rk3399.h | 3 +++ 1 file changed, 3 insertions(+)
include/configs/evb_rk3399.h +3 -0
@@ -15,4 +15,7 @@#define SDRAM_BANK_SIZE (2UL << 30) +#define CONFIG_USB_OHCI_NEW +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2 +#endif
Signature · 1 line
2.25.1
Hi Artem,
Quoted 5 lines · Artem Lapkin
Problem: not possible to use
CONFIG_USB_OHCI_HCD=yandCONFIG_USB_OHCI_GENERIC=yoptions withoutCONFIG_USB_OHCI_NEWandCONFIG_SYS_USB_OHCI_MAX_ROOT_PORTSdefinationsAdd missed definations.
But , evb_rk3399 board does not enable CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC.
Thanks,
- Kever
Quoted 18 lines
Signed-off-by Artem Lapkin <[email protected]>--- include/configs/evb_rk3399.h | 3 +++ 1 file changed, 3 insertions(+)include/configs/evb_rk3399.h +3
-0@@ -15,4 +15,7 @@#define SDRAM_BANK_SIZE (2UL << 30) +#define CONFIG_USB_OHCI_NEW +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2 +#endif
Quoted 1 line
But ,
evb_rk3399board does not enableCONFIG_USB_OHCI_HCDandCONFIG_USB_OHCI_GENERIC.
yes i know it !
for example some other rk3399 boards have it because (usb 1.1 didnt work without ohci on usb2.0 port and not possible to use usb kbd for this port )
grep CONFIG_USB_OHCI_GENERIC configs/*3399* configs/pinebook-pro-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y configs/rock960-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y configs/rockpro64-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y
many other boards which used TARGET_EVB_RK3399=y must have same problem (with usb1.1)
and i think other boards must have possibilities to use CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC.
grep EVB configs/*3399*
configs/evb-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/firefly-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/khadas-edge-captain-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/khadas-edge-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/khadas-edge-v-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/leez-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopc-t4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-m4-2gb-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-m4b-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-m4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-neo4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-r4s-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/orangepi-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/rock-pi-4c-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/rock-pi-4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/rock-pi-n10-rk3399pro_defconfig:CONFIG_TARGET_EVB_RK3399=y
Quoted 38 lines · Kever Yang
Hi Artem,
Quoted 5 lines · Artem Lapkin
Problem: not possible to use
CONFIG_USB_OHCI_HCD=yandCONFIG_USB_OHCI_GENERIC=yoptions withoutCONFIG_USB_OHCI_NEWandCONFIG_SYS_USB_OHCI_MAX_ROOT_PORTSdefinationsAdd missed definations.
But ,
evb_rk3399board does not enableCONFIG_USB_OHCI_HCDandCONFIG_USB_OHCI_GENERIC.Thanks,
- Kever
Quoted 18 lines
Signed-off-by Artem Lapkin <[email protected]>--- include/configs/evb_rk3399.h | 3 +++ 1 file changed, 3 insertions(+)include/configs/evb_rk3399.h +3
-0@@ -15,4 +15,7 @@#define SDRAM_BANK_SIZE (2UL << 30) +#define CONFIG_USB_OHCI_NEW +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2 +#endif
workable example for CONFIG_USB_OHCI_HCD and CONFIG_USB_OHCI_GENERIC (usb kbd on usb2.0 port)
kedge# usb tree
USB device tree:
1 Hub (480 Mb/s, 0mA)
u-boot EHCI Host Controller
1 Hub (12 Mb/s, 0mA)
| U-Boot Root Hub
|
+-2 Human Interface (1.5 Mb/s, 100mA)
Dell KB216 Wired Keyboard
1 Hub (480 Mb/s, 0mA)
u-boot EHCI Host Controller
1 Hub (12 Mb/s, 0mA)
U-Boot Root Hub
1 Hub (5 Gb/s, 0mA)
U-Boot XHCI Host Controller
and for usbkbd connected to usb3 port
kedge# usb tree
USB device tree:
1 Hub (480 Mb/s, 0mA)
u-boot EHCI Host Controller
1 Hub (12 Mb/s, 0mA)
U-Boot Root Hub
1 Hub (480 Mb/s, 0mA)
u-boot EHCI Host Controller
1 Hub (12 Mb/s, 0mA)
U-Boot Root Hub
1 Hub (5 Gb/s, 0mA)
| U-Boot XHCI Host Controller
|
+-2 Human Interface (1.5 Mb/s, 100mA)
Dell KB216 Wired Keyboard
PS: usb2.0 port cant recognize any usb1.1 devices without OHCI
Quoted 78 lines · Art Nikpal
Quoted 2 lines
But ,
evb_rk3399board does not enableCONFIG_USB_OHCI_HCDandCONFIG_USB_OHCI_GENERIC.yes i know it !
for example some other rk3399 boards have it because (usb 1.1 didnt work without ohci on usb2.0 port and not possible to use usb kbd for this port )
grep
CONFIG_USB_OHCI_GENERICconfigs/*3399* configs/pinebook-pro-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y configs/rock960-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y configs/rockpro64-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=ymany other boards which used TARGET_EVB_RK3399=y must have same problem (with usb1.1)
and i think other boards must have possibilities to use
CONFIG_USB_OHCI_HCDandCONFIG_USB_OHCI_GENERIC.grep EVB configs/*3399*
configs/evb-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/firefly-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/khadas-edge-captain-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/khadas-edge-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/khadas-edge-v-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/leez-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopc-t4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-m4-2gb-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-m4b-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-m4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-neo4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/nanopi-r4s-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/orangepi-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/rock-pi-4c-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/rock-pi-4-rk3399_defconfig:CONFIG_TARGET_EVB_RK3399=y configs/rock-pi-n10-rk3399pro_defconfig:CONFIG_TARGET_EVB_RK3399=y
Quoted 38 lines · Kever Yang
Hi Artem,
Quoted 5 lines · Artem Lapkin
Problem: not possible to use
CONFIG_USB_OHCI_HCD=yandCONFIG_USB_OHCI_GENERIC=yoptions withoutCONFIG_USB_OHCI_NEWandCONFIG_SYS_USB_OHCI_MAX_ROOT_PORTSdefinationsAdd missed definations.
But ,
evb_rk3399board does not enableCONFIG_USB_OHCI_HCDandCONFIG_USB_OHCI_GENERIC.Thanks,
- Kever
Quoted 18 lines
Signed-off-by Artem Lapkin <[email protected]>--- include/configs/evb_rk3399.h | 3 +++ 1 file changed, 3 insertions(+)include/configs/evb_rk3399.h +3
-0@@ -15,4 +15,7 @@#define SDRAM_BANK_SIZE (2UL << 30) +#define CONFIG_USB_OHCI_NEW +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2 +#endif
Quoted 9 lines · Art Nikpal
Quoted 2 lines
But ,
evb_rk3399board does not enableCONFIG_USB_OHCI_HCDandCONFIG_USB_OHCI_GENERIC.yes i know it !
for example some other rk3399 boards have it because (usb 1.1 didnt work without ohci on usb2.0 port and not possible to use usb kbd for this port )
Quoted 7 lines
grep
CONFIG_USB_OHCI_GENERICconfigs/*3399* configs/pinebook-pro-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y configs/rock960-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=y configs/rockpro64-rk3399_defconfig:CONFIG_USB_OHCI_GENERIC=ymany other boards which used TARGET_EVB_RK3399=y must have same problem (with usb1.1)
The 3 boards you mention above define their own target and don't use TARGET_EVB_RK3399
Quoted 2 lines
and i think other boards must have possibilities to use
CONFIG_USB_OHCI_HCDandCONFIG_USB_OHCI_GENERIC.
So I think Kever's point was that without defining the following two options in the appropriate config files your patch has no effect because the OHCI support isn't actually built for the boards. I suggest a v2 patch which does that.
CONFIG_USB_OHCI_HCD=yCONFIG_USB_OHCI_GENERIC=y
Regards,
Peter