Skip to contentSkip to conversation

drm/i915/xelpd: Enabling dithering after the CC1

PATCH In review Bhanuprakash Modem 5 participants 24 messages May 26, 2021 – Jun 21, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover drm/i915/xelpd: Enabling dithering after the CC1

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

Bhanuprakash Modem (1):
drm/i915/display/debug: Expose Dither status via debugfs

Nischal Varide (1):
drm/i915/xelpd: Enabling dithering after the CC1

 drivers/gpu/drm/i915/display/intel_color.c    | 15 +++++++++
 drivers/gpu/drm/i915/display/intel_display.c  |  7 +++-
 .../drm/i915/display/intel_display_debugfs.c  | 32 +++++++++++++++++++
 drivers/gpu/drm/i915/i915_reg.h               |  3 +-
 4 files changed, 55 insertions(+), 2 deletions(-)

--
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw

PATCH 1/2 drm/i915/xelpd: Enabling dithering after the CC1

From: Nischal Varide <[email protected]>

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

---
 drivers/gpu/drm/i915/display/intel_color.c   | 15 +++++++++++++++
 drivers/gpu/drm/i915/display/intel_display.c |  7 ++++++-
 drivers/gpu/drm/i915/i915_reg.h              |  3 ++-
 3 files changed, 23 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +15 -0
index dab892d2251b..4ad5bd849695 100644
@@ -1605,6 +1605,20 @@ static u32 icl_csc_mode(const struct intel_crtc_state *crtc_state)
 	return csc_mode;
 }
 
+static u32 dither_after_cc1_12bpc(const struct intel_crtc_state *crtc_state)
+{
+	u32 gamma_mode = crtc_state->gamma_mode;
+	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
+
+	if (DISPLAY_VER(i915) >= 13) {
+		if (!crtc_state->dither_force_disable &&
+		    (crtc_state->pipe_bpp == 36))
+			gamma_mode |= GAMMA_MODE_DITHER_AFTER_CC1;
+	}
+
+	return gamma_mode;
+}
+
 static int icl_color_check(struct intel_crtc_state *crtc_state)
 {
 	int ret;
@@ -1615,6 +1629,7 @@ static int icl_color_check(struct intel_crtc_state *crtc_state)
 
 	crtc_state->gamma_mode = icl_gamma_mode(crtc_state);
 
+	crtc_state->gamma_mode = dither_after_cc1_12bpc(crtc_state);
 	crtc_state->csc_mode = icl_csc_mode(crtc_state);
 
 	crtc_state->preload_luts = intel_can_preload_luts(crtc_state);
drivers/gpu/drm/i915/display/intel_display.c +6 -1
index 0bb2e582c87f..1a658bdaeab6 100644
@@ -5741,7 +5741,12 @@ static void bdw_set_pipemisc(const struct intel_crtc_state *crtc_state)
 		break;
 	}
 
-	if (crtc_state->dither)
+	/*
+	 * If 12bpc panel then, Enables dithering after the CC1 pipe
+	 * post color space conversion and not here
+	 */
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))
 		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
 
 	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
drivers/gpu/drm/i915/i915_reg.h +2 -1
index 4dbe79009c0e..5700097475c0 100644
@@ -6155,7 +6155,7 @@ enum {
 #define   PIPEMISC_DITHER_8_BPC		(0 << 5)
 #define   PIPEMISC_DITHER_10_BPC	(1 << 5)
 #define   PIPEMISC_DITHER_6_BPC		(2 << 5)
-#define   PIPEMISC_DITHER_12_BPC	(3 << 5)
+#define   PIPEMISC_DITHER_12_BPC	(4 << 5)
 #define   PIPEMISC_DITHER_ENABLE	(1 << 4)
 #define   PIPEMISC_DITHER_TYPE_MASK	(3 << 2)
 #define   PIPEMISC_DITHER_TYPE_SP	(0 << 2)
@@ -7726,6 +7726,7 @@ enum {
 #define  GAMMA_MODE_MODE_12BIT	(2 << 0)
 #define  GAMMA_MODE_MODE_SPLIT	(3 << 0) /* ivb-bdw */
 #define  GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED	(3 << 0) /* icl + */
+#define  GAMMA_MODE_DITHER_AFTER_CC1 (1 << 26)
 
 /* DMC */
 #define DMC_PROGRAM(i)		_MMIO(0x80000 + (i) * 4)
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#2 lore raw
Quoted 8 lines · Bhanuprakash Modem

From: Nischal Varide <[email protected]>

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

When you're sending someone else's patches, you need to add your own Signed-off-by here.

Quoted 32 lines
---
 drivers/gpu/drm/i915/display/intel_color.c   | 15 +++++++++++++++
 drivers/gpu/drm/i915/display/intel_display.c |  7 ++++++-
 drivers/gpu/drm/i915/i915_reg.h              |  3 ++-
 3 files changed, 23 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_color.c +14 -0
index dab892d2251b..4ad5bd849695 100644
@@ -1605,6 +1605,20 @@ static u32 icl_csc_mode(const struct intel_crtc_state *crtc_state)
 	return csc_mode;
 }
 
+static u32 dither_after_cc1_12bpc(const struct intel_crtc_state *crtc_state)
+{
+	u32 gamma_mode = crtc_state->gamma_mode;
+	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
+
+	if (DISPLAY_VER(i915) >= 13) {
+		if (!crtc_state->dither_force_disable &&
+		    (crtc_state->pipe_bpp == 36))
+			gamma_mode |= GAMMA_MODE_DITHER_AFTER_CC1;
+	}
+
+	return gamma_mode;
+}
+
 static int icl_color_check(struct intel_crtc_state *crtc_state)
 {
 	int ret;

drivers/gpu/drm/i915/display/intel_color.c static int icl_color_check(struct intel_crtc_state *crtc_state) · line 1632

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_color.c +1 -0
@@ -1615,6 +1629,7 @@ static int icl_color_check(struct intel_crtc_state *crtc_state)
 
 	crtc_state->gamma_mode = icl_gamma_mode(crtc_state);
 
+	crtc_state->gamma_mode = dither_after_cc1_12bpc(crtc_state);

We don't really do the kind of thing where you need a sequence of calls where one depends on the other, adding to the same state member. At a glance, this just looks wrong, superficially overwriting the previously set value. I'd just add the check at the end of icl_gamma_mode().

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_color.c +0 -0
 	crtc_state->csc_mode = icl_csc_mode(crtc_state);
 
 	crtc_state->preload_luts = intel_can_preload_luts(crtc_state);
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 0bb2e582c87f..1a658bdaeab6 100644

drivers/gpu/drm/i915/display/intel_display.c static void bdw_set_pipemisc(const struct intel_crtc_state *crtc_state) · line 5749

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display.c +6 -1
@@ -5741,7 +5741,12 @@ static void bdw_set_pipemisc(const struct intel_crtc_state *crtc_state)
 		break;
 	}
 
-	if (crtc_state->dither)
+	/*
+	 * If 12bpc panel then, Enables dithering after the CC1 pipe
+	 * post color space conversion and not here
+	 */
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))

This now duplicates the pipe_bpp condition in two places, which seems a bit fragile. Maybe the check should be on gamma_mode? It would remove the need for the whole comment above.

drivers/gpu/drm/i915/i915_reg.h enum { · line 6158

Quoted 13 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
 
 	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
drivers/gpu/drm/i915/i915_reg.h +1 -1
index 4dbe79009c0e..5700097475c0 100644
@@ -6155,7 +6155,7 @@ enum {
 #define   PIPEMISC_DITHER_8_BPC		(0 << 5)
 #define   PIPEMISC_DITHER_10_BPC	(1 << 5)
 #define   PIPEMISC_DITHER_6_BPC		(2 << 5)
-#define   PIPEMISC_DITHER_12_BPC	(3 << 5)
+#define   PIPEMISC_DITHER_12_BPC	(4 << 5)

We already use the macro. You can't just replace this like this without an explanation. Why would this not break existing stuff?

drivers/gpu/drm/i915/i915_reg.h enum { · line 7729

Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
 #define   PIPEMISC_DITHER_ENABLE	(1 << 4)
 #define   PIPEMISC_DITHER_TYPE_MASK	(3 << 2)
 #define   PIPEMISC_DITHER_TYPE_SP	(0 << 2)
@@ -7726,6 +7726,7 @@ enum {
 #define  GAMMA_MODE_MODE_12BIT	(2 << 0)
 #define  GAMMA_MODE_MODE_SPLIT	(3 << 0) /* ivb-bdw */
 #define  GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED	(3 << 0) /* icl + */
+#define  GAMMA_MODE_DITHER_AFTER_CC1 (1 << 26)

The bits are supposed to be defined in the order from highest to lowest bit. See the big comment at the beginning of the file.

It's confusing that this is named GAMMA_MODE_ while it's not included in GAMMA_MODE_MASK (and likely shouldn't be).

Quoted 3 lines
drivers/gpu/drm/i915/i915_reg.h +0 -0
 /* DMC */
 #define DMC_PROGRAM(i)		_MMIO(0x80000 + (i) * 4)
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 17 lines

From: Jani Nikula <[email protected]>
Sent: Wednesday, May 26, 2021 7:34 PM
To: Modem, Bhanuprakash <[email protected]>; intel- [email protected]; Varide, Nischal <[email protected]>; Shankar, Uma <[email protected]>; Gupta, Anshuman <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/xelpd: Enabling dithering after the CC1

Quoted 7 lines · Bhanuprakash Modem

From: Nischal Varide <[email protected]>

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

Quoted 4 lines
Quoted 1 line

When you're sending someone else's patches, you need to add your own Signed-off-by here.

Patch 2/2 in this series has a dependency on this patch. And I haven't made any changes in this patch, so not added my Signed-off-by :-)

- Bhanu

Quoted 106 lines

Review

Quoted 8 lines
---
 drivers/gpu/drm/i915/display/intel_color.c   | 15 +++++++++++++++
 drivers/gpu/drm/i915/display/intel_display.c |  7 ++++++-
 drivers/gpu/drm/i915/i915_reg.h              |  3 ++-
 3 files changed, 23 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/display/intel_color.c

drivers/gpu/drm/i915/display/intel_color.c static u32 icl_csc_mode(const struct intel_crtc_state

Quoted 4 lines

index dab892d2251b..4ad5bd849695 100644

drivers/gpu/drm/i915/display/intel_color.c +0 -0
@@ -1605,6 +1605,20 @@ static u32 icl_csc_mode(const struct intel_crtc_state

*crtc_state)

drivers/gpu/drm/i915/display/intel_color.c static u32 icl_csc_mode(const struct intel_crtc_state *crtc_state)

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_color.c +1 -0
 	return csc_mode;
 }
 
+static u32 dither_after_cc1_12bpc(const struct intel_crtc_state

*crtc_state)

drivers/gpu/drm/i915/display/intel_color.c static int icl_color_check(struct intel_crtc_state

Quoted 17 lines
drivers/gpu/drm/i915/display/intel_color.c +13 -0
+{
+	u32 gamma_mode = crtc_state->gamma_mode;
+	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
+
+	if (DISPLAY_VER(i915) >= 13) {
+		if (!crtc_state->dither_force_disable &&
+		    (crtc_state->pipe_bpp == 36))
+			gamma_mode |= GAMMA_MODE_DITHER_AFTER_CC1;
+	}
+
+	return gamma_mode;
+}
+
 static int icl_color_check(struct intel_crtc_state *crtc_state)
 {
 	int ret;
@@ -1615,6 +1629,7 @@ static int icl_color_check(struct intel_crtc_state

*crtc_state)

drivers/gpu/drm/i915/display/intel_color.c static int icl_color_check(struct intel_crtc_state *crtc_state) · line 1632

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_color.c +1 -0
 	crtc_state->gamma_mode = icl_gamma_mode(crtc_state);
 
+	crtc_state->gamma_mode = dither_after_cc1_12bpc(crtc_state);

We don't really do the kind of thing where you need a sequence of calls where one depends on the other, adding to the same state member. At a glance, this just looks wrong, superficially overwriting the previously set value. I'd just add the check at the end of icl_gamma_mode().

Review

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_color.c +0 -0
 	crtc_state->csc_mode = icl_csc_mode(crtc_state);
 
 	crtc_state->preload_luts = intel_can_preload_luts(crtc_state);
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/display/intel_display.c

drivers/gpu/drm/i915/display/intel_display.c static void bdw_set_pipemisc(const struct

Quoted 4 lines

index 0bb2e582c87f..1a658bdaeab6 100644

drivers/gpu/drm/i915/display/intel_display.c +0 -0
@@ -5741,7 +5741,12 @@ static void bdw_set_pipemisc(const struct

intel_crtc_state *crtc_state)

drivers/gpu/drm/i915/display/intel_display.c static void bdw_set_pipemisc(const struct intel_crtc_state *crtc_state) · line 5749

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display.c +6 -1
 		break;
 	}
 
-	if (crtc_state->dither)
+	/*
+	 * If 12bpc panel then, Enables dithering after the CC1 pipe
+	 * post color space conversion and not here
+	 */
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))

This now duplicates the pipe_bpp condition in two places, which seems a bit fragile. Maybe the check should be on gamma_mode? It would remove the need for the whole comment above.

Review

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
 
 	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_reg.h

drivers/gpu/drm/i915/i915_reg.h enum { · line 6158

Quoted 9 lines

index 4dbe79009c0e..5700097475c0 100644

drivers/gpu/drm/i915/i915_reg.h +1 -1
@@ -6155,7 +6155,7 @@ enum {
 #define   PIPEMISC_DITHER_8_BPC		(0 << 5)
 #define   PIPEMISC_DITHER_10_BPC	(1 << 5)
 #define   PIPEMISC_DITHER_6_BPC		(2 << 5)
-#define   PIPEMISC_DITHER_12_BPC	(3 << 5)
+#define   PIPEMISC_DITHER_12_BPC	(4 << 5)

We already use the macro. You can't just replace this like this without an explanation. Why would this not break existing stuff?

drivers/gpu/drm/i915/i915_reg.h enum { · line 7729

Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
 #define   PIPEMISC_DITHER_ENABLE	(1 << 4)
 #define   PIPEMISC_DITHER_TYPE_MASK	(3 << 2)
 #define   PIPEMISC_DITHER_TYPE_SP	(0 << 2)
@@ -7726,6 +7726,7 @@ enum {
 #define  GAMMA_MODE_MODE_12BIT	(2 << 0)
 #define  GAMMA_MODE_MODE_SPLIT	(3 << 0) /* ivb-bdw */
 #define  GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED	(3 << 0) /* icl + */
+#define  GAMMA_MODE_DITHER_AFTER_CC1 (1 << 26)

The bits are supposed to be defined in the order from highest to lowest bit. See the big comment at the beginning of the file.

It's confusing that this is named GAMMA_MODE_ while it's not included in GAMMA_MODE_MASK (and likely shouldn't be).

Quoted 1 line
Quoted 5 lines
Quoted 2 lines

/* DMC */
#define DMC_PROGRAM(i) _MMIO(0x80000 + (i) * 4)

--
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#4 lore raw
Quoted 6 lines · Bhanuprakash
Quoted 3 lines

From: Jani Nikula <[email protected]>
When you're sending someone else's patches, you need to add your own Signed-off-by here.

Patch 2/2 in this series has a dependency on this patch. And I haven't made any changes in this patch, so not added my Signed-off-by :-)

Signed-off-by isn't about changes.

https://developercertificate.org/

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw
In reply to Modem, Bhanuprakash

-----Original Message-----
From: Modem, Bhanuprakash <[email protected]>
Sent: Wednesday, May 26, 2021 9:29 PM
To: Jani Nikula <[email protected]>; [email protected]; Varide, Nischal <[email protected]>; Shankar, Uma <[email protected]>; Gupta, Anshuman <[email protected]>
Subject: RE: [Intel-gfx] [PATCH 1/2] drm/i915/xelpd: Enabling dithering after the CC1

Quoted 17 lines

From: Jani Nikula <[email protected]>
Sent: Wednesday, May 26, 2021 7:34 PM
To: Modem, Bhanuprakash <[email protected]>; intel- [email protected]; Varide, Nischal <[email protected]>; Shankar, Uma <[email protected]>; Gupta, Anshuman <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/xelpd: Enabling dithering after the CC1

Quoted 7 lines · Bhanuprakash Modem

From: Nischal Varide <[email protected]>

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

Quoted 4 lines
Quoted 1 line

When you're sending someone else's patches, you need to add your own Signed-off-by here.

Patch 2/2 in this series has a dependency on this patch. And I haven't made any changes in this patch, so not added my Signed-off-by :-)

- Bhanu

Quoted 40 lines

Review

Quoted 8 lines
---
 drivers/gpu/drm/i915/display/intel_color.c   | 15 +++++++++++++++
 drivers/gpu/drm/i915/display/intel_display.c |  7 ++++++-
 drivers/gpu/drm/i915/i915_reg.h              |  3 ++-
 3 files changed, 23 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/display/intel_color.c

Quoted 5 lines

index dab892d2251b..4ad5bd849695 100644

drivers/gpu/drm/i915/display/intel_color.c +0 -0
@@ -1605,6 +1605,20 @@ static u32 icl_csc_mode(const struct 

intel_crtc_state

*crtc_state)

drivers/gpu/drm/i915/display/intel_color.c static u32 icl_csc_mode(const struct intel_crtc_state *crtc_state)

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_color.c +1 -0
 	return csc_mode;
 }
 
+static u32 dither_after_cc1_12bpc(const struct intel_crtc_state

*crtc_state)

Quoted 17 lines
drivers/gpu/drm/i915/display/intel_color.c +14 -0
+{
+	u32 gamma_mode = crtc_state->gamma_mode;
+	struct drm_i915_private *i915 = 
+to_i915(crtc_state->uapi.crtc->dev);
+
+	if (DISPLAY_VER(i915) >= 13) {
+		if (!crtc_state->dither_force_disable &&
+		    (crtc_state->pipe_bpp == 36))
+			gamma_mode |= GAMMA_MODE_DITHER_AFTER_CC1;
+	}
+
+	return gamma_mode;
+}
+
 static int icl_color_check(struct intel_crtc_state *crtc_state)  {
 	int ret;
@@ -1615,6 +1629,7 @@ static int icl_color_check(struct 
Quoted 1 line

intel_crtc_state

*crtc_state)

Quoted 1 line
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_color.c static int icl_color_check(struct intel_crtc_state *crtc_state) · line 1632

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_color.c +1 -0
 	crtc_state->gamma_mode = icl_gamma_mode(crtc_state);
 
+	crtc_state->gamma_mode = dither_after_cc1_12bpc(crtc_state);

We don't really do the kind of thing where you need a sequence of calls where one depends on the other, adding to the same state member. At a glance, this just looks wrong, superficially overwriting the previously set value. I'd just add the check at the end of icl_gamma_mode().

Yes ,agree and will do the needful here.

Quoted 14 lines

Review

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_color.c +0 -0
 	crtc_state->csc_mode = icl_csc_mode(crtc_state);
 
 	crtc_state->preload_luts = intel_can_preload_luts(crtc_state);
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/display/intel_display.c

drivers/gpu/drm/i915/display/intel_display.c static void bdw_set_pipemisc(const struct

Quoted 4 lines

index 0bb2e582c87f..1a658bdaeab6 100644

drivers/gpu/drm/i915/display/intel_display.c +0 -0
@@ -5741,7 +5741,12 @@ static void bdw_set_pipemisc(const struct

intel_crtc_state *crtc_state)

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 		break;
 	}
 
Quoted 11 lines

drivers/gpu/drm/i915/display/intel_display.c static void bdw_set_pipemisc(const struct intel_crtc_state *crtc_state) · line 5749

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_display.c +6 -1
-	if (crtc_state->dither)
+	/*
+	 * If 12bpc panel then, Enables dithering after the CC1 pipe
+	 * post color space conversion and not here
+	 */
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))

This now duplicates the pipe_bpp condition in two places, which seems a bit fragile. Maybe the check should be on gamma_mode? It would remove the need for the whole comment above.

There are two bits for controlling the dithering one at pipe level and other at gamma level, So the checks at two places .

Quoted 18 lines

Review

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
 
 	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 || 
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_reg.h

drivers/gpu/drm/i915/i915_reg.h enum { · line 6158

Quoted 9 lines

index 4dbe79009c0e..5700097475c0 100644

drivers/gpu/drm/i915/i915_reg.h +1 -1
@@ -6155,7 +6155,7 @@ enum {
 #define   PIPEMISC_DITHER_8_BPC		(0 << 5)
 #define   PIPEMISC_DITHER_10_BPC	(1 << 5)
 #define   PIPEMISC_DITHER_6_BPC		(2 << 5)
-#define   PIPEMISC_DITHER_12_BPC	(3 << 5)
+#define   PIPEMISC_DITHER_12_BPC	(4 << 5)

We already use the macro. You can't just replace this like this without an explanation. Why would this not break existing stuff?

Quoted 11 lines

drivers/gpu/drm/i915/i915_reg.h enum { · line 7729

Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
 #define   PIPEMISC_DITHER_ENABLE	(1 << 4)
 #define   PIPEMISC_DITHER_TYPE_MASK	(3 << 2)
 #define   PIPEMISC_DITHER_TYPE_SP	(0 << 2)
@@ -7726,6 +7726,7 @@ enum {
 #define  GAMMA_MODE_MODE_12BIT	(2 << 0)
 #define  GAMMA_MODE_MODE_SPLIT	(3 << 0) /* ivb-bdw */
 #define  GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED	(3 << 0) /* icl + */
+#define  GAMMA_MODE_DITHER_AFTER_CC1 (1 << 26)

The bits are supposed to be defined in the order from highest to lowest bit. See the big comment at the beginning of the file.

Yes..Noted

Quoted 2 lines

It's confusing that this is named GAMMA_MODE_ while it's not included in GAMMA_MODE_MASK (and likely shouldn't be).

Yes..can change the name to GAMMA_DITHER_AFTER_CC1

Quoted 6 lines

drivers/gpu/drm/i915/i915_reg.h enum { · line 7732

Quoted 3 lines
drivers/gpu/drm/i915/i915_reg.h +0 -0
 /* DMC */
 #define DMC_PROGRAM(i)		_MMIO(0x80000 + (i) * 4)

--
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

-----Original Message-----
From: Modem, Bhanuprakash <[email protected]>
Sent: Wednesday, May 26, 2021 9:29 PM
To: Jani Nikula <[email protected]>; [email protected]; Varide, Nischal <[email protected]>; Shankar, Uma <[email protected]>; Gupta, Anshuman <[email protected]>
Subject: RE: [Intel-gfx] [PATCH 1/2] drm/i915/xelpd: Enabling dithering after the CC1

Quoted 17 lines

From: Jani Nikula <[email protected]>
Sent: Wednesday, May 26, 2021 7:34 PM
To: Modem, Bhanuprakash <[email protected]>; intel- [email protected]; Varide, Nischal <[email protected]>; Shankar, Uma <[email protected]>; Gupta, Anshuman <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/xelpd: Enabling dithering after the CC1

Quoted 7 lines · Bhanuprakash Modem

From: Nischal Varide <[email protected]>

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

Quoted 4 lines
Quoted 1 line

When you're sending someone else's patches, you need to add your own Signed-off-by here.

Patch 2/2 in this series has a dependency on this patch. And I haven't made any changes in this patch, so not added my Signed-off-by :-)

- Bhanu

Quoted 40 lines

Review

Quoted 8 lines
---
 drivers/gpu/drm/i915/display/intel_color.c   | 15 +++++++++++++++
 drivers/gpu/drm/i915/display/intel_display.c |  7 ++++++-
 drivers/gpu/drm/i915/i915_reg.h              |  3 ++-
 3 files changed, 23 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/display/intel_color.c

Quoted 5 lines

index dab892d2251b..4ad5bd849695 100644

drivers/gpu/drm/i915/display/intel_color.c +0 -0
@@ -1605,6 +1605,20 @@ static u32 icl_csc_mode(const struct 

intel_crtc_state

*crtc_state)

drivers/gpu/drm/i915/display/intel_color.c static u32 icl_csc_mode(const struct intel_crtc_state *crtc_state)

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_color.c +1 -0
 	return csc_mode;
 }
 
+static u32 dither_after_cc1_12bpc(const struct intel_crtc_state

*crtc_state)

Quoted 17 lines
drivers/gpu/drm/i915/display/intel_color.c +14 -0
+{
+	u32 gamma_mode = crtc_state->gamma_mode;
+	struct drm_i915_private *i915 =
+to_i915(crtc_state->uapi.crtc->dev);
+
+	if (DISPLAY_VER(i915) >= 13) {
+		if (!crtc_state->dither_force_disable &&
+		    (crtc_state->pipe_bpp == 36))
+			gamma_mode |= GAMMA_MODE_DITHER_AFTER_CC1;
+	}
+
+	return gamma_mode;
+}
+
 static int icl_color_check(struct intel_crtc_state *crtc_state)  {
 	int ret;
@@ -1615,6 +1629,7 @@ static int icl_color_check(struct 
Quoted 1 line

intel_crtc_state

*crtc_state)

Quoted 1 line
Quoted 8 lines

drivers/gpu/drm/i915/display/intel_color.c static int icl_color_check(struct intel_crtc_state *crtc_state) · line 1632

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_color.c +1 -0
 	crtc_state->gamma_mode = icl_gamma_mode(crtc_state);
 
+	crtc_state->gamma_mode = dither_after_cc1_12bpc(crtc_state);

We don't really do the kind of thing where you need a sequence of calls where one depends on the other, adding to the same state member. At a glance, this just looks wrong, superficially overwriting the previously set value. I'd just add the check at the end of icl_gamma_mode().

Yes ,agree and will do the needful here.

Quoted 14 lines

Review

Quoted 5 lines
drivers/gpu/drm/i915/display/intel_color.c +0 -0
 	crtc_state->csc_mode = icl_csc_mode(crtc_state);
 
 	crtc_state->preload_luts = intel_can_preload_luts(crtc_state);
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/display/intel_display.c

drivers/gpu/drm/i915/display/intel_display.c static void bdw_set_pipemisc(const struct

Quoted 4 lines

index 0bb2e582c87f..1a658bdaeab6 100644

drivers/gpu/drm/i915/display/intel_display.c +0 -0
@@ -5741,7 +5741,12 @@ static void bdw_set_pipemisc(const struct

intel_crtc_state *crtc_state)

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 		break;
 	}
 
Quoted 11 lines

drivers/gpu/drm/i915/display/intel_display.c static void bdw_set_pipemisc(const struct intel_crtc_state *crtc_state) · line 5749

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_display.c +6 -1
-	if (crtc_state->dither)
+	/*
+	 * If 12bpc panel then, Enables dithering after the CC1 pipe
+	 * post color space conversion and not here
+	 */
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))

This now duplicates the pipe_bpp condition in two places, which seems a bit fragile. Maybe the check should be on gamma_mode? It would remove the need for the whole comment above.

There are two bits for controlling the dithering one at pipe level and other at gamma level, So the checks at two places .

Quoted 5 lines

Review

Quoted 4 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
 
 	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 || 
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/i915_reg.h

Quoted 12 lines

drivers/gpu/drm/i915/i915_reg.h enum { · line 6158

Quoted 9 lines

index 4dbe79009c0e..5700097475c0 100644

drivers/gpu/drm/i915/i915_reg.h +1 -1
@@ -6155,7 +6155,7 @@ enum {
 #define   PIPEMISC_DITHER_8_BPC		(0 << 5)
 #define   PIPEMISC_DITHER_10_BPC	(1 << 5)
 #define   PIPEMISC_DITHER_6_BPC		(2 << 5)
-#define   PIPEMISC_DITHER_12_BPC	(3 << 5)
+#define   PIPEMISC_DITHER_12_BPC	(4 << 5)

We already use the macro. You can't just replace this like this without an explanation. Why would this not break existing stuff?

This is by referring a wrong register in bspec, not needed and removing it

Quoted 11 lines

drivers/gpu/drm/i915/i915_reg.h enum { · line 7729

Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
 #define   PIPEMISC_DITHER_ENABLE	(1 << 4)
 #define   PIPEMISC_DITHER_TYPE_MASK	(3 << 2)
 #define   PIPEMISC_DITHER_TYPE_SP	(0 << 2)
@@ -7726,6 +7726,7 @@ enum {
 #define  GAMMA_MODE_MODE_12BIT	(2 << 0)
 #define  GAMMA_MODE_MODE_SPLIT	(3 << 0) /* ivb-bdw */
 #define  GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED	(3 << 0) /* icl + */
+#define  GAMMA_MODE_DITHER_AFTER_CC1 (1 << 26)

The bits are supposed to be defined in the order from highest to lowest bit. See the big comment at the beginning of the file.

Yes..Noted

Quoted 2 lines

It's confusing that this is named GAMMA_MODE_ while it's not included in GAMMA_MODE_MASK (and likely shouldn't be).

Yes..can change the name to GAMMA_DITHER_AFTER_CC1

Quoted 6 lines

drivers/gpu/drm/i915/i915_reg.h enum { · line 7732

Quoted 3 lines
drivers/gpu/drm/i915/i915_reg.h +0 -0
 /* DMC */
 #define DMC_PROGRAM(i)		_MMIO(0x80000 + (i) * 4)

--
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

v2 cover Enabling dithering after the CC1

In reply to Bhanuprakash Modem

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

This is Version 2 of the patch, after addresing few review comments.

Nischal Varide (1):
drm/i915/xelpd: Enabling dithering after the CC1

 drivers/gpu/drm/i915/display/intel_color.c   | 7 +++++++
 drivers/gpu/drm/i915/display/intel_display.c | 7 ++++++-
 drivers/gpu/drm/i915/i915_reg.h              | 1 +
 3 files changed, 14 insertions(+), 1 deletion(-)
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw

PATCH v2 1/1 drm/i915/xelpd: Enabling dithering after the CC1

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

---
 drivers/gpu/drm/i915/display/intel_color.c   | 7 +++++++
 drivers/gpu/drm/i915/display/intel_display.c | 7 ++++++-
 drivers/gpu/drm/i915/i915_reg.h              | 1 +
 3 files changed, 14 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_color.c +7 -0
index dab892d2251b..e11b3dbf0b95 100644
@@ -1574,6 +1574,7 @@ static int glk_color_check(struct intel_crtc_state *crtc_state)
 static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state)
 {
 	u32 gamma_mode = 0;
+	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
 
 	if (crtc_state->hw.degamma_lut)
 		gamma_mode |= PRE_CSC_GAMMA_ENABLE;
@@ -1588,6 +1589,12 @@ static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state)
 	else
 		gamma_mode |= GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED;
 
+	if (DISPLAY_VER(i915) >= 13) {
+		if (!crtc_state->dither_force_disable &&
+				(crtc_state->pipe_bpp == 36))
+			gamma_mode |= POST_CC1_GAMMA_ENABLE;
+	}
+
 	return gamma_mode;
 }
 
drivers/gpu/drm/i915/display/intel_display.c +6 -1
index caf0414e0b50..fd3186a5e6ff 100644
@@ -5762,7 +5762,12 @@ static void bdw_set_pipemisc(const struct intel_crtc_state *crtc_state)
 		break;
 	}
 
-	if (crtc_state->dither)
+	/*
+	 * If 12bpc panel then, Enables dithering after the CC1 pipe
+	 * post color space conversion and not here
+	 */
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))
 		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
 
 	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
drivers/gpu/drm/i915/i915_reg.h +1 -0
index 24307c49085f..fa800a77ea49 100644
@@ -7743,6 +7743,7 @@ enum {
 #define GAMMA_MODE(pipe) _MMIO_PIPE(pipe, _GAMMA_MODE_A, _GAMMA_MODE_B)
 #define  PRE_CSC_GAMMA_ENABLE	(1 << 31)
 #define  POST_CSC_GAMMA_ENABLE	(1 << 30)
+#define  POST_CC1_GAMMA_ENABLE  (1 << 26)
 #define  GAMMA_MODE_MODE_MASK	(3 << 0)
 #define  GAMMA_MODE_MODE_8BIT	(0 << 0)
 #define  GAMMA_MODE_MODE_10BIT	(1 << 0)
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#9 lore raw
Quoted 56 lines

From: Intel-gfx <[email protected]> On Behalf Of Nischal Varide
Sent: Wednesday, June 2, 2021 11:48 AM
To: [email protected]; Varide, Nischal <[email protected]>; Shankar, Uma <[email protected]>; Gupta, Anshuman <[email protected]>; Nikula, Jani <[email protected]>
Subject: [Intel-gfx] [PATCH v2 1/1] drm/i915/xelpd: Enabling dithering after the CC1

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

---
 drivers/gpu/drm/i915/display/intel_color.c   | 7 +++++++
 drivers/gpu/drm/i915/display/intel_display.c | 7 ++++++-
 drivers/gpu/drm/i915/i915_reg.h              | 1 +
 3 files changed, 14 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_color.c +1 -0
index dab892d2251b..e11b3dbf0b95 100644
@@ -1574,6 +1574,7 @@ static int glk_color_check(struct intel_crtc_state
 *crtc_state)
 static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state)
 {
 	u32 gamma_mode = 0;
+	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
 
 	if (crtc_state->hw.degamma_lut)
drivers/gpu/drm/i915/display/intel_color.c +6 -0
 		gamma_mode |= PRE_CSC_GAMMA_ENABLE;
@@ -1588,6 +1589,12 @@ static u32 icl_gamma_mode(const struct intel_crtc_state
 *crtc_state)
 	else
 		gamma_mode |= GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED;
 
+	if (DISPLAY_VER(i915) >= 13) {
+		if (!crtc_state->dither_force_disable &&
+				(crtc_state->pipe_bpp == 36))
+			gamma_mode |= POST_CC1_GAMMA_ENABLE;
+	}
+
 	return gamma_mode;
 }
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index caf0414e0b50..fd3186a5e6ff 100644
@@ -5762,7 +5762,12 @@ static void bdw_set_pipemisc(const struct
 intel_crtc_state *crtc_state)

drivers/gpu/drm/i915/display/intel_display.c static void bdw_set_pipemisc(const struct · line 5771

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display.c +6 -1
 		break;
 	}
 
-	if (crtc_state->dither)
+	/*
+	 * If 12bpc panel then, Enables dithering after the CC1 pipe
+	 * post color space conversion and not here
+	 */
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))

Consider we have a config as 12bpc panel + DISPLAY_VER < 13

This check prevents the dither at end of the pipe and apparently icl_gamma_mode() will not enable the dither after CC1.

So, we'll end up not enable the Dither at all.

Quoted 18 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
 
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
drivers/gpu/drm/i915/i915_reg.h +1 -1
index 24307c49085f..fa800a77ea49 100644
@@ -7743,6 +7743,7 @@ enum {
 #define GAMMA_MODE(pipe) _MMIO_PIPE(pipe, _GAMMA_MODE_A, _GAMMA_MODE_B)
 #define  PRE_CSC_GAMMA_ENABLE	(1 << 31)
 #define  POST_CSC_GAMMA_ENABLE	(1 << 30)
+#define  POST_CC1_GAMMA_ENABLE  (1 << 26)
 #define  GAMMA_MODE_MODE_MASK	(3 << 0)
 #define  GAMMA_MODE_MODE_8BIT	(0 << 0)
 #define  GAMMA_MODE_MODE_10BIT	(1 << 0)
--

2.29.2

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

v3 cover Enabling dithering after the CC1

In reply to Nischal Varide

v3 : Addressed Review Comments by (Bhanu)

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

If the panel is 12bpc and display_ver < 13 then we can not enable dithering at all.So this v3 version of the patch has added an extra check to fix it.

Nischal Varide (1):
drm/i915/xelpd: Enabling dithering after the CC1

 drivers/gpu/drm/i915/display/intel_color.c   |  7 +++++++
 drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++++++-
 drivers/gpu/drm/i915/i915_reg.h              |  1 +
 3 files changed, 18 insertions(+), 1 deletion(-)
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#11 lore raw

PATCH v3 1/1 drm/i915/xelpd: Enabling dithering after the CC1

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

---
 drivers/gpu/drm/i915/display/intel_color.c   |  7 +++++++
 drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++++++-
 drivers/gpu/drm/i915/i915_reg.h              |  1 +
 3 files changed, 18 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_color.c +7 -0
index dab892d2251b..e11b3dbf0b95 100644
@@ -1574,6 +1574,7 @@ static int glk_color_check(struct intel_crtc_state *crtc_state)
 static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state)
 {
 	u32 gamma_mode = 0;
+	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
 
 	if (crtc_state->hw.degamma_lut)
 		gamma_mode |= PRE_CSC_GAMMA_ENABLE;
@@ -1588,6 +1589,12 @@ static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state)
 	else
 		gamma_mode |= GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED;
 
+	if (DISPLAY_VER(i915) >= 13) {
+		if (!crtc_state->dither_force_disable &&
+				(crtc_state->pipe_bpp == 36))
+			gamma_mode |= POST_CC1_GAMMA_ENABLE;
+	}
+
 	return gamma_mode;
 }
 
drivers/gpu/drm/i915/display/intel_display.c +10 -1
index caf0414e0b50..5345779cfce2 100644
@@ -5762,7 +5762,16 @@ static void bdw_set_pipemisc(const struct intel_crtc_state *crtc_state)
 		break;
 	}
 
-	if (crtc_state->dither)
+	/*
+	 * If 12bpc panel then, Enables dithering after the CC1 pipe
+	 * post color space conversion and not here for display_ver
+	 * greater than or equal to thirteen.
+	 */
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))
+		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp == 36) && (DISPLAY_VER(dev_priv) < 13))
 		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
 
 	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
drivers/gpu/drm/i915/i915_reg.h +1 -0
index 24307c49085f..fa800a77ea49 100644
@@ -7743,6 +7743,7 @@ enum {
 #define GAMMA_MODE(pipe) _MMIO_PIPE(pipe, _GAMMA_MODE_A, _GAMMA_MODE_B)
 #define  PRE_CSC_GAMMA_ENABLE	(1 << 31)
 #define  POST_CSC_GAMMA_ENABLE	(1 << 30)
+#define  POST_CC1_GAMMA_ENABLE  (1 << 26)
 #define  GAMMA_MODE_MODE_MASK	(3 << 0)
 #define  GAMMA_MODE_MODE_8BIT	(0 << 0)
 #define  GAMMA_MODE_MODE_10BIT	(1 << 0)
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#12 lore raw

PATCH 2/2 drm/i915/display/debug: Expose Dither status via debugfs

In reply to Bhanuprakash Modem

It's useful to know the dithering state & pipe bpc for IGT testing. This patch will expose the dithering state for the crtc via a debugfs file "dither".

Example usage: cat /sys/kernel/debug/dri/0/crtc-0/dither

Cc Uma Shankar <[email protected]>
Cc Nischal Varide <[email protected]>
Cc Matt Roper <[email protected]>
---
 .../drm/i915/display/intel_display_debugfs.c  | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/gpu/drm/i915/display/intel_display_debugfs.c +32 -0
index 94e5cbd86e77..a6fefc7d5ab9 100644
@@ -2158,11 +2158,43 @@ static const struct {
 	{"i915_edp_psr_debug", &i915_edp_psr_debug_fops},
 };
 
+static int dither_state_show(struct seq_file *m, void *data)
+{
+	struct intel_crtc *crtc = to_intel_crtc(m->private);
+	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
+	struct intel_crtc_state *crtc_state;
+	int ret;
+
+	if (!HAS_DISPLAY(dev_priv))
+		return -ENODEV;
+
+	ret = drm_modeset_lock_single_interruptible(&crtc->base.mutex);
+	if (ret)
+		return ret;
+
+	crtc_state = to_intel_crtc_state(crtc->base.state);
+	seq_printf(m, "bpc: %u\n", crtc_state->pipe_bpp / 3);
+	seq_printf(m, "Dither: %u\n", (crtc_state->dither) ? 1 : 0);
+	seq_printf(m, "Dither_CC1: %u\n",
+		(crtc_state->gamma_mode & GAMMA_MODE_DITHER_AFTER_CC1) ? 1 : 0);
+
+	drm_modeset_unlock(&crtc->base.mutex);
+
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(dither_state);
+
 void intel_display_debugfs_register(struct drm_i915_private *i915)
 {
 	struct drm_minor *minor = i915->drm.primary;
+	struct drm_device *dev = &i915->drm;
+	struct drm_crtc *crtc;
 	int i;
 
+	drm_for_each_crtc(crtc, dev)
+		debugfs_create_file("dither", 0444, crtc->debugfs_entry, crtc,
+				    &dither_state_fops);
+
 	for (i = 0; i < ARRAY_SIZE(intel_display_debugfs_files); i++) {
 		debugfs_create_file(intel_display_debugfs_files[i].name,
 				    S_IRUGO | S_IWUSR,
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#13 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

Quoted 21 lines · Bhanuprakash Modem

It's useful to know the dithering state & pipe bpc for IGT testing. This patch will expose the dithering state for the crtc via a debugfs file "dither".

Example usage: cat /sys/kernel/debug/dri/0/crtc-0/dither

Cc Uma Shankar <[email protected]>
Cc Nischal Varide <[email protected]>
Cc Matt Roper <[email protected]>
---
 .../drm/i915/display/intel_display_debugfs.c  | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/gpu/drm/i915/display/intel_display_debugfs.c +0 -0
index 94e5cbd86e77..a6fefc7d5ab9 100644
@@ -2158,11 +2158,43 @@ static const struct {
 	{"i915_edp_psr_debug", &i915_edp_psr_debug_fops},
 };

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2169

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +9 -0
 
+static int dither_state_show(struct seq_file *m, void *data)
+{
+	struct intel_crtc *crtc = to_intel_crtc(m->private);
+	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
+	struct intel_crtc_state *crtc_state;
+	int ret;
+
+	if (!HAS_DISPLAY(dev_priv))
+		return -ENODEV;

Unneeded.

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2179

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +10 -0
+
+	ret = drm_modeset_lock_single_interruptible(&crtc->base.mutex);
+	if (ret)
+		return ret;
+
+	crtc_state = to_intel_crtc_state(crtc->base.state);
+	seq_printf(m, "bpc: %u\n", crtc_state->pipe_bpp / 3);
+	seq_printf(m, "Dither: %u\n", (crtc_state->dither) ? 1 : 0);
+	seq_printf(m, "Dither_CC1: %u\n",
+		(crtc_state->gamma_mode & GAMMA_MODE_DITHER_AFTER_CC1) ? 1 : 0);

Are you looking to duplicate the conditions for enabling this CC1 mode in IGT, and then checking if the driver set the bit as well?

I thought the direction has been that we don't do this type of validation in IGT. There is no end to it.

Ville?

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +7 -0
+
+	drm_modeset_unlock(&crtc->base.mutex);
+
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(dither_state);
+
 void intel_display_debugfs_register(struct drm_i915_private *i915)

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2197

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +6 -0
 {
 	struct drm_minor *minor = i915->drm.primary;
+	struct drm_device *dev = &i915->drm;
+	struct drm_crtc *crtc;
 	int i;
 
+	drm_for_each_crtc(crtc, dev)
+		debugfs_create_file("dither", 0444, crtc->debugfs_entry, crtc,
+				    &dither_state_fops);
+

See intel_crtc_debugfs_add(), called from intel_crtc_late_register().

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +0 -0
 	for (i = 0; i < ARRAY_SIZE(intel_display_debugfs_files); i++) {
 		debugfs_create_file(intel_display_debugfs_files[i].name,
 				    S_IRUGO | S_IWUSR,
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#14 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

Quoted 49 lines · Jani Nikula
Quoted 21 lines · Bhanuprakash Modem

It's useful to know the dithering state & pipe bpc for IGT testing. This patch will expose the dithering state for the crtc via a debugfs file "dither".

Example usage: cat /sys/kernel/debug/dri/0/crtc-0/dither

Cc Uma Shankar <[email protected]>
Cc Nischal Varide <[email protected]>
Cc Matt Roper <[email protected]>
---
 .../drm/i915/display/intel_display_debugfs.c  | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
drivers/gpu/drm/i915/display/intel_display_debugfs.c +0 -0
index 94e5cbd86e77..a6fefc7d5ab9 100644
@@ -2158,11 +2158,43 @@ static const struct {
 	{"i915_edp_psr_debug", &i915_edp_psr_debug_fops},
 };

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2169

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +9 -0
 
+static int dither_state_show(struct seq_file *m, void *data)
+{
+	struct intel_crtc *crtc = to_intel_crtc(m->private);
+	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
+	struct intel_crtc_state *crtc_state;
+	int ret;
+
+	if (!HAS_DISPLAY(dev_priv))
+		return -ENODEV;

Unneeded.

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2179

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +10 -0
+
+	ret = drm_modeset_lock_single_interruptible(&crtc->base.mutex);
+	if (ret)
+		return ret;
+
+	crtc_state = to_intel_crtc_state(crtc->base.state);
+	seq_printf(m, "bpc: %u\n", crtc_state->pipe_bpp / 3);
+	seq_printf(m, "Dither: %u\n", (crtc_state->dither) ? 1 : 0);
+	seq_printf(m, "Dither_CC1: %u\n",
+		(crtc_state->gamma_mode & GAMMA_MODE_DITHER_AFTER_CC1) ? 1 : 0);

Are you looking to duplicate the conditions for enabling this CC1 mode in IGT, and then checking if the driver set the bit as well?

Quoted 4 lines

I thought the direction has been that we don't do this type of validation in IGT. There is no end to it.

Ville?

Yeah, I hate all the ad-hoc debugfs files. They just get in the way of refactoring all the time.

For state dumps we should just fix the midlayer crap in the atomic state dump framework and start using it.

Quoted 28 lines
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +7 -0
+
+	drm_modeset_unlock(&crtc->base.mutex);
+
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(dither_state);
+
 void intel_display_debugfs_register(struct drm_i915_private *i915)

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2197

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +6 -0
 {
 	struct drm_minor *minor = i915->drm.primary;
+	struct drm_device *dev = &i915->drm;
+	struct drm_crtc *crtc;
 	int i;
 
+	drm_for_each_crtc(crtc, dev)
+		debugfs_create_file("dither", 0444, crtc->debugfs_entry, crtc,
+				    &dither_state_fops);
+

See intel_crtc_debugfs_add(), called from intel_crtc_late_register().

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +0 -0
 	for (i = 0; i < ARRAY_SIZE(intel_display_debugfs_files); i++) {
 		debugfs_create_file(intel_display_debugfs_files[i].name,
 				    S_IRUGO | S_IWUSR,
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#15 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

Quoted 65 lines

From: Ville Syrjälä <[email protected]>
Sent: Wednesday, May 26, 2021 8:08 PM
To: Jani Nikula <[email protected]>
Cc: Modem, Bhanuprakash <[email protected]>; intel- [email protected]; Varide, Nischal <[email protected]>; Shankar, Uma <[email protected]>; Gupta, Anshuman <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

Quoted 1 line · Jani Nikula

On Wed, 26 May 2021, Bhanuprakash Modem <[email protected]>

Quoted 14 lines · wrote:
Quoted 14 lines

It's useful to know the dithering state & pipe bpc for IGT testing. This patch will expose the dithering state for the crtc via a debugfs file "dither".

Example usage: cat /sys/kernel/debug/dri/0/crtc-0/dither

Cc Uma Shankar <[email protected]>
Cc Nischal Varide <[email protected]>
Cc Matt Roper <[email protected]>
---
 .../drm/i915/display/intel_display_debugfs.c  | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
Quoted 1 line

Review

Quoted 1 line
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/display/intel_display_debugfs.c

Quoted 36 lines
Quoted 6 lines

index 94e5cbd86e77..a6fefc7d5ab9 100644

drivers/gpu/drm/i915/display/intel_display_debugfs.c +0 -0
@@ -2158,11 +2158,43 @@ static const struct {
 	{"i915_edp_psr_debug", &i915_edp_psr_debug_fops},
 };

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2169

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +9 -0
 
+static int dither_state_show(struct seq_file *m, void *data)
+{
+	struct intel_crtc *crtc = to_intel_crtc(m->private);
+	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
+	struct intel_crtc_state *crtc_state;
+	int ret;
+
+	if (!HAS_DISPLAY(dev_priv))
+		return -ENODEV;

Unneeded.

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2179

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +10 -0
+
+	ret = drm_modeset_lock_single_interruptible(&crtc->base.mutex);
+	if (ret)
+		return ret;
+
+	crtc_state = to_intel_crtc_state(crtc->base.state);
+	seq_printf(m, "bpc: %u\n", crtc_state->pipe_bpp / 3);
+	seq_printf(m, "Dither: %u\n", (crtc_state->dither) ? 1 : 0);
+	seq_printf(m, "Dither_CC1: %u\n",
+		(crtc_state->gamma_mode & GAMMA_MODE_DITHER_AFTER_CC1) ? 1 : 0);

Are you looking to duplicate the conditions for enabling this CC1 mode in IGT, and then checking if the driver set the bit as well?

I thought the direction has been that we don't do this type of validation in IGT. There is no end to it.

Quoted 7 lines
Quoted 1 line

Ville?

Yeah, I hate all the ad-hoc debugfs files. They just get in the way of refactoring all the time.

For state dumps we should just fix the midlayer crap in the atomic state dump framework and start using it.

AFAIK, user needs to trust the driver and atomic state checker will make sure the computed s/w state data is properly written to the h/w, and if there is a mismatch Kernel will throw the WARN.

What if the s/w state computation itself is wrong?

Example:
For 12-bpc panels, dither should be enabled after CC1 and disabled at end of pipe. Suppose, we have a bug in the driver and dither at end of pipe is enabled, still atomic state checkers are success.

I can see below options are useful:
1) We can add specific conditional checks in atomic state checkers for different scenarios, so that kernel will throw WARN.

2) As "dither_legacy", "pipe bpp" are already exposed to "i915_display_info" we can add "diter_cc1" to the same node instead of creating new nodes [*]. Then we can have robust checks in IGT.

Ville, Jani please suggest to proceed further.

[*]: https://patchwork.freedesktop.org/patch/439720

- Bhanu

Quoted 27 lines
Quoted 27 lines
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +7 -0
+
+	drm_modeset_unlock(&crtc->base.mutex);
+
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(dither_state);
+
 void intel_display_debugfs_register(struct drm_i915_private *i915)

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2197

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +6 -0
 {
 	struct drm_minor *minor = i915->drm.primary;
+	struct drm_device *dev = &i915->drm;
+	struct drm_crtc *crtc;
 	int i;
 
+	drm_for_each_crtc(crtc, dev)
+		debugfs_create_file("dither", 0444, crtc->debugfs_entry, crtc,
+				    &dither_state_fops);
+

See intel_crtc_debugfs_add(), called from intel_crtc_late_register().

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +0 -0
 	for (i = 0; i < ARRAY_SIZE(intel_display_debugfs_files); i++) {
 		debugfs_create_file(intel_display_debugfs_files[i].name,
 				    S_IRUGO | S_IWUSR,
Quoted 6 lines
Quoted 2 lines

--
Jani Nikula, Intel Open Source Graphics Center

--
Ville Syrjälä
Intel

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#16 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

In reply to Jani Nikula
Quoted 46 lines

From: Jani Nikula <[email protected]>
Sent: Wednesday, May 26, 2021 7:57 PM
To: Modem, Bhanuprakash <[email protected]>; intel- [email protected]; Varide, Nischal <[email protected]>; Shankar, Uma <[email protected]>; Gupta, Anshuman <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/display/debug: Expose Dither status via debugfs

Quoted 10 lines · Bhanuprakash Modem

It's useful to know the dithering state & pipe bpc for IGT testing. This patch will expose the dithering state for the crtc via a debugfs file "dither".

Example usage: cat /sys/kernel/debug/dri/0/crtc-0/dither

Cc Uma Shankar <[email protected]>
Cc Nischal Varide <[email protected]>
Cc Matt Roper <[email protected]>

Review

Quoted 5 lines
---
 .../drm/i915/display/intel_display_debugfs.c  | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/display/intel_display_debugfs.c

Quoted 6 lines

index 94e5cbd86e77..a6fefc7d5ab9 100644

drivers/gpu/drm/i915/display/intel_display_debugfs.c +0 -0
@@ -2158,11 +2158,43 @@ static const struct {
 	{"i915_edp_psr_debug", &i915_edp_psr_debug_fops},
 };

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2169

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +9 -0
 
+static int dither_state_show(struct seq_file *m, void *data)
+{
+	struct intel_crtc *crtc = to_intel_crtc(m->private);
+	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
+	struct intel_crtc_state *crtc_state;
+	int ret;
+
+	if (!HAS_DISPLAY(dev_priv))
+		return -ENODEV;

Unneeded.

Quoted 13 lines

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2179

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +10 -0
+
+	ret = drm_modeset_lock_single_interruptible(&crtc->base.mutex);
+	if (ret)
+		return ret;
+
+	crtc_state = to_intel_crtc_state(crtc->base.state);
+	seq_printf(m, "bpc: %u\n", crtc_state->pipe_bpp / 3);
+	seq_printf(m, "Dither: %u\n", (crtc_state->dither) ? 1 : 0);
+	seq_printf(m, "Dither_CC1: %u\n",
+		(crtc_state->gamma_mode & GAMMA_MODE_DITHER_AFTER_CC1) ? 1 : 0);

Are you looking to duplicate the conditions for enabling this CC1 mode in IGT, and then checking if the driver set the bit as well?

From IGT we just request a flip/modeset by setting "max bpc" prop with different values & check for the dithering status. I found debugfs is the best way to get this dither status info, since we don't have any KMS prop to expose this info. Otherwise, we need to read the registers and bitmask to get the dither status which is hectic.

- Bhanu

Quoted 27 lines

I thought the direction has been that we don't do this type of validation in IGT. There is no end to it.

Ville?

Quoted 8 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +7 -0
+
+	drm_modeset_unlock(&crtc->base.mutex);
+
+	return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(dither_state);
+
 void intel_display_debugfs_register(struct drm_i915_private *i915)

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2197

Quoted 10 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +6 -0
 {
 	struct drm_minor *minor = i915->drm.primary;
+	struct drm_device *dev = &i915->drm;
+	struct drm_crtc *crtc;
 	int i;
 
+	drm_for_each_crtc(crtc, dev)
+		debugfs_create_file("dither", 0444, crtc->debugfs_entry, crtc,
+				    &dither_state_fops);
+

See intel_crtc_debugfs_add(), called from intel_crtc_late_register().

Quoted 6 lines

drivers/gpu/drm/i915/display/intel_display_debugfs.c static const struct { · line 2200

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display_debugfs.c +0 -0
 	for (i = 0; i < ARRAY_SIZE(intel_display_debugfs_files); i++) {
 		debugfs_create_file(intel_display_debugfs_files[i].name,
 				    S_IRUGO | S_IWUSR,

--
Jani Nikula, Intel Open Source Graphics Center

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#17 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/xelpd: Enabling dithering after the CC1

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: drm/i915/xelpd: Enabling dithering after the CC1
URL : https://patchwork.freedesktop.org/series/90594/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
41e126e0ef3b drm/i915/xelpd: Enabling dithering after the CC1
-:27: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'crtc_state->pipe_bpp == 36'
#27: FILE: drivers/gpu/drm/i915/display/intel_color.c:1614:
+		if (!crtc_state->dither_force_disable &&
+		    (crtc_state->pipe_bpp == 36))

-:60: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'crtc_state->pipe_bpp != 36' #60: FILE: drivers/gpu/drm/i915/display/intel_display.c:5749:
+ if (crtc_state->dither && (crtc_state->pipe_bpp != 36))

total: 0 errors, 0 warnings, 2 checks, 55 lines checked f4a00c25cb0b drm/i915/display/debug: Expose Dither status via debugfs -:43: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #43: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2179:
+ seq_printf(m, "Dither_CC1: %u\n",
+ (crtc_state->gamma_mode & GAMMA_MODE_DITHER_AFTER_CC1) ? 1 : 0);

total: 0 errors, 0 warnings, 1 checks, 43 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#18 lore raw

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/xelpd: Enabling dithering after the CC1

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: drm/i915/xelpd: Enabling dithering after the CC1
URL : https://patchwork.freedesktop.org/series/90594/
State : warning

== Summary ==

$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/intel_display.c:1887:21:    expected struct i915_vma *[assigned] vma
+drivers/gpu/drm/i915/display/intel_display.c:1887:21:    got void [noderef] __iomem *[assigned] iomem
+drivers/gpu/drm/i915/display/intel_display.c:1887:21: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_reset.c:1328:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block
+drivers/gpu/drm/i915/gt/intel_ring_submission.c:1207:24: warning: Using plain integer as NULL pointer
+drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216
+drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216
+./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080)
+./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080)
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#19 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/xelpd: Enabling dithering after the CC1

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: drm/i915/xelpd: Enabling dithering after the CC1
URL : https://patchwork.freedesktop.org/series/90594/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10133 -> Patchwork_20202
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/index.html

Known issues
------------

Here are the changes found in Patchwork_20202 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][1] ([i915#2283])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-bdw-5557u/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [PASS][2] -> [FAIL][3] ([i915#1888]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-tgl-u2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-tgl-u2/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bdw-5557u: NOTRUN -> [DMESG-FAIL][4] ([i915#3462])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-bdw-5557u/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- fi-kbl-soraka: [PASS][5] -> [INCOMPLETE][6] ([i915#2782])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-kbl-soraka/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-kbl-soraka/igt@i915_selftest@[email protected]

* igt@kms_psr@cursor_plane_move:
- fi-bdw-5557u: NOTRUN -> [SKIP][7] ([fdo#109271]) +5 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html

#### Possible fixes ####

* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [FAIL][8] ([i915#49]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-icl-u2/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-icl-u2/igt@[email protected]

#### Warnings ####

* igt@i915_selftest@live@execlists:
- fi-tgl-u2: [INCOMPLETE][10] ([i915#3462]) -> [DMESG-FAIL][11] ([i915#3462])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-tgl-u2/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-tgl-u2/igt@i915_selftest@[email protected]

* igt@runner@aborted:
- fi-kbl-x1275: [FAIL][12] ([i915#1436] / [i915#3363]) -> [FAIL][13] ([i915#1436] / [i915#2426] / [i915#3363])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-kbl-x1275/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-kbl-x1275/igt@[email protected]
- fi-glk-dsi: [FAIL][14] ([i915#2426] / [i915#3363] / [k.org#202321]) -> [FAIL][15] ([i915#3363] / [k.org#202321])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-glk-dsi/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-glk-dsi/igt@[email protected]
- fi-bdw-5557u: [FAIL][16] ([i915#1602] / [i915#2029]) -> [FAIL][17] ([i915#3462])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-bdw-5557u/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-bdw-5557u/igt@[email protected]
- fi-kbl-soraka: [FAIL][18] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][19] ([i915#1436] / [i915#3363])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-kbl-soraka/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-kbl-soraka/igt@[email protected]
- fi-cml-u2: [FAIL][20] ([i915#2082] / [i915#2426] / [i915#3363] / [i915#3462]) -> [FAIL][21] ([i915#3363] / [i915#3462])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-cml-u2/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-cml-u2/igt@[email protected]
- fi-cfl-guc: [FAIL][22] ([i915#3363]) -> [FAIL][23] ([i915#2426] / [i915#3363])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/fi-cfl-guc/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/fi-cfl-guc/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2932]: https://gitlab.freedesktop.org/drm/intel/issues/2932
[i915#2966]: https://gitlab.freedesktop.org/drm/intel/issues/2966
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3276]: https://gitlab.freedesktop.org/drm/intel/issues/3276
[i915#3277]: https://gitlab.freedesktop.org/drm/intel/issues/3277
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3283]: https://gitlab.freedesktop.org/drm/intel/issues/3283
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321

Participating hosts (45 -> 41)
------------------------------

Additional (1): fi-rkl-11500t
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_10133 -> Patchwork_20202

CI-20190529: 20190529
CI_DRM_10133: 79cace2bbe3bb9cbff1aa14428adea42072b56b0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6092: d87087c321da07035d4f96d98c34e451b3ccb809 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_20202: f4a00c25cb0bf63792e9f2cde420725ad1233db3 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

f4a00c25cb0b drm/i915/display/debug: Expose Dither status via debugfs 41e126e0ef3b drm/i915/xelpd: Enabling dithering after the CC1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#20 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/xelpd: Enabling dithering after the CC1

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: drm/i915/xelpd: Enabling dithering after the CC1
URL : https://patchwork.freedesktop.org/series/90594/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10133_full -> Patchwork_20202_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_20202_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_20202_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_20202_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_mmap_offset@clear:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb5/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb6/igt@[email protected]

### Piglit changes ###

#### Possible regressions ####

* spec@arb_shader_image_size@builtin (NEW):
- pig-skl-6260u: NOTRUN -> [INCOMPLETE][3] +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/pig-skl-6260u/spec@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_10133_full and Patchwork_20202_full:

### New Piglit tests (3) ###

* spec@arb_shader_image_size@builtin:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s

* spec@arb_shader_texture_image_samples@builtin-image:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s

* spec@arb_texture_stencil8@draw:
- Statuses : 1 incomplete(s)
- Exec time: [0.0] s

Known issues
------------

Here are the changes found in Patchwork_20202_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-snb: NOTRUN -> [DMESG-WARN][4] ([i915#3002])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-snb2/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][5] ([i915#3002])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl7/igt@[email protected]

* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-snb6/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-apl: NOTRUN -> [FAIL][7] ([i915#2846])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl8/igt@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-glk7/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-glk4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-wide-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][12] ([i915#2389])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb1/igt@gem_exec_reloc@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#2190])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl7/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy:
- shard-tglb: [PASS][14] -> [INCOMPLETE][15] ([i915#3468])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-tglb6/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-tglb6/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-iclb: [PASS][16] -> [INCOMPLETE][17] ([i915#2910] / [i915#3468])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb5/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb1/igt@[email protected]
- shard-skl: NOTRUN -> [INCOMPLETE][18] ([i915#198] / [i915#2910] / [i915#3468])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl3/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-kbl: [PASS][19] -> [INCOMPLETE][20] ([i915#3468])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl4/igt@[email protected]
- shard-iclb: [PASS][21] -> [INCOMPLETE][22] ([i915#3468])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb4/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-medium-copy-xy:
- shard-glk: [PASS][23] -> [INCOMPLETE][24] ([i915#3468])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-glk2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-glk4/igt@[email protected]

* igt@gem_mmap_gtt@fault-concurrent:
- shard-snb: NOTRUN -> [INCOMPLETE][25] ([i915#3468])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-snb2/igt@[email protected]
- shard-kbl: NOTRUN -> [INCOMPLETE][26] ([i915#3468])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl3/igt@[email protected]

* igt@gem_mmap_gtt@fault-concurrent-x:
- shard-snb: NOTRUN -> [INCOMPLETE][27] ([i915#3468] / [i915#3485])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-snb2/igt@[email protected]

* igt@gem_mmap_gtt@fault-concurrent-y:
- shard-skl: NOTRUN -> [INCOMPLETE][28] ([i915#3468])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl7/igt@[email protected]

* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#768])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb4/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][30] ([i915#2724])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-snb6/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-skl: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl8/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl7/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#1937])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl2/igt@i915_pm_lpsp@[email protected]

* igt@i915_selftest@live@execlists:
- shard-apl: NOTRUN -> [DMESG-FAIL][34] ([i915#3462])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl3/igt@i915_selftest@[email protected]

* igt@i915_suspend@forcewake:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([i915#146] / [i915#636])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl3/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#109284] / [fdo#111827])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-tglb2/igt@[email protected]

* igt@kms_chamelium@vga-hpd:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +20 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl7/igt@[email protected]

* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +3 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl2/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-0-25:
- shard-snb: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +15 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-snb2/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +6 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl2/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][42] ([i915#1319]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-32x32-random:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#3319])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [PASS][44] -> [DMESG-WARN][45] ([i915#180])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-apl7/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][46] -> [DMESG-WARN][47] ([i915#180]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl7/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl7/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge:
- shard-snb: NOTRUN -> [SKIP][48] ([fdo#109271]) +291 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-snb2/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-torture-move:
- shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271]) +68 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl2/igt@[email protected]

* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109274]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb4/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#2672])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#2642])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109280])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render:
- shard-skl: NOTRUN -> [FAIL][54] ([i915#49])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-render.html

* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][55] -> [FAIL][56] ([i915#1188])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl3/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#533]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-skl: NOTRUN -> [FAIL][58] ([fdo#108145] / [i915#265])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][59] ([fdo#108145] / [i915#265]) +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][60] ([i915#265])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl8/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][61] ([fdo#108145] / [i915#265]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][62] -> [FAIL][63] ([fdo#108145] / [i915#265])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl3/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl4/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl3/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#658]) +5 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl3/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-skl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#658])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl3/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_cursor_plane_move:
- shard-tglb: NOTRUN -> [FAIL][67] ([i915#132] / [i915#3467])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-tglb2/igt@kms_psr@psr2_cursor_plane_move.html

* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][68] -> [SKIP][69] ([fdo#109441]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb6/igt@kms_psr@psr2_cursor_render.html

* igt@kms_psr@suspend:
- shard-skl: [PASS][70] -> [INCOMPLETE][71] ([i915#146] / [i915#198])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl6/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl6/igt@[email protected]

* igt@kms_tv_load_detect@load-detect:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109309])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb4/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][73] -> [DMESG-WARN][74] ([i915#180] / [i915#295])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl3/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl7/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#533])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl3/igt@[email protected]

* igt@kms_writeback@writeback-invalid-parameters:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#2437])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl6/igt@[email protected]

* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271]) +234 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl7/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html

* igt@prime_nv_api@i915_self_import:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#109291])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-tglb2/igt@prime_nv_api@i915_self_import.html

* igt@prime_nv_pcopy@test2:
- shard-kbl: NOTRUN -> [SKIP][79] ([fdo#109271]) +50 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl2/igt@[email protected]

* igt@prime_vgem@sync@rcs0:
- shard-iclb: [PASS][80] -> [INCOMPLETE][81] ([i915#409])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb2/igt@prime_vgem@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb6/igt@prime_vgem@[email protected]

* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#2994]) +4 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-apl3/igt@[email protected]

* igt@sysfs_clients@sema-25:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2994]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl2/igt@[email protected]

#### Possible fixes ####

* igt@gem_eio@in-flight-suspend:
- shard-skl: [INCOMPLETE][84] ([i915#146] / [i915#198]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl10/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl2/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][86] ([i915#2842]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-tglb5/igt@gem_exec_fair@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-tglb2/igt@gem_exec_fair@[email protected]
- shard-glk: [FAIL][88] ([i915#2842]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-glk6/igt@gem_exec_fair@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-glk6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [SKIP][90] ([fdo#109271]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@gem_exec_fair@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_mmap_gtt@big-copy:
- shard-glk: [FAIL][92] ([i915#307]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-glk7/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-glk7/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy:
- shard-skl: [INCOMPLETE][94] ([i915#198] / [i915#3468]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl10/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl2/igt@[email protected]
- shard-kbl: [INCOMPLETE][96] ([i915#3468]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl4/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl2/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-tglb: [INCOMPLETE][98] ([i915#2910] / [i915#3468]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-tglb3/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-tglb2/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-medium-copy-odd:
- shard-iclb: [FAIL][100] ([i915#307]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb6/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb1/igt@[email protected]

* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-glk: [FAIL][102] ([i915#644]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-glk1/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-glk4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x256-onscreen:
- shard-skl: [FAIL][104] ([i915#3444]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl4/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl5/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][106] ([i915#72]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-glk5/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-glk7/igt@[email protected]

* igt@kms_flip@flip-vs-rmfb@a-edp1:
- shard-skl: [DMESG-WARN][108] ([i915#1982]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl1/igt@kms_flip@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][110] ([i915#180]) -> [PASS][111] +3 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][112] ([fdo#108145] / [i915#265]) -> [PASS][113] +1 similar issue
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl5/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl1/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][114] ([fdo#109441]) -> [PASS][115] +3 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

* igt@perf@polling-parameterized:
- shard-skl: [FAIL][116] ([i915#1542]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl9/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl6/igt@[email protected]

* igt@perf@polling-small-buf:
- shard-skl: [FAIL][118] ([i915#1722]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-skl9/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-skl6/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][120] ([i915#2684]) -> [WARN][121] ([i915#1804] / [i915#2684])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb1/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb7/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-tglb: [WARN][122] ([i915#2681] / [i915#2684]) -> [FAIL][123] ([i915#2681])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-tglb7/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-tglb2/igt@[email protected]
- shard-iclb: [WARN][124] ([i915#1804] / [i915#2684]) -> [WARN][125] ([i915#2684])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb6/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb1/igt@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-iclb: [SKIP][126] ([i915#2920]) -> [SKIP][127] ([i915#658]) +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb2/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb4/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][128] ([i915#658]) -> [SKIP][129] ([i915#2920]) +2 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-iclb1/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-iclb2/igt@[email protected]

* igt@runner@aborted:
- shard-kbl: ([FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2722] / [i915#3002] / [i915#3363]) -> ([FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2722] / [i915#3002] / [i915#3363] / [i915#602])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl2/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl2/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl7/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl4/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl2/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl7/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl3/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl1/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10133/shard-kbl3/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl3/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl1/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl2/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl3/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/shard-kbl1/igt@runner@abo

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20202/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#21 lore raw

v3 cover Enabling dithering after the CC1

In reply to Bhanuprakash Modem

v3 : Addressed Review Comments by (Bhanu)

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

If the panel is 12bpc and display_ver < 13 then we can not enable dithering at all.So this v3 version of the patch has added an extra check to fix it.

Nischal Varide (1):
drm/i915/xelpd: Enabling dithering after the CC1

 drivers/gpu/drm/i915/display/intel_color.c   |  7 +++++++
 drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++++++-
 drivers/gpu/drm/i915/i915_reg.h              |  1 +
 3 files changed, 18 insertions(+), 1 deletion(-)
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#22 lore raw

PATCH v3 1/1 drm/i915/xelpd: Enabling dithering after the CC1

If the panel is 12bpc then Dithering is not enabled in the Legacy dithering block , instead its Enabled after the C1 CC1 pipe post color space conversion.For a 6bpc pannel Dithering is enabled in Legacy block.

---
 drivers/gpu/drm/i915/display/intel_color.c   |  7 +++++++
 drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++++++-
 drivers/gpu/drm/i915/i915_reg.h              |  1 +
 3 files changed, 18 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_color.c +7 -0
index dab892d2251b..e11b3dbf0b95 100644
@@ -1574,6 +1574,7 @@ static int glk_color_check(struct intel_crtc_state *crtc_state)
 static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state)
 {
 	u32 gamma_mode = 0;
+	struct drm_i915_private *i915 = to_i915(crtc_state->uapi.crtc->dev);
 
 	if (crtc_state->hw.degamma_lut)
 		gamma_mode |= PRE_CSC_GAMMA_ENABLE;
@@ -1588,6 +1589,12 @@ static u32 icl_gamma_mode(const struct intel_crtc_state *crtc_state)
 	else
 		gamma_mode |= GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED;
 
+	if (DISPLAY_VER(i915) >= 13) {
+		if (!crtc_state->dither_force_disable &&
+				(crtc_state->pipe_bpp == 36))
+			gamma_mode |= POST_CC1_GAMMA_ENABLE;
+	}
+
 	return gamma_mode;
 }
 
drivers/gpu/drm/i915/display/intel_display.c +10 -1
index caf0414e0b50..5345779cfce2 100644
@@ -5762,7 +5762,16 @@ static void bdw_set_pipemisc(const struct intel_crtc_state *crtc_state)
 		break;
 	}
 
-	if (crtc_state->dither)
+	/*
+	 * If 12bpc panel then, Enables dithering after the CC1 pipe
+	 * post color space conversion and not here for display_ver
+	 * greater than or equal to thirteen.
+	 */
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))
+		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
+
+	if (crtc_state->dither && (crtc_state->pipe_bpp == 36) && (DISPLAY_VER(dev_priv) < 13))
 		val |= PIPEMISC_DITHER_ENABLE | PIPEMISC_DITHER_TYPE_SP;
 
 	if (crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420 ||
drivers/gpu/drm/i915/i915_reg.h +1 -0
index 24307c49085f..fa800a77ea49 100644
@@ -7743,6 +7743,7 @@ enum {
 #define GAMMA_MODE(pipe) _MMIO_PIPE(pipe, _GAMMA_MODE_A, _GAMMA_MODE_B)
 #define  PRE_CSC_GAMMA_ENABLE	(1 << 31)
 #define  POST_CSC_GAMMA_ENABLE	(1 << 30)
+#define  POST_CC1_GAMMA_ENABLE  (1 << 26)
 #define  GAMMA_MODE_MODE_MASK	(3 << 0)
 #define  GAMMA_MODE_MODE_8BIT	(0 << 0)
 #define  GAMMA_MODE_MODE_10BIT	(1 << 0)
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#23 lore raw

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/xelpd: Enabling dithering after the CC1 (rev3)

In reply to Bhanuprakash Modem
== Series Details ==

== Series Details ==

Series: drm/i915/xelpd: Enabling dithering after the CC1 (rev3)
URL : https://patchwork.freedesktop.org/series/90594/
State : failure

== Summary ==

CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/display/intel_display_debugfs.o
drivers/gpu/drm/i915/display/intel_display_debugfs.c: In function ‘dither_state_show’:
drivers/gpu/drm/i915/display/intel_display_debugfs.c:2179:29: error: ‘GAMMA_MODE_DITHER_AFTER_CC1’ undeclared (first use in this function); did you mean ‘DRM_MODE_DITHERING_ON’?

   (crtc_state->gamma_mode & GAMMA_MODE_DITHER_AFTER_CC1) ? 1 : 0);
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                             DRM_MODE_DITHERING_ON

drivers/gpu/drm/i915/display/intel_display_debugfs.c:2179:29: note: each undeclared identifier is reported only once for each function it appears in scripts/Makefile.build:272: recipe for target 'drivers/gpu/drm/i915/display/intel_display_debugfs.o' failed
make[4]: *** [drivers/gpu/drm/i915/display/intel_display_debugfs.o] Error 1
scripts/Makefile.build:515: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:515: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:515: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1844: recipe for target 'drivers' failed
make: *** [drivers] Error 2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx