xfs: fix check of whether the mkfs fail
PATCH 1/1 xfs: fix check of whether the mkfs fail
The return value ("$?") is always the status of the last command in the pipe.
Signed-off-by Sun Ke <[email protected]>
--- tests/xfs/070 | 3 ++- tests/xfs/448 | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
tests/xfs/070 +2 -1
@@ -84,7 +84,8 @@ _supported_fs xfs _require_scratch_nocheck _require_command "$KILLALL_PROG" killall -_scratch_mkfs | _filter_mkfs > /dev/null 2> $tmp.mkfs || _fail "mkfs failed" +_scratch_mkfs | _filter_mkfs > /dev/null 2> $tmp.mkfs +test "${PIPESTATUS[0]}" -eq 0 || _fail "mkfs failed" . $tmp.mkfs # import agcount
tests/xfs/448 +2 -1
@@ -47,7 +47,8 @@ _require_no_xfs_bug_on_assert rm -f "$seqres.full" # Format and mount -_scratch_mkfs | _filter_mkfs > $seqres.full 2> $tmp.mkfs || _fail "mkfs failed" +_scratch_mkfs | _filter_mkfs > $seqres.full 2> $tmp.mkfs +test "${PIPESTATUS[0]}" -eq 0 || _fail "mkfs failed" _scratch_mount # Get directory block size
Signature · 1 line
2.25.4
Quoted 3 lines · Sun Ke
The return value ("$?") is always the status of the last command in the pipe.
Signed-off-by Sun Ke <[email protected]>
Heh, whooops. Thanks for fixing this!
Reviewed-by Darrick J. Wong <[email protected]>
--D
Quoted 36 lines
--- tests/xfs/070 | 3 ++- tests/xfs/448 | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)tests/xfs/070 +2
-1@@ -84,7 +84,8 @@ _supported_fs xfs _require_scratch_nocheck _require_command "$KILLALL_PROG" killall -_scratch_mkfs | _filter_mkfs > /dev/null 2> $tmp.mkfs || _fail "mkfs failed" +_scratch_mkfs | _filter_mkfs > /dev/null 2> $tmp.mkfs +test "${PIPESTATUS[0]}" -eq 0 || _fail "mkfs failed" . $tmp.mkfs # import agcounttests/xfs/448 +2
-1@@ -47,7 +47,8 @@ _require_no_xfs_bug_on_assert rm -f "$seqres.full" # Format and mount -_scratch_mkfs | _filter_mkfs > $seqres.full 2> $tmp.mkfs || _fail "mkfs failed" +_scratch_mkfs | _filter_mkfs > $seqres.full 2> $tmp.mkfs +test "${PIPESTATUS[0]}" -eq 0 || _fail "mkfs failed" _scratch_mount # Get directory block sizeSignature · 1 line
2.25.4
Quoted 9 lines · Darrick J. Wong
Quoted 3 lines · Sun Ke
The return value ("$?") is always the status of the last command in the pipe.
Signed-off-by Sun Ke <[email protected]>Heh, whooops. Thanks for fixing this!
Reviewed-by Darrick J. Wong <[email protected]>--D
Thanks for your review.