Skip to contentSkip to conversation

Fix cache aging cleanup of threads

PATCH In review Rob Herring 2 participants 2 messages Jun 1, 2021

lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 Fix cache aging cleanup of threads

The cache aging for threads was not running resulting in failures to fetch new messages in threads. Fix the empty cache check which should be for no '.msgs' directories.

Fixes 4950093c0c3e ("Don't use mboxo for anything")
Signed-off-by Rob Herring <[email protected]>
---
 b4/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
b4/__init__.py +1 -1
index e16ebe6c8a37..c0ff004eb88d 100644
@@ -1882,7 +1882,7 @@ def get_cache_dir(appname: str = 'b4') -> str:
         expmin = 600
     expage = time.time() - expmin
     for entry in os.listdir(cachedir):
-        if entry.find('.mbx') <= 0 and entry.find('.lookup') <= 0 and entry.find('.msgs'):
+        if entry.find('.mbx') <= 0 and entry.find('.lookup') <= 0 and entry.find('.msgs') <= 0:
             continue
         fullpath = os.path.join(cachedir, entry)
         st = os.stat(fullpath)
Signature · 1 line
2.27.0
#1 lore raw
Quoted 3 lines · Rob Herring

The cache aging for threads was not running resulting in failures to fetch new messages in threads. Fix the empty cache check which should be for no '.msgs' directories.

Ugh, thanks for finding that. Applied to both master and stable-0.7.y. This is bad enough to roll a 0.7.1 soon.

[1/1] Fix cache aging cleanup of threads

      commit: b29c92d3e0a74024ce30c2eaf0cd6f9c5ca1fae9

Best regards,

Signature · 1 line
Konstantin Ryabitsev <[email protected]>