Skip to contentSkip to conversation

drm/i915/gem/mman: only allow WC for lmem

PATCH Superseded Matthew Auld 3 participants 6 messages Jun 2, 2021 – Jun 8, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gem/mman: only allow WC for lmem

For dgfx where we now have lmem and ttm, we can only support single mmap mode for the lifetime of the object, and for lmem objects this should be WC, so reject all other mapping modes for mmap_offset, including if the object can be placed in both smem and lmem.

Cc Thomas Hellström <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 drivers/gpu/drm/i915/gem/i915_gem_mman.c   |  4 ++++
 drivers/gpu/drm/i915/gem/i915_gem_object.c | 22 ++++++++++++++++++++++
 drivers/gpu/drm/i915/gem/i915_gem_object.h |  4 ++++
 3 files changed, 30 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_mman.c +4 -0
index fd1c9714f8d8..32f88f236771 100644
@@ -689,6 +689,10 @@ __assign_mmap_offset(struct drm_file *file,
 		goto out;
 	}
 
+	if (mmap_type != I915_MMAP_TYPE_WC &&
+	    i915_gem_object_placements_contain_type(obj, INTEL_MEMORY_LOCAL))
+		return -ENODEV;
+
 	mmo = mmap_offset_attach(obj, mmap_type, file);
 	if (IS_ERR(mmo)) {
 		err = PTR_ERR(mmo);
drivers/gpu/drm/i915/gem/i915_gem_object.c +22 -0
index 2be6109d0093..d4b0da8ed969 100644
@@ -403,6 +403,28 @@ int i915_gem_object_read_from_page(struct drm_i915_gem_object *obj, u64 offset,
 	return 0;
 }
 
+/**
+ * i915_gem_object_placements_contain_type - Check whether the object can be
+ * placed at certain memory type
+ * @obj: Pointer to the object
+ * @type: The memory type to check
+ *
+ * Return: True if the object can be placed in @type. False otherwise.
+ */
+bool i915_gem_object_placements_contain_type(struct drm_i915_gem_object *obj,
+					     enum intel_memory_type type)
+{
+	unsigned int i;
+
+	/* TODO: consider maybe storing as a mask when doing gem_create_ext */
+	for (i = 0; i < obj->mm.n_placements; i++) {
+		if (obj->mm.placements[i]->type == type)
+			return true;
+	}
+
+	return false;
+}
+
 void i915_gem_init__objects(struct drm_i915_private *i915)
 {
 	INIT_WORK(&i915->mm.free_work, __i915_gem_free_work);
drivers/gpu/drm/i915/gem/i915_gem_object.h +4 -0
index 2ebd79537aea..4d6ea9e07df0 100644
@@ -12,6 +12,7 @@
 #include <drm/drm_device.h>
 
 #include "display/intel_frontbuffer.h"
+#include "intel_memory_region.h"
 #include "i915_gem_object_types.h"
 #include "i915_gem_gtt.h"
 #include "i915_vma_types.h"
@@ -587,6 +588,9 @@ int i915_gem_object_read_from_page(struct drm_i915_gem_object *obj, u64 offset,
 
 bool i915_gem_object_is_shmem(const struct drm_i915_gem_object *obj);
 
+bool i915_gem_object_placements_contain_type(struct drm_i915_gem_object *obj,
+					     enum intel_memory_type type);
+
 #ifdef CONFIG_MMU_NOTIFIER
 static inline bool
 i915_gem_object_is_userptr(struct drm_i915_gem_object *obj)
Signature · 6 lines
2.26.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem/mman: only allow WC for lmem

== Series Details ==

== Series Details ==

Series: drm/i915/gem/mman: only allow WC for lmem
URL : https://patchwork.freedesktop.org/series/90875/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10159 -> Patchwork_20263
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/index.html

Known issues
------------

Here are the changes found in Patchwork_20263 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][1] -> [INCOMPLETE][2] ([i915#2782])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/fi-snb-2600/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/fi-snb-2600/igt@i915_selftest@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [FAIL][3] ([i915#1888]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/fi-tgl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/fi-tgl-u2/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- fi-bdw-5557u: [DMESG-FAIL][5] -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/fi-bdw-5557u/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/fi-bdw-5557u/igt@i915_selftest@live@gt_heartbeat.html

#### Warnings ####

* igt@i915_selftest@live@execlists:
- fi-tgl-u2: [INCOMPLETE][7] ([i915#3462]) -> [DMESG-FAIL][8] ([i915#3462])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/fi-tgl-u2/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/fi-tgl-u2/igt@i915_selftest@[email protected]

* igt@runner@aborted:
- fi-glk-dsi: [FAIL][9] ([i915#3363] / [k.org#202321]) -> [FAIL][10] ([i915#2426] / [i915#3363] / [k.org#202321])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/fi-glk-dsi/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/fi-glk-dsi/igt@[email protected]
- fi-cml-u2: [FAIL][11] ([i915#2082] / [i915#2426] / [i915#3363] / [i915#3462]) -> [FAIL][12] ([i915#3363] / [i915#3462])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/fi-cml-u2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/fi-cml-u2/igt@[email protected]

[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2082]: https://gitlab.freedesktop.org/drm/intel/issues/2082
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321

Participating hosts (46 -> 41)
------------------------------

Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_10159 -> Patchwork_20263

CI-20190529: 20190529
CI_DRM_10159: cd6eb5f605478f2fff85ec7ac39b7cf445d3deb9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6098: 1fbc1e7d602f96a7f4e2b95057eef994656b8e74 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_20263: 7c89c545d78b4e23b1a2d13f2d8da8eebdc3a0bf @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

7c89c545d78b drm/i915/gem/mman: only allow WC for lmem

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Matthew Auld

Hi,

Quoted 20 lines · Matthew Auld

For dgfx where we now have lmem and ttm, we can only support single mmap mode for the lifetime of the object, and for lmem objects this should be WC, so reject all other mapping modes for mmap_offset, including if the object can be placed in both smem and lmem.

Cc Thomas Hellström <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Daniel Vetter <[email protected]>
---
  drivers/gpu/drm/i915/gem/i915_gem_mman.c   |  4 ++++
  drivers/gpu/drm/i915/gem/i915_gem_object.c | 22 ++++++++++++++++++++++
  drivers/gpu/drm/i915/gem/i915_gem_object.h |  4 ++++
  3 files changed, 30 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_mman.c +0 -0
index fd1c9714f8d8..32f88f236771 100644

drivers/gpu/drm/i915/gem/i915_gem_mman.c __assign_mmap_offset(struct drm_file *file, · line 695

Quoted 7 lines
drivers/gpu/drm/i915/gem/i915_gem_mman.c +4 -0
@@ -689,6 +689,10 @@ __assign_mmap_offset(struct drm_file *file,
  		goto out;
  	}
 
+	if (mmap_type != I915_MMAP_TYPE_WC &&
+	    i915_gem_object_placements_contain_type(obj, INTEL_MEMORY_LOCAL))
+		return -ENODEV;
+

I think we will also have the restriction that any other objects on DGFX can only be mapped cached? At least that's what the TTM code is implementing currently.

Quoted 23 lines
drivers/gpu/drm/i915/gem/i915_gem_mman.c +0 -0
  	mmo = mmap_offset_attach(obj, mmap_type, file);
  	if (IS_ERR(mmo)) {
  		err = PTR_ERR(mmo);
drivers/gpu/drm/i915/gem/i915_gem_object.c +12 -0
index 2be6109d0093..d4b0da8ed969 100644
@@ -403,6 +403,28 @@ int i915_gem_object_read_from_page(struct drm_i915_gem_object *obj, u64 offset,
  	return 0;
  }
 
+/**
+ * i915_gem_object_placements_contain_type - Check whether the object can be
+ * placed at certain memory type
+ * @obj: Pointer to the object
+ * @type: The memory type to check
+ *
+ * Return: True if the object can be placed in @type. False otherwise.
+ */
+bool i915_gem_object_placements_contain_type(struct drm_i915_gem_object *obj,
+					     enum intel_memory_type type)
+{
+	unsigned int i;

drivers/gpu/drm/i915/gem/i915_gem_object.c int i915_gem_object_read_from_page(struct drm_i915_gem_object *obj, u64 offset, · line 427

Quoted 10 lines
drivers/gpu/drm/i915/gem/i915_gem_object.c +10 -0
+
+	/* TODO: consider maybe storing as a mask when doing gem_create_ext */
+	for (i = 0; i < obj->mm.n_placements; i++) {
+		if (obj->mm.placements[i]->type == type)
+			return true;
+	}
+
+	return false;
+}
+

Do we need something for the in-kernel mappings as well? Or just return a mapping with the only allowed caching mode?

/Thomas

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem/mman: only allow WC for lmem

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: drm/i915/gem/mman: only allow WC for lmem
URL : https://patchwork.freedesktop.org/series/90875/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10159_full -> Patchwork_20263_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_20263_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-snb: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-snb6/igt@[email protected]

* igt@gem_ctx_persistence@legacy-engines-queued:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +6 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-snb7/igt@[email protected]

* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#2410])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-tglb3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb2/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#2842]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-tglb5/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb1/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@gem_exec_fair@[email protected]
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-glk2/igt@gem_exec_fair@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-iclb: NOTRUN -> [FAIL][11] ([i915#2842]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@gem_exec_fair@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][12] -> [SKIP][13] ([i915#2190])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-tglb8/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb6/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#2190])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@[email protected]

* igt@gem_mmap_gtt@big-copy:
- shard-skl: [PASS][15] -> [FAIL][16] ([i915#307])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl10/igt@[email protected]

* igt@gem_mmap_gtt@big-copy-xy:
- shard-skl: NOTRUN -> [FAIL][17] ([i915#307])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl3/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy:
- shard-skl: [PASS][18] -> [INCOMPLETE][19] ([i915#198] / [i915#3468])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl3/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl7/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-apl: NOTRUN -> [INCOMPLETE][20] ([i915#3468]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl7/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-glk: [PASS][21] -> [INCOMPLETE][22] ([i915#2055] / [i915#3468])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-glk9/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk8/igt@[email protected]

* igt@gem_mmap_gtt@fault-concurrent:
- shard-snb: NOTRUN -> [INCOMPLETE][23] ([i915#3468])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-snb5/igt@[email protected]

* igt@gem_mmap_gtt@medium-copy-xy:
- shard-iclb: [PASS][24] -> [INCOMPLETE][25] ([i915#2502] / [i915#3468])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb1/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-snb: NOTRUN -> [WARN][26] ([i915#2658]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-snb5/igt@[email protected]

* igt@gem_userptr_blits@coherency-unsync:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#3297])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][28] ([i915#3002])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl3/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][29] ([i915#3002])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][30] -> [DMESG-WARN][31] ([i915#180]) +5 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-kbl2/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-kbl1/igt@[email protected]

* igt@gen7_exec_parse@basic-allocation:
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109289])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@gen9_exec_parse@basic-rejected:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#112306])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@gen9_exec_parse@bb-oversize:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#2527])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#109506] / [i915#2411]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@i915_selftest@live@execlists:
- shard-apl: NOTRUN -> [DMESG-FAIL][36] ([i915#3462])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@i915_selftest@[email protected]

* igt@i915_suspend@forcewake:
- shard-kbl: NOTRUN -> [DMESG-WARN][37] ([i915#180])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-kbl1/igt@[email protected]

* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#110725] / [fdo#111614])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-fast:
- shard-glk: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk5/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-snb: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +27 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-snb6/igt@[email protected]

* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@kms_color@pipe-d-ctm-max:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278] / [i915#1149])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +22 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl7/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-gamma:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl3/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-max:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109284] / [fdo#111827]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-apl: NOTRUN -> [TIMEOUT][47] ([i915#1319]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-32x32-offscreen:
- shard-tglb: NOTRUN -> [SKIP][48] ([i915#3319])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#109279] / [i915#3359])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x512-random:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109278] / [fdo#109279])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x170-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109278]) +9 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109274] / [fdo#109278])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][53] -> [FAIL][54] ([i915#2346] / [i915#533])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#533])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#533])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl3/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-dp:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109349])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_flip@2x-blocking-wf_vblank:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109274])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@kms_flip@2x-blocking-wf_vblank.html

* igt@kms_flip@dpms-off-confusion-interruptible@a-edp1:
- shard-skl: [PASS][59] -> [DMESG-WARN][60] ([i915#1982])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl4/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1:
- shard-glk: [PASS][61] -> [FAIL][62] ([i915#79])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-glk9/igt@kms_flip@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk8/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#2642])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl2/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-snb: NOTRUN -> [SKIP][64] ([fdo#109271]) +474 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-snb2/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#2672])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@[email protected]

* igt@kms_flip_tiling@flip-to-yf-tiled:
- shard-tglb: NOTRUN -> [SKIP][66] ([fdo#111615]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-glk: [PASS][67] -> [DMESG-FAIL][68] ([i915#118] / [i915#95])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-glk6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-2p-pri-indfb-multidraw:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109280]) +10 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271]) +15 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt:
- shard-glk: NOTRUN -> [SKIP][71] ([fdo#109271]) +5 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk5/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#111825]) +7 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][73] -> [INCOMPLETE][74] ([i915#123])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl7/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl10/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][75] ([fdo#108145] / [i915#265])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][76] ([i915#265]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#658]) +4 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl7/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-iclb: NOTRUN -> [SKIP][78] ([i915#658]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#2920])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][80] -> [SKIP][81] ([fdo#109642] / [fdo#111068] / [i915#658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb2/igt@kms_psr2_su@page_flip.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb7/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_cursor_render:
- shard-tglb: NOTRUN -> [FAIL][82] ([i915#132])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@kms_psr@psr2_cursor_render.html

* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][83] ([fdo#109441])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@kms_psr@psr2_sprite_mmap_cpu.html

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][84] -> [SKIP][85] ([fdo#109441]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-skl: [PASS][86] -> [FAIL][87] ([i915#43])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl10/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl1/igt@[email protected]

* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2437])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#2437])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl3/igt@[email protected]

* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271]) +222 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl1/igt@[email protected]

* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#2530])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]

* igt@perf@blocking:
- shard-skl: [PASS][92] -> [FAIL][93] ([i915#1542])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl1/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl2/igt@[email protected]

* igt@perf_pmu@module-unload:
- shard-skl: [PASS][94] -> [DMESG-WARN][95] ([i915#1982] / [i915#262])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl9/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl4/igt@[email protected]

* igt@sysfs_clients@sema-10:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#2994]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-apl2/igt@[email protected]

* igt@sysfs_clients@split-10:
- shard-glk: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2994])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk5/igt@[email protected]

* igt@sysfs_clients@split-50:
- shard-iclb: NOTRUN -> [SKIP][98] ([i915#2994])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@sysfs_timeslice_duration@timeout@vcs0:
- shard-skl: NOTRUN -> [FAIL][99] ([i915#3259])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl3/igt@sysfs_timeslice_duration@[email protected]

#### Possible fixes ####

* igt@gem_ctx_ringsize@active@bcs0:
- shard-skl: [INCOMPLETE][100] ([i915#3316]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl3/igt@gem_ctx_ringsize@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl3/igt@gem_ctx_ringsize@[email protected]

* igt@gem_ctx_shared@detached-shared-gtt:
- shard-iclb: [INCOMPLETE][102] -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb7/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][104] ([i915#2369] / [i915#3063]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-tglb8/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb6/igt@[email protected]

* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: [FAIL][106] ([i915#2842]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-glk4/igt@gem_exec_fair@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-tglb: [FAIL][108] ([i915#2842]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-tglb3/igt@gem_exec_fair@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb3/igt@gem_exec_fair@[email protected]

* igt@gem_mmap_gtt@big-copy:
- shard-glk: [FAIL][110] ([i915#307]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-glk1/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk4/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-odd:
- shard-glk: [INCOMPLETE][112] ([i915#2055] / [i915#3468]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-glk4/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk5/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-medium-copy-xy:
- shard-iclb: [INCOMPLETE][114] ([i915#3468]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb7/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb5/igt@[email protected]

* igt@gem_mmap_gtt@medium-copy-xy:
- shard-tglb: [INCOMPLETE][116] ([i915#2502] / [i915#3468]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-tglb6/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-tglb7/igt@[email protected]
- shard-kbl: [INCOMPLETE][118] ([i915#2502] / [i915#3468]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-kbl7/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-kbl1/igt@[email protected]

* igt@kms_big_fb@linear-16bpp-rotate-0:
- shard-iclb: [DMESG-FAIL][120] ([i915#1226]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb4/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
- shard-skl: [FAIL][122] ([i915#3444]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl4/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl8/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][124] ([i915#2346]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl1/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl1/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-blt-ytiled:
- shard-skl: [FAIL][126] -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl8/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl4/igt@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][128] ([i915#79]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-glk9/igt@kms_flip@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-glk8/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][130] ([i915#2122]) -> [PASS][131] +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl4/igt@kms_flip@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl8/igt@kms_flip@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][132] ([i915#1188]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl1/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][134] ([fdo#108145] / [i915#265]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-skl4/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-skl8/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][136] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb1/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][138] ([fdo#109441]) -> [PASS][139] +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb7/igt@kms_psr@psr2_sprite_blt.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

#### Warnings ####

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][140] ([i915#2684]) -> [WARN][141] ([i915#1804] / [i915#2684])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb5/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb3/igt@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][142] ([i915#2920]) -> [SKIP][143] ([i915#658]) +2 similar issues
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10159/shard-iclb2/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/shard-iclb4/igt@[email protected]

* igt@runner@aborted:
- shard-apl: ([FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147]

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20263/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Thomas Hellström
Quoted 18 lines · Thomas Hellström

Hi,

Quoted 15 lines · Matthew Auld

For dgfx where we now have lmem and ttm, we can only support single mmap mode for the lifetime of the object, and for lmem objects this should be WC, so reject all other mapping modes for mmap_offset, including if the object can be placed in both smem and lmem.

Cc Thomas Hellström <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Daniel Vetter <[email protected]>

---
  drivers/gpu/drm/i915/gem/i915_gem_mman.c   |  4 ++++ drivers/gpu/drm/i915/gem/i915_gem_object.c | 22 ++++++++++++++++++++++ drivers/gpu/drm/i915/gem/i915_gem_object.h |  4 ++++

  3 files changed, 30 insertions(+)
Quoted 14 lines

drivers/gpu/drm/i915/gem/i915_gem_mman.c __assign_mmap_offset(struct drm_file *file, · line 695

Quoted 12 lines
drivers/gpu/drm/i915/gem/i915_gem_mman.c +4 -0
index fd1c9714f8d8..32f88f236771 100644
@@ -689,6 +689,10 @@ __assign_mmap_offset(struct drm_file *file,
           goto out;
       }
+    if (mmap_type != I915_MMAP_TYPE_WC &&
+        i915_gem_object_placements_contain_type(obj, 
 INTEL_MEMORY_LOCAL))
+        return -ENODEV;
+

I think we will also have the restriction that any other objects on DGFX can only be mapped cached? At least that's what the TTM code is implementing currently.

Yeah, with this patch the caching mode should now at least be consistent for lmem objects, for smem we still need more patches.

Quoted 32 lines
Quoted 32 lines
drivers/gpu/drm/i915/gem/i915_gem_mman.c +0 -0
       mmo = mmap_offset_attach(obj, mmap_type, file);
       if (IS_ERR(mmo)) {
           err = PTR_ERR(mmo);
drivers/gpu/drm/i915/gem/i915_gem_object.c +2 -0
index 2be6109d0093..d4b0da8ed969 100644
@@ -403,6 +403,28 @@ int i915_gem_object_read_from_page(struct 
 drm_i915_gem_object *obj, u64 offset,
       return 0;
   }
+/**
+ * i915_gem_object_placements_contain_type - Check whether the object 

can be
+ * placed at certain memory type
+ * @obj: Pointer to the object
+ * @type: The memory type to check
+ *
+ * Return: True if the object can be placed in @type. False otherwise.
+ */
+bool i915_gem_object_placements_contain_type(struct drm_i915_gem_object *obj,
+                         enum intel_memory_type type)

drivers/gpu/drm/i915/gem/i915_gem_object.c +4 -0
+{
+    unsigned int i;
+
+    /* TODO: consider maybe storing as a mask when doing 

gem_create_ext */
+    for (i = 0; i < obj->mm.n_placements; i++) {
+        if (obj->mm.placements[i]->type == type)

Quoted 8 lines

drivers/gpu/drm/i915/gem/i915_gem_object.c int i915_gem_object_read_from_page(struct drm_i915_gem_object *obj, u64 offset, · line 427

Quoted 6 lines

+            return true;
+    }

drivers/gpu/drm/i915/gem/i915_gem_object.c +4 -0
+
+    return false;
+}
+

Do we need something for the in-kernel mappings as well? Or just return a mapping with the only allowed caching mode?

For lmem everything should already be WC for in-kernel mappings. For everything else which uses pin_map() we will need to default to cached. I guess just add a different helper for this? We should probably also adjust the obj->cache_level for dg1.

Quoted 4 lines

/Thomas

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 92 lines · Matthew Auld
Quoted 32 lines · Thomas Hellström

Hi,

Quoted 29 lines · Matthew Auld

For dgfx where we now have lmem and ttm, we can only support single mmap
mode for the lifetime of the object, and for lmem objects this should be
WC, so reject all other mapping modes for mmap_offset, including if the
object can be placed in both smem and lmem.

Cc Thomas Hellström <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Daniel Vetter <[email protected]>

---
  drivers/gpu/drm/i915/gem/i915_gem_mman.c   |  4 ++++ drivers/gpu/drm/i915/gem/i915_gem_object.c | 22
++++++++++++++++++++++
  drivers/gpu/drm/i915/gem/i915_gem_object.h |  4 ++++

  3 files changed, 30 insertions(+)
drivers/gpu/drm/i915/gem/i915_gem_mman.c +2 -0
index fd1c9714f8d8..32f88f236771 100644
@@ -689,6 +689,10 @@ __assign_mmap_offset(struct drm_file *file,
           goto out;
       }
+    if (mmap_type != I915_MMAP_TYPE_WC &&
+        i915_gem_object_placements_contain_type(obj, 
Quoted 8 lines

drivers/gpu/drm/i915/gem/i915_gem_mman.c __assign_mmap_offset(struct drm_file *file, · line 695

Quoted 3 lines
drivers/gpu/drm/i915/gem/i915_gem_mman.c +2 -0
 INTEL_MEMORY_LOCAL))
+        return -ENODEV;
+

I think we will also have the restriction that any other objects on DGFX
can only be mapped cached? At least that's what the TTM code is implementing currently.

Yeah, with this patch the caching mode should now at least be consistent
for lmem objects, for smem we still need more patches.

Quoted 37 lines
Quoted 37 lines
drivers/gpu/drm/i915/gem/i915_gem_mman.c +0 -0
       mmo = mmap_offset_attach(obj, mmap_type, file);
       if (IS_ERR(mmo)) {
           err = PTR_ERR(mmo);
drivers/gpu/drm/i915/gem/i915_gem_object.c +2 -0
index 2be6109d0093..d4b0da8ed969 100644
@@ -403,6 +403,28 @@ int i915_gem_object_read_from_page(struct 
 drm_i915_gem_object *obj, u64 offset,
       return 0;
   }
+/**
+ * i915_gem_object_placements_contain_type - Check whether the

object
can be
+ * placed at certain memory type
+ * @obj: Pointer to the object
+ * @type: The memory type to check
+ *
+ * Return: True if the object can be placed in @type. False otherwise.
+ */
+bool i915_gem_object_placements_contain_type(struct drm_i915_gem_object *obj,
+                         enum intel_memory_type type)

drivers/gpu/drm/i915/gem/i915_gem_object.c +4 -0
+{
+    unsigned int i;
+
+    /* TODO: consider maybe storing as a mask when doing 

gem_create_ext */
+    for (i = 0; i < obj->mm.n_placements; i++) { +        if (obj->mm.placements[i]->type == type) +            return true;
+    }

Quoted 8 lines

drivers/gpu/drm/i915/gem/i915_gem_object.c int i915_gem_object_read_from_page(struct drm_i915_gem_object *obj, u64 offset, · line 427

Quoted 4 lines
drivers/gpu/drm/i915/gem/i915_gem_object.c +4 -0
+
+    return false;
+}
+

Do we need something for the in-kernel mappings as well? Or just return
a mapping with the only allowed caching mode?

Quoted 5 lines

For lmem everything should already be WC for in-kernel mappings. For everything else which uses pin_map() we will need to default to cached.
I guess just add a different helper for this? We should probably also adjust the obj->cache_level for dg1.

Note that objects that have LMEM in the allowed placement list, but are migrated to SMEM for some reason (we haven't really decided the policy for this yet, but perhaps for dma-buf export reasons or just being evicted with smem as an allowable placement) will still be WC-only, which was Daniel's recommendation to begin with, (but we can flip caching mode on eviction / migration if we'd want to).

Currently we don't flip GEM region when evicting even if SMEM is an allowed placement, because the object may then end up stuck in SMEM. Not sure if we want to expose a user-space madvise-type hint for this?

/Thomas

Quoted 5 lines
Quoted 5 lines

/Thomas