Skip to contentSkip to conversation

h8300: Remove unused variable

PATCH Applied Souptick Joarder 3 participants 3 messages Jun 2, 2021 – Jun 6, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 h8300: Remove unused variable

Kernel test robot throws below warning ->

Quoted 1 line
Quoted 1 line

arch/h8300/kernel/setup.c:72:26:

warning: Unused variable: region [unusedVariable]

    struct memblock_region *region;

Fixed it by removing unused variable.

---
 arch/h8300/kernel/setup.c | 2 --
 1 file changed, 2 deletions(-)
arch/h8300/kernel/setup.c +0 -2
index 15280af7251c..5745a763dc78 100644
@@ -69,8 +69,6 @@ void __init h8300_fdt_init(void *fdt, char *bootargs)
 
 static void __init bootmem_init(void)
 {
-	struct memblock_region *region;
-
 	memory_end = memory_start = 0;
 
 	/* Find main memory where is the kernel */
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Souptick Joarder

Kernel test robot throws below warning ->

Quoted 1 line
Quoted 1 line

arch/h8300/kernel/setup.c:72:26:

warning: Unused variable: region [unusedVariable]

    struct memblock_region *region;

Fixed it by removing unused variable.

I believe a Fixes: tag would be appropriate here. Otherwise

Quoted 20 lines
---
 arch/h8300/kernel/setup.c | 2 --
 1 file changed, 2 deletions(-)
arch/h8300/kernel/setup.c +0 -2
index 15280af7251c..5745a763dc78 100644
@@ -69,8 +69,6 @@ void __init h8300_fdt_init(void *fdt, char *bootargs)
 
 static void __init bootmem_init(void)
 {
-	struct memblock_region *region;
-
 	memory_end = memory_start = 0;
 
 	/* Find main memory where is the kernel */
Signature · 1 line
2.25.1
Signature · 2 lines
Sincerely yours,
Mike.
Acked-by on v1 1/1
#2 lore raw
In reply to Souptick Joarder
Quoted 31 lines · Souptick Joarder

Kernel test robot throws below warning ->

Quoted 1 line
Quoted 1 line

arch/h8300/kernel/setup.c:72:26:

warning: Unused variable: region [unusedVariable]

    struct memblock_region *region;

Fixed it by removing unused variable.

---
 arch/h8300/kernel/setup.c | 2 --
 1 file changed, 2 deletions(-)
arch/h8300/kernel/setup.c +0 -2
index 15280af7251c..5745a763dc78 100644
@@ -69,8 +69,6 @@ void __init h8300_fdt_init(void *fdt, char *bootargs)
 
 static void __init bootmem_init(void)
 {
-	struct memblock_region *region;
-
 	memory_end = memory_start = 0;
 
 	/* Find main memory where is the kernel */
Signature · 1 line
2.25.1
Signature · 1 line
Yoshinori Sato