Skip to contentSkip to conversation

can: mcp251xfd: Align the table of comments

PATCH In review Fabio Estevam 2 participants 3 messages Jun 3, 2021 – Jun 7, 2021

Subsystems (2)
CAN network drivers MCP251XFD SPI-CAN network driver
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 can: mcp251xfd: Align the table of comments

Align the table of comments for better readability.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c +7 -7
index 47c3f408a799..db07dd112603 100644
@@ -2957,14 +2957,14 @@ static int mcp251xfd_probe(struct spi_device *spi)
 	 *
 	 * Known good combinations are:
 	 *
-	 * MCP	ext-clk	SoC			SPI			SPI-clk		max-clk	parent-clk	config
+	 * MCP		ext-clk SoC			SPI			SPI-clk	max-clk	parent-clk	config
 	 *
-	 * 2518	20 MHz	allwinner,sun8i-h3	allwinner,sun8i-h3-spi	 8333333 Hz	 83.33%	600000000 Hz	assigned-clocks = <&ccu CLK_SPIx>
-	 * 2518	40 MHz	allwinner,sun8i-h3	allwinner,sun8i-h3-spi	16666667 Hz	 83.33%	600000000 Hz	assigned-clocks = <&ccu CLK_SPIx>
-	 * 2517	40 MHz	atmel,sama5d27		atmel,at91rm9200-spi	16400000 Hz	 82.00%	 82000000 Hz	default
-	 * 2518	40 MHz	atmel,sama5d27		atmel,at91rm9200-spi	16400000 Hz	 82.00%	 82000000 Hz	default
-	 * 2518	40 MHz	fsl,imx6dl		fsl,imx51-ecspi		15000000 Hz	 75.00%	 30000000 Hz	default
-	 * 2517	20 MHz	fsl,imx8mm		fsl,imx51-ecspi		 8333333 Hz	 83.33%	 16666667 Hz	assigned-clocks = <&clk IMX8MM_CLK_ECSPIx_ROOT>
+	 * 2518	20 MHz	allwinner,sun8i-h3	allwinner,sun8i-h3-spi	8333333 Hz	83.33%		600000000 Hz	assigned-clocks = <&ccu CLK_SPIx>
+	 * 2518	40 MHz	allwinner,sun8i-h3	allwinner,sun8i-h3-spi	16666667 Hz	83.33%		600000000 Hz	assigned-clocks = <&ccu CLK_SPIx>
+	 * 2517	40 MHz	atmel,sama5d27		atmel,at91rm9200-spi	16400000 Hz	82.00%		82000000 Hz	default
+	 * 2518	40 MHz	atmel,sama5d27		atmel,at91rm9200-spi	16400000 Hz	82.00%		82000000 Hz	default
+	 * 2518	40 MHz	fsl,imx6dl		fsl,imx51-ecspi	15000000 Hz	75.00%		30000000 Hz	default
+	 * 2517	20 MHz	fsl,imx8mm		fsl,imx51-ecspi	8333333 Hz	83.33%		16666667 Hz	assigned-clocks = <&clk IMX8MM_CLK_ECSPIx_ROOT>
 	 *
 	 */
 	priv->spi_max_speed_hz_orig = spi->max_speed_hz;
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 1 line · Fabio Estevam

Align the table of comments for better readability.

My editor uses 1 tab = 8 spaces and it looks correct without the patch. Have a look at:

| tps://elixir.bootlin.com/linux/v5.12/source/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c#L2915

regards,
Marc

Signature · 4 lines
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |
author
#2 lore raw

Hi Marc,

Quoted 8 lines · Marc Kleine-Budde
Quoted 1 line · Fabio Estevam

Align the table of comments for better readability.

My editor uses 1 tab = 8 spaces and it looks correct without the patch. Have a look at:

| tps://elixir.bootlin.com/linux/v5.12/source/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c#L2915

Oh, it is on my editor that it appears unaligned then. Sorry for the noise!

Cheers