Skip to contentSkip to conversation

arm: iproc: Add higher speed configurations

PATCH In review Chris Packham 2 participants 5 messages Jun 4, 2021 – Jul 6, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: iproc: Add higher speed configurations

Add support for 1.3GHz, 1.35GHz and 1.4GHz parts. This is based on equivalent code in Broadcom's LDK 5.0.6.

---
As Broadcom are currently migrating users to the BCM58525BB1KF14G part I suspect others may want this. In our case because we wanted to still run at 1.2GHz we also had to set CONFIG_ARMCLK to 1200.

 arch/arm/cpu/armv7/iproc-common/armpll.c | 29 +++++++++++++-----------
 1 file changed, 16 insertions(+), 13 deletions(-)
arch/arm/cpu/armv7/iproc-common/armpll.c +16 -13
index efa3d9e5a9bd..8c3a323f0654 100644
@@ -19,19 +19,22 @@ struct armpll_parameters {
 };
 
 struct armpll_parameters armpll_clk_tab[] = {
-	{   25, 64,      1, 1, 0},
-	{  100, 64,      1, 1, 2},
-	{  400, 64,      1, 1, 6},
-	{  448, 71, 713050, 1, 6},
-	{  500, 80,      1, 1, 6},
-	{  560, 89, 629145, 1, 6},
-	{  600, 96,      1, 1, 6},
-	{  800, 64,      1, 1, 7},
-	{  896, 71, 713050, 1, 7},
-	{ 1000, 80,      1, 1, 7},
-	{ 1100, 88,      1, 1, 7},
-	{ 1120, 89, 629145, 1, 7},
-	{ 1200, 96,      1, 1, 7},
+	{   25,  64,      1, 1, 0},
+	{  100,  64,      1, 1, 2},
+	{  400,  64,      1, 1, 6},
+	{  448,  71, 713050, 1, 6},
+	{  500,  80,      1, 1, 6},
+	{  560,  89, 629145, 1, 6},
+	{  600,  96,      1, 1, 6},
+	{  800,  64,      1, 1, 7},
+	{  896,  71, 713050, 1, 7},
+	{ 1000,  80,      1, 1, 7},
+	{ 1100,  88,      1, 1, 7},
+	{ 1120,  89, 629145, 1, 7},
+	{ 1200,  96,      1, 1, 7},
+	{ 1300, 104,      1, 1, 7},
+	{ 1350, 108,      1, 1, 7},
+	{ 1400, 112,      1, 1, 7},
 };
 
 uint32_t armpll_config(uint32_t clkmhz)
Signature · 1 line
2.31.1
#1 lore raw
Quoted 6 lines · Chris Packham

Add support for 1.3GHz, 1.35GHz and 1.4GHz parts. This is based on equivalent code in Broadcom's LDK 5.0.6.

Hi Tom,

This seems to have fallen between the cracks. Are you able to take it through one of your trees?

Quoted 51 lines

---
As Broadcom are currently migrating users to the BCM58525BB1KF14G part I suspect others may want this. In our case because we wanted to still run at 1.2GHz we also had to set CONFIG_ARMCLK to 1200.

 arch/arm/cpu/armv7/iproc-common/armpll.c | 29 +++++++++++++-----------
 1 file changed, 16 insertions(+), 13 deletions(-)
arch/arm/cpu/armv7/iproc-common/armpll.c +16 -14
index efa3d9e5a9bd..8c3a323f0654 100644
@@ -19,19 +19,22 @@ struct armpll_parameters {
 };
 
 struct armpll_parameters armpll_clk_tab[] = {
-       {   25, 64,      1, 1, 0},
-       {  100, 64,      1, 1, 2},
-       {  400, 64,      1, 1, 6},
-       {  448, 71, 713050, 1, 6},
-       {  500, 80,      1, 1, 6},
-       {  560, 89, 629145, 1, 6},
-       {  600, 96,      1, 1, 6},
-       {  800, 64,      1, 1, 7},
-       {  896, 71, 713050, 1, 7},
-       { 1000, 80,      1, 1, 7},
-       { 1100, 88,      1, 1, 7},
-       { 1120, 89, 629145, 1, 7},
-       { 1200, 96,      1, 1, 7},
+       {   25,  64,      1, 1, 0},
+       {  100,  64,      1, 1, 2},
+       {  400,  64,      1, 1, 6},
+       {  448,  71, 713050, 1, 6},
+       {  500,  80,      1, 1, 6},
+       {  560,  89, 629145, 1, 6},
+       {  600,  96,      1, 1, 6},
+       {  800,  64,      1, 1, 7},
+       {  896,  71, 713050, 1, 7},
+       { 1000,  80,      1, 1, 7},
+       { 1100,  88,      1, 1, 7},
+       { 1120,  89, 629145, 1, 7},
+       { 1200,  96,      1, 1, 7},
+       { 1300, 104,      1, 1, 7},
+       { 1350, 108,      1, 1, 7},
+       { 1400, 112,      1, 1, 7},
 };
 
 uint32_t armpll_config(uint32_t clkmhz)
--

2.31.1

#2 lore raw
Quoted 11 lines · Chris Packham
Quoted 5 lines · Chris Packham

Add support for 1.3GHz, 1.35GHz and 1.4GHz parts. This is based on equivalent code in Broadcom's LDK 5.0.6.

Hi Tom,

This seems to have fallen between the cracks. Are you able to take it through one of your trees?

I can, is this needed for the v2021.07 release?

Signature · 1 line
Tom
#3 lore raw
Quoted 8 lines · Tom Rini
Quoted 5 lines · Chris Packham
Quoted 4 lines · Chris Packham

Add support for 1.3GHz, 1.35GHz and 1.4GHz parts. This is based on equivalent code in Broadcom's LDK 5.0.6.

Quoted 9 lines
Quoted 6 lines
Quoted 1 line

Hi Tom,

This seems to have fallen between the cracks. Are you able to take it through one of your trees?

I can, is this needed for the v2021.07 release?

Personally I'd like to see it in v2021.07 but I understand that we're well past the merge window and this is not strictly a fix.