Skip to contentSkip to conversation

media: Kconfig: Fix DVB_CORE can't be selected as module

PATCH In review Lecopzer Chen 2 participants 3 messages Jun 8, 2021 – Jun 19, 2021 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: Kconfig: Fix DVB_CORE can't be selected as module

The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.

Change MEDIA_DIGITAL_TV_SUPPORT to tristate so it's possible to set DVB_CORE as =m.

---
 drivers/media/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/Kconfig +1 -1
index b07812657cee..c3baf92b4d02 100644
@@ -88,7 +88,7 @@ config MEDIA_ANALOG_TV_SUPPORT
 		will disable support for them.
 
 config MEDIA_DIGITAL_TV_SUPPORT
-	bool
+	tristate
 	prompt "Digital TV" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
Signature · 1 line
2.18.0
#1 lore raw
Quoted 3 lines · Lecopzer Chen

The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.

First of all, the distributions carrry dvb_core as a module, so clearly it possible to set DVB_CORE=m.

As far as I can see, if MEDIA_SUPPORT=m, then DVB_CORE=m.

So it is possible.

Sean

Quoted 23 lines

Change MEDIA_DIGITAL_TV_SUPPORT to tristate so it's possible to set DVB_CORE as =m.

---
 drivers/media/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/Kconfig +1 -1
index b07812657cee..c3baf92b4d02 100644
@@ -88,7 +88,7 @@ config MEDIA_ANALOG_TV_SUPPORT
 		will disable support for them.
 
 config MEDIA_DIGITAL_TV_SUPPORT
-	bool
+	tristate
 	prompt "Digital TV" if MEDIA_SUPPORT_FILTER
 	default y if !MEDIA_SUPPORT_FILTER
 	help
Signature · 1 line
2.18.0
#2 lore raw
Quoted 11 lines · Lecopzer Chen
Quoted 3 lines

The DVB_CORE now depends on MEDIA_DIGITAL_TV_SUPPORT and default MEDIA_DIGITAL_TV_SUPPORT, and this makes it can never be =m since the type of MEDIA_DIGITAL_TV_SUPPORT is bool.

First of all, the distributions carrry dvb_core as a module, so clearly it possible to set DVB_CORE=m.

As far as I can see, if MEDIA_SUPPORT=m, then DVB_CORE=m.

So it is possible.

Thanks for review.

After checking, It does change DVB_CORE=m if MEDIA_SUPPORT=m.

We had MEDIA_SUPPORT=y, thus misunderstood by 'default MEDIA_DIGITAL_TV_SUPPORT'.

Thanks again for figuring out this.

-Lecopzer