crash_core, vmcoreinfo: Append 'SECTION_SIZE_BITS' to vmcoreinfo
Subsystems (3)
PATCH 1/1 crash_core, vmcoreinfo: Append 'SECTION_SIZE_BITS' to vmcoreinfo
As mentioned in kernel commit 1d50e5d0c505 ("crash_core, vmcoreinfo:
Append 'MAX_PHYSMEM_BITS' to vmcoreinfo"), SECTION_SIZE_BITS in the formula:
#define SECTIONS_SHIFT (MAX_PHYSMEM_BITS - SECTION_SIZE_BITS)
Besides SECTIONS_SHIFT, SECTION_SIZE_BITS is also used to calculate PAGES_PER_SECTION in makedumpfile just like kernel.
Unfortunately, this arch-dependent macro SECTION_SIZE_BITS changes, e.g. recently in kernel commit f0b13ee23241 ("arm64/sparsemem: reduce SECTION_SIZE_BITS"). But user space wants a stable interface to get this info. Such info is impossible to be deduced from a crashdump vmcore. Hence append SECTION_SIZE_BITS to vmcoreinfo.
--- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+)
kernel/crash_core.c +1 -0
@@ -464,6 +464,7 @@ static int __init crash_save_vmcoreinfo_init(void)VMCOREINFO_LENGTH (mem_section,NR_SECTION_ROOTS );VMCOREINFO_STRUCT_SIZE (mem_section);VMCOREINFO_OFFSET (mem_section, section_mem_map); +VMCOREINFO_NUMBER (SECTION_SIZE_BITS );VMCOREINFO_NUMBER (MAX_PHYSMEM_BITS );#endif VMCOREINFO_STRUCT_SIZE (page);
Signature · 7 lines
2.29.2 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Quoted 28 lines · Pingfan Liu
As mentioned in kernel commit
1d50e5d0c505("crash_core, vmcoreinfo:
Append 'MAX_PHYSMEM_BITS' to vmcoreinfo"),SECTION_SIZE_BITSin the formula:#define SECTIONS_SHIFT (MAX_PHYSMEM_BITS - SECTION_SIZE_BITS)Besides
SECTIONS_SHIFT,SECTION_SIZE_BITSis also used to calculatePAGES_PER_SECTIONin makedumpfile just like kernel.Unfortunately, this arch-dependent macro
SECTION_SIZE_BITSchanges, e.g. recently in kernel commitf0b13ee23241("arm64/sparsemem: reduceSECTION_SIZE_BITS"). But user space wants a stable interface to get this info. Such info is impossible to be deduced from a crashdump vmcore. Hence appendSECTION_SIZE_BITSto vmcoreinfo.Signed-off-by Pingfan Liu <[email protected]>Cc Bhupesh Sharma <[email protected]>Cc Kazuhito Hagio <[email protected]>Cc Dave Young <[email protected]>Cc Baoquan He <[email protected]>Cc Boris Petkov <[email protected]>Cc Ingo Molnar <[email protected]>Cc Thomas Gleixner <[email protected]>Cc James Morse <[email protected]>Cc Mark Rutland <[email protected]>Cc Will Deacon <[email protected]>Cc Catalin Marinas <[email protected]>Cc Michael Ellerman <[email protected]>
Quoted 8 lines
Cc Paul Mackerras <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc Dave Anderson <[email protected]>
Add the discussion of the original thread in kexec ML for reference:
http://lists.infradead.org/pipermail/kexec/2021-June/022676.html
This looks good to me.
Quoted 19 lines
--- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+)kernel/crash_core.c +1
-0@@ -464,6 +464,7 @@ static int __init crash_save_vmcoreinfo_init(void)VMCOREINFO_LENGTH (mem_section,NR_SECTION_ROOTS );VMCOREINFO_STRUCT_SIZE (mem_section);VMCOREINFO_OFFSET (mem_section, section_mem_map); +VMCOREINFO_NUMBER (SECTION_SIZE_BITS );VMCOREINFO_NUMBER (MAX_PHYSMEM_BITS );#endif VMCOREINFO_STRUCT_SIZE (page);Signature · 1 line
2.29.2
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Andrew Morton
maintainerQuoted 15 lines · On Tue, 8 Jun 2021 22:24:32 +0800 Baoquan He <[email protected]> wrote:
Quoted 5 lines · Pingfan Liu
As mentioned in kernel commit
1d50e5d0c505("crash_core, vmcoreinfo:
Append 'MAX_PHYSMEM_BITS' to vmcoreinfo"),SECTION_SIZE_BITSin the formula:#define SECTIONS_SHIFT (MAX_PHYSMEM_BITS - SECTION_SIZE_BITS)Quoted 8 lines
Besides
SECTIONS_SHIFT,SECTION_SIZE_BITSis also used to calculatePAGES_PER_SECTIONin makedumpfile just like kernel.Unfortunately, this arch-dependent macro
SECTION_SIZE_BITSchanges, e.g. recently in kernel commitf0b13ee23241("arm64/sparsemem: reduceSECTION_SIZE_BITS"). But user space wants a stable interface to get this info. Such info is impossible to be deduced from a crashdump vmcore. Hence appendSECTION_SIZE_BITSto vmcoreinfo.
Quoted 4 lines
...
Add the discussion of the original thread in kexec ML for reference:
http://lists.infradead.org/pipermail/kexec/2021-June/022676.html
I added a Link: for this.
Quoted 3 lines
This looks good to me.
Acked-by Baoquan He <[email protected]>
I'm thinking we should backport this at least to Fixes:f0b13ee23241. But perhaps it's simpler to just backport it as far as possible, so I added a bare cc:stable with no Fixes:. Thoughts?
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Correct mail address of Kazuhito
Quoted 55 lines · Pingfan Liu
As mentioned in kernel commit
1d50e5d0c505("crash_core, vmcoreinfo:
Append 'MAX_PHYSMEM_BITS' to vmcoreinfo"),SECTION_SIZE_BITSin the formula:#define SECTIONS_SHIFT (MAX_PHYSMEM_BITS - SECTION_SIZE_BITS)Besides
SECTIONS_SHIFT,SECTION_SIZE_BITSis also used to calculatePAGES_PER_SECTIONin makedumpfile just like kernel.Unfortunately, this arch-dependent macro
SECTION_SIZE_BITSchanges, e.g. recently in kernel commitf0b13ee23241("arm64/sparsemem: reduceSECTION_SIZE_BITS"). But user space wants a stable interface to get this info. Such info is impossible to be deduced from a crashdump vmcore. Hence appendSECTION_SIZE_BITSto vmcoreinfo.Signed-off-by Pingfan Liu <[email protected]>Cc Bhupesh Sharma <[email protected]>Cc Kazuhito Hagio <[email protected]>Cc Dave Young <[email protected]>Cc Baoquan He <[email protected]>Cc Boris Petkov <[email protected]>Cc Ingo Molnar <[email protected]>Cc Thomas Gleixner <[email protected]>Cc James Morse <[email protected]>Cc Mark Rutland <[email protected]>Cc Will Deacon <[email protected]>Cc Catalin Marinas <[email protected]>Cc Michael Ellerman <[email protected]>Cc Paul Mackerras <[email protected]>Cc Benjamin Herrenschmidt <[email protected]>Cc Dave Anderson <[email protected]>--- kernel/crash_core.c | 1 + 1 file changed, 1 insertion(+)kernel/crash_core.c +1
-1@@ -464,6 +464,7 @@ static int __init crash_save_vmcoreinfo_init(void)VMCOREINFO_LENGTH (mem_section,NR_SECTION_ROOTS );VMCOREINFO_STRUCT_SIZE (mem_section);VMCOREINFO_OFFSET (mem_section, section_mem_map); +VMCOREINFO_NUMBER (SECTION_SIZE_BITS );VMCOREINFO_NUMBER (MAX_PHYSMEM_BITS );#endif VMCOREINFO_STRUCT_SIZE (page); --2.29.2
Quoted 17 lines · Andrew Morton
Quoted 15 lines · On Tue, 8 Jun 2021 22:24:32 +0800 Baoquan He <[email protected]> wrote:
Quoted 13 lines · Pingfan Liu
As mentioned in kernel commit
1d50e5d0c505("crash_core, vmcoreinfo:
Append 'MAX_PHYSMEM_BITS' to vmcoreinfo"),SECTION_SIZE_BITSin the formula:#define SECTIONS_SHIFT (MAX_PHYSMEM_BITS - SECTION_SIZE_BITS)Besides
SECTIONS_SHIFT,SECTION_SIZE_BITSis also used to calculatePAGES_PER_SECTIONin makedumpfile just like kernel.Unfortunately, this arch-dependent macro
SECTION_SIZE_BITSchanges, e.g. recently in kernel commitf0b13ee23241("arm64/sparsemem: reduceSECTION_SIZE_BITS"). But user space wants a stable interface to get this info. Such info is impossible to be deduced from a crashdump vmcore. Hence appendSECTION_SIZE_BITSto vmcoreinfo.
Quoted 6 lines
Quoted 4 lines
...
Add the discussion of the original thread in kexec ML for reference:
http://lists.infradead.org/pipermail/kexec/2021-June/022676.htmlI added a Link: for this.
Thanks, Andrew.
Quoted 8 lines
Quoted 4 lines
This looks good to me.
Acked-by Baoquan He <[email protected]>I'm thinking we should backport this at least to Fixes:f0b13ee23241. But perhaps it's simpler to just backport it as far as possible, so I added a bare cc:stable with no Fixes:. Thoughts?
Yeah, it should add cc:stable, thanks. Otherwise it will break vmcore dumping on 5.12 stable kernel even though with the updated makedumpfile utility. Fixes:f0b13ee23241 will help stable kernel maintainer easier to identify which kernel this patch need be applied on? If only having cc:stable with no Fixes is allowed, it's also OK.
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec