Skip to contentSkip to conversation

misc: bcm-vk: use list_move_tail instead of list_del/list_add_tail in bcm_vk_msg.c

PATCH In review Baokun Li 2 participants 2 messages Jun 9, 2021

Subsystems (3)
lore
Share & tools
lore

Baokun Li

author
#0 lore raw

PATCH v2 1/1 misc: bcm-vk: use list_move_tail instead of list_del/list_add_tail in bcm_vk_msg.c

Using list_move_tail() instead of list_del() + list_add_tail() in bcm_vk_msg.c.

---
V1->V2:
CC mailist

 drivers/misc/bcm-vk/bcm_vk_msg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/misc/bcm-vk/bcm_vk_msg.c +1 -2
index 6efc52b49af6..066b9ef7fcd7 100644
@@ -354,8 +354,7 @@ static void bcm_vk_drain_all_pend(struct device *dev,
 	for (num = 0; num < chan->q_nr; num++) {
 		list_for_each_entry_safe(entry, tmp, &chan->pendq[num], node) {
 			if ((!ctx) || (entry->ctx->idx == ctx->idx)) {
-				list_del(&entry->node);
-				list_add_tail(&entry->node, &del_q);
+				list_move_tail(&entry->node, &del_q);
 			}
 		}
 	}
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 4 lines · Baokun Li

Using list_move_tail() instead of list_del() + list_add_tail() in bcm_vk_msg.c.

Quoted 22 lines

---
V1->V2:
CC mailist

 drivers/misc/bcm-vk/bcm_vk_msg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/misc/bcm-vk/bcm_vk_msg.c +1 -2
index 6efc52b49af6..066b9ef7fcd7 100644
@@ -354,8 +354,7 @@ static void bcm_vk_drain_all_pend(struct device *dev,
 	for (num = 0; num < chan->q_nr; num++) {
 		list_for_each_entry_safe(entry, tmp, &chan->pendq[num], node) {
 			if ((!ctx) || (entry->ctx->idx == ctx->idx)) {
-				list_del(&entry->node);
-				list_add_tail(&entry->node, &del_q);
+				list_move_tail(&entry->node, &del_q);
 			}
 		}
 	}