Skip to contentSkip to conversation

platform/x86: thinkpad-lmi: set fw_attr_class storage-class to static

PATCH New [email protected] 1 participant 1 message Jun 9, 2021 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: thinkpad-lmi: set fw_attr_class storage-class to static

From: Tom Rix <[email protected]>

An allyesconfig has this linking error drivers/platform/x86/think-lmi.o:
multiple definition of `fw_attr_class'
drivers/platform/x86/dell/dell-wmi-sysman/sysman.o:
first defined here

fw_attr_class is only used locally, so change to static

---
 drivers/platform/x86/think-lmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/think-lmi.c +1 -1
index 782d8e3fe7a1e..c6413b906e4a3 100644
@@ -134,7 +134,7 @@ static const char * const encoding_options[] = {
 	[TLMI_ENCODING_SCANCODE] = "scancode",
 };
 static struct think_lmi tlmi_priv;
-struct class *fw_attr_class;
+static struct class *fw_attr_class;
 
 /* ------ Utility functions ------------*/
 /* Convert BIOS WMI error string to suitable error code */
Signature · 1 line
2.26.3