Skip to contentSkip to conversation

i2c: cht-wc: Replace of_node by NULL

PATCH Applied Andy Shevchenko 3 participants 3 messages Jun 9, 2021 – Jun 20, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 i2c: cht-wc: Replace of_node by NULL

The driver is run on the platforms where OF node is always NULL. The confusion comes from IRQ domain APIs that take either OF or firmware node as input parameter. Since fwnode is not used here either, replace of_node by NULL.

---
v2: rewrote in order to pass NULL instead of of_node (Hans)

 drivers/i2c/busses/i2c-cht-wc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/busses/i2c-cht-wc.c +1 -2
index 08f491ea21ac..1cf68f85b2e1 100644
@@ -354,8 +354,7 @@ static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev)
 		return ret;
 
 	/* Alloc and register client IRQ */
-	adap->irq_domain = irq_domain_add_linear(pdev->dev.of_node, 1,
-						 &irq_domain_simple_ops, NULL);
+	adap->irq_domain = irq_domain_add_linear(NULL, 1, &irq_domain_simple_ops, NULL);
 	if (!adap->irq_domain)
 		return -ENOMEM;
 
Signature · 1 line
2.30.2
Reviewed-by on v2 1/1
#1 lore raw

Hi,

Quoted 10 lines · Andy Shevchenko

The driver is run on the platforms where OF node is always NULL. The confusion comes from IRQ domain APIs that take either OF or firmware node as input parameter. Since fwnode is not used here either, replace of_node by NULL.

---
v2: rewrote in order to pass NULL instead of of_node (Hans)

 drivers/i2c/busses/i2c-cht-wc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, patch looks good to me:

Regards,

Hans

Quoted 16 lines
drivers/i2c/busses/i2c-cht-wc.c +1 -2
index 08f491ea21ac..1cf68f85b2e1 100644
@@ -354,8 +354,7 @@ static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev)
 		return ret;
 
 	/* Alloc and register client IRQ */
-	adap->irq_domain = irq_domain_add_linear(pdev->dev.of_node, 1,
-						 &irq_domain_simple_ops, NULL);
+	adap->irq_domain = irq_domain_add_linear(NULL, 1, &irq_domain_simple_ops, NULL);
 	if (!adap->irq_domain)
 		return -ENOMEM;
 
Applied
#2 lore raw
In reply to Andy Shevchenko
Quoted 6 lines · Andy Shevchenko

The driver is run on the platforms where OF node is always NULL. The confusion comes from IRQ domain APIs that take either OF or firmware node as input parameter. Since fwnode is not used here either, replace of_node by NULL.

Applied to for-next, thanks!