drm/i915/fbc: Clean up cfb allocation code
Subsystems (3)
cover drm/i915/fbc: Clean up cfb allocation code
From: Ville Syrjälä <[email protected]>
I need to tweak the cfb stride/size handling a bit the current cfb allocation code is too messy to make that easy. Start by cleaning stuff up.
Ville Syrjälä (9):
drm/i915/fbc: s/threshold/limit/
drm/i915/fbc: Extract intel_fbc_program_cfb() drm/i915/fbc: Embed the compressed_llb node drm/i915/fbc: Don't pass around the mm node drm/i915/fbc: Handle 16bpp compression limit better drm/i915/fbc: Introduce g4x_dpfc_ctl_limit() drm/i915/fbc: Extract intel_fbc_stolen_end() drm/i915/fbc: Make the cfb allocation loop a bit more legible drm/i915/fbc: Allocate llb before cfb
drivers/gpu/drm/i915/display/intel_fbc.c | 214 +++++++++++------------ drivers/gpu/drm/i915/i915_drv.h | 5 +- 2 files changed, 107 insertions(+), 112 deletions(-)
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/9 drm/i915/fbc: s/threshold/limit/
From: Ville Syrjälä <[email protected]>
Let's call the compression limit the limit.
--- drivers/gpu/drm/i915/display/intel_fbc.c | 50 ++++++++++++------------ drivers/gpu/drm/i915/i915_drv.h | 3 +- 2 files changed, 27 insertions(+), 26 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +25 -25
@@ -104,7 +104,7 @@ static void i8xx_fbc_activate(struct drm_i915_private *dev_priv)int i;u32 fbc_ctl; -/* Note: fbc.threshold == 1 for i8xx */ +/* Note: fbc.limit == 1 for i8xx */ cfb_pitch = params->cfb_size /FBC_LL_SIZE ;if (params->fb.stride < cfb_pitch) cfb_pitch = params->fb.stride;
@@ -235,13 +235,13 @@ static void ilk_fbc_activate(struct drm_i915_private *dev_priv) {struct intel_fbc_reg_params *params = &dev_priv->fbc.params;u32 dpfc_ctl; -int threshold = dev_priv->fbc.threshold; +int limit = dev_priv->fbc.limit; dpfc_ctl =DPFC_CTL_PLANE (params->crtc.i9xx_plane);if (params->fb.format->cpp[0 ] ==2 ) - threshold++; + limit++; -switch (threshold) { +switch (limit) {case 4 :case 3 : dpfc_ctl |=DPFC_CTL_LIMIT_4X ;
@@ -300,7 +300,7 @@ static void gen7_fbc_activate(struct drm_i915_private *dev_priv) {struct intel_fbc_reg_params *params = &dev_priv->fbc.params;u32 dpfc_ctl; -int threshold = dev_priv->fbc.threshold; +int limit = dev_priv->fbc.limit;/* Display WA #0529: skl, kbl, bxt. */ if (DISPLAY_VER (dev_priv) ==9 ) {
@@ -319,9 +319,9 @@ static void gen7_fbc_activate(struct drm_i915_private *dev_priv) dpfc_ctl |=IVB_DPFC_CTL_PLANE (params->crtc.i9xx_plane);if (params->fb.format->cpp[0 ] ==2 ) - threshold++; + limit++; -switch (threshold) { +switch (limit) {case 4 :case 3 : dpfc_ctl |=DPFC_CTL_LIMIT_4X ;
@@ -433,12 +433,12 @@ static u64 intel_fbc_cfb_base_max(struct drm_i915_private *i915)return BIT_ULL (32 ); } -static int find_compression_threshold (struct drm_i915_private *dev_priv, -struct drm_mm_node *node, -unsigned int size, -unsigned int fb_cpp) +static int find_compression_limit (struct drm_i915_private *dev_priv, +struct drm_mm_node *node, +unsigned int size, +unsigned int fb_cpp) { -int compression_threshold =1 ; +int compression_limit =1 ;int ret;u64 end;
@@ -458,19 +458,19 @@ static int find_compression_threshold(struct drm_i915_private *dev_priv,* code changes, this code needs to change as well. * * The enable_fbc code will attempt to use one of our 2 compression -* thresholds, therefore, in that case, we only have 1 resort. +* limits, therefore, in that case, we only have 1 resort. */ /* Try to over-allocate to reduce reallocations and fragmentation. */ ret =i915_gem_stolen_insert_node_in_range (dev_priv, node, size <<=1 ,4096 ,0 , end);if (ret ==0 ) -return compression_threshold; +return compression_limit; again:/* HW's ability to limit the CFB is 1:4 */ -if (compression_threshold >4 || - (fb_cpp ==2 && compression_threshold ==2 )) +if (compression_limit >4 || + (fb_cpp ==2 && compression_limit ==2 ))return 0 ; ret = i915_gem_stolen_insert_node_in_range(dev_priv, node, size >>= 1,
@@ -478,10 +478,10 @@ static int find_compression_threshold(struct drm_i915_private *dev_priv,if (ret &&DISPLAY_VER (dev_priv) <=4 ) {return 0 ; }else if (ret) { - compression_threshold <<=1 ; + compression_limit <<=1 ; goto again; }else { -return compression_threshold; +return compression_limit; } }
@@ -495,8 +495,8 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv,drm_WARN_ON (&dev_priv->drm,drm_mm_node_allocated (&fbc->compressed_fb)); - ret =find_compression_threshold (dev_priv, &fbc->compressed_fb, - size, fb_cpp); + ret =find_compression_limit (dev_priv, &fbc->compressed_fb, + size, fb_cpp);if (!ret) goto err_llb;else if (ret >1 ) {
@@ -504,7 +504,7 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv, "Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n"); } - fbc->threshold = ret; + fbc->limit = ret;if (DISPLAY_VER (dev_priv) >=5 ) intel_de_write(dev_priv, ILK_DPFC_CB_BASE,
@@ -537,8 +537,8 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv, }drm_dbg_kms (&dev_priv->drm, -"reserved %llu bytes of contiguous stolen space for FBC, threshold: %d\n" , - fbc->compressed_fb.size, fbc->threshold); +"reserved %llu bytes of contiguous stolen space for FBC, limit: %d\n" , + fbc->compressed_fb.size, fbc->limit);return 0 ;
@@ -753,7 +753,7 @@ static bool intel_fbc_cfb_size_changed(struct drm_i915_private *dev_priv)struct intel_fbc *fbc = &dev_priv->fbc;return intel_fbc_calculate_cfb_size (dev_priv, &fbc->state_cache) > - fbc->compressed_fb.size * fbc->threshold; + fbc->compressed_fb.size * fbc->limit; }static u16 intel_fbc_gen9_wa_cfb_stride (struct drm_i915_private *dev_priv)
@@ -763,7 +763,7 @@ static u16 intel_fbc_gen9_wa_cfb_stride(struct drm_i915_private *dev_priv)if ((DISPLAY_VER (dev_priv) ==9 ) && cache->fb.modifier !=I915_FORMAT_MOD_X_TILED ) -return DIV_ROUND_UP (cache->plane.src_w,32 * fbc->threshold) *8 ; +return DIV_ROUND_UP (cache->plane.src_w,32 * fbc->limit) *8 ;else return 0 ; }
drivers/gpu/drm/i915/i915_drv.h +2 -1
@@ -346,7 +346,6 @@ struct intel_fbc {/* This is always the inner lock when overlapping with struct_mutex and * it's the outer lock when overlapping with stolen_lock. */ struct mutex lock; -unsigned threshold;unsigned int possible_framebuffer_bits;unsigned int busy_bits;struct intel_crtc *crtc;
@@ -354,6 +353,8 @@ struct intel_fbc {struct drm_mm_node compressed_fb;struct drm_mm_node *compressed_llb; +u8 limit; +bool false_color;bool active;
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/9 drm/i915/fbc: Extract intel_fbc_program_cfb()
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Extract the CFB (+LLB) programming into a separate function.
--- drivers/gpu/drm/i915/display/intel_fbc.c | 46 ++++++++++++++---------- 1 file changed, 28 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +28 -18
@@ -506,13 +506,7 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv, fbc->limit = ret; -if (DISPLAY_VER (dev_priv) >=5 ) -intel_de_write (dev_priv,ILK_DPFC_CB_BASE , - fbc->compressed_fb.start); -else if (IS_GM45 (dev_priv)) { -intel_de_write (dev_priv,DPFC_CB_BASE , - fbc->compressed_fb.start); - }else { +if (DISPLAY_VER (dev_priv) <5 && !IS_G4X (dev_priv)) { compressed_llb =kzalloc (sizeof (*compressed_llb),GFP_KERNEL );if (!compressed_llb) goto err_fb;
@@ -523,17 +517,6 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv, goto err_fb; fbc->compressed_llb = compressed_llb; - -GEM_BUG_ON (range_overflows_end_t (u64, dev_priv->dsm.start, - fbc->compressed_fb.start, -U32_MAX )); -GEM_BUG_ON (range_overflows_end_t (u64, dev_priv->dsm.start, - fbc->compressed_llb->start, -U32_MAX )); -intel_de_write (dev_priv,FBC_CFB_BASE , - dev_priv->dsm.start + fbc->compressed_fb.start); -intel_de_write (dev_priv,FBC_LL_BASE , - dev_priv->dsm.start + compressed_llb->start); } drm_dbg_kms(&dev_priv->drm,
@@ -551,6 +534,31 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv,return -ENOSPC ; } +static void intel_fbc_program_cfb (struct drm_i915_private *dev_priv) +{ +struct intel_fbc *fbc = &dev_priv->fbc; + +if (DISPLAY_VER (dev_priv) >=5 ) { +intel_de_write (dev_priv,ILK_DPFC_CB_BASE , + fbc->compressed_fb.start); + }else if (IS_GM45 (dev_priv)) { +intel_de_write (dev_priv,DPFC_CB_BASE , + fbc->compressed_fb.start); + }else { +GEM_BUG_ON (range_overflows_end_t (u64, dev_priv->dsm.start, + fbc->compressed_fb.start, +U32_MAX )); +GEM_BUG_ON (range_overflows_end_t (u64, dev_priv->dsm.start, + fbc->compressed_llb->start, +U32_MAX )); + +intel_de_write (dev_priv,FBC_CFB_BASE , + dev_priv->dsm.start + fbc->compressed_fb.start); +intel_de_write (dev_priv,FBC_LL_BASE , + dev_priv->dsm.start + fbc->compressed_llb->start); + } +} +static void __intel_fbc_cleanup_cfb (struct drm_i915_private *dev_priv) {struct intel_fbc *fbc = &dev_priv->fbc;
@@ -1302,6 +1310,8 @@ void intel_fbc_enable(struct intel_atomic_state *state, fbc->no_fbc_reason ="FBC enabled but not active yet\n" ; fbc->crtc = crtc; + +intel_fbc_program_cfb (dev_priv); out:mutex_unlock (&fbc->lock); }
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/9 drm/i915/fbc: Embed the compressed_llb node
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Not much point in dynamically allocating the line length buffer mm node that I can see. Just embed it directly like we do the for the cfb node. One less failure point to worry about.
--- drivers/gpu/drm/i915/display/intel_fbc.c | 29 ++++++++---------------- drivers/gpu/drm/i915/i915_drv.h | 2 +- 2 files changed, 10 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +9 -20
@@ -489,11 +489,12 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv, unsigned int size, unsigned int fb_cpp) {struct intel_fbc *fbc = &dev_priv->fbc; -struct drm_mm_node *compressed_llb;int ret;drm_WARN_ON (&dev_priv->drm,drm_mm_node_allocated (&fbc->compressed_fb)); +drm_WARN_ON (&dev_priv->drm, +drm_mm_node_allocated (&fbc->compressed_llb)); ret =find_compression_limit (dev_priv, &fbc->compressed_fb, size, fb_cpp);
@@ -507,16 +508,10 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv, fbc->limit = ret;if (DISPLAY_VER (dev_priv) <5 && !IS_G4X (dev_priv)) { - compressed_llb =kzalloc (sizeof (*compressed_llb),GFP_KERNEL ); -if (!compressed_llb) - goto err_fb; - - ret =i915_gem_stolen_insert_node (dev_priv, compressed_llb, + ret =i915_gem_stolen_insert_node (dev_priv, &fbc->compressed_llb,4096 ,4096 );if (ret) goto err_fb; - - fbc->compressed_llb = compressed_llb; } drm_dbg_kms(&dev_priv->drm,
@@ -526,7 +521,6 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv,return 0 ; err_fb: -kfree (compressed_llb);i915_gem_stolen_remove_node (dev_priv, &fbc->compressed_fb); err_llb:if (drm_mm_initialized (&dev_priv->mm.stolen))
@@ -549,13 +543,13 @@ static void intel_fbc_program_cfb(struct drm_i915_private *dev_priv) fbc->compressed_fb.start, U32_MAX));GEM_BUG_ON (range_overflows_end_t (u64, dev_priv->dsm.start, - fbc->compressed_llb->start, + fbc->compressed_llb.start,U32_MAX ));intel_de_write (dev_priv,FBC_CFB_BASE , dev_priv->dsm.start + fbc->compressed_fb.start);intel_de_write (dev_priv,FBC_LL_BASE , - dev_priv->dsm.start + fbc->compressed_llb->start); + dev_priv->dsm.start + fbc->compressed_llb.start); } }
@@ -566,15 +560,10 @@ static void __intel_fbc_cleanup_cfb(struct drm_i915_private *dev_priv)if (WARN_ON (intel_fbc_hw_is_active (dev_priv)))return ; -if (!drm_mm_node_allocated (&fbc->compressed_fb)) -return ; - -if (fbc->compressed_llb) { -i915_gem_stolen_remove_node (dev_priv, fbc->compressed_llb); -kfree (fbc->compressed_llb); - } - -i915_gem_stolen_remove_node (dev_priv, &fbc->compressed_fb); +if (drm_mm_node_allocated (&fbc->compressed_llb)) +i915_gem_stolen_remove_node (dev_priv, &fbc->compressed_llb); +if (drm_mm_node_allocated (&fbc->compressed_fb)) +i915_gem_stolen_remove_node (dev_priv, &fbc->compressed_fb); }void intel_fbc_cleanup_cfb (struct drm_i915_private *dev_priv)
drivers/gpu/drm/i915/i915_drv.h +1 -1
@@ -351,7 +351,7 @@ struct intel_fbc {struct intel_crtc *crtc;struct drm_mm_node compressed_fb; -struct drm_mm_node *compressed_llb; +struct drm_mm_node compressed_llb;u8 limit;
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/9 drm/i915/fbc: Don't pass around the mm node
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
No point in passing the mm node explicitly to find_compression_limit() since it's always the same node for the cfb.
--- drivers/gpu/drm/i915/display/intel_fbc.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +6 -7
@@ -434,10 +434,10 @@ static u64 intel_fbc_cfb_base_max(struct drm_i915_private *i915) }static int find_compression_limit (struct drm_i915_private *dev_priv, -struct drm_mm_node *node,unsigned int size,unsigned int fb_cpp) { +struct intel_fbc *fbc = &dev_priv->fbc;int compression_limit =1 ;int ret;u64 end;
@@ -462,8 +462,8 @@ static int find_compression_limit(struct drm_i915_private *dev_priv,*/ /* Try to over-allocate to reduce reallocations and fragmentation. */ - ret =i915_gem_stolen_insert_node_in_range (dev_priv, node, size <<=1 , -4096 ,0 , end); + ret =i915_gem_stolen_insert_node_in_range (dev_priv, &fbc->compressed_fb, + size <<=1 ,4096 ,0 , end);if (ret ==0 )return compression_limit;
@@ -473,8 +473,8 @@ static int find_compression_limit(struct drm_i915_private *dev_priv, (fb_cpp == 2 && compression_limit == 2))return 0 ; - ret =i915_gem_stolen_insert_node_in_range (dev_priv, node, size >>=1 , -4096 ,0 , end); + ret =i915_gem_stolen_insert_node_in_range (dev_priv, &fbc->compressed_fb, + size >>=1 ,4096 ,0 , end);if (ret &&DISPLAY_VER (dev_priv) <=4 ) {return 0 ; }else if (ret) {
@@ -496,8 +496,7 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv,drm_WARN_ON (&dev_priv->drm,drm_mm_node_allocated (&fbc->compressed_llb)); - ret =find_compression_limit (dev_priv, &fbc->compressed_fb, - size, fb_cpp); + ret =find_compression_limit (dev_priv, size, fb_cpp);if (!ret) goto err_llb;else if (ret >1 ) {
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/9 drm/i915/fbc: Handle 16bpp compression limit better
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
The limit++ for the 16bpp case is nonsense since the compression limit is always supposed to be power of two. Replace it with <<=1.
--- drivers/gpu/drm/i915/display/intel_fbc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +2 -4
@@ -239,11 +239,10 @@ static void ilk_fbc_activate(struct drm_i915_private *dev_priv) dpfc_ctl =DPFC_CTL_PLANE (params->crtc.i9xx_plane);if (params->fb.format->cpp[0 ] ==2 ) - limit++; + limit <<=1 ;switch (limit) {case 4 : -case 3 : dpfc_ctl |=DPFC_CTL_LIMIT_4X ;break ;case 2 :
@@ -319,11 +318,10 @@ static void gen7_fbc_activate(struct drm_i915_private *dev_priv) dpfc_ctl |=IVB_DPFC_CTL_PLANE (params->crtc.i9xx_plane);if (params->fb.format->cpp[0 ] ==2 ) - limit++; + limit <<=1 ;switch (limit) {case 4 : -case 3 : dpfc_ctl |=DPFC_CTL_LIMIT_4X ;break ;case 2 :
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/9 drm/i915/fbc: Introduce g4x_dpfc_ctl_limit()
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Exctract the limit->register value conversion into a common helper.
--- drivers/gpu/drm/i915/display/intel_fbc.c | 58 ++++++++++-------------- 1 file changed, 25 insertions(+), 33 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +25 -33
@@ -148,16 +148,35 @@ static bool i8xx_fbc_is_active(struct drm_i915_private *dev_priv)return intel_de_read (dev_priv,FBC_CONTROL ) &FBC_CTL_EN ; } +static u32 g4x_dpfc_ctl_limit (struct drm_i915_private *i915) +{ +const struct intel_fbc_reg_params *params = &i915->fbc.params; +int limit = i915->fbc.limit; + +if (params->fb.format->cpp[0 ] ==2 ) + limit <<=1 ; + +switch (limit) { +default : +MISSING_CASE (limit); + fallthrough; +case 1 : +return DPFC_CTL_LIMIT_1X ; +case 2 : +return DPFC_CTL_LIMIT_2X ; +case 4 : +return DPFC_CTL_LIMIT_4X ; + } +} +static void g4x_fbc_activate (struct drm_i915_private *dev_priv) {struct intel_fbc_reg_params *params = &dev_priv->fbc.params;u32 dpfc_ctl; dpfc_ctl =DPFC_CTL_PLANE (params->crtc.i9xx_plane) |DPFC_SR_EN ; -if (params->fb.format->cpp[0 ] ==2 ) - dpfc_ctl |=DPFC_CTL_LIMIT_2X ; -else - dpfc_ctl |=DPFC_CTL_LIMIT_1X ; + + dpfc_ctl |=g4x_dpfc_ctl_limit (dev_priv);if (params->fence_id >=0 ) { dpfc_ctl |=DPFC_CTL_FENCE_EN | params->fence_id;
@@ -235,23 +254,10 @@ static void ilk_fbc_activate(struct drm_i915_private *dev_priv) {struct intel_fbc_reg_params *params = &dev_priv->fbc.params;u32 dpfc_ctl; -int limit = dev_priv->fbc.limit; dpfc_ctl =DPFC_CTL_PLANE (params->crtc.i9xx_plane); -if (params->fb.format->cpp[0 ] ==2 ) - limit <<=1 ; -switch (limit) { -case 4 : - dpfc_ctl |=DPFC_CTL_LIMIT_4X ; -break ; -case 2 : - dpfc_ctl |=DPFC_CTL_LIMIT_2X ; -break ; -case 1 : - dpfc_ctl |=DPFC_CTL_LIMIT_1X ; -break ; - } + dpfc_ctl |=g4x_dpfc_ctl_limit (dev_priv);if (params->fence_id >=0 ) { dpfc_ctl |=DPFC_CTL_FENCE_EN ;
@@ -299,7 +305,6 @@ static void gen7_fbc_activate(struct drm_i915_private *dev_priv) {struct intel_fbc_reg_params *params = &dev_priv->fbc.params;u32 dpfc_ctl; -int limit = dev_priv->fbc.limit;/* Display WA #0529: skl, kbl, bxt. */ if (DISPLAY_VER (dev_priv) ==9 ) {
@@ -317,20 +322,7 @@ static void gen7_fbc_activate(struct drm_i915_private *dev_priv)if (IS_IVYBRIDGE (dev_priv)) dpfc_ctl |=IVB_DPFC_CTL_PLANE (params->crtc.i9xx_plane); -if (params->fb.format->cpp[0 ] ==2 ) - limit <<=1 ; - -switch (limit) { -case 4 : - dpfc_ctl |=DPFC_CTL_LIMIT_4X ; -break ; -case 2 : - dpfc_ctl |=DPFC_CTL_LIMIT_2X ; -break ; -case 1 : - dpfc_ctl |=DPFC_CTL_LIMIT_1X ; -break ; - } + dpfc_ctl |=g4x_dpfc_ctl_limit (dev_priv);if (params->fence_id >=0 ) { dpfc_ctl |=IVB_DPFC_CTL_FENCE_EN ;
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/9 drm/i915/fbc: Extract intel_fbc_stolen_end()
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Declutter find_compression_limit() a bit by extracting intel_fbc_stolen_end().
--- drivers/gpu/drm/i915/display/intel_fbc.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +12 -7
@@ -423,13 +423,8 @@ static u64 intel_fbc_cfb_base_max(struct drm_i915_private *i915)return BIT_ULL (32 ); } -static int find_compression_limit (struct drm_i915_private *dev_priv, -unsigned int size, -unsigned int fb_cpp) +static u64 intel_fbc_stolen_end (struct drm_i915_private *dev_priv) { -struct intel_fbc *fbc = &dev_priv->fbc; -int compression_limit =1 ; -int ret;u64 end;/* The FBC hardware for BDW/SKL doesn't have access to the stolen
@@ -442,7 +437,17 @@ static int find_compression_limit(struct drm_i915_private *dev_priv,else end =U64_MAX ; - end =min (end,intel_fbc_cfb_base_max (dev_priv)); +return min (end,intel_fbc_cfb_base_max (dev_priv)); +} + +static int find_compression_limit (struct drm_i915_private *dev_priv, +unsigned int size, +unsigned int fb_cpp) +{ +struct intel_fbc *fbc = &dev_priv->fbc; +u64 end =intel_fbc_stolen_end (dev_priv); +int compression_limit =1 ; +int ret;/* HACK: This code depends on what we will do in *_enable_fbc. If that * code changes, this code needs to change as well.
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/9 drm/i915/fbc: Make the cfb allocation loop a bit more legible
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Write the cfb allocation loop as an actual loop instead of some hard to read goto thing.
--- drivers/gpu/drm/i915/display/intel_fbc.c | 51 ++++++++++++------------ 1 file changed, 26 insertions(+), 25 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +26 -25
@@ -440,44 +440,45 @@ static u64 intel_fbc_stolen_end(struct drm_i915_private *dev_priv)return min (end,intel_fbc_cfb_base_max (dev_priv)); } +static int intel_fbc_max_limit (struct drm_i915_private *dev_priv,int fb_cpp) +{ +/* +* FIXME: FBC1 can have arbitrary cfb stride, +* so we could support different compression ratios. +*/ +if (DISPLAY_VER (dev_priv) <5 && !IS_G4X (dev_priv)) +return 1 ; + +/* WaFbcOnly1to1Ratio:ctg */ +if (IS_G4X (dev_priv)) +return 1 ; + +/* FBC2 can only do 1:1, 1:2, 1:4 */ +return fb_cpp ==2 ?2 :4 ; +} +static int find_compression_limit (struct drm_i915_private *dev_priv,unsigned int size,unsigned int fb_cpp) {struct intel_fbc *fbc = &dev_priv->fbc;u64 end =intel_fbc_stolen_end (dev_priv); -int compression_limit =1 ; -int ret; - -/* HACK: This code depends on what we will do in *_enable_fbc. If that -* code changes, this code needs to change as well. -* -* The enable_fbc code will attempt to use one of our 2 compression -* limits, therefore, in that case, we only have 1 resort. -*/ +int ret, limit =1 ;/* Try to over-allocate to reduce reallocations and fragmentation. */ ret =i915_gem_stolen_insert_node_in_range (dev_priv, &fbc->compressed_fb, size <<=1 ,4096 ,0 , end);if (ret ==0 ) -return compression_limit; +return limit; -again: -/* HW's ability to limit the CFB is 1:4 */ -if (compression_limit >4 || - (fb_cpp ==2 && compression_limit ==2 )) -return 0 ; - - ret =i915_gem_stolen_insert_node_in_range (dev_priv, &fbc->compressed_fb, - size >>=1 ,4096 ,0 , end); -if (ret &&DISPLAY_VER (dev_priv) <=4 ) { -return 0 ; - }else if (ret) { - compression_limit <<=1 ; - goto again; - }else { -return compression_limit; +for (; limit <=intel_fbc_max_limit (dev_priv, fb_cpp); limit <<=1 ) { + ret =i915_gem_stolen_insert_node_in_range (dev_priv, &fbc->compressed_fb, + size >>=1 ,4096 ,0 , end); +if (ret ==0 ) +return limit; } + +return 0 ; } static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv,
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 9/9 drm/i915/fbc: Allocate llb before cfb
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Since the llb allocation has a fixed size, let's grab it before the potentially variable sized cfb. That should avoid some allocation failure cases once we allow different compression ratios for FBC1.
--- drivers/gpu/drm/i915/display/intel_fbc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_fbc.c +9 -9
@@ -492,6 +492,13 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv,drm_WARN_ON (&dev_priv->drm,drm_mm_node_allocated (&fbc->compressed_llb)); +if (DISPLAY_VER (dev_priv) <5 && !IS_G4X (dev_priv)) { + ret =i915_gem_stolen_insert_node (dev_priv, &fbc->compressed_llb, +4096 ,4096 ); +if (ret) + goto err; + } + ret =find_compression_limit (dev_priv, size, fb_cpp);if (!ret) goto err_llb;
@@ -502,22 +509,15 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv, fbc->limit = ret; -if (DISPLAY_VER (dev_priv) <5 && !IS_G4X (dev_priv)) { - ret =i915_gem_stolen_insert_node (dev_priv, &fbc->compressed_llb, -4096 ,4096 ); -if (ret) - goto err_fb; - } -drm_dbg_kms (&dev_priv->drm,"reserved %llu bytes of contiguous stolen space for FBC, limit: %d\n" , fbc->compressed_fb.size, fbc->limit);return 0 ; -err_fb: -i915_gem_stolen_remove_node (dev_priv, &fbc->compressed_fb); err_llb: +i915_gem_stolen_remove_node (dev_priv, &fbc->compressed_llb); +err:if (drm_mm_initialized (&dev_priv->mm.stolen))drm_info_once (&dev_priv->drm,"not enough stolen space for compressed buffer (need %d more bytes), disabling. Hint: you may be able to increase stolen memory size in the BIOS to avoid this.\n" , size);return -ENOSPC ;
Signature · 6 lines
2.31.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 9/9] drm/i915/fbc: Allocate llb before cfb
whole series is
Quoted 44 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Since the llb allocation has a fixed size, let's grab it before the potentially variable sized cfb. That should avoid some allocation failure cases once we allow different compression ratios for FBC1.
Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/display/intel_fbc.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)drivers/gpu/drm/i915/display/intel_fbc.c +7
-7@@ -492,6 +492,13 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv,drm_WARN_ON (&dev_priv->drm,drm_mm_node_allocated (&fbc->compressed_llb)); +if (DISPLAY_VER (dev_priv) <5 && !IS_G4X (dev_priv)) { + ret =i915_gem_stolen_insert_node (dev_priv, &fbc->compressed_llb, +4096 ,4096 ); +if (ret) + goto err; + } + ret =find_compression_limit (dev_priv, size, fb_cpp);if (!ret) goto err_llb;@@ -502,22 +509,15 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv, fbc->limit = ret; -if (DISPLAY_VER (dev_priv) <5 && !IS_G4X (dev_priv)) { - ret =i915_gem_stolen_insert_node (dev_priv, &fbc->compressed_llb, -4096 ,4096 ); -if (ret) - goto err_fb; - } -drm_dbg_kms (&dev_priv->drm,"reserved %llu bytes of contiguous stolen space for FBC, limit: %d\n" , fbc->compressed_fb.size, fbc->limit);
drivers/gpu/drm/i915/display/intel_fbc.c static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv, · line 523
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_fbc.c +2
-2return 0 ; -err_fb: -i915_gem_stolen_remove_node (dev_priv, &fbc->compressed_fb); err_llb: +i915_gem_stolen_remove_node (dev_priv, &fbc->compressed_llb); +err:if (drm_mm_initialized (&dev_priv->mm.stolen))drm_info_once (&dev_priv->drm,"not enough stolen space for compressed buffer (need %d more bytes), disabling. Hint: you may be able to increase stolen memory size in the BIOS to avoid this.\n" , size);return -ENOSPC ;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/fbc: Clean up cfb allocation code
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915/fbc: Clean up cfb allocation code
URL : https://patchwork.freedesktop.org/series/91347/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_display.c:1893:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_display.c:1893:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_display.c:1893:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1207:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/fbc: Clean up cfb allocation code
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915/fbc: Clean up cfb allocation code
URL : https://patchwork.freedesktop.org/series/91347/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10205 -> Patchwork_20335
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20335:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@runner@aborted:
- {fi-jsl-1}: [FAIL][1] ([i915#1222]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-jsl-1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/fi-jsl-1/igt@[email protected]
- {fi-ehl-2}: [FAIL][3] ([i915#1222]) -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-ehl-2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/fi-ehl-2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_20335 that come from known issues:
### IGT changes ###
#### Warnings ####
* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [DMESG-FAIL][5] ([i915#3462]) -> [INCOMPLETE][6] ([i915#2782] / [i915#2940] / [i915#3462])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-bsw-nick/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/fi-bsw-nick/igt@i915_selftest@[email protected]
- fi-bsw-kefka: [DMESG-FAIL][7] ([i915#3462]) -> [INCOMPLETE][8] ([i915#2782] / [i915#2940] / [i915#3462])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-bsw-kefka/igt@i915_selftest@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/fi-bsw-kefka/igt@i915_selftest@[email protected]
* igt@runner@aborted:
- fi-glk-dsi: [FAIL][9] ([i915#2426] / [i915#3363] / [k.org#202321]) -> [FAIL][10] ([i915#3363] / [k.org#202321])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-glk-dsi/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/fi-glk-dsi/igt@[email protected]
- fi-kbl-guc: [FAIL][11] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][12] ([i915#1436] / [i915#3363])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-kbl-guc/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/fi-kbl-guc/igt@[email protected]
- fi-kbl-7567u: [FAIL][13] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][14] ([i915#1436] / [i915#3363])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-kbl-7567u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/fi-kbl-7567u/igt@[email protected]
- fi-skl-guc: [FAIL][15] ([i915#1436] / [i915#3363]) -> [FAIL][16] ([i915#1436] / [i915#2426] / [i915#3363])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-skl-guc/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/fi-skl-guc/igt@[email protected]
- fi-skl-6700k2: [FAIL][17] ([i915#1436] / [i915#2426] / [i915#3363]) -> [FAIL][18] ([i915#1436] / [i915#3363])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/fi-skl-6700k2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/fi-skl-6700k2/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3276]: https://gitlab.freedesktop.org/drm/intel/issues/3276
[i915#3277]: https://gitlab.freedesktop.org/drm/intel/issues/3277
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3283]: https://gitlab.freedesktop.org/drm/intel/issues/3283
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3462]: https://gitlab.freedesktop.org/drm/intel/issues/3462
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3542]: https://gitlab.freedesktop.org/drm/intel/issues/3542
[i915#3544]: https://gitlab.freedesktop.org/drm/intel/issues/3544
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (46 -> 39)
------------------------------
Additional (1): fi-rkl-11500t
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-adlp-4 bat-adls-4 fi-bdw-samus bat-jsl-1 fi-snb-2600
Build changes
-------------
* Linux: CI_DRM_10205 -> Patchwork_20335
CI-20190529: 20190529
CI_DRM_10205: e3375fd2aeeb2416a8e8c8b59d106adf9c0dd938 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6103: 3aa79e55e73d4a49a5222e5dfde486b800a29fe7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20335: 4901bb206944ba33cc690e6d81fbc6d632e6cc1c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4901bb206944 drm/i915/fbc: Allocate llb before cfb c089272d98e4 drm/i915/fbc: Make the cfb allocation loop a bit more legible caf30d274793 drm/i915/fbc: Extract intel_fbc_stolen_end() 7f47788d9eb7 drm/i915/fbc: Introduce g4x_dpfc_ctl_limit() 6f21b931b413 drm/i915/fbc: Handle 16bpp compression limit better 491545052b2c drm/i915/fbc: Don't pass around the mm node f6e1ebc163e6 drm/i915/fbc: Embed the compressed_llb node 3dba16a8f7bf drm/i915/fbc: Extract intel_fbc_program_cfb() 6f1b95ff4fe2 drm/i915/fbc: s/threshold/limit/
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/fbc: Clean up cfb allocation code
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915/fbc: Clean up cfb allocation code
URL : https://patchwork.freedesktop.org/series/91347/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10205_full -> Patchwork_20335_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20335_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_20335_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20335_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb3/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_20335_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@clone:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +5 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-snb6/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][4] ([fdo#109271]) +41 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk3/igt@gem_exec_fair@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl7/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271]) +424 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-snb6/igt@[email protected]
* igt@gem_exec_parallel@engines@basic:
- shard-glk: [PASS][10] -> [DMESG-WARN][11] ([i915#118] / [i915#95])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk8/igt@gem_exec_parallel@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-glk3/igt@gem_exec_parallel@[email protected]
* igt@gem_exec_reloc@basic-wide-active@bcs0:
- shard-apl: NOTRUN -> [FAIL][12] ([i915#2389]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl6/igt@gem_exec_reloc@[email protected]
* igt@gem_exec_reloc@basic-wide-active@vcs1:
- shard-iclb: NOTRUN -> [FAIL][13] ([i915#2389])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb2/igt@gem_exec_reloc@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#2190])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl2/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#2190])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl4/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#2190])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl4/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-skl: NOTRUN -> [INCOMPLETE][17] ([i915#198] / [i915#2405])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl10/igt@[email protected]
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][18] -> [DMESG-WARN][19] ([i915#180])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl3/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl7/igt@[email protected]
* igt@gen7_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][20] ([fdo#109289])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@[email protected]
* igt@i915_hangman@engine-error@vecs0:
- shard-kbl: NOTRUN -> [SKIP][21] ([fdo#109271]) +101 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl2/igt@i915_hangman@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][22] ([i915#454])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl4/igt@[email protected]
* igt@i915_pm_rpm@modeset-lpsp-stress:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271]) +137 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl7/igt@[email protected]
* igt@kms_big_fb@yf-tiled-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][24] ([fdo#111615]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@[email protected]
* igt@kms_ccs@pipe-c-ccs-on-another-bo:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111304])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl4/igt@[email protected]
* igt@kms_chamelium@hdmi-audio:
- shard-skl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl4/igt@[email protected]
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-snb: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +19 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-snb6/igt@[email protected]
* igt@kms_color@pipe-a-ctm-0-25:
- shard-skl: [PASS][28] -> [DMESG-WARN][29] ([i915#1982])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl5/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl3/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109284] / [fdo#111827]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +12 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl6/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-gamma:
- shard-kbl: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +7 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl4/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-kbl: NOTRUN -> [TIMEOUT][33] ([i915#1319])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl4/igt@[email protected]
* igt@kms_content_protection@srm:
- shard-apl: NOTRUN -> [TIMEOUT][34] ([i915#1319])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl2/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][35] -> [DMESG-WARN][36] ([i915#180]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl4/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#109279] / [i915#3359]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][38] -> [FAIL][39] ([i915#2346])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl8/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl10/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-iclb: [PASS][40] -> [FAIL][41] ([i915#2346])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb5/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb2/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][42] -> [FAIL][43] ([i915#79])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl9/igt@kms_flip@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl5/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a2:
- shard-glk: [PASS][44] -> [FAIL][45] ([i915#79])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk9/igt@kms_flip@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: NOTRUN -> [DMESG-WARN][46] ([i915#180]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl6/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@b-dp1:
- shard-kbl: [PASS][47] -> [FAIL][48] ([i915#2122])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@kms_flip@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl7/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile:
- shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#2642])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl4/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#2642])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl2/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#2642])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl4/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][52] ([fdo#111825]) +5 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch:
- shard-skl: [PASS][53] -> [FAIL][54] ([i915#1188])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][55] ([fdo#108145] / [i915#265])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-kbl: NOTRUN -> [FAIL][56] ([i915#265])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][57] ([fdo#108145] / [i915#265])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][58] -> [FAIL][59] ([fdo#108145] / [i915#265])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl2/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][60] ([fdo#108145] / [i915#265])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-kbl: [PASS][61] -> [FAIL][62] ([fdo#108145] / [i915#265])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl7/igt@[email protected]
* igt@kms_plane_lowres@pipe-c-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][63] ([i915#3536])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658]) +2 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl4/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-apl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#658]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl2/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [PASS][66] -> [SKIP][67] ([fdo#109441]) +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb8/igt@kms_psr@psr2_cursor_plane_move.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][68] ([i915#132] / [i915#3467])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-glk: [PASS][69] -> [DMESG-WARN][70] ([i915#118] / [i915#295] / [i915#95])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk2/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-glk1/igt@[email protected]
* igt@kms_vrr@flip-basic:
- shard-tglb: NOTRUN -> [SKIP][71] ([fdo#109502])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@[email protected]
* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#2437])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl7/igt@[email protected]
* igt@prime_nv_pcopy@test3_2:
- shard-tglb: NOTRUN -> [SKIP][73] ([fdo#109291])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@prime_nv_pcopy@test3_2.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#2994])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl6/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2994])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl4/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][76] ([i915#2369] / [i915#3063]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb3/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb3/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][78] ([i915#2842]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb1/igt@gem_exec_fair@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][80] ([i915#2842]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb5/igt@gem_exec_fair@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: [FAIL][82] ([i915#2842]) -> [PASS][83] +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk2/igt@gem_exec_fair@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-glk5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][84] ([i915#2842]) -> [PASS][85] +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl7/igt@gem_exec_fair@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-glk: [DMESG-WARN][86] ([i915#118] / [i915#95]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk7/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-glk9/igt@[email protected]
* igt@gem_mmap_gtt@big-copy:
- shard-glk: [FAIL][88] ([i915#307]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk2/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-glk5/igt@[email protected]
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-iclb: [FAIL][90] ([i915#307]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb2/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb8/igt@[email protected]
* igt@gem_mmap_offset@clear:
- shard-skl: [FAIL][92] ([i915#3160]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl8/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl10/igt@[email protected]
- shard-iclb: [FAIL][94] ([i915#3160]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb8/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb5/igt@[email protected]
* igt@gem_spin_batch@engines@bcs0:
- shard-apl: [FAIL][96] ([i915#2898]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl3/igt@gem_spin_batch@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl7/igt@gem_spin_batch@[email protected]
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][98] ([i915#2782]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-snb6/igt@i915_selftest@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-snb5/igt@i915_selftest@[email protected]
* igt@kms_color@pipe-c-ctm-0-5:
- shard-skl: [DMESG-WARN][100] ([i915#1982]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl8/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl7/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2:
- shard-glk: [FAIL][102] ([i915#79]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-glk9/igt@kms_flip@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-glk3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@b-dp1:
- shard-apl: [DMESG-WARN][104] ([i915#180]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-apl8/igt@kms_flip@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-apl2/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][106] ([i915#180]) -> [PASS][107] +3 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl6/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][108] ([fdo#108145] / [i915#265]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl4/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl5/igt@[email protected]
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][110] ([fdo#109441]) -> [PASS][111] +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb7/igt@kms_psr@psr2_cursor_blt.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][112] ([i915#180] / [i915#295]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl7/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl2/igt@[email protected]
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][114] ([i915#1542]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-skl10/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-skl1/igt@[email protected]
* igt@prime_vgem@sync@rcs0:
- shard-tglb: [INCOMPLETE][116] ([i915#409]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb6/igt@prime_vgem@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb5/igt@prime_vgem@[email protected]
#### Warnings ####
* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [FAIL][118] ([i915#2428]) -> [FAIL][119] ([i915#307])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb1/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb1/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][120] ([i915#1804] / [i915#2684]) -> [WARN][121] ([i915#2684])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb7/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb1/igt@[email protected]
* igt@i915_selftest@live@execlists:
- shard-tglb: [DMESG-FAIL][122] ([i915#3462]) -> [INCOMPLETE][123] ([i915#3462])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-tglb2/igt@i915_selftest@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-tglb6/igt@i915_selftest@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][124] ([i915#658]) -> [SKIP][125] ([i915#2920]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb5/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][126] ([i915#2920]) -> [SKIP][127] ([i915#658]) +1 similar issue
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb2/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-iclb8/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602]) -> ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2505] / [i915#3002] / [i915#3363] / [i915#602])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl6/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl7/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl2/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl4/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl6/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl1/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl6/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl4/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl7/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-kbl3/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl6/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl6/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl7/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl7/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl6/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl3/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl7/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl1/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl2/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl1/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl1/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/shard-kbl1/igt@[email protected]
- shard-iclb: ([FAIL][155], [FAIL][156], [FAIL][157]) ([i915#2426] / [i915#2782] / [i915#3002]) -> ([FAIL][158], [FAIL][159], [FAIL][160]) ([i915#2782] / [i915#3002])
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb2/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb8/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10205/shard-iclb7/igt@[email protected]
[158]: https://intel-gfx-c
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20335/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx