net: caif: fix memory leak in ldisc_open
Subsystems (2)
PATCH 1/1 net: caif: fix memory leak in ldisc_open
Syzbot reported memory leak in tty_init_dev().
The problem was in unputted tty in ldisc_open()
static int ldisc_open(struct tty_struct *tty)
{
...
ser->tty = tty_kref_get(tty);
...
result = register_netdevice(dev);
if (result) {
rtnl_unlock();
free_netdev(dev);
return -ENODEV;
}...
}
Ser pointer is netdev private_data, so after free_netdev() this pointer goes away with unputted tty reference. So, fix it by adding tty_kref_put() before freeing netdev.
--- drivers/net/caif/caif_serial.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/caif/caif_serial.c +1 -0
@@ -350,6 +350,7 @@ static int ldisc_open(struct tty_struct *tty)rtnl_lock (); result =register_netdevice (dev);if (result) { +tty_kref_put (tty);rtnl_unlock ();free_netdev (dev);return -ENODEV ;
Signature · 1 line
2.32.0
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 14 lines · On Sat, 12 Jun 2021 17:51:22 +0300 you wrote:
Syzbot reported memory leak in
tty_init_dev().
The problem was in unputted tty inldisc_open()static int
ldisc_open(struct tty_struct *tty)
{
...ser->tty = tty_kref_get(tty); ... result = register_netdevice(dev); if (result) { rtnl_unlock(); free_netdev(dev); return -ENODEV; }
Quoted 4 lines
...
}[...]
Here is the summary with links:
- net: caif: fix memory leak in ldisc_open
https://git.kernel.org/netdev/net/c/58af3d3d54e8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html