acpi: acpi_video: Fixed comment style code issues
PATCH 1/1 acpi: acpi_video: Fixed comment style code issues
Fixed coding style issues.
Signed-off-by Clayton Casciato <[email protected]>
--- drivers/acpi/acpi_video.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/acpi/acpi_video.c +3 -6
@@ -134,8 +134,7 @@ struct acpi_video_device_attrib { u32 display_type:4; /* Describe the specific type in use */ u32 vendor_specific:4; /* Chipset Vendor Specific */ u32 bios_can_detect:1; /* BIOS can detect the device */ - u32 depend_on_vga:1; /* Non-VGA output device whose power is related to -the VGA device. */ + u32 depend_on_vga:1; /* Non-VGA output device whose power is related to the VGA device */ u32 pipe_id:3; /* For VGA multiple-head devices. */ u32 reserved:10; /* Must be 0 */
@@ -1581,13 +1580,11 @@ static void acpi_video_bus_notify(struct acpi_device *device, u32 event) input = video->input;switch (event) { -case ACPI_VIDEO_NOTIFY_SWITCH :/* User requested a switch, -* most likely via hotkey. */ +case ACPI_VIDEO_NOTIFY_SWITCH :/* User requested a switch, most likely via hotkey. */ keycode =KEY_SWITCHVIDEOMODE ;break ; -case ACPI_VIDEO_NOTIFY_PROBE :/* User plugged in or removed a video -* connector. */ +case ACPI_VIDEO_NOTIFY_PROBE :/* User plugged in or removed a video connector. */ acpi_video_device_enumerate (video);acpi_video_device_rebind (video); keycode =KEY_SWITCHVIDEOMODE ;
Signature · 1 line
2.31.1
Rafael J. Wysocki
maintainerQuoted 2 lines · Clayton Casciato
Fixed coding style issues.
The comments are broken the way they are to avoid going over 80 characters. What's wrong with them?
Quoted 38 lines
Signed-off-by Clayton Casciato <[email protected]>--- drivers/acpi/acpi_video.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)drivers/acpi/acpi_video.c +3
-7@@ -134,8 +134,7 @@ struct acpi_video_device_attrib { u32 display_type:4; /* Describe the specific type in use */ u32 vendor_specific:4; /* Chipset Vendor Specific */ u32 bios_can_detect:1; /* BIOS can detect the device */ - u32 depend_on_vga:1; /* Non-VGA output device whose power is related to -the VGA device. */ + u32 depend_on_vga:1; /* Non-VGA output device whose power is related to the VGA device */ u32 pipe_id:3; /* For VGA multiple-head devices. */ u32 reserved:10; /* Must be 0 */@@ -1581,13 +1580,11 @@ static void acpi_video_bus_notify(struct acpi_device *device, u32 event) input = video->input;switch (event) { -case ACPI_VIDEO_NOTIFY_SWITCH :/* User requested a switch, -* most likely via hotkey. */ +case ACPI_VIDEO_NOTIFY_SWITCH :/* User requested a switch, most likely via hotkey. */ keycode =KEY_SWITCHVIDEOMODE ;break ; -case ACPI_VIDEO_NOTIFY_PROBE :/* User plugged in or removed a video -* connector. */ +case ACPI_VIDEO_NOTIFY_PROBE :/* User plugged in or removed a video connector. */ acpi_video_device_enumerate (video);acpi_video_device_rebind (video); keycode =KEY_SWITCHVIDEOMODE ; --2.31.1
Quoted 8 lines · Rafael J. Wysocki
Quoted 2 lines · Clayton Casciato
Fixed coding style issues.
The comments are broken the way they are to avoid going over 80 characters. What's wrong with them?
Checkpatch warns that "block comments use a trailing */ on a separate line".
I believe the patch fixes the style issue and improves readability.
NB: the first comment exceeds 80 characters pre-patch.
From my understanding, the default limit is 100 characters as of bdc48fa11e46.
Thank you for your consideration!
Quoted 38 lines
Quoted 38 lines
Signed-off-by Clayton Casciato <[email protected]>--- drivers/acpi/acpi_video.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)drivers/acpi/acpi_video.c +3
-7@@ -134,8 +134,7 @@ struct acpi_video_device_attrib { u32 display_type:4; /* Describe the specific type in use */ u32 vendor_specific:4; /* Chipset Vendor Specific */ u32 bios_can_detect:1; /* BIOS can detect the device */ - u32 depend_on_vga:1; /* Non-VGA output device whose power is related to -the VGA device. */ + u32 depend_on_vga:1; /* Non-VGA output device whose power is related to the VGA device */ u32 pipe_id:3; /* For VGA multiple-head devices. */ u32 reserved:10; /* Must be 0 */@@ -1581,13 +1580,11 @@ static void acpi_video_bus_notify(struct acpi_device *device, u32 event) input = video->input;switch (event) { -case ACPI_VIDEO_NOTIFY_SWITCH :/* User requested a switch, -* most likely via hotkey. */ +case ACPI_VIDEO_NOTIFY_SWITCH :/* User requested a switch, most likely via hotkey. */ keycode =KEY_SWITCHVIDEOMODE ;break ; -case ACPI_VIDEO_NOTIFY_PROBE :/* User plugged in or removed a video -* connector. */ +case ACPI_VIDEO_NOTIFY_PROBE :/* User plugged in or removed a video connector. */ acpi_video_device_enumerate (video);acpi_video_device_rebind (video); keycode =KEY_SWITCHVIDEOMODE ; --2.31.1