Skip to contentSkip to conversation

e1000e: Add space to the debug print

PATCH Superseded Sasha Neftin 2 participants 2 messages Jun 14, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000e: Add space to the debug print

Complete to commit 3cf31b1a9eff ("e1000e: bump up timeout to wait when ME un-configures ULP mode")
Minor fixes to allow debug prints more readable.

Fixes 3cf31b1a9eff ("e1000e: bump up timeout to

wait when ME un-configures ULP mode")

---
 drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/e1000e/ich8lan.c +2 -2
index 5b008c88beb7..a3cf0af7aedd 100644
@@ -1271,9 +1271,9 @@ static s32 e1000_disable_ulp_lpt_lp(struct e1000_hw *hw, bool force)
 			usleep_range(10000, 11000);
 		}
 		if (firmware_bug)
-			e_warn("ULP_CONFIG_DONE took %dmsec.  This is a firmware bug\n", i * 10);
+			e_warn("ULP_CONFIG_DONE took %d msec.  This is a firmware bug\n", i * 10);
 		else
-			e_dbg("ULP_CONFIG_DONE cleared after %dmsec\n", i * 10);
+			e_dbg("ULP_CONFIG_DONE cleared after %d msec\n", i * 10);
 
 		if (force) {
 			mac_reg = er32(H2ME);
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 e1000e: Add space to the debug print

Quoted 6 lines · Sasha Neftin

Complete to commit 3cf31b1a9eff ("e1000e: bump up timeout to wait when ME un-configures ULP mode")
Minor fixes to allow debug prints more readable.

Fixes 3cf31b1a9eff ("e1000e: bump up timeout to

wait when ME un-configures ULP mode")

The Fixes should all be on one line.
Fixes tag: Fixes: 3cf31b1a9eff ("e1000e: bump up timeout to Has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes

Quoted 23 lines
---
 drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/e1000e/ich8lan.c +1 -2
index 5b008c88beb7..a3cf0af7aedd 100644
@@ -1271,9 +1271,9 @@ static s32 e1000_disable_ulp_lpt_lp(struct
 e1000_hw *hw, bool force)
 			usleep_range(10000, 11000);
 		}
 		if (firmware_bug)
-			e_warn("ULP_CONFIG_DONE took %dmsec.  This is a
 firmware bug\n", i * 10);
+			e_warn("ULP_CONFIG_DONE took %d msec.  This is
 a firmware bug\n", i * 10);
 		else
-			e_dbg("ULP_CONFIG_DONE cleared after %dmsec\n",

i * 10);

drivers/net/ethernet/intel/e1000e/ich8lan.c +1 -0
+			e_dbg("ULP_CONFIG_DONE cleared after %d
Quoted 1 line

msec\n", i * 10);

nit: Since there will be a new version, can you put the 'i * 10's on a new line?
WARNING: line length of 81 exceeds 80 columns
WARNING: line length of 98 exceeds 80 columns

Quoted 3 lines
drivers/net/ethernet/intel/e1000e/ich8lan.c +0 -0
 		if (force) {
 			mac_reg = er32(H2ME);