drivers: drop unused usb_gadget_{map,unmap}_request()
PATCH 1/1 drivers: drop unused usb_gadget_{map,unmap}_request()
There is no code that is dependent on
usb_gadget_{map,unmap}_request().
Signed-off-by Antony Pavlov <[email protected]>
--- drivers/usb/gadget/udc-core.c | 55 ----------------------------------- include/usb/gadget.h | 10 ------- 2 files changed, 65 deletions(-)
drivers/usb/gadget/udc-core.c +0 -55
@@ -46,61 +46,6 @@ static LIST_HEAD(udc_list);/* ------------------------------------------------------------------------- */ -#ifdef CONFIG_KERNEL_HAS_DMA - -int usb_gadget_map_request (struct usb_gadget *gadget, -struct usb_request *req,int is_in) -{ -if (req->length ==0 ) -return 0 ; - -if (req->num_sgs) { -int mapped; - - mapped =dma_map_sg (&gadget->dev, req->sg, req->num_sgs, - is_in ?DMA_TO_DEVICE :DMA_FROM_DEVICE ); -if (mapped ==0 ) { -dev_err (&gadget->dev,"failed to map SGs\n" ); -return -EFAULT ; - } - - req->num_mapped_sgs = mapped; - }else { - req->dma =dma_map_single (&gadget->dev, req->buf, req->length, - is_in ?DMA_TO_DEVICE :DMA_FROM_DEVICE ); - -if (dma_mapping_error (&gadget->dev, req->dma)) { -dev_err (&gadget->dev,"failed to map buffer\n" ); -return -EFAULT ; - } - } - -return 0 ; -} -EXPORT_SYMBOL_GPL (usb_gadget_map_request); - -void usb_gadget_unmap_request (struct usb_gadget *gadget, -struct usb_request *req,int is_in) -{ -if (req->length ==0 ) -return ; - -if (req->num_mapped_sgs) { -dma_unmap_sg (&gadget->dev, req->sg, req->num_mapped_sgs, - is_in ?DMA_TO_DEVICE :DMA_FROM_DEVICE ); - - req->num_mapped_sgs =0 ; - }else { -dma_unmap_single (&gadget->dev, req->dma, req->length, - is_in ?DMA_TO_DEVICE :DMA_FROM_DEVICE ); - } -} -EXPORT_SYMBOL_GPL (usb_gadget_unmap_request); - -#endif /* CONFIG_HAS_DMA */ - -/* ------------------------------------------------------------------------- */ -void usb_gadget_set_state (struct usb_gadget *gadget,enum usb_device_state state) {
include/usb/gadget.h +0 -10
@@ -1002,16 +1002,6 @@ void usb_free_all_descriptors(struct usb_function *f);/*-------------------------------------------------------------------------*/ -/* utility to simplify map/unmap of usb_requests to/from DMA */ - -extern int usb_gadget_map_request (struct usb_gadget *gadget, -struct usb_request *req,int is_in); - -extern void usb_gadget_unmap_request (struct usb_gadget *gadget, -struct usb_request *req,int is_in); - -/*-------------------------------------------------------------------------*/ -/* utility to set gadget state properly */ extern void usb_gadget_set_state(struct usb_gadget *gadget,
Signature · 7 lines
2.32.0.rc0 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 2 lines · Antony Pavlov
There is no code that is dependent on
usb_gadget_{map,unmap}_request().
My first reaction was: But maybe there *should* be code depending on that, but
drivers/usb/gadget/udc-core.c static LIST_HEAD(udc_list); · line 61
Quoted 13 lines
drivers/usb/gadget/udc-core.c +0
-13-#ifdef CONFIG_KERNEL_HAS_DMA - -int usb_gadget_map_request (struct usb_gadget *gadget, -struct usb_request *req,int is_in) -{ -if (req->length ==0 ) -return 0 ; - -if (req->num_sgs) { -int mapped; - - mapped =dma_map_sg (&gadget->dev, req->sg, req->num_sgs, - is_in ?DMA_TO_DEVICE :DMA_FROM_DEVICE );
Trying to use it would at least fail when trying to link this. We don't have any implementation for dma_map_sg().
So ok to remove this nonfunctional code.
Sascha
Signature · 9 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox