Skip to contentSkip to conversation

arm64: dts: rockchip: Add Rotation Property for OGA Panel

PATCH Applied Chris Morgan 2 participants 2 messages Jun 14, 2021 – Jun 19, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Add Rotation Property for OGA Panel

From: Chris Morgan <[email protected]>

Add rotation property for Odroid Go Advance panel to note that it is rotated 270 degrees. Rotation affects DRM connector after this patch:

https://cgit.freedesktop.org/drm/drm/commit/drivers/gpu/drm/panel/panel-elida-kd35t133.c?id=610d9c311b1387f8c4ac602fee1f2a1cb0508707

Note: following example of motorola-mapphone-common and tegra30-asus-nexus7-grouper-common where rotation is specified by itself with other physical properties (which are already hard-coded into the driver in this case so not necessary). Please advise if this is not the correct manner in the devicetree to specify this.

---
 arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts +2 -0
index 49c97f76df77..32d7b8270649 100644
@@ -241,6 +241,8 @@ panel@0 {
 		reset-gpios = <&gpio3 RK_PC0 GPIO_ACTIVE_LOW>;
 		vdd-supply = <&vcc_lcd>;
 
+		rotation = <270>;
+
 		port {
 			mipi_in_panel: endpoint {
 				remote-endpoint = <&mipi_out_panel>;
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 10 lines · Chris Morgan

Add rotation property for Odroid Go Advance panel to note that it is rotated 270 degrees. Rotation affects DRM connector after this patch:

https://cgit.freedesktop.org/drm/drm/commit/drivers/gpu/drm/panel/panel-elida-kd35t133.c?id=610d9c311b1387f8c4ac602fee1f2a1cb0508707

Note: following example of motorola-mapphone-common and tegra30-asus-nexus7-grouper-common where rotation is specified by itself with other physical properties (which are already hard-coded into the driver in this case so not necessary). Please advise if this is not the correct manner in the devicetree to specify this.

Applied, thanks!
(adapted to property ordering to just follow our alphabetical sorting)

[1/1] arm64: dts: rockchip: Add Rotation Property for OGA Panel

      commit: edb39de5d731f147c7b08c4a5eb246ae1dbdd947

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>