Skip to contentSkip to conversation

Updates docs/system/arm to include new bmc machines

PATCH Applied Patrick Venture 3 participants 9 messages Jun 15, 2021 – Jun 28, 2021 Arm/Aspeed machine support

lore
Share & tools
lore
#0 lore raw

cover Updates docs/system/arm to include new bmc machines

Patrick Venture (2):
docs/system/arm: Add quanta-q7l1-bmc reference
docs/system/arm: Add quanta-gbs-bmc reference

 docs/system/arm/aspeed.rst  | 1 +
 docs/system/arm/nuvoton.rst | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.32.0.272.g935e593368-goog
#1 lore raw

PATCH 1/2 docs/system/arm: Add quanta-q7l1-bmc reference

Adds a line-item reference to the supported quanta-q71l-bmc aspeed entry.

---
 docs/system/arm/aspeed.rst | 1 +
 1 file changed, 1 insertion(+)
docs/system/arm/aspeed.rst +1 -0
index 57ee2bd94f..cec87e3743 100644
@@ -13,6 +13,7 @@ etc.
 AST2400 SoC based machines :
 
 - ``palmetto-bmc``         OpenPOWER Palmetto POWER8 BMC
+- ``quanta-q71l-bmc``      OpenBMC Quanta BMC
 
 AST2500 SoC based machines :
 
Signature · 1 line
2.32.0.272.g935e593368-goog
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] docs/system/arm: Add quanta-q7l1-bmc reference

Quoted 4 lines · Patrick Venture

Adds a line-item reference to the supported quanta-q71l-bmc aspeed entry.

Thanks,

C.

Quoted 17 lines
---
 docs/system/arm/aspeed.rst | 1 +
 1 file changed, 1 insertion(+)
docs/system/arm/aspeed.rst +1 -0
index 57ee2bd94f..cec87e3743 100644
@@ -13,6 +13,7 @@ etc.
 AST2400 SoC based machines :
 
 - ``palmetto-bmc``         OpenPOWER Palmetto POWER8 BMC
+- ``quanta-q71l-bmc``      OpenBMC Quanta BMC
 
 AST2500 SoC based machines :
 
#3 lore raw

PATCH 2/2 docs/system/arm: Add quanta-gbs-bmc reference

In reply to Patrick Venture

Add line item reference to quanta-gbs-bmc machine.

---
 docs/system/arm/nuvoton.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
docs/system/arm/nuvoton.rst +2 -1
index ca011bd479..197d149f66 100644
@@ -1,4 +1,4 @@
-Nuvoton iBMC boards (``npcm750-evb``, ``quanta-gsj``)
+Nuvoton iBMC boards (``*-bmc``, ``npcm750-evb``, ``quanta-gsj``)
 =====================================================
 
 The `Nuvoton iBMC`_ chips (NPCM7xx) are a family of ARM-based SoCs that are
@@ -18,6 +18,7 @@ segment. The following machines are based on this chip :
 The NPCM730 SoC has two Cortex-A9 cores and is targeted for Data Center and
 Hyperscale applications. The following machines are based on this chip :
 
+- ``quanta-gbs-bmc``    Quanta GBS server BMC
 - ``quanta-gsj``        Quanta GSJ server BMC
 
 There are also two more SoCs, NPCM710 and NPCM705, which are single-core
Signature · 1 line
2.32.0.272.g935e593368-goog
Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] docs/system/arm: Add quanta-gbs-bmc reference

Quoted 3 lines · Patrick Venture

Add line item reference to quanta-gbs-bmc machine.

Thanks,

C.

Quoted 23 lines
---
 docs/system/arm/nuvoton.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
docs/system/arm/nuvoton.rst +2 -1
index ca011bd479..197d149f66 100644
@@ -1,4 +1,4 @@
-Nuvoton iBMC boards (``npcm750-evb``, ``quanta-gsj``)
+Nuvoton iBMC boards (``*-bmc``, ``npcm750-evb``, ``quanta-gsj``)
 =====================================================
 
 The `Nuvoton iBMC`_ chips (NPCM7xx) are a family of ARM-based SoCs that are
@@ -18,6 +18,7 @@ segment. The following machines are based on this chip :
 The NPCM730 SoC has two Cortex-A9 cores and is targeted for Data Center and
 Hyperscale applications. The following machines are based on this chip :
 
+- ``quanta-gbs-bmc``    Quanta GBS server BMC
 - ``quanta-gsj``        Quanta GSJ server BMC
 
 There are also two more SoCs, NPCM710 and NPCM705, which are single-core
#5 lore raw

Re: [PATCH 2/2] docs/system/arm: Add quanta-gbs-bmc reference

In reply to Patrick Venture
Quoted 19 lines · Patrick Venture

Add line item reference to quanta-gbs-bmc machine.

---
 docs/system/arm/nuvoton.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
docs/system/arm/nuvoton.rst +1 -1
index ca011bd479..197d149f66 100644
@@ -1,4 +1,4 @@
-Nuvoton iBMC boards (``npcm750-evb``, ``quanta-gsj``)
+Nuvoton iBMC boards (``*-bmc``, ``npcm750-evb``, ``quanta-gsj``)
 =====================================================
 
 The `Nuvoton iBMC`_ chips (NPCM7xx) are a family of ARM-based SoCs that are

docs/system/arm/nuvoton.rst segment. The following machines are based on this chip : · line 22

Quoted 5 lines
docs/system/arm/nuvoton.rst +1 -0
@@ -18,6 +18,7 @@ segment. The following machines are based on this chip :
 The NPCM730 SoC has two Cortex-A9 cores and is targeted for Data Center and
 Hyperscale applications. The following machines are based on this chip :
 
+- ``quanta-gbs-bmc``    Quanta GBS server BMC
 - ``quanta-gsj``        Quanta GSJ server BMC

Why aren't we consistent about the names of the machines here? This suggests that either we should have called the new board 'quanta-gbs', not 'quanta-gbs-bmc', or we should deprecate 'quanta-gsj' and rename it 'quanta-gsj-bmc' ...

thanks
-- PMM

#6 lore raw

Re: [PATCH 2/2] docs/system/arm: Add quanta-gbs-bmc reference

Quoted 23 lines · Peter Maydell
Quoted 22 lines · Patrick Venture

Add line item reference to quanta-gbs-bmc machine.

---
 docs/system/arm/nuvoton.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
docs/system/arm/nuvoton.rst +1 -1
index ca011bd479..197d149f66 100644
@@ -1,4 +1,4 @@
-Nuvoton iBMC boards (``npcm750-evb``, ``quanta-gsj``)
+Nuvoton iBMC boards (``*-bmc``, ``npcm750-evb``, ``quanta-gsj``)
 =====================================================
 
 The `Nuvoton iBMC`_ chips (NPCM7xx) are a family of ARM-based SoCs that are
@@ -18,6 +18,7 @@ segment. The following machines are based on this chip :
 The NPCM730 SoC has two Cortex-A9 cores and is targeted for Data Center and
 Hyperscale applications. The following machines are based on this chip :
 
Quoted 7 lines

docs/system/arm/nuvoton.rst segment. The following machines are based on this chip : · line 22

Quoted 2 lines
docs/system/arm/nuvoton.rst +1 -0
+- ``quanta-gbs-bmc``    Quanta GBS server BMC
 - ``quanta-gsj``        Quanta GSJ server BMC

Why aren't we consistent about the names of the machines here? This suggests that either we should have called the new board 'quanta-gbs', not 'quanta-gbs-bmc', or we should deprecate 'quanta-gsj' and rename it 'quanta-gsj-bmc' ...

Indeed, the latter would be the best option.

Thanks,

C.

#7 lore raw
In reply to Patrick Venture
Quoted 9 lines · Patrick Venture

Patrick Venture (2):
docs/system/arm: Add quanta-q7l1-bmc reference
docs/system/arm: Add quanta-gbs-bmc reference

 docs/system/arm/aspeed.rst  | 1 +
 docs/system/arm/nuvoton.rst | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

Applied to target-arm.next, thanks.

-- PMM

#8 lore raw
Quoted 8 lines · Peter Maydell
Quoted 6 lines · Patrick Venture

Patrick Venture (2):
docs/system/arm: Add quanta-q7l1-bmc reference
docs/system/arm: Add quanta-gbs-bmc reference

Quoted 7 lines
Quoted 3 lines
 docs/system/arm/aspeed.rst  | 1 +
 docs/system/arm/nuvoton.rst | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

Applied to target-arm.next, thanks.

Just noticed the docs don't actually build:

Warning, treated as error:
/home/petmay01/linaro/qemu-from-laptop/qemu/docs/system/arm/nuvoton.rst:2:Title underline too short.

Nuvoton iBMC boards (``*-bmc``, ``npcm750-evb``, ``quanta-gsj``)
=====================================================

But the fix is trivial, so I will make it locally.

Passing configure '--enable-docs' will enforce that it complains if you don't have enough prerequisites to build the docs, rather than silently skipping them.

thanks
-- PMM