configs: aspeed-common: Add redundant env for mmc
PATCH 1/1 configs: aspeed-common: Add redundant env for mmc
From: Adriana Kobylak <[email protected]>
If the env is in MMC, specify the location of the redundant environment. Per the ast2600_openbmc_spl_emmc_defconfig, the environment is located at byte offset 0x5000 in the user data partition, and is sized at 0x10000. The redundant environment follows it immediately and is the same size.
--- include/configs/aspeed-common.h | 1 + 1 file changed, 1 insertion(+)
include/configs/aspeed-common.h +1 -0
@@ -83,6 +83,7 @@#ifdef CONFIG_ENV_IS_IN_MMC #define CONFIG_SYS_MMC_ENV_DEV 0#define CONFIG_SYS_MMC_ENV_PART 0 +#define CONFIG_ENV_OFFSET_REDUND 0x15000#endif #endif /* __ASPEED_COMMON_CONFIG_H */
Signature · 1 line
2.25.1
Joel Stanley
maintainerQuoted 20 lines · Adriana Kobylak
From: Adriana Kobylak <[email protected]>
If the env is in MMC, specify the location of the redundant environment. Per the
ast2600_openbmc_spl_emmc_defconfig, the environment is located at byte offset0x5000in the user data partition, and is sized at0x10000. The redundant environment follows it immediately and is the same size.Signed-off-by Eddie James <[email protected]>Signed-off-by Adriana Kobylak <[email protected]>--- include/configs/aspeed-common.h | 1 + 1 file changed, 1 insertion(+)include/configs/aspeed-common.h +0
-0
include/configs/aspeed-common.h line 86
Quoted 4 lines
include/configs/aspeed-common.h +1
-0@@ -83,6 +83,7 @@#ifdef CONFIG_ENV_IS_IN_MMC #define CONFIG_SYS_MMC_ENV_DEV 0#define CONFIG_SYS_MMC_ENV_PART 0 +#define CONFIG_ENV_OFFSET_REDUND 0x15000
Would it make more sense to write it like this:
#define CONFIG_ENV_OFFSET_REDUND (CONFIG_ENV_OFFSET + CONFIG_ENV_SIZE)
Quoted 6 lines
include/configs/aspeed-common.h +0
-1#endif #endif /* __ASPEED_COMMON_CONFIG_H */ --2.25.1
On Jun 22, 2021, at 7:55 AM, Joel Stanley <[email protected]> wrote:On Fri, 18 Jun 2021 at 15:14, Adriana Kobylak <[email protected]> wrote:From: Adriana Kobylak <[email protected]>If the env is in MMC, specify the location of the redundant environment.Per the ast2600_openbmc_spl_emmc_defconfig, the environment is locatedat byte offset 0x5000 in the user data partition, and is sized at0x10000. The redundant environment follows it immediately and is thesame size.Signed-off-by: Eddie James <[email protected]>Signed-off-by: Adriana Kobylak <[email protected]>---include/configs/aspeed-common.h | 1 +1 file changed, 1 insertion(+)diff --git a/include/configs/aspeed-common.h b/include/configs/aspeed-common.hindex 8f404570b1..59449d36d0 100644--- a/include/configs/aspeed-common.h+++ b/include/configs/aspeed-common.h@@ -83,6 +83,7 @@#ifdef CONFIG_ENV_IS_IN_MMC#define CONFIG_SYS_MMC_ENV_DEV 0#define CONFIG_SYS_MMC_ENV_PART 0+#define CONFIG_ENV_OFFSET_REDUND 0x15000Would it make more sense to write it like this:#define CONFIG_ENV_OFFSET_REDUND (CONFIG_ENV_OFFSET + CONFIG_ENV_SIZE)Yeah good point. Just sent a v2 with that change.#endif#endif /* __ASPEED_COMMON_CONFIG_H */--2.25.1