Skip to contentSkip to conversation

staging: rtl8188eu: remove useless comment

PATCH In review Michael Straube 2 participants 2 messages Jun 19, 2021 – Jun 20, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8188eu: remove useless comment

Remove block comment about function HwSuspendModeEnable92Cu. The comment contains no useful information and there is even no HwSuspendModeEnable92Cu function in the driver code. 'git grep -n HwSuspendModeEnable92Cu drivers/staging/rtl8188eu' returns nothing.

---
 drivers/staging/rtl8188eu/hal/usb_halinit.c | 16 ----------------
 1 file changed, 16 deletions(-)
drivers/staging/rtl8188eu/hal/usb_halinit.c +0 -16
index dcdf868b394d..6c88675ae251 100644
@@ -601,22 +601,6 @@ static void _InitAntenna_Selection(struct adapter *Adapter)
 		haldata->CurAntenna = Antenna_B;
 }
 
-/*-----------------------------------------------------------------------------
- * Function:	HwSuspendModeEnable92Cu()
- *
- * Overview:	HW suspend mode switch.
- *
- * Input:		NONE
- *
- * Output:	NONE
- *
- * Return:	NONE
- *
- * Revised History:
- *	When		Who		Remark
- *	08/23/2010	MHC		HW suspend mode switch test..
- *---------------------------------------------------------------------------
- */
 enum rt_rf_power_state RfOnOffDetect(struct adapter *adapt)
 {
 	u8 val8;
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw

Thus wrote Michael Straube ([email protected]):

Quoted 40 lines

Remove block comment about function HwSuspendModeEnable92Cu. The comment contains no useful information and there is even no HwSuspendModeEnable92Cu function in the driver code. 'git grep -n HwSuspendModeEnable92Cu drivers/staging/rtl8188eu' returns nothing.

---
 drivers/staging/rtl8188eu/hal/usb_halinit.c | 16 ----------------
 1 file changed, 16 deletions(-)
drivers/staging/rtl8188eu/hal/usb_halinit.c +0 -16
index dcdf868b394d..6c88675ae251 100644
@@ -601,22 +601,6 @@ static void _InitAntenna_Selection(struct adapter *Adapter)
 		haldata->CurAntenna = Antenna_B;
 }
 
-/*-----------------------------------------------------------------------------
- * Function:	HwSuspendModeEnable92Cu()
- *
- * Overview:	HW suspend mode switch.
- *
- * Input:		NONE
- *
- * Output:	NONE
- *
- * Return:	NONE
- *
- * Revised History:
- *	When		Who		Remark
- *	08/23/2010	MHC		HW suspend mode switch test..
- *---------------------------------------------------------------------------
- */
 enum rt_rf_power_state RfOnOffDetect(struct adapter *adapt)
 {
 	u8 val8;
Signature · 1 line
2.32.0

You're right. The function for this comment is already gone.