arm: snapdragon: Use correct GICC register on APQ8016
Subsystems (2)
PATCH 1/2 arm: snapdragon: Use correct GICC register on APQ8016
The GICC register used by u-boot is 0x0a20c000, which is actually a GICC for WCNSS, the WLAN processor. U-boot runs on the Application Processor, therefore it should use APCS GICC instead. Hence, correct it with APCS GICC register address.
---
arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-snapdragon/include/mach/sysmap-apq8016.h +1 -1
@@ -8,7 +8,7 @@#define _MACH_SYSMAP_APQ8016_H#define GICD_BASE (0x0b000000) -#define GICC_BASE (0x0a20c000) +#define GICC_BASE (0x0b002000)/* Clocks: (from CLK_CTL_BASE) */ #define GPLL0_STATUS (0x2101C)
Signature · 1 line
2.30.2
PATCH 2/2 arm: snapdragon: Fix typo in clk_bcr_update()
Fix typo in clock-snapdragon.c
---
arch/arm/mach-snapdragon/clock-snapdragon.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/mach-snapdragon/clock-snapdragon.c +5 -5
@@ -56,15 +56,15 @@ void clk_enable_vote_clk(phys_addr_t base, const struct vote_clk *vclk) }while ((val !=BRANCH_ON_VAL ) && (val !=BRANCH_NOC_FSM_ON_VAL )); } -#define APPS_CMD_RGCR_UPDATE BIT(0) +#define APPS_CMD_RCGR_UPDATE BIT(0) -/* Update clock command via CMD_RGCR */ -void clk_bcr_update (phys_addr_t apps_cmd_rgcr) +/* Update clock command via CMD_RCGR */ +void clk_bcr_update (phys_addr_t apps_cmd_rcgr) { -setbits_le32 (apps_cmd_rgcr,APPS_CMD_RGCR_UPDATE ); +setbits_le32 (apps_cmd_rcgr,APPS_CMD_RCGR_UPDATE );/* Wait for frequency to be updated. */ -while (readl (apps_cmd_rgcr) &APPS_CMD_RGCR_UPDATE ) +while (readl (apps_cmd_rcgr) &APPS_CMD_RCGR_UPDATE ) ; }
Signature · 1 line
2.30.2
Re: [PATCH 2/2] arm: snapdragon: Fix typo in clk_bcr_update()
Quoted 3 lines · Sheep Sun
Fix typo in
clock-snapdragon.cSigned-off-by Sheep Sun <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom
Quoted 6 lines · Sheep Sun
The GICC register used by u-boot is
0x0a20c000, which is actually a GICC for WCNSS, the WLAN processor. U-boot runs on the Application Processor, therefore it should use APCS GICC instead. Hence, correct it with APCS GICC register address.Signed-off-by Sheep Sun <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom