ALSA: usb-audio: scarlett2: Remove interrupt debug message

PATCH New Geoffrey D. Bennett 1 participant 1 message Jun 20, 2021 Sound

Share & tools

Geoffrey D. Bennett

author

2021-06-20 16:48 UTC #0 lore raw

PATCH 5/14 ALSA: usb-audio: scarlett2: Remove interrupt debug message

Just ignore instead of printing an error if the interrupt data is not the expected length. This check was for development and the condition has not been observed.

Signed-off-by Geoffrey D. Bennett <[email protected]>

---
 sound/usb/mixer_scarlett_gen2.c | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

sound/usb/mixer_scarlett_gen2.c +6 ~~-11~~

index a5f5c537e344..3225ec709d98 100644
@@ -2018,19 +2018,14 @@ static void scarlett2_mixer_interrupt(struct urb *urb)
 	int ustatus = urb->status;
 	u32 data;
 
-	if (ustatus != 0)
+	if (ustatus != 0 || len != 8)
 		goto requeue;
 
-	if (len == 8) {
-		data = le32_to_cpu(*(__le32 *)urb->transfer_buffer);
-		if (data & SCARLETT2_USB_INTERRUPT_VOL_CHANGE)
-			scarlett2_mixer_interrupt_vol_change(mixer);
-		if (data & SCARLETT2_USB_INTERRUPT_BUTTON_CHANGE)
-			scarlett2_mixer_interrupt_button_change(mixer);
-	} else {
-		usb_audio_err(mixer->chip,
-			      "scarlett mixer interrupt length %d\n", len);
-	}
+	data = le32_to_cpu(*(__le32 *)urb->transfer_buffer);
+	if (data & SCARLETT2_USB_INTERRUPT_VOL_CHANGE)
+		scarlett2_mixer_interrupt_vol_change(mixer);
+	if (data & SCARLETT2_USB_INTERRUPT_BUTTON_CHANGE)
+		scarlett2_mixer_interrupt_button_change(mixer);
 
 requeue:
 	if (ustatus != -ENOENT &&

Signature · 1 line

2.31.1