Skip to contentSkip to conversation

sh4: Replace TAB indentations with spaces

PATCH In review Ahmed Abouzied 4 participants 4 messages Jun 20, 2021 – Mar 18, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sh4: Replace TAB indentations with spaces

Replaces TABs with spaces, making sure to have a consistent coding style of 4 space indentations in the SH4 subsystem.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/376

---
 hw/intc/sh_intc.c         |  208 ++---
 hw/sh4/r2d.c              |   36 +-
 hw/sh4/sh7750.c           |  516 ++++++------
 hw/sh4/sh7750_regnames.c  |  144 ++--
 hw/sh4/sh7750_regs.h      | 1592 ++++++++++++++++++-------------------
 linux-user/sh4/termbits.h |  204 ++---
 target/sh4/cpu.h          |   80 +-
 target/sh4/helper.c       |  236 +++---
 target/sh4/op_helper.c    |   68 +-
 target/sh4/translate.c    | 1588 ++++++++++++++++++------------------
 10 files changed, 2336 insertions(+), 2336 deletions(-)
hw/intc/sh_intc.c +104 -104
index 72a55e32dd..63efec6ea1 100644
@@ -20,7 +20,7 @@
 #define INTC_A7(x) ((x) & 0x1fffffff)
 
 void sh_intc_toggle_source(struct intc_source *source,
-			   int enable_adj, int assert_adj)
+               int enable_adj, int assert_adj)
 {
     int enable_changed = 0;
     int pending_changed = 0;
@@ -54,22 +54,22 @@ void sh_intc_toggle_source(struct intc_source *source,
             if (source->parent->pending == 0) {
                 cpu_reset_interrupt(first_cpu, CPU_INTERRUPT_HARD);
             }
-	}
+    }
     }
 
   if (enable_changed || assert_adj || pending_changed) {
 #ifdef DEBUG_INTC_SOURCES
             printf("sh_intc: (%d/%d/%d/%d) interrupt source 0x%x %s%s%s\n",
-		   source->parent->pending,
-		   source->asserted,
-		   source->enable_count,
-		   source->enable_max,
-		   source->vect,
-		   source->asserted ? "asserted " :
-		   assert_adj ? "deasserted" : "",
-		   enable_changed == 1 ? "enabled " :
-		   enable_changed == -1 ? "disabled " : "",
-		   source->pending ? "pending" : "");
+           source->parent->pending,
+           source->asserted,
+           source->enable_count,
+           source->enable_max,
+           source->vect,
+           source->asserted ? "asserted " :
+           assert_adj ? "deasserted" : "",
+           enable_changed == 1 ? "enabled " :
+           enable_changed == -1 ? "disabled " : "",
+           source->pending ? "pending" : "");
 #endif
   }
 }
@@ -99,13 +99,13 @@ int sh_intc_get_pending_vector(struct intc_desc *desc, int imask)
     for (i = 0; i < desc->nr_sources; i++) {
         struct intc_source *source = desc->sources + i;
 
-	if (source->pending) {
+    if (source->pending) {
 #ifdef DEBUG_INTC_SOURCES
             printf("sh_intc: (%d) returning interrupt source 0x%x\n",
-		   desc->pending, source->vect);
+           desc->pending, source->vect);
 #endif
             return source->vect;
-	}
+    }
     }
 
     abort();
@@ -119,16 +119,16 @@ int sh_intc_get_pending_vector(struct intc_desc *desc, int imask)
 #define INTC_MODE_IS_PRIO    8
 
 static unsigned int sh_intc_mode(unsigned long address,
-				 unsigned long set_reg, unsigned long clr_reg)
+                 unsigned long set_reg, unsigned long clr_reg)
 {
     if ((address != INTC_A7(set_reg)) &&
-	(address != INTC_A7(clr_reg)))
+    (address != INTC_A7(clr_reg)))
         return INTC_MODE_NONE;
 
     if (set_reg && clr_reg) {
         if (address == INTC_A7(set_reg))
             return INTC_MODE_DUAL_SET;
-	else
+    else
             return INTC_MODE_DUAL_CLR;
     }
 
@@ -139,12 +139,12 @@ static unsigned int sh_intc_mode(unsigned long address,
 }
 
 static void sh_intc_locate(struct intc_desc *desc,
-			   unsigned long address,
-			   unsigned long **datap,
-			   intc_enum **enums,
-			   unsigned int *first,
-			   unsigned int *width,
-			   unsigned int *modep)
+               unsigned long address,
+               unsigned long **datap,
+               intc_enum **enums,
+               unsigned int *first,
+               unsigned int *width,
+               unsigned int *modep)
 {
     unsigned int i, mode;
 
@@ -152,54 +152,54 @@ static void sh_intc_locate(struct intc_desc *desc,
 
     if (desc->mask_regs) {
         for (i = 0; i < desc->nr_mask_regs; i++) {
-	    struct intc_mask_reg *mr = desc->mask_regs + i;
+        struct intc_mask_reg *mr = desc->mask_regs + i;
 
-	    mode = sh_intc_mode(address, mr->set_reg, mr->clr_reg);
-	    if (mode == INTC_MODE_NONE)
+        mode = sh_intc_mode(address, mr->set_reg, mr->clr_reg);
+        if (mode == INTC_MODE_NONE)
                 continue;
 
-	    *modep = mode;
-	    *datap = &mr->value;
-	    *enums = mr->enum_ids;
-	    *first = mr->reg_width - 1;
-	    *width = 1;
-	    return;
-	}
+        *modep = mode;
+        *datap = &mr->value;
+        *enums = mr->enum_ids;
+        *first = mr->reg_width - 1;
+        *width = 1;
+        return;
+    }
     }
 
     if (desc->prio_regs) {
         for (i = 0; i < desc->nr_prio_regs; i++) {
-	    struct intc_prio_reg *pr = desc->prio_regs + i;
+        struct intc_prio_reg *pr = desc->prio_regs + i;
 
-	    mode = sh_intc_mode(address, pr->set_reg, pr->clr_reg);
-	    if (mode == INTC_MODE_NONE)
+        mode = sh_intc_mode(address, pr->set_reg, pr->clr_reg);
+        if (mode == INTC_MODE_NONE)
                 continue;
 
-	    *modep = mode | INTC_MODE_IS_PRIO;
-	    *datap = &pr->value;
-	    *enums = pr->enum_ids;
-	    *first = (pr->reg_width / pr->field_width) - 1;
-	    *width = pr->field_width;
-	    return;
-	}
+        *modep = mode | INTC_MODE_IS_PRIO;
+        *datap = &pr->value;
+        *enums = pr->enum_ids;
+        *first = (pr->reg_width / pr->field_width) - 1;
+        *width = pr->field_width;
+        return;
+    }
     }
 
     abort();
 }
 
 static void sh_intc_toggle_mask(struct intc_desc *desc, intc_enum id,
-				int enable, int is_group)
+                int enable, int is_group)
 {
     struct intc_source *source = desc->sources + id;
 
     if (!id)
-	return;
+    return;
 
     if (!source->next_enum_id && (!source->enable_max || !source->vect)) {
 #ifdef DEBUG_INTC_SOURCES
         printf("sh_intc: reserved interrupt source %d modified\n", id);
 #endif
-	return;
+    return;
     }
 
     if (source->vect)
@@ -237,7 +237,7 @@ static uint64_t sh_intc_read(void *opaque, hwaddr offset,
 #endif
 
     sh_intc_locate(desc, (unsigned long)offset, &valuep, 
-		   &enum_ids, &first, &width, &mode);
+           &enum_ids, &first, &width, &mode);
     return *valuep;
 }
 
@@ -258,7 +258,7 @@ static void sh_intc_write(void *opaque, hwaddr offset,
 #endif
 
     sh_intc_locate(desc, (unsigned long)offset, &valuep, 
-		   &enum_ids, &first, &width, &mode);
+           &enum_ids, &first, &width, &mode);
 
     switch (mode) {
     case INTC_MODE_ENABLE_REG | INTC_MODE_IS_PRIO: break;
@@ -270,11 +270,11 @@ static void sh_intc_write(void *opaque, hwaddr offset,
     for (k = 0; k <= first; k++) {
         mask = ((1 << width) - 1) << ((first - k) * width);
 
-	if ((*valuep & mask) == (value & mask))
+    if ((*valuep & mask) == (value & mask))
             continue;
 #if 0
-	printf("k = %d, first = %d, enum = %d, mask = 0x%08x\n", 
-	       k, first, enum_ids[k], (unsigned int)mask);
+    printf("k = %d, first = %d, enum = %d, mask = 0x%08x\n", 
+           k, first, enum_ids[k], (unsigned int)mask);
 #endif
         sh_intc_toggle_mask(desc, enum_ids[k], value & mask, 0);
     }
@@ -333,74 +333,74 @@ static unsigned int sh_intc_register(MemoryRegion *sysmem,
 }
 
 static void sh_intc_register_source(struct intc_desc *desc,
-				    intc_enum source,
-				    struct intc_group *groups,
-				    int nr_groups)
+                    intc_enum source,
+                    struct intc_group *groups,
+                    int nr_groups)
 {
     unsigned int i, k;
     struct intc_source *s;
 
     if (desc->mask_regs) {
         for (i = 0; i < desc->nr_mask_regs; i++) {
-	    struct intc_mask_reg *mr = desc->mask_regs + i;
+        struct intc_mask_reg *mr = desc->mask_regs + i;
 
-	    for (k = 0; k < ARRAY_SIZE(mr->enum_ids); k++) {
+        for (k = 0; k < ARRAY_SIZE(mr->enum_ids); k++) {
                 if (mr->enum_ids[k] != source)
                     continue;
 
-		s = sh_intc_source(desc, mr->enum_ids[k]);
-		if (s)
+        s = sh_intc_source(desc, mr->enum_ids[k]);
+        if (s)
                     s->enable_max++;
-	    }
-	}
+        }
+    }
     }
 
     if (desc->prio_regs) {
         for (i = 0; i < desc->nr_prio_regs; i++) {
-	    struct intc_prio_reg *pr = desc->prio_regs + i;
+        struct intc_prio_reg *pr = desc->prio_regs + i;
 
-	    for (k = 0; k < ARRAY_SIZE(pr->enum_ids); k++) {
+        for (k = 0; k < ARRAY_SIZE(pr->enum_ids); k++) {
                 if (pr->enum_ids[k] != source)
                     continue;
 
-		s = sh_intc_source(desc, pr->enum_ids[k]);
-		if (s)
+        s = sh_intc_source(desc, pr->enum_ids[k]);
+        if (s)
                     s->enable_max++;
-	    }
-	}
+        }
+    }
     }
 
     if (groups) {
         for (i = 0; i < nr_groups; i++) {
-	    struct intc_group *gr = groups + i;
+        struct intc_group *gr = groups + i;
 
-	    for (k = 0; k < ARRAY_SIZE(gr->enum_ids); k++) {
+        for (k = 0; k < ARRAY_SIZE(gr->enum_ids); k++) {
                 if (gr->enum_ids[k] != source)
                     continue;
 
-		s = sh_intc_source(desc, gr->enum_ids[k]);
-		if (s)
+        s = sh_intc_source(desc, gr->enum_ids[k]);
+        if (s)
                     s->enable_max++;
-	    }
-	}
+        }
+    }
     }
 
 }
 
 void sh_intc_register_sources(struct intc_desc *desc,
-			      struct intc_vect *vectors,
-			      int nr_vectors,
-			      struct intc_group *groups,
-			      int nr_groups)
+                  struct intc_vect *vectors,
+                  int nr_vectors,
+                  struct intc_group *groups,
+                  int nr_groups)
 {
     unsigned int i, k;
     struct intc_source *s;
 
     for (i = 0; i < nr_vectors; i++) {
-	struct intc_vect *vect = vectors + i;
+    struct intc_vect *vect = vectors + i;
 
-	sh_intc_register_source(desc, vect->enum_id, groups, nr_groups);
-	s = sh_intc_source(desc, vect->enum_id);
+    sh_intc_register_source(desc, vect->enum_id, groups, nr_groups);
+    s = sh_intc_source(desc, vect->enum_id);
         if (s) {
             s->vect = vect->vect;
 
@@ -413,34 +413,34 @@ void sh_intc_register_sources(struct intc_desc *desc,
 
     if (groups) {
         for (i = 0; i < nr_groups; i++) {
-	    struct intc_group *gr = groups + i;
+        struct intc_group *gr = groups + i;
 
-	    s = sh_intc_source(desc, gr->enum_id);
-	    s->next_enum_id = gr->enum_ids[0];
+        s = sh_intc_source(desc, gr->enum_id);
+        s->next_enum_id = gr->enum_ids[0];
 
-	    for (k = 1; k < ARRAY_SIZE(gr->enum_ids); k++) {
+        for (k = 1; k < ARRAY_SIZE(gr->enum_ids); k++) {
                 if (!gr->enum_ids[k])
                     continue;
 
-		s = sh_intc_source(desc, gr->enum_ids[k - 1]);
-		s->next_enum_id = gr->enum_ids[k];
-	    }
+        s = sh_intc_source(desc, gr->enum_ids[k - 1]);
+        s->next_enum_id = gr->enum_ids[k];
+        }
 
 #ifdef DEBUG_INTC_SOURCES
-	    printf("sh_intc: registered group %d (%d/%d)\n",
-		   gr->enum_id, s->enable_count, s->enable_max);
+        printf("sh_intc: registered group %d (%d/%d)\n",
+           gr->enum_id, s->enable_count, s->enable_max);
 #endif
-	}
+    }
     }
 }
 
 int sh_intc_init(MemoryRegion *sysmem,
          struct intc_desc *desc,
-		 int nr_sources,
-		 struct intc_mask_reg *mask_regs,
-		 int nr_mask_regs,
-		 struct intc_prio_reg *prio_regs,
-		 int nr_prio_regs)
+         int nr_sources,
+         struct intc_mask_reg *mask_regs,
+         int nr_mask_regs,
+         struct intc_prio_reg *prio_regs,
+         int nr_prio_regs)
 {
     unsigned int i, j;
 
@@ -474,24 +474,24 @@ int sh_intc_init(MemoryRegion *sysmem,
         reg_struct->action##_reg, #type, #action, j
     if (desc->mask_regs) {
         for (i = 0; i < desc->nr_mask_regs; i++) {
-	    struct intc_mask_reg *mr = desc->mask_regs + i;
+        struct intc_mask_reg *mr = desc->mask_regs + i;
 
             j += sh_intc_register(sysmem, desc,
                                   INT_REG_PARAMS(mr, mask, set, j));
             j += sh_intc_register(sysmem, desc,
                                   INT_REG_PARAMS(mr, mask, clr, j));
-	}
+    }
     }
 
     if (desc->prio_regs) {
         for (i = 0; i < desc->nr_prio_regs; i++) {
-	    struct intc_prio_reg *pr = desc->prio_regs + i;
+        struct intc_prio_reg *pr = desc->prio_regs + i;
 
             j += sh_intc_register(sysmem, desc,
                                   INT_REG_PARAMS(pr, prio, set, j));
             j += sh_intc_register(sysmem, desc,
                                   INT_REG_PARAMS(pr, prio, clr, j));
-	}
+    }
     }
 #undef INT_REG_PARAMS
 
@@ -505,10 +505,10 @@ void sh_intc_set_irl(void *opaque, int n, int level)
     struct intc_source *s = opaque;
     int i, irl = level ^ 15;
     for (i = 0; (s = sh_intc_source(s->parent, s->next_enum_id)); i++) {
-	if (i == irl)
-	    sh_intc_toggle_source(s, s->enable_count?0:1, s->asserted?0:1);
-	else
-	    if (s->asserted)
-	        sh_intc_toggle_source(s, 0, -1);
+    if (i == irl)
+        sh_intc_toggle_source(s, s->enable_count?0:1, s->asserted?0:1);
+    else
+        if (s->asserted)
+            sh_intc_toggle_source(s, 0, -1);
     }
 }
hw/sh4/r2d.c +18 -18
index 006010f30a..dadbe16390 100644
@@ -1,4 +1,4 @@
-/*
+:wq/*
  * Renesas SH7751R R2D-PLUS emulation
  *
  * Copyright (c) 2007 Magnus Damm
@@ -56,10 +56,10 @@
 #define LINUX_LOAD_OFFSET  0x0800000
 #define INITRD_LOAD_OFFSET 0x1800000
 
-#define PA_IRLMSK	0x00
-#define PA_POWOFF	0x30
-#define PA_VERREG	0x32
-#define PA_OUTPORT	0x36
+#define PA_IRLMSK    0x00
+#define PA_POWOFF    0x30
+#define PA_VERREG    0x32
+#define PA_OUTPORT    0x36
 
 typedef struct {
     uint16_t bcr;
@@ -96,19 +96,19 @@ enum r2d_fpga_irq {
 };
 
 static const struct { short irl; uint16_t msk; } irqtab[NR_IRQS] = {
-    [CF_IDE]	= {  1, 1<<9 },
-    [CF_CD]	= {  2, 1<<8 },
-    [PCI_INTA]	= {  9, 1<<14 },
-    [PCI_INTB]	= { 10, 1<<13 },
-    [PCI_INTC]	= {  3, 1<<12 },
-    [PCI_INTD]	= {  0, 1<<11 },
-    [SM501]	= {  4, 1<<10 },
-    [KEY]	= {  5, 1<<6 },
-    [RTC_A]	= {  6, 1<<5 },
-    [RTC_T]	= {  7, 1<<4 },
-    [SDCARD]	= {  8, 1<<7 },
-    [EXT]	= { 11, 1<<0 },
-    [TP]	= { 12, 1<<15 },
+    [CF_IDE]    = {  1, 1<<9 },
+    [CF_CD]    = {  2, 1<<8 },
+    [PCI_INTA]    = {  9, 1<<14 },
+    [PCI_INTB]    = { 10, 1<<13 },
+    [PCI_INTC]    = {  3, 1<<12 },
+    [PCI_INTD]    = {  0, 1<<11 },
+    [SM501]    = {  4, 1<<10 },
+    [KEY]    = {  5, 1<<6 },
+    [RTC_A]    = {  6, 1<<5 },
+    [RTC_T]    = {  7, 1<<4 },
+    [SDCARD]    = {  8, 1<<7 },
+    [EXT]    = { 11, 1<<0 },
+    [TP]    = { 12, 1<<15 },
 };
 
 static void update_irl(r2d_fpga_t *fpga)
hw/sh4/sh7750.c +258 -258

826 lines not on this page · raw message

hw/sh4/sh7750_regnames.c +72 -72

156 lines not on this page · raw message

hw/sh4/sh7750_regs.h +796 -796

1,572 lines not on this page · raw message

linux-user/sh4/termbits.h +102 -102

204 lines not on this page · raw message

target/sh4/cpu.h +40 -40

80 lines not on this page · raw message

target/sh4/helper.c +118 -118

236 lines not on this page · raw message

target/sh4/op_helper.c +34 -34

68 lines not on this page · raw message

target/sh4/translate.c +794 -794

1,588 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.25.1

Part of the diff is not shown here. View the raw message.

#1 lore raw
Patchew URL: https://patchew.org/QEMU/[email protected]/

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series seems to have some coding style problems. See output below for more information:

Type: series
Message-id: [email protected]
Subject: [PATCH] sh4: Replace TAB indentations with spaces

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu

 - [tag update]      patchew/[email protected] -> patchew/[email protected]
 - [tag update]      patchew/[email protected] -> patchew/[email protected]
 - [tag update]      patchew/[email protected] -> patchew/[email protected]
 - [tag update]      patchew/[email protected] -> patchew/[email protected]
 * [new tag]         patchew/[email protected] -> patchew/[email protected]

Switched to a new branch 'test'
60b0425 sh4: Replace TAB indentations with spaces

=== OUTPUT BEGIN ===
ERROR: braces {} are necessary even for single statement blocks #106: FILE: hw/intc/sh_intc.c:131:
+ else

             return INTC_MODE_DUAL_CLR;

ERROR: suspect code indent for conditional statements (8, 8) #132: FILE: hw/intc/sh_intc.c:154:

         for (i = 0; i < desc->nr_mask_regs; i++) {

+ struct intc_mask_reg *mr = desc->mask_regs + i;

ERROR: braces {} are necessary for all arms of this statement #139: FILE: hw/intc/sh_intc.c:158:
+ if (mode == INTC_MODE_NONE)
[...]

ERROR: suspect code indent for conditional statements (8, 8) #159: FILE: hw/intc/sh_intc.c:171:

         for (i = 0; i < desc->nr_prio_regs; i++) {

+ struct intc_prio_reg *pr = desc->prio_regs + i;

ERROR: braces {} are necessary for all arms of this statement #166: FILE: hw/intc/sh_intc.c:175:
+ if (mode == INTC_MODE_NONE)
[...]

ERROR: suspect code indent for conditional statements (4, 4) #194: FILE: hw/intc/sh_intc.c:195:

     if (!id)

+ return;

ERROR: braces {} are necessary for all arms of this statement #230: FILE: hw/intc/sh_intc.c:273:
+ if ((*valuep & mask) == (value & mask))
[...]

ERROR: trailing whitespace
#235: FILE: hw/intc/sh_intc.c:276:
+ printf("k = %d, first = %d, enum = %d, mask = 0x%08x\n", $

ERROR: suspect code indent for conditional statements (8, 8) #255: FILE: hw/intc/sh_intc.c:344:

         for (i = 0; i < desc->nr_mask_regs; i++) {

+ struct intc_mask_reg *mr = desc->mask_regs + i;

ERROR: braces {} are necessary for all arms of this statement #267: FILE: hw/intc/sh_intc.c:352:
+ if (s)
[...]

ERROR: suspect code indent for conditional statements (8, 8) #276: FILE: hw/intc/sh_intc.c:359:

         for (i = 0; i < desc->nr_prio_regs; i++) {

+ struct intc_prio_reg *pr = desc->prio_regs + i;

ERROR: braces {} are necessary for all arms of this statement #288: FILE: hw/intc/sh_intc.c:367:
+ if (s)
[...]

ERROR: suspect code indent for conditional statements (8, 8) #297: FILE: hw/intc/sh_intc.c:374:

         for (i = 0; i < nr_groups; i++) {

+ struct intc_group *gr = groups + i;

ERROR: suspect code indent for conditional statements (4, 4) #332: FILE: hw/intc/sh_intc.c:399:

     for (i = 0; i < nr_vectors; i++) {

+ struct intc_vect *vect = vectors + i;

ERROR: suspect code indent for conditional statements (8, 8) #346: FILE: hw/intc/sh_intc.c:415:

         for (i = 0; i < nr_groups; i++) {

+ struct intc_group *gr = groups + i;

ERROR: suspect code indent for conditional statements (8, 8) #396: FILE: hw/intc/sh_intc.c:476:

         for (i = 0; i < desc->nr_mask_regs; i++) {

+ struct intc_mask_reg *mr = desc->mask_regs + i;

ERROR: suspect code indent for conditional statements (8, 8) #409: FILE: hw/intc/sh_intc.c:487:

         for (i = 0; i < desc->nr_prio_regs; i++) {

+ struct intc_prio_reg *pr = desc->prio_regs + i;

ERROR: suspect code indent for conditional statements (4, 4) #425: FILE: hw/intc/sh_intc.c:507:

     for (i = 0; (s = sh_intc_source(s->parent, s->next_enum_id)); i++) {

+ if (i == irl)

ERROR: spaces required around that '?' (ctx:VxV)
#432: FILE: hw/intc/sh_intc.c:509:

+        sh_intc_toggle_source(s, s->enable_count?0:1, s->asserted?0:1);
                                                 ^

ERROR: spaces required around that ':' (ctx:VxV)
#432: FILE: hw/intc/sh_intc.c:509:

+        sh_intc_toggle_source(s, s->enable_count?0:1, s->asserted?0:1);
                                                   ^

ERROR: spaces required around that '?' (ctx:VxV)
#432: FILE: hw/intc/sh_intc.c:509:

+        sh_intc_toggle_source(s, s->enable_count?0:1, s->asserted?0:1);
                                                                  ^

ERROR: spaces required around that ':' (ctx:VxV)
#432: FILE: hw/intc/sh_intc.c:509:

+        sh_intc_toggle_source(s, s->enable_count?0:1, s->asserted?0:1);
                                                                    ^

ERROR: braces {} are necessary for all arms of this statement #434: FILE: hw/intc/sh_intc.c:511:
+ if (s->asserted)
[...]

ERROR: spaces required around that ':' (ctx:ExV)
#444: FILE: hw/sh4/r2d.c:1:
+:wq/*
^

ERROR: spaces required around that '<<' (ctx:VxV)
#480: FILE: hw/sh4/r2d.c:99:
+ [CF_IDE] = { 1, 1<<9 },

                          ^

ERROR: spaces required around that '<<' (ctx:VxV)
#481: FILE: hw/sh4/r2d.c:100:
+ [CF_CD] = { 2, 1<<8 },

                         ^

ERROR: spaces required around that '<<' (ctx:VxV)
#482: FILE: hw/sh4/r2d.c:101:
+ [PCI_INTA] = { 9, 1<<14 },

                            ^

ERROR: spaces required around that '<<' (ctx:VxV)
#483: FILE: hw/sh4/r2d.c:102:
+ [PCI_INTB] = { 10, 1<<13 },

                            ^

ERROR: spaces required around that '<<' (ctx:VxV)
#484: FILE: hw/sh4/r2d.c:103:
+ [PCI_INTC] = { 3, 1<<12 },

                            ^

ERROR: spaces required around that '<<' (ctx:VxV)
#485: FILE: hw/sh4/r2d.c:104:
+ [PCI_INTD] = { 0, 1<<11 },

                            ^

ERROR: spaces required around that '<<' (ctx:VxV)
#486: FILE: hw/sh4/r2d.c:105:
+ [SM501] = { 4, 1<<10 },

                         ^

ERROR: spaces required around that '<<' (ctx:VxV)
#487: FILE: hw/sh4/r2d.c:106:
+ [KEY] = { 5, 1<<6 },

                       ^

ERROR: spaces required around that '<<' (ctx:VxV)
#488: FILE: hw/sh4/r2d.c:107:
+ [RTC_A] = { 6, 1<<5 },

                         ^

ERROR: spaces required around that '<<' (ctx:VxV)
#489: FILE: hw/sh4/r2d.c:108:
+ [RTC_T] = { 7, 1<<4 },

                         ^

ERROR: spaces required around that '<<' (ctx:VxV)
#490: FILE: hw/sh4/r2d.c:109:
+ [SDCARD] = { 8, 1<<7 },

                          ^

ERROR: spaces required around that '<<' (ctx:VxV)
#491: FILE: hw/sh4/r2d.c:110:
+ [EXT] = { 11, 1<<0 },

                       ^

ERROR: spaces required around that '<<' (ctx:VxV)
#492: FILE: hw/sh4/r2d.c:111:
+ [TP] = { 12, 1<<15 },

                      ^

ERROR: spaces required around that '*' (ctx:WxV)
#523: FILE: hw/sh4/sh7750.c:73:
+ sh7750_io_device *devices[NB_DEVICES]; /* External peripherals */

                      ^

ERROR: suspect code indent for conditional statements (4, 4) #530: FILE: hw/sh4/sh7750.c:93:

     for (i = 0; i < NB_DEVICES; i++) {

+ if (s->devices[i] == NULL) {

ERROR: suspect code indent for conditional statements (4, 4) #606: FILE: hw/sh4/sh7750.c:155:

     if (currenta == prev)

+ return;

ERROR: suspect code indent for conditional statements (4, 4) #611: FILE: hw/sh4/sh7750.c:159:

     for (i = 0; i < NB_DEVICES; i++) {

+ if (s->devices[i] && (s->devices[i]->portamask_trigger & changes)) {

ERROR: suspect code indent for conditional statements (4, 4) #628: FILE: hw/sh4/sh7750.c:169:

     if (r)

+ gen_port_interrupts(s);

ERROR: suspect code indent for conditional statements (4, 4) #637: FILE: hw/sh4/sh7750.c:179:

     if (currentb == prev)

+ return;

ERROR: suspect code indent for conditional statements (4, 4) #642: FILE: hw/sh4/sh7750.c:183:

     for (i = 0; i < NB_DEVICES; i++) {

+ if (s->devices[i] && (s->devices[i]->portbmask_trigger & changes)) {

ERROR: suspect code indent for conditional statements (4, 4) #659: FILE: hw/sh4/sh7750.c:193:

     if (r)

+ gen_port_interrupts(s);

ERROR: space required before the open parenthesis '(' #699: FILE: hw/sh4/sh7750.c:230:
+ if(!has_bcr3_and_bcr4(s))

ERROR: braces {} are necessary for all arms of this statement #699: FILE: hw/sh4/sh7750.c:230:
+ if(!has_bcr3_and_bcr4(s))
[...]

ERROR: space required before the open parenthesis '(' #744: FILE: hw/sh4/sh7750.c:265:
+ if(!has_bcr3_and_bcr4(s))

ERROR: braces {} are necessary for all arms of this statement #744: FILE: hw/sh4/sh7750.c:265:
+ if(!has_bcr3_and_bcr4(s))
[...]

ERROR: suspect code indent for conditional statements (4, 4) #783: FILE: hw/sh4/sh7750.c:313:

     if (is_in_sdrmx(addr, 2) || is_in_sdrmx(addr, 3)) {

+ ignore_access("byte write", addr);

ERROR: space required before the open parenthesis '(' #812: FILE: hw/sh4/sh7750.c:334:
+ if(!has_bcr3_and_bcr4(s))

ERROR: braces {} are necessary for all arms of this statement #812: FILE: hw/sh4/sh7750.c:334:
+ if(!has_bcr3_and_bcr4(s))
[...]

ERROR: space required before the open parenthesis '(' #892: FILE: hw/sh4/sh7750.c:386:
+ if(!has_bcr3_and_bcr4(s))

ERROR: braces {} are necessary for all arms of this statement #892: FILE: hw/sh4/sh7750.c:386:
+ if(!has_bcr3_and_bcr4(s))
[...]

WARNING: Block comments use a leading /* on a separate line #1048: FILE: hw/sh4/sh7750.c:549:
+ { 0xffd00004, 0, 16, 4, /* IPRA */ { TMU0, TMU1, TMU2, RTC } },

WARNING: Block comments use a leading /* on a separate line #1049: FILE: hw/sh4/sh7750.c:550:
+ { 0xffd00008, 0, 16, 4, /* IPRB */ { WDT, REF, SCI1, 0 } },

WARNING: Block comments use a leading /* on a separate line #1050: FILE: hw/sh4/sh7750.c:551:
+ { 0xffd0000c, 0, 16, 4, /* IPRC */ { GPIOI, DMAC, SCIF, HUDI } },

WARNING: Block comments use a leading /* on a separate line #1051: FILE: hw/sh4/sh7750.c:552:
+ { 0xffd00010, 0, 16, 4, /* IPRD */ { IRL0, IRL1, IRL2, IRL3 } },

WARNING: Block comments use a leading /* on a separate line #1052: FILE: hw/sh4/sh7750.c:553:
+ { 0xfe080000, 0, 32, 4, /* INTPRI00 */ { 0, 0, 0, 0,

ERROR: space prohibited after that '-' (ctx:WxW)
#1488: FILE: hw/sh4/sh7750_regnames.c:84:
+ REGNAME(SH7750_SDMR3_A7) {(uint32_t) - 1, NULL}

                                          ^

ERROR: suspect code indent for conditional statements (4, 4) #1495: FILE: hw/sh4/sh7750_regnames.c:91:

     for (i = 0; regnames[i].regaddr != (uint32_t) - 1; i++) {

+ if (regnames[i].regaddr == addr)

ERROR: braces {} are necessary for all arms of this statement #1498: FILE: hw/sh4/sh7750_regnames.c:92:
+ if (regnames[i].regaddr == addr)
[...]

WARNING: Block comments use a leading /* on a separate line #1514: FILE: hw/sh4/sh7750_regs.h:46:
+#define SH7750_P4_BASE 0xff000000 /* Accessible only in

WARNING: Block comments use * on subsequent lines
#1515: FILE: hw/sh4/sh7750_regs.h:47:
+#define SH7750_P4_BASE 0xff000000 /* Accessible only in
+ privileged mode */

WARNING: Block comments use a trailing */ on a separate line #1515: FILE: hw/sh4/sh7750_regs.h:47:
+ privileged mode */

WARNING: line over 80 characters
#1575: FILE: hw/sh4/sh7750_regs.h:82:
+#define SH7750_PTEL_PR_ROPU 0x00000040 /* read-only in priv or user mode */

WARNING: line over 80 characters
#1576: FILE: hw/sh4/sh7750_regs.h:83:
+#define SH7750_PTEL_PR_RWPU 0x00000060 /* read-write in priv or user mode */

WARNING: Block comments use a leading /* on a separate line #1577: FILE: hw/sh4/sh7750_regs.h:84:
+#define SH7750_PTEL_C 0x00000008 /* Cacheability

WARNING: Block comments use * on subsequent lines
#1578: FILE: hw/sh4/sh7750_regs.h:85:
+#define SH7750_PTEL_C 0x00000008 /* Cacheability
+ (0 - page not cacheable) */

WARNING: Block comments use a trailing */ on a separate line #1578: FILE: hw/sh4/sh7750_regs.h:85:
+ (0 - page not cacheable) */

WARNING: Block comments use a leading /* on a separate line #1579: FILE: hw/sh4/sh7750_regs.h:86:
+#define SH7750_PTEL_D 0x00000004 /* Dirty bit (1 - write has been

WARNING: Block comments use * on subsequent lines
#1580: FILE: hw/sh4/sh7750_regs.h:87:
+#define SH7750_PTEL_D 0x00000004 /* Dirty bit (1 - write has been
+ performed to a page) */

WARNING: Block comments use a trailing */ on a separate line #1580: FILE: hw/sh4/sh7750_regs.h:87:
+ performed to a page) */

WARNING: Block comments use a leading /* on a separate line #1581: FILE: hw/sh4/sh7750_regs.h:88:
+#define SH7750_PTEL_SH 0x00000002 /* Share Status bit (1 - page are

WARNING: Block comments use * on subsequent lines
#1582: FILE: hw/sh4/sh7750_regs.h:89:
+#define SH7750_PTEL_SH 0x00000002 /* Share Status bit (1 - page are
+ shared by processes) */

WARNING: Block comments use a trailing */ on a separate line #1582: FILE: hw/sh4/sh7750_regs.h:89:
+ shared by processes) */

WARNING: Block comments use a leading /* on a separate line #1583: FILE: hw/sh4/sh7750_regs.h:90:
+#define SH7750_PTEL_WT 0x00000001 /* Write-through bit, specifies the

WARNING: Block comments use * on subsequent lines
#1584: FILE: hw/sh4/sh7750_regs.h:91:
+#define SH7750_PTEL_WT 0x00000001 /* Write-through bit, specifies the
+ cache write mode:

WARNING: Block comments use a trailing */ on a separate line #1586: FILE: hw/sh4/sh7750_regs.h:93:
+ 1 - Write-through mode */

WARNING: Block comments use a leading /* on a separate line #1605: FILE: hw/sh4/sh7750_regs.h:99:
+#define SH7750_PTEA_TC 0x00000008 /* Timing Control bit

WARNING: Block comments use * on subsequent lines
#1606: FILE: hw/sh4/sh7750_regs.h:100:
+#define SH7750_PTEA_TC 0x00000008 /* Timing Control bit
+ 0 - use area 5 wait states

WARNING: Block comments use a trailing */ on a separate line #1607: FILE: hw/sh4/sh7750_regs.h:101:
+ 1 - use area 6 wait states */

WARNING: line over 80 characters
#1613: FILE: hw/sh4/sh7750_regs.h:107:
+#define SH7750_PTEA_SA_CMEM8 0x00000004 /* 4 - 8-bit common memory space */

WARNING: line over 80 characters
#1614: FILE: hw/sh4/sh7750_regs.h:108:
+#define SH7750_PTEA_SA_CMEM16 0x00000005 /* 5 - 16-bit common memory space */

WARNING: line over 80 characters
#1616: FILE: hw/sh4/sh7750_regs.h:110:
+#define SH7750_PTEA_SA_AMEM16 0x00000007 /* 7 - 16-bit attr memory space */

WARNING: Block comments use a leading /* on a separate line #1677: FILE: hw/sh4/sh7750_regs.h:153:
+#define SH7750_CCR_ICI 0x00000800 /* IC invalidation bit:

WARNING: Block comments use * on subsequent lines
#1678: FILE: hw/sh4/sh7750_regs.h:154:
+#define SH7750_CCR_ICI 0x00000800 /* IC invalidation bit:
+ set it to clear IC */

WARNING: Block comments use a trailing */ on a separate line #1678: FILE: hw/sh4/sh7750_regs.h:154:
+ set it to clear IC */

WARNING: Block comments use a leading /* on a separate line #1681: FILE: hw/sh4/sh7750_regs.h:157:
+#define SH7750_CCR_ORA 0x00000020 /* OC RAM enable bit

WARNING: Block comments use * on subsequent lines
#1682: FILE: hw/sh4/sh7750_regs.h:158:
+#define SH7750_CCR_ORA 0x00000020 /* OC RAM enable bit
+ if you set OCE = 0,

WARNING: Block comments use a trailing */ on a separate line #1683: FILE: hw/sh4/sh7750_regs.h:159:
+ you should set ORA = 0 */

WARNING: line over 80 characters
#1686: FILE: hw/sh4/sh7750_regs.h:162:
+#define SH7750_CCR_WT 0x00000002 /* Write-through bit for P0,U0,P3 area */

WARNING: Block comments use a leading /* on a separate line #1766: FILE: hw/sh4/sh7750_regs.h:216:
+#define SH7750_EVT_TLB_READ_MISS 0x040 /* ITLB miss exception /

WARNING: Block comments use * on subsequent lines
#1767: FILE: hw/sh4/sh7750_regs.h:217:
+#define SH7750_EVT_TLB_READ_MISS 0x040 /* ITLB miss exception /
+ DTLB miss exception (read) */

WARNING: Block comments use a trailing */ on a separate line #1767: FILE: hw/sh4/sh7750_regs.h:217:
+ DTLB miss exception (read) */

WARNING: Block comments use a leading /* on a separate line #1768: FILE: hw/sh4/sh7750_regs.h:218:
+#define SH7750_EVT_TLB_READ_PROTV 0x0A0 /* ITLB protection violation /

WARNING: Block comments use * on subsequent lines
#1769: FILE: hw/sh4/sh7750_regs.h:219:
+#define SH7750_EVT_TLB_READ_PROTV 0x0A0 /* ITLB protection violation /
+ DTLB protection violation (read) */

WARNING: Block comments use a trailing */ on a separate line #1769: FILE: hw/sh4/sh7750_regs.h:219:
+ DTLB protection violation (read) */

WARNING: Block comments use a leading /* on a separate line #1770: FILE: hw/sh4/sh7750_regs.h:220:
+#define SH7750_EVT_ILLEGAL_INSTR 0x180 /* General Illegal Instruction

WARNING: Block comments use * on subsequent lines
#1771: FILE: hw/sh4/sh7750_regs.h:221:
+#define SH7750_EVT_ILLEGAL_INSTR 0x180 /* General Illegal Instruction
+ exception */

WARNING: Block comments use a trailing */ on a separate line #1771: FILE: hw/sh4/sh7750_regs.h:221:
+ exception */

WARNING: Block comments use a leading /* on a separate line #1772: FILE: hw/sh4/sh7750_regs.h:222:
+#define SH7750_EVT_SLOT_ILLEGAL_INSTR 0x1A0 /* Slot Illegal Instruction

WARNING: Block comments use * on subsequent lines
#1773: FILE: hw/sh4/sh7750_regs.h:223:
+#define SH7750_EVT_SLOT_ILLEGAL_INSTR 0x1A0 /* Slot Illegal Instruction
+ exception */

WARNING: Block comments use a trailing */ on a separate line #1773: FILE: hw/sh4/sh7750_regs.h:223:
+ exception */

WARNING: line over 80 characters
#1774: FILE: hw/sh4/sh7750_regs.h:224:
+#define SH7750_EVT_FPU_DISABLE 0x800 /* General FPU disable exception */

WARNING: line over 80 characters
#1778: FILE: hw/sh4/sh7750_regs.h:228:
+#define SH7750_EVT_DTLB_WRITE_MISS 0x060 /* DTLB miss exception (write) */

WARNING: Block comments use a leading /* on a separate line #1779: FILE: hw/sh4/sh7750_regs.h:229:
+#define SH7750_EVT_DTLB_WRITE_PROTV 0x0C0 /* DTLB protection violation

WARNING: Block comments use * on subsequent lines
#1780: FILE: hw/sh4/sh7750_regs.h:230:
+#define SH7750_EVT_DTLB_WRITE_PROTV 0x0C0 /* DTLB protection violation
+ exception (write) */

WARNING: Block comments use a trailing */ on a separate line #1780: FILE: hw/sh4/sh7750_regs.h:230:
+ exception (write) */

WARNING: line over 80 characters
#1782: FILE: hw/sh4/sh7750_regs.h:232:
+#define SH7750_EVT_INITIAL_PGWRITE 0x080 /* Initial Page Write exception */

WARNING: line over 80 characters
#1827: FILE: hw/sh4/sh7750_regs.h:257:
+#define SH7750_EVT_TICPI2 0x460 /* TMU Input Capture Interrupt 2 */

WARNING: line over 80 characters
#1844: FILE: hw/sh4/sh7750_regs.h:267:
+#define SH7750_EVT_SCI_TXI 0x520 /* Transmit Data Register Empty */

WARNING: Block comments use a leading /* on a separate line #1851: FILE: hw/sh4/sh7750_regs.h:271:
+#define SH7750_EVT_WDT_ITI 0x560 /* Interval Timer Interrupt

WARNING: Block comments use * on subsequent lines
#1852: FILE: hw/sh4/sh7750_regs.h:272:
+#define SH7750_EVT_WDT_ITI 0x560 /* Interval Timer Interrupt
+ (used when WDT operates in

WARNING: Block comments use a trailing */ on a separate line #1853: FILE: hw/sh4/sh7750_regs.h:273:
+ interval timer mode) */

WARNING: Block comments use a leading /* on a separate line #1860: FILE: hw/sh4/sh7750_regs.h:277:
+#define SH7750_EVT_REF_ROVI 0x5A0 /* Refresh Counter Overflow

WARNING: Block comments use * on subsequent lines
#1861: FILE: hw/sh4/sh7750_regs.h:278:
+#define SH7750_EVT_REF_ROVI 0x5A0 /* Refresh Counter Overflow
+ interrupt */

WARNING: Block comments use a trailing */ on a separate line #1861: FILE: hw/sh4/sh7750_regs.h:278:
+ interrupt */

WARNING: line over 80 characters
#1877: FILE: hw/sh4/sh7750_regs.h:287:
+#define SH7750_EVT_DMAC_DMTE0 0x640 /* DMAC 0 Transfer End Interrupt */

WARNING: line over 80 characters
#1878: FILE: hw/sh4/sh7750_regs.h:288:
+#define SH7750_EVT_DMAC_DMTE1 0x660 /* DMAC 1 Transfer End Interrupt */

WARNING: line over 80 characters
#1879: FILE: hw/sh4/sh7750_regs.h:289:
+#define SH7750_EVT_DMAC_DMTE2 0x680 /* DMAC 2 Transfer End Interrupt */

WARNING: line over 80 characters
#1880: FILE: hw/sh4/sh7750_regs.h:290:
+#define SH7750_EVT_DMAC_DMTE3 0x6A0 /* DMAC 3 Transfer End Interrupt */

WARNING: line over 80 characters
#1881: FILE: hw/sh4/sh7750_regs.h:291:
+#define SH7750_EVT_DMAC_DMAE 0x6C0 /* DMAC Address Error Interrupt */

WARNING: Block comments use a leading /* on a separate line #1891: FILE: hw/sh4/sh7750_regs.h:296:
+#define SH7750_EVT_SCIF_RXI 0x720 /* Receive FIFO Data Full or

WARNING: Block comments use * on subsequent lines
#1892: FILE: hw/sh4/sh7750_regs.h:297:
+#define SH7750_EVT_SCIF_RXI 0x720 /* Receive FIFO Data Full or
+ Receive Data ready interrupt */

WARNING: Block comments use a trailing */ on a separate line #1892: FILE: hw/sh4/sh7750_regs.h:297:
+ Receive Data ready interrupt */

WARNING: Block comments use a leading /* on a separate line #1911: FILE: hw/sh4/sh7750_regs.h:308:
+#define SH7750_STBCR_STBY 0x80 /* Specifies a transition to standby mode:

WARNING: Block comments use * on subsequent lines
#1912: FILE: hw/sh4/sh7750_regs.h:309:
+#define SH7750_STBCR_STBY 0x80 /* Specifies a transition to standby mode:
+ 0 - Transition to SLEEP mode on SLEEP

WARNING: Block comments use a trailing */ on a separate line #1913: FILE: hw/sh4/sh7750_regs.h:310:
+ 1 - Transition to STANDBY mode on SLEEP */

WARNING: Block comments use a leading /* on a separate line #1914: FILE: hw/sh4/sh7750_regs.h:311:
+#define SH7750_STBCR_PHZ 0x40 /* State of peripheral module pins in

WARNING: Block comments use * on subsequent lines
#1915: FILE: hw/sh4/sh7750_regs.h:312:
+#define SH7750_STBCR_PHZ 0x40 /* State of peripheral module pins in
+ standby mode:

WARNING: Block comments use a trailing */ on a separate line #1917: FILE: hw/sh4/sh7750_regs.h:314:
+ 1 - high-impendance state */

WARNING: line over 80 characters
#1921: FILE: hw/sh4/sh7750_regs.h:316:
+#define SH7750_STBCR_PPU 0x20 /* Peripheral module pins pull-up controls */

WARNING: line over 80 characters
#1952: FILE: hw/sh4/sh7750_regs.h:335:
+#define SH7750_STBCR2_DSLP 0x80 /* Specifies transition to deep sleep mode:

WARNING: Block comments use a leading /* on a separate line #1952: FILE: hw/sh4/sh7750_regs.h:335:
+#define SH7750_STBCR2_DSLP 0x80 /* Specifies transition to deep sleep mode:

WARNING: Block comments use * on subsequent lines
#1953: FILE: hw/sh4/sh7750_regs.h:336:
+#define SH7750_STBCR2_DSLP 0x80 /* Specifies transition to deep sleep mode:
+ 0 - transition to sleep or standby mode

WARNING: Block comments use a trailing */ on a separate line #1956: FILE: hw/sh4/sh7750_regs.h:339:
+ execution of SLEEP instruction */

WARNING: line over 80 characters
#1957: FILE: hw/sh4/sh7750_regs.h:340:
+#define SH7750_STBCR2_MSTP6 0x02 /* Stopping the clock supply to Store Queue

WARNING: Block comments use a leading /* on a separate line #1957: FILE: hw/sh4/sh7750_regs.h:340:
+#define SH7750_STBCR2_MSTP6 0x02 /* Stopping the clock supply to Store Queue

WARNING: Block comments use * on subsequent lines
#1958: FILE: hw/sh4/sh7750_regs.h:341:
+#define SH7750_STBCR2_MSTP6 0x02 /* Stopping the clock supply to Store Queue
+ in the cache controller */

WARNING: Block comments use a trailing */ on a separate line #1958: FILE: hw/sh4/sh7750_regs.h:341:
+ in the cache controller */

WARNING: Block comments use a leading /* on a separate line #1962: FILE: hw/sh4/sh7750_regs.h:343:
+#define SH7750_STBCR2_MSTP5 0x01 /* Stopping the clock supply to the User

WARNING: Block comments use * on subsequent lines
#1963: FILE: hw/sh4/sh7750_regs.h:344:
+#define SH7750_STBCR2_MSTP5 0x01 /* Stopping the clock supply to the User
+ Break Controller (UBC) */

WARNING: Block comments use a trailing */ on a separate line #1963: FILE: hw/sh4/sh7750_regs.h:344:
+ Break Controller (UBC) */

WARNING: Block comments use a leading /* on a separate line #1979: FILE: hw/sh4/sh7750_regs.h:354:
+#define SH7750_FRQCR_CKOEN 0x0800 /* Clock Output Enable

WARNING: Block comments use * on subsequent lines
#1980: FILE: hw/sh4/sh7750_regs.h:355:
+#define SH7750_FRQCR_CKOEN 0x0800 /* Clock Output Enable
+ 0 - CKIO pin goes to HiZ/pullup

WARNING: Block comments use a trailing */ on a separate line #1981: FILE: hw/sh4/sh7750_regs.h:356:
+ 1 - Clock is output from CKIO */

WARNING: line over 80 characters
#1992: FILE: hw/sh4/sh7750_regs.h:360:
+#define SH7750_FRQCR_IFC 0x01C0 /* CPU clock frequency division ratio: */

WARNING: line over 80 characters
#2007: FILE: hw/sh4/sh7750_regs.h:368:
+#define SH7750_FRQCR_BFC 0x0038 /* Bus clock frequency division ratio: */

WARNING: Block comments use a leading /* on a separate line #2022: FILE: hw/sh4/sh7750_regs.h:376:
+#define SH7750_FRQCR_PFC 0x0007 /* Peripheral module clock frequency

WARNING: Block comments use * on subsequent lines
#2023: FILE: hw/sh4/sh7750_regs.h:377:
+#define SH7750_FRQCR_PFC 0x0007 /* Peripheral module clock frequency
+ division ratio: */

WARNING: Block comments use a trailing */ on a separate line #2023: FILE: hw/sh4/sh7750_regs.h:377:
+ division ratio: */

WARNING: Block comments use a leading /* on a separate line #2042: FILE: hw/sh4/sh7750_regs.h:392:
+#define SH7750_WTCNT_KEY 0x5A00 /* When WTCNT byte register written,

WARNING: Block comments use * on subsequent lines
#2043: FILE: hw/sh4/sh7750_regs.h:393:
+#define SH7750_WTCNT_KEY 0x5A00 /* When WTCNT byte register written,
+ you have to set the upper byte to

WARNING: Block comments use a trailing */ on a separate line #2044: FILE: hw/sh4/sh7750_regs.h:394:
+ 0x5A */

WARNING: Block comments use a leading /* on a separate line #2072: FILE: hw/sh4/sh7750_regs.h:400:
+#define SH7750_WTCSR_KEY 0xA500 /* When WTCSR byte register written,

WARNING: Block comments use * on subsequent lines
#2073: FILE: hw/sh4/sh7750_regs.h:401:
+#define SH7750_WTCSR_KEY 0xA500 /* When WTCSR byte register written,
+ you have to set the upper byte to

WARNING: Block comments use a trailing */ on a separate line #2074: FILE: hw/sh4/sh7750_regs.h:402:
+ 0xA5 */

WARNING: line over 80 characters
#2085: FILE: hw/sh4/sh7750_regs.h:413:
+#define SH7750_WTCSR_CKS_DIV32 0x00 /* 1/32 of frequency divider 2 input */

WARNING: line over 80 characters
#2271: FILE: hw/sh4/sh7750_regs.h:542:
+#define SH7750_RCR2_RESET 0x02 /* Frequency divider circuits are reset */

WARNING: Block comments use a leading /* on a separate line #2272: FILE: hw/sh4/sh7750_regs.h:543:
+#define SH7750_RCR2_START 0x01 /* 0 - sec, min, hr, day-of-week, month,

WARNING: Block comments use * on subsequent lines
#2273: FILE: hw/sh4/sh7750_regs.h:544:
+#define SH7750_RCR2_START 0x01 /* 0 - sec, min, hr, day-of-week, month,
+ year counters are stopped

WARNING: Block comments use a trailing */ on a separate line #2275: FILE: hw/sh4/sh7750_regs.h:546:
+ year counters operate normally */

WARNING: line over 80 characters
#2341: FILE: hw/sh4/sh7750_regs.h:556:
+#define SH7750_BCR1_A0MPX 0x20000000 /* Area 0 Memory Type (0-SRAM,1-MPX) */

WARNING: Block comments use a leading /* on a separate line #2342: FILE: hw/sh4/sh7750_regs.h:557:
+#define SH7750_BCR1_IPUP 0x02000000 /* Input Pin Pull-up Control:

WARNING: Block comments use * on subsequent lines
#2343: FILE: hw/sh4/sh7750_regs.h:558:
+#define SH7750_BCR1_IPUP 0x02000000 /* Input Pin Pull-up Control:
+ 0 - pull-up resistor is on for

WARNING: Block comments use a trailing */ on a separate line #2345: FILE: hw/sh4/sh7750_regs.h:560:
+ 1 - pull-up resistor is off */

WARNING: Block comments use a leading /* on a separate line #2346: FILE: hw/sh4/sh7750_regs.h:561:
+#define SH7750_BCR1_OPUP 0x01000000 /* Output Pin Pull-up Control:

WARNING: Block comments use * on subsequent lines
#2347: FILE: hw/sh4/sh7750_regs.h:562:
+#define SH7750_BCR1_OPUP 0x01000000 /* Output Pin Pull-up Control:
+ 0 - pull-up resistor is on for

WARNING: Block comments use a trailing */ on a separate line #2349: FILE: hw/sh4/sh7750_regs.h:564:
+ 1 - pull-up resistor is off */

WARNING: Block comments use a leading /* on a separate line #2350: FILE: hw/sh4/sh7750_regs.h:565:
+#define SH7750_BCR1_A1MBC 0x00200000 /* Area 1 SRAM Byte Control Mode:

WARNING: Block comments use * on subsequent lines
#2351: FILE: hw/sh4/sh7750_regs.h:566:
+#define SH7750_BCR1_A1MBC 0x00200000 /* Area 1 SRAM Byte Control Mode:
+ 0 - Area 1 SRAM is set to

WARNING: Block comments use a trailing */ on a separate line #2354: FILE: hw/sh4/sh7750_regs.h:569:
+ control mode */

WARNING: Block comments use a leading /* on a separate line #2355: FILE: hw/sh4/sh7750_regs.h:570:
+#define SH7750_BCR1_A4MBC 0x00100000 /* Area 4 SRAM Byte Control Mode:

WARNING: Block comments use * on subsequent lines
#2356: FILE: hw/sh4/sh7750_regs.h:571:
+#define SH7750_BCR1_A4MBC 0x00100000 /* Area 4 SRAM Byte Control Mode:
+ 0 - Area 4 SRAM is set to

WARNING: Block comments use a trailing */ on a separate line #2359: FILE: hw/sh4/sh7750_regs.h:574:
+ control mode */

WARNING: Block comments use a leading /* on a separate line #2360: FILE: hw/sh4/sh7750_regs.h:575:
+#define SH7750_BCR1_BREQEN 0x00080000 /* BREQ Enable:

WARNING: Block comments use * on subsequent lines
#2361: FILE: hw/sh4/sh7750_regs.h:576:
+#define SH7750_BCR1_BREQEN 0x00080000 /* BREQ Enable:
+ 0 - External requests are not

WARNING: Block comments use a trailing */ on a separate line #2364: FILE: hw/sh4/sh7750_regs.h:579:
+ accepted */

WARNING: Block comments use a leading /* on a separate line #2365: FILE: hw/sh4/sh7750_regs.h:580:
+#define SH7750_BCR1_PSHR 0x00040000 /* Partial Sharing Bit:

WARNING: Block comments use * on subsequent lines
#2366: FILE: hw/sh4/sh7750_regs.h:581:
+#define SH7750_BCR1_PSHR 0x00040000 /* Partial Sharing Bit:
+ 0 - Master Mode

WARNING: Block comments use a trailing */ on a separate line #2367: FILE: hw/sh4/sh7750_regs.h:582:
+ 1 - Partial-sharing Mode */

WARNING: Block comments use a leading /* on a separate line #2368: FILE: hw/sh4/sh7750_regs.h:583:
+#define SH7750_BCR1_MEMMPX 0x00020000 /* Area 1 to 6 MPX Interface:

WARNING: Block comments use * on subsequent lines
#2369: FILE: hw/sh4/sh7750_regs.h:584:
+#define SH7750_BCR1_MEMMPX 0x00020000 /* Area 1 to 6 MPX Interface:
+ 0 - SRAM/burst ROM interface

WARNING: Block comments use a trailing */ on a separate line #2370: FILE: hw/sh4/sh7750_regs.h:585:
+ 1 - MPX interface */

WARNING: line over 80 characters
#2371: FILE: hw/sh4/sh7750_regs.h:586:
+#define SH7750_BCR1_HIZMEM 0x00008000 /* High Impendance Control. Specifies

WARNING: Block comments use a leading /* on a separate line #2371: FILE: hw/sh4/sh7750_regs.h:586:
+#define SH7750_BCR1_HIZMEM 0x00008000 /* High Impendance Control. Specifies

WARNING: Block comments use * on subsequent lines
#2372: FILE: hw/sh4/sh7750_regs.h:587:
+#define SH7750_BCR1_HIZMEM 0x00008000 /* High Impendance Control. Specifies
+ the state of A[25:0], BS\, CSn\,

WARNING: Block comments use a trailing */ on a separate line #2376: FILE: hw/sh4/sh7750_regs.h:591:
+ 1 - signals driven */

WARNING: line over 80 characters
#2377: FILE: hw/sh4/sh7750_regs.h:592:
+#define SH7750_BCR1_HIZCNT 0x00004000 /* High Impendance Control. Specifies

WARNING: Block comments use a leading /* on a separate line #2377: FILE: hw/sh4/sh7750_regs.h:592:
+#define SH7750_BCR1_HIZCNT 0x00004000 /* High Impendance Control. Specifies

WARNING: Block comments use * on subsequent lines
#2378: FILE: hw/sh4/sh7750_regs.h:593:
+#define SH7750_BCR1_HIZCNT 0x00004000 /* High Impendance Control. Specifies
+ the state of the RAS\, RAS2\, WEn\,

WARNING: Block comments use a trailing */ on a separate line #2383: FILE: hw/sh4/sh7750_regs.h:598:
+ 1 - signals driven */

WARNING: Block comments use a leading /* on a separate line #2386: FILE: hw/sh4/sh7750_regs.h:601:
+#define SH7750_BCR1_A0BST_ROM4 0x0800 /* Area 0 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2387: FILE: hw/sh4/sh7750_regs.h:602:
+#define SH7750_BCR1_A0BST_ROM4 0x0800 /* Area 0 accessed as burst ROM
+ interface, 4 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2387: FILE: hw/sh4/sh7750_regs.h:602:
+ interface, 4 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2388: FILE: hw/sh4/sh7750_regs.h:603:
+#define SH7750_BCR1_A0BST_ROM8 0x1000 /* Area 0 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2389: FILE: hw/sh4/sh7750_regs.h:604:
+#define SH7750_BCR1_A0BST_ROM8 0x1000 /* Area 0 accessed as burst ROM
+ interface, 8 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2389: FILE: hw/sh4/sh7750_regs.h:604:
+ interface, 8 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2390: FILE: hw/sh4/sh7750_regs.h:605:
+#define SH7750_BCR1_A0BST_ROM16 0x1800 /* Area 0 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2391: FILE: hw/sh4/sh7750_regs.h:606:
+#define SH7750_BCR1_A0BST_ROM16 0x1800 /* Area 0 accessed as burst ROM
+ interface, 16 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2391: FILE: hw/sh4/sh7750_regs.h:606:
+ interface, 16 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2392: FILE: hw/sh4/sh7750_regs.h:607:
+#define SH7750_BCR1_A0BST_ROM32 0x2000 /* Area 0 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2393: FILE: hw/sh4/sh7750_regs.h:608:
+#define SH7750_BCR1_A0BST_ROM32 0x2000 /* Area 0 accessed as burst ROM
+ interface, 32 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2393: FILE: hw/sh4/sh7750_regs.h:608:
+ interface, 32 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2407: FILE: hw/sh4/sh7750_regs.h:612:
+#define SH7750_BCR1_A5BST_ROM4 0x0100 /* Area 5 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2408: FILE: hw/sh4/sh7750_regs.h:613:
+#define SH7750_BCR1_A5BST_ROM4 0x0100 /* Area 5 accessed as burst ROM
+ interface, 4 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2408: FILE: hw/sh4/sh7750_regs.h:613:
+ interface, 4 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2409: FILE: hw/sh4/sh7750_regs.h:614:
+#define SH7750_BCR1_A5BST_ROM8 0x0200 /* Area 5 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2410: FILE: hw/sh4/sh7750_regs.h:615:
+#define SH7750_BCR1_A5BST_ROM8 0x0200 /* Area 5 accessed as burst ROM
+ interface, 8 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2410: FILE: hw/sh4/sh7750_regs.h:615:
+ interface, 8 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2411: FILE: hw/sh4/sh7750_regs.h:616:
+#define SH7750_BCR1_A5BST_ROM16 0x0300 /* Area 5 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2412: FILE: hw/sh4/sh7750_regs.h:617:
+#define SH7750_BCR1_A5BST_ROM16 0x0300 /* Area 5 accessed as burst ROM
+ interface, 16 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2412: FILE: hw/sh4/sh7750_regs.h:617:
+ interface, 16 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2413: FILE: hw/sh4/sh7750_regs.h:618:
+#define SH7750_BCR1_A5BST_ROM32 0x0400 /* Area 5 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2414: FILE: hw/sh4/sh7750_regs.h:619:
+#define SH7750_BCR1_A5BST_ROM32 0x0400 /* Area 5 accessed as burst ROM
+ interface, 32 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2414: FILE: hw/sh4/sh7750_regs.h:619:
+ interface, 32 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2428: FILE: hw/sh4/sh7750_regs.h:623:
+#define SH7750_BCR1_A6BST_ROM4 0x0020 /* Area 6 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2429: FILE: hw/sh4/sh7750_regs.h:624:
+#define SH7750_BCR1_A6BST_ROM4 0x0020 /* Area 6 accessed as burst ROM
+ interface, 4 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2429: FILE: hw/sh4/sh7750_regs.h:624:
+ interface, 4 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2430: FILE: hw/sh4/sh7750_regs.h:625:
+#define SH7750_BCR1_A6BST_ROM8 0x0040 /* Area 6 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2431: FILE: hw/sh4/sh7750_regs.h:626:
+#define SH7750_BCR1_A6BST_ROM8 0x0040 /* Area 6 accessed as burst ROM
+ interface, 8 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2431: FILE: hw/sh4/sh7750_regs.h:626:
+ interface, 8 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2432: FILE: hw/sh4/sh7750_regs.h:627:
+#define SH7750_BCR1_A6BST_ROM16 0x0060 /* Area 6 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2433: FILE: hw/sh4/sh7750_regs.h:628:
+#define SH7750_BCR1_A6BST_ROM16 0x0060 /* Area 6 accessed as burst ROM
+ interface, 16 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2433: FILE: hw/sh4/sh7750_regs.h:628:
+ interface, 16 cosequtive access */

WARNING: Block comments use a leading /* on a separate line #2434: FILE: hw/sh4/sh7750_regs.h:629:
+#define SH7750_BCR1_A6BST_ROM32 0x0080 /* Area 6 accessed as burst ROM

WARNING: Block comments use * on subsequent lines
#2435: FILE: hw/sh4/sh7750_regs.h:630:
+#define SH7750_BCR1_A6BST_ROM32 0x0080 /* Area 6 accessed as burst ROM
+ interface, 32 cosequtive access */

WARNING: Block comments use a trailing */ on a separate line #2435: FILE: hw/sh4/sh7750_regs.h:630:
+ interface, 32 cosequtive access */

WARNING: line over 80 characters
#2449: FILE: hw/sh4/sh7750_regs.h:633:
+#define SH7750_BCR1_DRAMTP_2SRAM_3SRAM 0x0000 /* Area 2 and 3 are SRAM or MPX

WARNING: Block comments use a leading /* on a separate line #2449: FILE: hw/sh4/sh7750_regs.h:633:
+#define SH7750_BCR1_DRAMTP_2SRAM_3SRAM 0x0000 /* Area 2 and 3 are SRAM or MPX

WARNING: Block comments use * on subsequent lines
#2450: FILE: hw/sh4/sh7750_regs.h:634:
+#define SH7750_BCR1_DRAMTP_2SRAM_3SRAM 0x0000 /* Area 2 and 3 are SRAM or MPX
+ interface. */

WARNING: Block comments use a trailing */ on a separate line #2450: FILE: hw/sh4/sh7750_regs.h:634:
+ interface. */

WARNING: line over 80 characters
#2451: FILE: hw/sh4/sh7750_regs.h:635:
+#define SH7750_BCR1_DRAMTP_2SRAM_3SDRAM 0x0008 /* Area 2 - SRAM/MPX, Area 3 -

WARNING: Block comments use a leading /* on a separate line #2451: FILE: hw/sh4/sh7750_regs.h:635:
+#define SH7750_BCR1_DRAMTP_2SRAM_3SDRAM 0x0008 /* Area 2 - SRAM/MPX, Area 3 -

WARNING: Block comments use * on subsequent lines
#2452: FILE: hw/sh4/sh7750_regs.h:636:
+#define SH7750_BCR1_DRAMTP_2SRAM_3SDRAM 0x0008 /* Area 2 - SRAM/MPX, Area 3 -
+ synchronous DRAM */

WARNING: Block comments use a trailing */ on a separate line #2452: FILE: hw/sh4/sh7750_regs.h:636:
+ synchronous DRAM */

WARNING: line over 80 characters
#2453: FILE: hw/sh4/sh7750_regs.h:637:
+#define SH7750_BCR1_DRAMTP_2SDRAM_3SDRAM 0x000C /* Area 2 and 3 are synchronous

WARNING: Block comments use a leading /* on a separate line #2453: FILE: hw/sh4/sh7750_regs.h:637:
+#define SH7750_BCR1_DRAMTP_2SDRAM_3SDRAM 0x000C /* Area 2 and 3 are synchronous

WARNING: Block comments use * on subsequent lines
#2454: FILE: hw/sh4/sh7750_regs.h:638:
+#define SH7750_BCR1_DRAMTP_2SDRAM_3SDRAM 0x000C /* Area 2 and 3 are synchronous
+ DRAM interface */

WARNING: Block comments use a trailing */ on a separate line #2454: FILE: hw/sh4/sh7750_regs.h:638:
+ DRAM interface */

WARNING: line over 80 characters
#2455: FILE: hw/sh4/sh7750_regs.h:639:
+#define SH7750_BCR1_DRAMTP_2SRAM_3DRAM 0x0010 /* Area 2 - SRAM/MPX, Area 3 -

WARNING: Block comments use a leading /* on a separate line #2455: FILE: hw/sh4/sh7750_regs.h:639:
+#define SH7750_BCR1_DRAMTP_2SRAM_3DRAM 0x0010 /* Area 2 - SRAM/MPX, Area 3 -

WARNING: Block comments use * on subsequent lines
#2456: FILE: hw/sh4/sh7750_regs.h:640:
+#define SH7750_BCR1_DRAMTP_2SRAM_3DRAM 0x0010 /* Area 2 - SRAM/MPX, Area 3 -
+ DRAM interface */

WARNING: Block comments use a trailing */ on a separate line #2456: FILE: hw/sh4/sh7750_regs.h:640:
+ DRAM interface */

WARNING: Block comments use a leading /* on a separate line #2457: FILE: hw/sh4/sh7750_regs.h:641:
+#define SH7750_BCR1_DRAMTP_2DRAM_3DRAM 0x0014 /* Area 2 and 3 are DRAM

WARNING: Block comments use * on subsequent lines
#2458: FILE: hw/sh4/sh7750_regs.h:642:
+#define SH7750_BCR1_DRAMTP_2DRAM_3DRAM 0x0014 /* Area 2 and 3 are DRAM
+ interface */

WARNING: Block comments use a trailing */ on a separate line #2458: FILE: hw/sh4/sh7750_regs.h:642:
+ interface */

WARNING: Block comments use a leading /* on a separate line #2463: FILE: hw/sh4/sh7750_regs.h:644:
+#define SH7750_BCR1_A56PCM 0x00000001 /* Area 5 and 6 Bus Type:

WARNING: Block comments use * on subsequent lines
#2464: FILE: hw/sh4/sh7750_regs.h:645:
+#define SH7750_BCR1_A56PCM 0x00000001 /* Area 5 and 6 Bus Type:
+ 0 - SRAM interface

WARNING: Block comments use a trailing */ on a separate line #2465: FILE: hw/sh4/sh7750_regs.h:646:
+ 1 - PCMCIA interface */

WARNING: Block comments use a leading /* on a separate line #2505: FILE: hw/sh4/sh7750_regs.h:671:
+#define SH7750_BCR2_PORTEN 0x0001 /* Port Function Enable :

WARNING: Block comments use * on subsequent lines
#2506: FILE: hw/sh4/sh7750_regs.h:672:
+#define SH7750_BCR2_PORTEN 0x0001 /* Port Function Enable :
+ 0 - D51-D32 are not used as a port

WARNING: Block comments use a trailing */ on a separate line #2507: FILE: hw/sh4/sh7750_regs.h:673:
+ 1 - D51-D32 are used as a port */

WARNING: Block comments use a leading /* on a separate line #2516: FILE: hw/sh4/sh7750_regs.h:679:
+#define SH7750_WCR1_DMAIW 0x70000000 /* DACK Device Inter-Cycle Idle

WARNING: Block comments use * on subsequent lines
#2517: FILE: hw/sh4/sh7750_regs.h:680:
+#define SH7750_WCR1_DMAIW 0x70000000 /* DACK Device Inter-Cycle Idle
+ specification */

WARNING: Block comments use a trailing */ on a separate line #2517: FILE: hw/sh4/sh7750_regs.h:680:
+ specification */

WARNING: Block comments use a leading /* on a separate line #2714: FILE: hw/sh4/sh7750_regs.h:797:
+#define SH7750_MCR_TRC 0x38000000 /* RAS Precharge Time at End of

WARNING: Block comments use * on subsequent lines
#2715: FILE: hw/sh4/sh7750_regs.h:798:
+#define SH7750_MCR_TRC 0x38000000 /* RAS Precharge Time at End of
+ Refresh: */

WARNING: Block comments use a trailing */ on a separate line #2715: FILE: hw/sh4/sh7750_regs.h:798:
+ Refresh: */

WARNING: Block comments use a leading /* on a separate line #2736: FILE: hw/sh4/sh7750_regs.h:812:
+#define SH7750_MCR_TPC 0x00380000 /* DRAM: RAS Precharge Period

WARNING: Block comments use * on subsequent lines
#2737: FILE: hw/sh4/sh7750_regs.h:813:
+#define SH7750_MCR_TPC 0x00380000 /* DRAM: RAS Precharge Period
+ SDRAM: minimum number of cycles

WARNING: Block comments use a trailing */ on a separate line #2739: FILE: hw/sh4/sh7750_regs.h:815:
+ is output after precharging */

WARNING: line over 80 characters
#2768: FILE: hw/sh4/sh7750_regs.h:826:
+#define SH7750_MCR_RCD 0x00030000 /* DRAM: RAS-CAS Assertion Delay time

WARNING: Block comments use a leading /* on a separate line #2768: FILE: hw/sh4/sh7750_regs.h:826:
+#define SH7750_MCR_RCD 0x00030000 /* DRAM: RAS-CAS Assertion Delay time

WARNING: Block comments use * on subsequent lines
#2769: FILE: hw/sh4/sh7750_regs.h:827:
+#define SH7750_MCR_RCD 0x00030000 /* DRAM: RAS-CAS Assertion Delay time
+ SDRAM: bank active-read/write cmd

WARNING: Block comments use a trailing */ on a separate line #2770: FILE: hw/sh4/sh7750_regs.h:828:
+ delay time */

WARNING: Block comments use a leading /* on a separate line #2804: FILE: hw/sh4/sh7750_regs.h:844:
+#define SH7750_MCR_TRAS 0x00001C00 /* DRAM: CAS-Before-RAS Refresh RAS

WARNING: Block comments use * on subsequent lines
#2805: FILE: hw/sh4/sh7750_regs.h:845:
+#define SH7750_MCR_TRAS 0x00001C00 /* DRAM: CAS-Before-RAS Refresh RAS
+ asserting period

WARNING: Block comments use a trailing */ on a separate line #2807: FILE: hw/sh4/sh7750_regs.h:847:
+ synchronous DRAM refresh */

WARNING: Block comments use a leading /* on a separate line #2890: FILE: hw/sh4/sh7750_regs.h:901:
+#define SH7750_PCR_A5PCW 0xC000 /* Area 5 PCMCIA Wait - Number of wait

WARNING: Block comments use * on subsequent lines
#2891: FILE: hw/sh4/sh7750_regs.h:902:
+#define SH7750_PCR_A5PCW 0xC000 /* Area 5 PCMCIA Wait - Number of wait
+ states to be added to the number of

WARNING: Block comments use a trailing */ on a separate line #2893: FILE: hw/sh4/sh7750_regs.h:904:
+ PCMCIA wait cycle */

WARNING: Block comments use a leading /* on a separate line #2907: FILE: hw/sh4/sh7750_regs.h:910:
+#define SH7750_PCR_A6PCW 0x3000 /* Area 6 PCMCIA Wait - Number of wait

WARNING: Block comments use * on subsequent lines
#2908: FILE: hw/sh4/sh7750_regs.h:911:
+#define SH7750_PCR_A6PCW 0x3000 /* Area 6 PCMCIA Wait - Number of wait
+ states to be added to the number of

WARNING: Block comments use a trailing */ on a separate line #2910: FILE: hw/sh4/sh7750_regs.h:913:
+ PCMCIA wait cycle */

WARNING: line over 80 characters
#2920: FILE: hw/sh4/sh7750_regs.h:919:
+#define SH7750_PCR_A5TED 0x0E00 /* Area 5 Address-OE\/WE\ Assertion Delay,

WARNING: Block comments use a leading /* on a separate line #2920: FILE: hw/sh4/sh7750_regs.h:919:
+#define SH7750_PCR_A5TED 0x0E00 /* Area 5 Address-OE\/WE\ Assertion Delay,

WARNING: Block comments use * on subsequent lines
#2921: FILE: hw/sh4/sh7750_regs.h:920:
+#define SH7750_PCR_A5TED 0x0E00 /* Area 5 Address-OE\/WE\ Assertion Delay,
+ delay time from address output to

WARNING: Block comments use a trailing */ on a separate line #2923: FILE: hw/sh4/sh7750_regs.h:922:
+ PCMCIA interface */

WARNING: line over 80 characters
#2926: FILE: hw/sh4/sh7750_regs.h:924:
+#define SH7750_PCR_A6TED 0x01C0 /* Area 6 Address-OE\/WE\ Assertion Delay */

WARNING: line over 80 characters
#2950: FILE: hw/sh4/sh7750_regs.h:936:
+#define SH7750_PCR_A5TEH 0x0038 /* Area 5 OE\/WE\ Negation Address delay,

WARNING: Block comments use a leading /* on a separate line #2950: FILE: hw/sh4/sh7750_regs.h:936:
+#define SH7750_PCR_A5TEH 0x0038 /* Area 5 OE\/WE\ Negation Address delay,

WARNING: Block comments use * on subsequent lines
#2951: FILE: hw/sh4/sh7750_regs.h:937:
+#define SH7750_PCR_A5TEH 0x0038 /* Area 5 OE\/WE\ Negation Address delay,
+ address hold delay time from OE\/WE\

WARNING: Block comments use a trailing */ on a separate line #2953: FILE: hw/sh4/sh7750_regs.h:939:
+ PCMCIA interface */

WARNING: line over 80 characters
#2957: FILE: hw/sh4/sh7750_regs.h:942:
+#define SH7750_PCR_A6TEH 0x0007 /* Area 6 OE\/WE\ Negation Address delay */

WARNING: Block comments use a leading /* on a separate line #2998: FILE: hw/sh4/sh7750_regs.h:960:
+#define SH7750_RTCSR_CMF 0x0080 /* Compare-Match Flag (indicates a

WARNING: Block comments use * on subsequent lines
#2999: FILE: hw/sh4/sh7750_regs.h:961:
+#define SH7750_RTCSR_CMF 0x0080 /* Compare-Match Flag (indicates a
+ match between the refresh timer

WARNING: Block comments use a trailing */ on a separate line #3000: FILE: hw/sh4/sh7750_regs.h:962:
+ counter and refresh time constant) */

WARNING: Block comments use a leading /* on a separate line #3019: FILE: hw/sh4/sh7750_regs.h:975:
+#define SH7750_RTCSR_OVIE 0x0002 /* Refresh Count Overflow Interrupt

WARNING: Block comments use * on subsequent lines
#3020: FILE: hw/sh4/sh7750_regs.h:976:
+#define SH7750_RTCSR_OVIE 0x0002 /* Refresh Count Overflow Interrupt
+ Enable */

WARNING: Block comments use a trailing */ on a separate line #3020: FILE: hw/sh4/sh7750_regs.h:976:
+ Enable */

WARNING: line over 80 characters
#3021: FILE: hw/sh4/sh7750_regs.h:977:
+#define SH7750_RTCSR_LMTS 0x0001 /* Refresh Count Overflow Limit Select */

ERROR: spaces required around that '*' (ctx:VxV)
#3072: FILE: hw/sh4/sh7750_regs.h:1018:
+#define SH7750_SAR_REGOFS(n) (0xA00000 + ((n)*16)) /* offset */

                                               ^

ERROR: spaces required around that '*' (ctx:VxV)
#3081: FILE: hw/sh4/sh7750_regs.h:1031:
+#define SH7750_DAR_REGOFS(n) (0xA00004 + ((n)*16)) /* offset */

                                               ^

ERROR: spaces required around that '*' (ctx:VxV)
#3090: FILE: hw/sh4/sh7750_regs.h:1044:
+#define SH7750_DMATCR_REGOFS(n) (0xA00008 + ((n)*16)) /* offset */

                                                  ^

ERROR: spaces required around that '*' (ctx:VxV)
#3099: FILE: hw/sh4/sh7750_regs.h:1057:
+#define SH7750_CHCR_REGOFS(n) (0xA0000C + ((n)*16)) /* offset */

                                                ^

WARNING: line over 80 characters
#3124: FILE: hw/sh4/sh7750_regs.h:1077:
+#define SH7750_CHCR_SSA_AMEM16 0xE0000000 /* 16-bit attribute memory space */

WARNING: line over 80 characters
#3129: FILE: hw/sh4/sh7750_regs.h:1079:
+#define SH7750_CHCR_STC 0x10000000 /* Source Address Wait Control Select,

WARNING: Block comments use a leading /* on a separate line #3129: FILE: hw/sh4/sh7750_regs.h:1079:
+#define SH7750_CHCR_STC 0x10000000 /* Source Address Wait Control Select,

WARNING: Block comments use * on subsequent lines
#3130: FILE: hw/sh4/sh7750_regs.h:1080:
+#define SH7750_CHCR_STC 0x10000000 /* Source Address Wait Control Select,
+ specifies CS5 or CS6 space wait

WARNING: Block comments use a trailing */ on a separate line #3131: FILE: hw/sh4/sh7750_regs.h:1081:
+ control for PCMCIA access */

WARNING: line over 80 characters
#3150: FILE: hw/sh4/sh7750_regs.h:1091:
+#define SH7750_CHCR_DSA_AMEM16 0x0E000000 /* 16-bit attribute memory space */

WARNING: Block comments use a leading /* on a separate line #3156: FILE: hw/sh4/sh7750_regs.h:1093:
+#define SH7750_CHCR_DTC 0x01000000 /* Destination Address Wait Control

WARNING: Block comments use * on subsequent lines
#3157: FILE: hw/sh4/sh7750_regs.h:1094:
+#define SH7750_CHCR_DTC 0x01000000 /* Destination Address Wait Control
+ Select, specifies CS5 or CS6

WARNING: Block comments use a trailing */ on a separate line #3159: FILE: hw/sh4/sh7750_regs.h:1096:
+ access */

WARNING: line over 80 characters
#3179: FILE: hw/sh4/sh7750_regs.h:1107:
+#define SH7750_CHCR_AM_RD 0x00000000 /* DACK is output in read cycle */

WARNING: line over 80 characters
#3180: FILE: hw/sh4/sh7750_regs.h:1108:
+#define SH7750_CHCR_AM_WR 0x00020000 /* DACK is output in write cycle */

WARNING: line over 80 characters
#3195: FILE: hw/sh4/sh7750_regs.h:1116:
+#define SH7750_CHCR_DM_INC 0x00004000 /* Destination Addr Incremented */

WARNING: line over 80 characters
#3196: FILE: hw/sh4/sh7750_regs.h:1117:
+#define SH7750_CHCR_DM_DEC 0x00008000 /* Destination Addr Decremented */

WARNING: line over 80 characters
#3221: FILE: hw/sh4/sh7750_regs.h:1125:
+#define SH7750_CHCR_RS_ER_DA_EA_TO_EA 0x000 /* External Request, Dual Address

WARNING: Block comments use a leading /* on a separate line #3221: FILE: hw/sh4/sh7750_regs.h:1125:
+#define SH7750_CHCR_RS_ER_DA_EA_TO_EA 0x000 /* External Request, Dual Address

WARNING: Block comments use * on subsequent lines
#3222: FILE: hw/sh4/sh7750_regs.h:1126:
+#define SH7750_CHCR_RS_ER_DA_EA_TO_EA 0x000 /* External Request, Dual Address
+ Mode (External Addr Space->

WARNING: Block comments use a trailing */ on a separate line #3223: FILE: hw/sh4/sh7750_regs.h:1127:
+ External Addr Space) */

WARNING: Block comments use a leading /* on a separate line #3224: FILE: hw/sh4/sh7750_regs.h:1128:
+#define SH7750_CHCR_RS_ER_SA_EA_TO_ED 0x200 /* External Request, Single

WARNING: Block comments use * on subsequent lines
#3225: FILE: hw/sh4/sh7750_regs.h:1129:
+#define SH7750_CHCR_RS_ER_SA_EA_TO_ED 0x200 /* External Request, Single
+ Address Mode (External Addr

WARNING: Block comments use a trailing */ on a separate line #3226: FILE: hw/sh4/sh7750_regs.h:1130:
+ Space -> External Device) */

WARNING: Block comments use a leading /* on a separate line #3227: FILE: hw/sh4/sh7750_regs.h:1131:
+#define SH7750_CHCR_RS_ER_SA_ED_TO_EA 0x300 /* External Request, Single

WARNING: Block comments use * on subsequent lines
#3228: FILE: hw/sh4/sh7750_regs.h:1132:
+#define SH7750_CHCR_RS_ER_SA_ED_TO_EA 0x300 /* External Request, Single
+ Address Mode, (External

WARNING: Block comments use a trailing */ on a separate line #3230: FILE: hw/sh4/sh7750_regs.h:1134:
+ Space) */

WARNING: Block comments use a leading /* on a separate line #3231: FILE: hw/sh4/sh7750_regs.h:1135:
+#define SH7750_CHCR_RS_AR_EA_TO_EA 0x400 /* Auto-Request (External Addr

WARNING: Block comments use * on subsequent lines
#3232: FILE: hw/sh4/sh7750_regs.h:1136:
+#define SH7750_CHCR_RS_AR_EA_TO_EA 0x400 /* Auto-Request (External Addr
+ Space -> External Addr Space) */

WARNING: Block comments use a trailing */ on a separate line #3232: FILE: hw/sh4/sh7750_regs.h:1136:
+ Space -> External Addr Space) */

WARNING: Block comments use a leading /* on a separate line #3264: FILE: hw/sh4/sh7750_regs.h:1138:
+#define SH7750_CHCR_RS_AR_EA_TO_OCP 0x500 /* Auto-Request (External Addr

WARNING: Block comments use * on subsequent lines
#3265: FILE: hw/sh4/sh7750_regs.h:1139:
+#define SH7750_CHCR_RS_AR_EA_TO_OCP 0x500 /* Auto-Request (External Addr
+ Space -> On-chip Peripheral

WARNING: Block comments use a trailing */ on a separate line #3266: FILE: hw/sh4/sh7750_regs.h:1140:
+ Module) */

WARNING: Block comments use a leading /* on a separate line #3267: FILE: hw/sh4/sh7750_regs.h:1141:
+#define SH7750_CHCR_RS_AR_OCP_TO_EA 0x600 /* Auto-Request (On-chip

WARNING: Block comments use * on subsequent lines
#3268: FILE: hw/sh4/sh7750_regs.h:1142:
+#define SH7750_CHCR_RS_AR_OCP_TO_EA 0x600 /* Auto-Request (On-chip
+ Peripheral Module ->

WARNING: Block comments use a trailing */ on a separate line #3269: FILE: hw/sh4/sh7750_regs.h:1143:
+ External Addr Space */

WARNING: Block comments use a leading /* on a separate line #3270: FILE: hw/sh4/sh7750_regs.h:1144:
+#define SH7750_CHCR_RS_SCITX_EA_TO_SC 0x800 /* SCI Transmit-Data-Empty intr

WARNING: Block comments use * on subsequent lines
#3271: FILE: hw/sh4/sh7750_regs.h:1145:
+#define SH7750_CHCR_RS_SCITX_EA_TO_SC 0x800 /* SCI Transmit-Data-Empty intr
+ transfer request (external

WARNING: Block comments use a trailing */ on a separate line #3272: FILE: hw/sh4/sh7750_regs.h:1146:
+ address space -> SCTDR1) */

WARNING: Block comments use a leading /* on a separate line #3273: FILE: hw/sh4/sh7750_regs.h:1147:
+#define SH7750_CHCR_RS_SCIRX_SC_TO_EA 0x900 /* SCI Receive-Data-Full intr

WARNING: Block comments use * on subsequent lines
#3274: FILE: hw/sh4/sh7750_regs.h:1148:
+#define SH7750_CHCR_RS_SCIRX_SC_TO_EA 0x900 /* SCI Receive-Data-Full intr
+ transfer request (SCRDR1 ->

WARNING: Block comments use a trailing */ on a separate line #3275: FILE: hw/sh4/sh7750_regs.h:1149:
+ External Addr Space) */

WARNING: line over 80 characters
#3276: FILE: hw/sh4/sh7750_regs.h:1150:
+#define SH7750_CHCR_RS_SCIFTX_EA_TO_SC 0xA00 /* SCIF Transmit-Data-Empty intr

WARNING: Block comments use a leading /* on a separate line #3276: FILE: hw/sh4/sh7750_regs.h:1150:
+#define SH7750_CHCR_RS_SCIFTX_EA_TO_SC 0xA00 /* SCIF Transmit-Data-Empty intr

WARNING: Block comments use * on subsequent lines
#3277: FILE: hw/sh4/sh7750_regs.h:1151:
+#define SH7750_CHCR_RS_SCIFTX_EA_TO_SC 0xA00 /* SCIF Transmit-Data-Empty intr
+ transfer request (external

WARNING: Block comments use a trailing */ on a separate line #3278: FILE: hw/sh4/sh7750_regs.h:1152:
+ address space -> SCFTDR1) */

WARNING: Block comments use a leading /* on a separate line #3279: FILE: hw/sh4/sh7750_regs.h:1153:
+#define SH7750_CHCR_RS_SCIFRX_SC_TO_EA 0xB00 /* SCIF Receive-Data-Full intr

WARNING: Block comments use * on subsequent lines
#3280: FILE: hw/sh4/sh7750_regs.h:1154:
+#define SH7750_CHCR_RS_SCIFRX_SC_TO_EA 0xB00 /* SCIF Receive-Data-Full intr
+ transfer request (SCFRDR2 ->

WARNING: Block comments use a trailing */ on a separate line #3281: FILE: hw/sh4/sh7750_regs.h:1155:
+ External Addr Space) */

WARNING: Block comments use a leading /* on a separate line #3282: FILE: hw/sh4/sh7750_regs.h:1156:
+#define SH7750_CHCR_RS_TMU2_EA_TO_EA 0xC00 /* TMU Channel 2 (input capture

WARNING: Block comments use * on subsequent lines
#3283: FILE: hw/sh4/sh7750_regs.h:1157:
+#define SH7750_CHCR_RS_TMU2_EA_TO_EA 0xC00 /* TMU Channel 2 (input capture
+ interrupt), (external address

WARNING: Block comments use a trailing */ on a separate line #3285: FILE: hw/sh4/sh7750_regs.h:1159:
+ space) */

WARNING: Block comments use a leading /* on a separate line #3286: FILE: hw/sh4/sh7750_regs.h:1160:
+#define SH7750_CHCR_RS_TMU2_EA_TO_OCP 0xD00 /* TMU Channel 2 (input capture

WARNING: Block comments use * on subsequent lines
#3287: FILE: hw/sh4/sh7750_regs.h:1161:
+#define SH7750_CHCR_RS_TMU2_EA_TO_OCP 0xD00 /* TMU Channel 2 (input capture
+ interrupt), (external address

WARNING: Block comments use a trailing */ on a separate line #3289: FILE: hw/sh4/sh7750_regs.h:1163:
+ module) */

WARNING: Block comments use a leading /* on a separate line #3290: FILE: hw/sh4/sh7750_regs.h:1164:
+#define SH7750_CHCR_RS_TMU2_OCP_TO_EA 0xE00 /* TMU Channel 2 (input capture

WARNING: Block comments use * on subsequent lines
#3291: FILE: hw/sh4/sh7750_regs.h:1165:
+#define SH7750_CHCR_RS_TMU2_OCP_TO_EA 0xE00 /* TMU Channel 2 (input capture
+ interrupt), (on-chip

WARNING: Block comments use a trailing */ on a separate line #3293: FILE: hw/sh4/sh7750_regs.h:1167:
+ address space) */

ERROR: spaces required around that '*' (ctx:VxV)
#3365: FILE: hw/sh4/sh7750_regs.h:1211:
+#define SH7750_PCTRA_PBNPUP(n) (1 << ((n)*2+1)) /* Bit n is not pulled up */

                                          ^

ERROR: spaces required around that '+' (ctx:VxV)
#3365: FILE: hw/sh4/sh7750_regs.h:1211:
+#define SH7750_PCTRA_PBNPUP(n) (1 << ((n)*2+1)) /* Bit n is not pulled up */

                                            ^

ERROR: spaces required around that '*' (ctx:VxV)
#3367: FILE: hw/sh4/sh7750_regs.h:1213:
+#define SH7750_PCTRA_PBOUT(n) (1 << ((n)*2)) /* Bit n is an output */

                                         ^

WARNING: line over 80 characters
#3388: FILE: hw/sh4/sh7750_regs.h:1228:
+#define SH7750_PCTRB_PBNPUP(n) (1 << ((n-16)*2+1)) /* Bit n is not pulled up */

ERROR: spaces required around that '-' (ctx:VxV)
#3388: FILE: hw/sh4/sh7750_regs.h:1228:
+#define SH7750_PCTRB_PBNPUP(n) (1 << ((n-16)*2+1)) /* Bit n is not pulled up */

                                         ^

ERROR: spaces required around that '*' (ctx:VxV)
#3388: FILE: hw/sh4/sh7750_regs.h:1228:
+#define SH7750_PCTRB_PBNPUP(n) (1 << ((n-16)*2+1)) /* Bit n is not pulled up */

                                             ^

ERROR: spaces required around that '+' (ctx:VxV)
#3388: FILE: hw/sh4/sh7750_regs.h:1228:
+#define SH7750_PCTRB_PBNPUP(n) (1 << ((n-16)*2+1)) /* Bit n is not pulled up */

                                               ^

ERROR: spaces required around that '-' (ctx:VxV)
#3390: FILE: hw/sh4/sh7750_regs.h:1230:
+#define SH7750_PCTRB_PBOUT(n) (1 << ((n-16)*2)) /* Bit n is an output */

                                        ^

ERROR: spaces required around that '*' (ctx:VxV)
#3390: FILE: hw/sh4/sh7750_regs.h:1230:
+#define SH7750_PCTRB_PBOUT(n) (1 << ((n-16)*2)) /* Bit n is an output */

                                            ^

WARNING: Block comments use a leading /* on a separate line #3429: FILE: hw/sh4/sh7750_regs.h:1258:
+#define SH7750_ICR_NMIB_BLK 0x0000 /* NMI requests held pending while

WARNING: Block comments use * on subsequent lines
#3430: FILE: hw/sh4/sh7750_regs.h:1259:
+#define SH7750_ICR_NMIB_BLK 0x0000 /* NMI requests held pending while
+ SR.BL bit is set to 1 */

WARNING: Block comments use a trailing */ on a separate line #3430: FILE: hw/sh4/sh7750_regs.h:1259:
+ SR.BL bit is set to 1 */

WARNING: line over 80 characters
#3431: FILE: hw/sh4/sh7750_regs.h:1260:
+#define SH7750_ICR_NMIB_NBLK 0x0200 /* NMI requests detected when SR.BL bit

WARNING: Block comments use a leading /* on a separate line #3431: FILE: hw/sh4/sh7750_regs.h:1260:
+#define SH7750_ICR_NMIB_NBLK 0x0200 /* NMI requests detected when SR.BL bit

WARNING: Block comments use * on subsequent lines
#3432: FILE: hw/sh4/sh7750_regs.h:1261:
+#define SH7750_ICR_NMIB_NBLK 0x0200 /* NMI requests detected when SR.BL bit
+ set to 1 */

WARNING: Block comments use a trailing */ on a separate line #3432: FILE: hw/sh4/sh7750_regs.h:1261:
+ set to 1 */

WARNING: line over 80 characters
#3440: FILE: hw/sh4/sh7750_regs.h:1264:
+#define SH7750_ICR_NMIE_FALL 0x0000 /* Interrupt request detected on falling

WARNING: Block comments use a leading /* on a separate line #3440: FILE: hw/sh4/sh7750_regs.h:1264:
+#define SH7750_ICR_NMIE_FALL 0x0000 /* Interrupt request detected on falling

WARNING: Block comments use * on subsequent lines
#3441: FILE: hw/sh4/sh7750_regs.h:1265:
+#define SH7750_ICR_NMIE_FALL 0x0000 /* Interrupt request detected on falling
+ edge of NMI input */

WARNING: Block comments use a trailing */ on a separate line #3441: FILE: hw/sh4/sh7750_regs.h:1265:
+ edge of NMI input */

WARNING: line over 80 characters
#3442: FILE: hw/sh4/sh7750_regs.h:1266:
+#define SH7750_ICR_NMIE_RISE 0x0100 /* Interrupt request detected on rising

WARNING: Block comments use a leading /* on a separate line #3442: FILE: hw/sh4/sh7750_regs.h:1266:
+#define SH7750_ICR_NMIE_RISE 0x0100 /* Interrupt request detected on rising

WARNING: Block comments use * on subsequent lines
#3443: FILE: hw/sh4/sh7750_regs.h:1267:
+#define SH7750_ICR_NMIE_RISE 0x0100 /* Interrupt request detected on rising
+ edge of NMI input */

WARNING: Block comments use a trailing */ on a separate line #3443: FILE: hw/sh4/sh7750_regs.h:1267:
+ edge of NMI input */

WARNING: Block comments use a leading /* on a separate line #3451: FILE: hw/sh4/sh7750_regs.h:1270:
+#define SH7750_ICR_IRLM_ENC 0x0000 /* IRL\ pins used as a level-encoded

WARNING: Block comments use * on subsequent lines
#3452: FILE: hw/sh4/sh7750_regs.h:1271:
+#define SH7750_ICR_IRLM_ENC 0x0000 /* IRL\ pins used as a level-encoded
+ interrupt requests */

WARNING: Block comments use a trailing */ on a separate line #3452: FILE: hw/sh4/sh7750_regs.h:1271:
+ interrupt requests */

WARNING: line over 80 characters
#3453: FILE: hw/sh4/sh7750_regs.h:1272:
+#define SH7750_ICR_IRLM_RAW 0x0080 /* IRL\ pins used as a four independent

WARNING: Block comments use a leading /* on a separate line #3453: FILE: hw/sh4/sh7750_regs.h:1272:
+#define SH7750_ICR_IRLM_RAW 0x0080 /* IRL\ pins used as a four independent

WARNING: Block comments use * on subsequent lines
#3454: FILE: hw/sh4/sh7750_regs.h:1273:
+#define SH7750_ICR_IRLM_RAW 0x0080 /* IRL\ pins used as a four independent
+ interrupt requests */

WARNING: Block comments use a trailing */ on a separate line #3454: FILE: hw/sh4/sh7750_regs.h:1273:
+ interrupt requests */

WARNING: line over 80 characters
#3658: FILE: linux-user/sh4/termbits.h:139:
+#define TARGET_CMSPAR 010000000000 /* mark or space (stick) parity */

ERROR: suspect code indent for conditional statements (4, 4) #3862: FILE: target/sh4/helper.c:98:

     if (qemu_loglevel_mask(CPU_LOG_INT)) {

+ const char *expname;

ERROR: switch and case should be at the same indent #3865: FILE: target/sh4/helper.c:100:

         switch (cs->exception_index) {

+ case 0x0e0:
[...]
+ case 0x040:
[...]
+ case 0x0a0:
[...]
+ case 0x180:
[...]
+ case 0x1a0:
[...]
+ case 0x800:
[...]
+ case 0x820:
[...]
+ case 0x100:
[...]
+ case 0x060:
[...]
+ case 0x0c0:
[...]
+ case 0x120:
[...]
+ case 0x080:
[...]
+ case 0x160:
[...]
+ default:

ERROR: suspect code indent for conditional statements (4, 4) #4001: FILE: target/sh4/helper.c:220:

     if ((env->mmucr & 0xe0000000) == 0xe0000000) {

+ return 0;

ERROR: suspect code indent for conditional statements (4, 4) #4005: FILE: target/sh4/helper.c:223:

     if ((env->mmucr & 0x98000000) == 0x18000000) {

+ return 1;

ERROR: suspect code indent for conditional statements (4, 4) #4009: FILE: target/sh4/helper.c:226:

     if ((env->mmucr & 0x54000000) == 0x04000000) {

+ return 2;

ERROR: suspect code indent for conditional statements (4, 4) #4013: FILE: target/sh4/helper.c:229:

     if ((env->mmucr & 0x2c000000) == 0x00000000) {

+ return 3;

ERROR: "foo * bar" should be "foo *bar"
#4024: FILE: target/sh4/helper.c:239:
+ tlb_t * entries, uint8_t nbtlb, int use_asid)

ERROR: suspect code indent for conditional statements (4, 4) #4031: FILE: target/sh4/helper.c:248:

     for (i = 0; i < nbtlb; i++) {

+ if (!entries[i].v)

ERROR: braces {} are necessary for all arms of this statement #4043: FILE: target/sh4/helper.c:249:
+ if (!entries[i].v)
[...]

ERROR: braces {} are necessary for all arms of this statement #4045: FILE: target/sh4/helper.c:251:
+ if (!entries[i].sh && use_asid && entries[i].asid != asid)
[...]

ERROR: suspect code indent for conditional statements (8, 8) #4050: FILE: target/sh4/helper.c:256:
+ if (match != MMU_DTLB_MISS)
+ return MMU_DTLB_MULTIPLE; /* Multiple match */

ERROR: braces {} are necessary for all arms of this statement #4050: FILE: target/sh4/helper.c:256:
+ if (match != MMU_DTLB_MISS)
[...]

ERROR: suspect code indent for conditional statements (4, 4) #4060: FILE: target/sh4/helper.c:272:

     if ((urb > 0 && urc > urb) || urc > (UTLB_SIZE - 1))

+ urc = 0;

ERROR: suspect code indent for conditional statements (4, 4) #4069: FILE: target/sh4/helper.c:304:

     if (e == MMU_DTLB_MULTIPLE) {

+ e = MMU_ITLB_MULTIPLE;

ERROR: suspect code indent for conditional statements (4, 4) #4072: FILE: target/sh4/helper.c:306:

     } else if (e == MMU_DTLB_MISS) {

+ e = MMU_ITLB_MISS;

ERROR: suspect code indent for conditional statements (4, 4) #4075: FILE: target/sh4/helper.c:308:

     } else if (e >= 0) {

+ update_itlb_use(env, e);

ERROR: "foo * bar" should be "foo *bar"
#4105: FILE: target/sh4/helper.c:620:
+ tlb_t * utlb_match_entry = NULL;

ERROR: suspect code indent for conditional statements (12, 12) #4113: FILE: target/sh4/helper.c:626:

             if (!entry->v)

+ continue;

ERROR: suspect code indent for conditional statements (12, 12) #4117: FILE: target/sh4/helper.c:629:

             if (entry->vpn == vpn

[...]
+ if (utlb_match_entry) {

ERROR: braces {} are necessary for all arms of this statement #4140: FILE: target/sh4/helper.c:639:
+ if (entry->v && !v)
[...]

ERROR: suspect code indent for conditional statements (12, 12) #4154: FILE: target/sh4/helper.c:651:

             if (entry->vpn == vpn

[...]
+ if (entry->v && !v)

ERROR: suspect code indent for conditional statements (12, 12) #4165: FILE: target/sh4/helper.c:653:
+ if (entry->v && !v)
+ needs_tlb_flush = 1;

ERROR: braces {} are necessary for all arms of this statement #4165: FILE: target/sh4/helper.c:653:
+ if (entry->v && !v)
[...]

ERROR: suspect code indent for conditional statements (12, 12) #4167: FILE: target/sh4/helper.c:655:
+ if (utlb_match_entry)
+ *entry = *utlb_match_entry;

ERROR: braces {} are necessary for all arms of this statement #4167: FILE: target/sh4/helper.c:655:
+ if (utlb_match_entry)
[...]
+ else
[...]

ERROR: braces {} are necessary for all arms of this statement #4237: FILE: target/sh4/op_helper.c:134:
+ if (current == NULL)
[...]

ERROR: that open brace { should be on the previous line #4251: FILE: target/sh4/op_helper.c:145:
+ if ((a & ~0x1F) == (address & ~0x1F))
+ {

ERROR: trailing whitespace
#4260: FILE: target/sh4/op_helper.c:149:
+ $

ERROR: that open brace { should be on the previous line #4261: FILE: target/sh4/op_helper.c:150:
+ if (next == NULL)
+ {

ERROR: suspect code indent for conditional statements (8, 8) #4261: FILE: target/sh4/op_helper.c:150:
+ if (next == NULL)
+ {

ERROR: suspect code indent for conditional statements (4, 4) #4279: FILE: target/sh4/op_helper.c:170:

     if (env->sr & (1u << SR_S)) {

+ if (res < 0)

ERROR: braces {} are necessary for all arms of this statement #4284: FILE: target/sh4/op_helper.c:171:
+ if (res < 0)
[...]
+ else
[...]

ERROR: suspect code indent for conditional statements (4, 4) #4294: FILE: target/sh4/op_helper.c:186:

     if (env->sr & (1u << SR_S)) {

+ if (res < -0x80000000) {

ERROR: suspect code indent for conditional statements (4, 4) #4315: FILE: target/sh4/op_helper.c:200:

     if ((val & FPSCR_RM_MASK) == FPSCR_RM_ZERO) {

+ set_float_rounding_mode(float_round_to_zero, &env->fp_status);

ERROR: suspect code indent for conditional statements (4, 4) #4365: FILE: target/sh4/translate.c:262:

     if (ctx->delayed_pc == -1) {

+ /* Target is not statically known, it comes necessarily from a

WARNING: Block comments use a leading /* on a separate line #4369: FILE: target/sh4/translate.c:263:
+ /* Target is not statically known, it comes necessarily from a

WARNING: Block comments use * on subsequent lines
#4370: FILE: target/sh4/translate.c:264:
+ /* Target is not statically known, it comes necessarily from a
+ delayed jump as immediate jump are conditinal jumps */

WARNING: Block comments use a trailing */ on a separate line #4370: FILE: target/sh4/translate.c:264:
+ delayed jump as immediate jump are conditinal jumps */

ERROR: that open brace { should be on the previous line #4387: FILE: target/sh4/translate.c:423:

     if (ctx->has_movcal)

+ {

ERROR: suspect code indent for conditional statements (4, 6) #4387: FILE: target/sh4/translate.c:423:

     if (ctx->has_movcal)

+ {

ERROR: suspect code indent for conditional statements (6, 18) #4395: FILE: target/sh4/translate.c:426:
+ if (opcode != 0x0093 /* ocbi */
[...]
+ {

ERROR: externs should be avoided in .c files
#4422: FILE: target/sh4/translate.c:445:
+ CHECK_NOT_DELAY_SLOT

ERROR: space prohibited after that '-' (ctx:WxW)
#4432: FILE: target/sh4/translate.c:448:

+    ctx->delayed_pc = (uint32_t) - 1;
                                  ^

ERROR: externs should be avoided in .c files
#4450: FILE: target/sh4/translate.c:461:
+ CHECK_PRIVILEGED

ERROR: externs should be avoided in .c files
#4459: FILE: target/sh4/translate.c:466:
+ CHECK_NOT_DELAY_SLOT

ERROR: space prohibited after that '-' (ctx:WxW)
#4465: FILE: target/sh4/translate.c:470:

+    ctx->delayed_pc = (uint32_t) - 1;
                                  ^

ERROR: externs should be avoided in .c files
#4506: FILE: target/sh4/translate.c:497:
+ CHECK_PRIVILEGED

ERROR: externs should be avoided in .c files
#4598: FILE: target/sh4/translate.c:556:
+ CHECK_NOT_DELAY_SLOT

WARNING: line over 80 characters
#4672: FILE: target/sh4/translate.c:591:
+ tcg_gen_mov_i32(REG(B11_8), addr); /* modify register status */

ERROR: space prohibited after that open parenthesis '(' #4739: FILE: target/sh4/translate.c:615:
+ if ( B11_8 != B7_4 )

ERROR: space prohibited before that close parenthesis ')' #4739: FILE: target/sh4/translate.c:615:
+ if ( B11_8 != B7_4 )

ERROR: braces {} are necessary for all arms of this statement #4739: FILE: target/sh4/translate.c:615:
+ if ( B11_8 != B7_4 )
[...]

ERROR: space prohibited after that open parenthesis '(' #4744: FILE: target/sh4/translate.c:620:
+ if ( B11_8 != B7_4 )

ERROR: space prohibited before that close parenthesis ')' #4744: FILE: target/sh4/translate.c:620:
+ if ( B11_8 != B7_4 )

ERROR: braces {} are necessary for all arms of this statement #4744: FILE: target/sh4/translate.c:620:
+ if ( B11_8 != B7_4 )
[...]

ERROR: space prohibited after that open parenthesis '(' #4749: FILE: target/sh4/translate.c:625:
+ if ( B11_8 != B7_4 )

ERROR: space prohibited before that close parenthesis ')' #4749: FILE: target/sh4/translate.c:625:
+ if ( B11_8 != B7_4 )

ERROR: braces {} are necessary for all arms of this statement #4749: FILE: target/sh4/translate.c:625:
+ if ( B11_8 != B7_4 )
[...]

ERROR: externs should be avoided in .c files
#5462: FILE: target/sh4/translate.c:1185:
+ CHECK_NOT_DELAY_SLOT

ERROR: externs should be avoided in .c files
#5469: FILE: target/sh4/translate.c:1189:
+ CHECK_NOT_DELAY_SLOT

ERROR: externs should be avoided in .c files
#5478: FILE: target/sh4/translate.c:1195:
+ CHECK_NOT_DELAY_SLOT

ERROR: externs should be avoided in .c files
#5485: FILE: target/sh4/translate.c:1199:
+ CHECK_NOT_DELAY_SLOT

ERROR: externs should be avoided in .c files
#5689: FILE: target/sh4/translate.c:1310:
+ CHECK_NOT_DELAY_SLOT

ERROR: externs should be avoided in .c files
#5774: FILE: target/sh4/translate.c:1356:
+ CHECK_PRIVILEGED

ERROR: externs should be avoided in .c files
#5778: FILE: target/sh4/translate.c:1360:
+ CHECK_PRIVILEGED

ERROR: externs should be avoided in .c files
#5794: FILE: target/sh4/translate.c:1365:
+ CHECK_PRIVILEGED

ERROR: externs should be avoided in .c files
#5817: FILE: target/sh4/translate.c:1382:
+ CHECK_NOT_DELAY_SLOT

ERROR: space prohibited after that '-' (ctx:WxW)
#5824: FILE: target/sh4/translate.c:1385:

+    ctx->delayed_pc = (uint32_t) - 1;
                                  ^

ERROR: externs should be avoided in .c files
#5827: FILE: target/sh4/translate.c:1388:
+ CHECK_NOT_DELAY_SLOT

ERROR: space prohibited after that '-' (ctx:WxW)
#5835: FILE: target/sh4/translate.c:1392:

+    ctx->delayed_pc = (uint32_t) - 1;
                                  ^

ERROR: externs should be avoided in .c files
#5857: FILE: target/sh4/translate.c:1405:
+ CHECK_NOT_DELAY_SLOT

ERROR: space prohibited after that '-' (ctx:WxW)
#5864: FILE: target/sh4/translate.c:1408:

+    ctx->delayed_pc = (uint32_t) - 1;
                                  ^

ERROR: externs should be avoided in .c files
#5867: FILE: target/sh4/translate.c:1411:
+ CHECK_NOT_DELAY_SLOT

ERROR: space prohibited after that '-' (ctx:WxW)
#5876: FILE: target/sh4/translate.c:1415:

+    ctx->delayed_pc = (uint32_t) - 1;
                                  ^

ERROR: externs should be avoided in .c files
#5912: FILE: target/sh4/translate.c:1440:
+ CHECK_PRIVILEGED

ERROR: space required after that ',' (ctx:VxV)
#5945: FILE: target/sh4/translate.c:1456:

+#define LD(reg,ldnum,ldpnum,prechk)        \
               ^

ERROR: space required after that ',' (ctx:VxV)
#5945: FILE: target/sh4/translate.c:1456:

+#define LD(reg,ldnum,ldpnum,prechk)        \
                     ^

ERROR: space required after that ',' (ctx:VxV)
#5945: FILE: target/sh4/translate.c:1456:

+#define LD(reg,ldnum,ldpnum,prechk)        \
                            ^

ERROR: Macros with multiple statements should be enclosed in a do - while loop #5945: FILE: target/sh4/translate.c:1456:
+#define LD(reg,ldnum,ldpnum,prechk) \
+ case ldnum: \

+    prechk                                \
+    tcg_gen_mov_i32 (cpu_##reg, REG(B11_8));            \
+    return;                            \
+  case ldpnum:                            \
+    prechk                                \
     tcg_gen_qemu_ld_i32(cpu_##reg, REG(B11_8), ctx->memidx, MO_TESL); \
-    tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4);               \
+    tcg_gen_addi_i32(REG(B11_8), REG(B11_8), 4);        \
     return;

ERROR: space prohibited between function name and open parenthesis '(' #5948: FILE: target/sh4/translate.c:1459:
+ tcg_gen_mov_i32 (cpu_##reg, REG(B11_8)); \

ERROR: space required after that ',' (ctx:VxV)
#5966: FILE: target/sh4/translate.c:1466:

+#define ST(reg,stnum,stpnum,prechk)        \
               ^

ERROR: space required after that ',' (ctx:VxV)
#5966: FILE: target/sh4/translate.c:1466:

+#define ST(reg,stnum,stpnum,prechk)        \
                     ^

ERROR: space required after that ',' (ctx:VxV)
#5966: FILE: target/sh4/translate.c:1466:

+#define ST(reg,stnum,stpnum,prechk)        \
                            ^

ERROR: Macros with multiple statements should be enclosed in a do - while loop #5966: FILE: target/sh4/translate.c:1466:
+#define ST(reg,stnum,stpnum,prechk) \
+ case stnum: \

+    prechk                                \
+    tcg_gen_mov_i32 (REG(B11_8), cpu_##reg);            \
+    return;                            \
+  case stpnum:                            \
+    prechk                                \
+    {                                \
+    TCGv addr = tcg_temp_new();                \
+    tcg_gen_subi_i32(addr, REG(B11_8), 4);            \
         tcg_gen_qemu_st_i32(cpu_##reg, addr, ctx->memidx, MO_TEUL); \
-       tcg_gen_mov_i32(REG(B11_8), addr);                      \
-       tcg_temp_free(addr);                                    \
-    }                                                          \
+    tcg_gen_mov_i32(REG(B11_8), addr);            \
+    tcg_temp_free(addr);                    \
+    }                                \
     return;

ERROR: space prohibited between function name and open parenthesis '(' #5969: FILE: target/sh4/translate.c:1469:
+ tcg_gen_mov_i32 (REG(B11_8), cpu_##reg); \

ERROR: space required after that ',' (ctx:VxV)
#5992: FILE: target/sh4/translate.c:1481:

+#define LDST(reg,ldnum,ldpnum,stnum,stpnum,prechk)        \
                 ^

ERROR: space required after that ',' (ctx:VxV)
#5992: FILE: target/sh4/translate.c:1481:

+#define LDST(reg,ldnum,ldpnum,stnum,stpnum,prechk)        \
                       ^

ERROR: space required after that ',' (ctx:VxV)
#5992: FILE: target/sh4/translate.c:1481:

+#define LDST(reg,ldnum,ldpnum,stnum,stpnum,prechk)        \
                              ^

ERROR: space required after that ',' (ctx:VxV)
#5992: FILE: target/sh4/translate.c:1481:

+#define LDST(reg,ldnum,ldpnum,stnum,stpnum,prechk)        \
                                    ^

ERROR: space required after that ',' (ctx:VxV)
#5992: FILE: target/sh4/translate.c:1481:

+#define LDST(reg,ldnum,ldpnum,stnum,stpnum,prechk)        \
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#5993: FILE: target/sh4/translate.c:1482:

+    LD(reg,ldnum,ldpnum,prechk)                \
           ^

ERROR: space required after that ',' (ctx:VxV)
#5993: FILE: target/sh4/translate.c:1482:

+    LD(reg,ldnum,ldpnum,prechk)                \
                 ^

ERROR: space required after that ',' (ctx:VxV)
#5993: FILE: target/sh4/translate.c:1482:

+    LD(reg,ldnum,ldpnum,prechk)                \
                        ^

ERROR: space required after that ',' (ctx:VxV)
#5994: FILE: target/sh4/translate.c:1483:
+ ST(reg,stnum,stpnum,prechk)

           ^

ERROR: space required after that ',' (ctx:VxV)
#5994: FILE: target/sh4/translate.c:1483:
+ ST(reg,stnum,stpnum,prechk)

                 ^

ERROR: space required after that ',' (ctx:VxV)
#5994: FILE: target/sh4/translate.c:1483:
+ ST(reg,stnum,stpnum,prechk)

                        ^

ERROR: externs should be avoided in .c files
#6014: FILE: target/sh4/translate.c:1496:
+ CHECK_FPU_ENABLED

ERROR: externs should be avoided in .c files
#6051: FILE: target/sh4/translate.c:1512:
+ CHECK_FPU_ENABLED

ERROR: externs should be avoided in .c files
#6255: FILE: target/sh4/translate.c:1708:
+ CHECK_FPU_ENABLED

ERROR: externs should be avoided in .c files
#6261: FILE: target/sh4/translate.c:1712:
+ CHECK_FPU_ENABLED

ERROR: suspect code indent for conditional statements (8, 8) #6268: FILE: target/sh4/translate.c:1717:

         if (ctx->tbflags & FPSCR_PR) {

+ TCGv_i64 fp;

ERROR: else should follow close brace '}'
#6283: FILE: target/sh4/translate.c:1727:
+ }
+ else {

ERROR: suspect code indent for conditional statements (8, 8) #6292: FILE: target/sh4/translate.c:1733:

         if (ctx->tbflags & FPSCR_PR) {

+ TCGv_i64 fp;

ERROR: else should follow close brace '}'
#6307: FILE: target/sh4/translate.c:1743:
+ }
+ else {

ERROR: externs should be avoided in .c files
#6315: FILE: target/sh4/translate.c:1748:
+ CHECK_FPU_ENABLED

ERROR: externs should be avoided in .c files
#6321: FILE: target/sh4/translate.c:1752:
+ CHECK_FPU_ENABLED

ERROR: suspect code indent for conditional statements (8, 8) #6401: FILE: target/sh4/translate.c:1879:

         if (old_flags & DELAY_SLOT_CONDITIONAL) {

+ gen_delayed_conditional_jump(ctx);

total: 172 errors, 318 warnings, 6252 lines checked

Commit 60b042546abd (sh4: Replace TAB indentations with spaces) has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]

#2 lore raw
In reply to Ahmed Abouzied
Quoted 6 lines · Ahmed Abouzied

Replaces TABs with spaces, making sure to have a consistent coding style of 4 space indentations in the SH4 subsystem.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/376
---

...

Quoted 5 lines
target/sh4/translate.c +0 -1
@@ -1705,101 +1705,101 @@ static void _decode_opc(DisasContext * ctx)
          }
          return;
      case 0xf00d: /* fsts FPUL,FRn - FPSCR: Nothing */
-	CHECK_FPU_ENABLED

target/sh4/translate.c static void _decode_opc(DisasContext * ctx) · line 1714

Quoted 10 lines
target/sh4/translate.c +4 -3
+    CHECK_FPU_ENABLED
          tcg_gen_mov_i32(FREG(B11_8), cpu_fpul);
-	return;
+    return;
      case 0xf01d: /* flds FRm,FPUL - FPSCR: Nothing */
-	CHECK_FPU_ENABLED
+    CHECK_FPU_ENABLED
          tcg_gen_mov_i32(cpu_fpul, FREG(B11_8));
-	return;
+    return;

Sorry, it's a very late reply ... but in case you're still interested in fixing this: It seems like at least some of these files used TABs as 8 spaces, not as 4 spaces, so after applying your patch, the indentation seems to be wrong in all places. Please double-check the look of the files before sending! Thanks!

Thomas

#3 lore raw

Hello,

I remember this PR. It was a long time ago. I'll take a look at it and propose a fix.

Thanks,
Ahmed

Quoted 35 lines · Thomas Huth
Quoted 6 lines · Ahmed Abouzied

Replaces TABs with spaces, making sure to have a consistent coding style of 4 space indentations in the SH4 subsystem.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/376
---

...

Quoted 5 lines
target/sh4/translate.c +0 -1
@@ -1705,101 +1705,101 @@ static void _decode_opc(DisasContext * ctx)
          }
          return;
      case 0xf00d: /* fsts FPUL,FRn - FPSCR: Nothing */
-     CHECK_FPU_ENABLED

target/sh4/translate.c static void _decode_opc(DisasContext * ctx) · line 1714

Quoted 10 lines
target/sh4/translate.c +4 -3
+    CHECK_FPU_ENABLED
          tcg_gen_mov_i32(FREG(B11_8), cpu_fpul);
-     return;
+    return;
      case 0xf01d: /* flds FRm,FPUL - FPSCR: Nothing */
-     CHECK_FPU_ENABLED
+    CHECK_FPU_ENABLED
          tcg_gen_mov_i32(cpu_fpul, FREG(B11_8));
-     return;
+    return;

Sorry, it's a very late reply ... but in case you're still interested in fixing this: It seems like at least some of these files used TABs as 8 spaces, not as 4 spaces, so after applying your patch, the indentation seems
to be wrong in all places. Please double-check the look of the files before
sending! Thanks!

Thomas