mailbox: imx: Avoid using val uninitialized in imx_mu_isr()
Subsystems (2)
PATCH 1/1 mailbox: imx: Avoid using val uninitialized in imx_mu_isr()
Clang warns:
drivers/mailbox/imx-mailbox.c:284:2: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
drivers/mailbox/imx-mailbox.c:288:7: note: uninitialized use occurs here
if (!val)
^~~
drivers/mailbox/imx-mailbox.c:263:9: note: initialize the variable 'val'
to silence this warning
u32 val, ctrl;
^
= 01 warning generated.
Prior to commit 91c8c1fbe498 ("mailbox: imx: add xSR/xCR register array"), val was always initialized in imx_mu_isr() but now, it is not initialized in the default case. Return IRQ_NONE like the statement below does and add a message that there is an unhandled type for this switch statement so that it can be updated.
Fixes 91c8c1fbe498 ("mailbox: imx: add xSR/xCR register array")
Signed-off-by Nathan Chancellor <[email protected]>
--- drivers/mailbox/imx-mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mailbox/imx-mailbox.c +3 -1
@@ -282,7 +282,9 @@ static irqreturn_t imx_mu_isr(int irq, void *p) (ctrl &IMX_MU_xCR_GIEn (priv->dcfg->type, cp->idx));break ;default : -break ; +dev_warn_ratelimited (priv->dev,"Unhandled channel type %d\n" , + cp->type); +return IRQ_NONE ; }if (!val)
base-commit: 6393989e2a31914bdc50211ff350dade6c729ea7
Signature · 1 line
2.32.0.93.g670b81a890