perf data: close all files in close_dir
PATCH 1/1 perf data: close all files in close_dir
When using perf report in directory mode, the first file is not closed on exit, causing a memory leak.
The problem is caused by the iterating variable never reaching 0.
Signed-off-by Riccardo Mancini <[email protected]>
--- tools/perf/util/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/data.c +1 -1
@@ -20,7 +20,7 @@static void close_dir (struct perf_data_file *files,int nr) { -while (--nr >=1 ) { +while (--nr >=0 ) {close (files[nr].fd);zfree (&files[nr].path); }
Signature · 1 line
2.23.0
Quoted 6 lines · Riccardo Mancini
When using perf report in directory mode, the first file is not closed on exit, causing a memory leak.
The problem is caused by the iterating variable never reaching 0.Signed-off-by Riccardo Mancini <[email protected]>
Acked-by Namhyung Kim <[email protected]>
Thanks,
Namhyung
Quoted 20 lines
--- tools/perf/util/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/perf/util/data.c +1
-2@@ -20,7 +20,7 @@static void close_dir (struct perf_data_file *files,int nr) { -while (--nr >=1 ) { +while (--nr >=0 ) {close (files[nr].fd);zfree (&files[nr].path); } --2.23.0