drm/i915/ttm: consider all placements for the page alignment
Subsystems (2)
PATCH 1/3 drm/i915/ttm: consider all placements for the page alignment
Just checking the current region is not enough, if we later migrate the object somewhere else. For example if the placements are {SMEM, LMEM}, then we might get this wrong. Another idea might be to make the page_alignment part of the ttm_place, instead of the BO.
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +20 -1
@@ -753,6 +753,25 @@ void i915_ttm_bo_destroy(struct ttm_buffer_object *bo)call_rcu (&obj->rcu, __i915_gem_free_object_rcu); } +static u64 i915_gem_object_page_size (struct drm_i915_gem_object *obj) +{ +u64 page_size; +int i; + +if (!obj->mm.n_placements) +return obj->mm.region->min_page_size; + + page_size =0 ; +for (i =0 ; i < obj->mm.n_placements; i++) { +struct intel_memory_region *mr = obj->mm.placements[i]; + + page_size =max_t (u64, mr->min_page_size, page_size); + } + +GEM_BUG_ON (!page_size); +return page_size; +} +/** * __i915_gem_ttm_object_init - Initialize a ttm-backed i915 gem object * @mem: The initial memory region for the object.
@@ -793,7 +812,7 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem, obj->base.vma_node.driver_private =i915_gem_to_ttm (obj); ret =ttm_bo_init (&i915->bdev,i915_gem_to_ttm (obj), size, bo_type, &i915_sys_placement, - mem->min_page_size >>PAGE_SHIFT , +i915_gem_object_page_size (obj) >>PAGE_SHIFT , true,NULL ,NULL , i915_ttm_bo_destroy);if (!ret) obj->ttm.created = true;
Signature · 6 lines
2.26.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/3 drm/i915/gtt: ignore min_page_size for paging structures
The min_page_size is only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore the min_page_size restrictions here, otherwise we might see some severe overallocation on some devices.
--- drivers/gpu/drm/i915/gt/intel_gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_gtt.c +1 -1
@@ -16,7 +16,7 @@ struct drm_i915_gem_object *alloc_pt_lmem(struct i915_address_space *vm, int sz) {struct drm_i915_gem_object *obj; - obj =i915_gem_object_create_lmem (vm->i915, sz,0 ); + obj =__i915_gem_object_create_lmem_with_ps (vm->i915, sz, sz,0 );/* * Ensure all paging structures for this vm share the same dma-resv * object underneath, with the idea that one object_lock() will lock
Signature · 6 lines
2.26.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/3 drm/i915: support forcing the page size with lmem
In reply to Matthew AuldFor some specialised objects we might need something larger than the regions min_page_size due to some hw restriction, and slightly more hairy is needing something smaller with the guarantee that such objects will never be inserted into any GTT, which is the case for the paging structures.
--- drivers/gpu/drm/i915/gem/i915_gem_create.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 33 +++++++++- drivers/gpu/drm/i915/gem/i915_gem_lmem.h | 5 ++ drivers/gpu/drm/i915/gem/i915_gem_region.c | 10 ++- drivers/gpu/drm/i915/gem/i915_gem_region.h | 1 + drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 3 +- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 14 +++-- drivers/gpu/drm/i915/gem/i915_gem_ttm.h | 1 + .../gpu/drm/i915/gem/selftests/huge_pages.c | 3 +- .../drm/i915/gem/selftests/i915_gem_mman.c | 8 +-- drivers/gpu/drm/i915/intel_memory_region.h | 1 + .../drm/i915/selftests/intel_memory_region.c | 63 ++++++++++++++++++- drivers/gpu/drm/i915/selftests/mock_region.c | 1 + 14 files changed, 130 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_create.c +1 -1
@@ -90,7 +90,7 @@ i915_gem_setup(struct drm_i915_gem_object *obj, u64 size)*/ flags =I915_BO_ALLOC_USER ; - ret = mr->ops->init_object (mr, obj, size, flags); + ret = mr->ops->init_object (mr, obj, size,0 , flags);if (ret)return ret;
drivers/gpu/drm/i915/gem/i915_gem_lmem.c +32 -1
@@ -71,11 +71,42 @@ bool i915_gem_object_is_lmem(struct drm_i915_gem_object *obj) mr->type == INTEL_MEMORY_STOLEN_LOCAL); } +/** +* __i915_gem_object_create_lmem_with_ps - Create lmem object and force the +* minimum page size for the backing pages. +* @i915: The i915 instance. +* @size: The size in bytes for the object. Note that we need to round the size +* up depending on the @page_size. The final object size can be fished out from +* the drm GEM object. +* @page_size: The requested minimum page size in bytes for this object. The is +* useful if we need something bigger than the regions min_page_size due to some +* hw restriction, or in some very specialised cases where it needs to be +* smaller, where the internal fragmentation cost is too great when rounding up +* the object size. +* @flags: the optional BO allocation flags +* +* Note that this interface assumes you know what you are doing when forcing the +* page_size. If this is smaller than the regions min_page_size then it can +* never be inserted into any GTT, otherwise it might lead to undefined +* behaviour. +* +* Return: The object pointer, which might be an ERR_PTR in the case of failure. +*/ +struct drm_i915_gem_object * +__i915_gem_object_create_lmem_with_ps (struct drm_i915_private *i915, +resource_size_t size, +resource_size_t page_size, +unsigned int flags) +{ +return i915_gem_object_create_region (i915->mm.regions[INTEL_REGION_LMEM ], + size, page_size, flags); +} +struct drm_i915_gem_object *i915_gem_object_create_lmem (struct drm_i915_private *i915,resource_size_t size,unsigned int flags) {return i915_gem_object_create_region (i915->mm.regions[INTEL_REGION_LMEM ], - size, flags); + size,0 , flags); }
drivers/gpu/drm/i915/gem/i915_gem_lmem.h +5 -0
@@ -21,6 +21,11 @@ i915_gem_object_lmem_io_map(struct drm_i915_gem_object *obj,bool i915_gem_object_is_lmem (struct drm_i915_gem_object *obj); +struct drm_i915_gem_object * +__i915_gem_object_create_lmem_with_ps (struct drm_i915_private *i915, +resource_size_t size, +resource_size_t page_size, +unsigned int flags);struct drm_i915_gem_object * i915_gem_object_create_lmem(struct drm_i915_private *i915, resource_size_t size,
drivers/gpu/drm/i915/gem/i915_gem_region.c +8 -2
@@ -36,6 +36,7 @@ void i915_gem_object_release_memory_region(struct drm_i915_gem_object *obj)struct drm_i915_gem_object *i915_gem_object_create_region (struct intel_memory_region *mem,resource_size_t size, +resource_size_t page_size,unsigned int flags) {struct drm_i915_gem_object *obj;
@@ -48,11 +49,16 @@ i915_gem_object_create_region(struct intel_memory_region *mem,*/ GEM_BUG_ON (flags & ~I915_BO_ALLOC_FLAGS ); +GEM_BUG_ON (!is_power_of_2_u64 (page_size)); +GEM_BUG_ON (page_size <PAGE_SIZE );if (!mem)return ERR_PTR (-ENODEV ); - size =round_up (size, mem->min_page_size); +if (!page_size) + page_size = mem->min_page_size; + + size =round_up (size, page_size);GEM_BUG_ON (!size);GEM_BUG_ON (!IS_ALIGNED (size,I915_GTT_MIN_ALIGNMENT ));
@@ -64,7 +70,7 @@ i915_gem_object_create_region(struct intel_memory_region *mem,if (!obj)return ERR_PTR (-ENOMEM ); - err = mem->ops->init_object (mem, obj, size, flags); + err = mem->ops->init_object (mem, obj, size, page_size, flags);if (err) goto err_object_free;
drivers/gpu/drm/i915/gem/i915_gem_region.h +1 -0
@@ -19,6 +19,7 @@ void i915_gem_object_release_memory_region(struct drm_i915_gem_object *obj);struct drm_i915_gem_object *i915_gem_object_create_region (struct intel_memory_region *mem,resource_size_t size, +resource_size_t page_size,unsigned int flags);#endif
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +2 -1
@@ -489,6 +489,7 @@ static int __create_shmem(struct drm_i915_private *i915,static int shmem_object_init (struct intel_memory_region *mem,struct drm_i915_gem_object *obj,resource_size_t size, +resource_size_t page_size,unsigned int flags) {static struct lock_class_key lock_class;
@@ -548,7 +549,7 @@ i915_gem_object_create_shmem(struct drm_i915_private *i915, resource_size_t size) {return i915_gem_object_create_region (i915->mm.regions[INTEL_REGION_SMEM ], - size,0 ); + size,0 ,0 ); }/* Allocate a new GEM object and fill it with the supplied data */
drivers/gpu/drm/i915/gem/i915_gem_stolen.c +2 -1
@@ -670,6 +670,7 @@ static int __i915_gem_object_create_stolen(struct intel_memory_region *mem,static int _i915_gem_object_stolen_init (struct intel_memory_region *mem,struct drm_i915_gem_object *obj,resource_size_t size, +resource_size_t page_size,unsigned int flags) {struct drm_i915_private *i915 = mem->i915;
@@ -708,7 +709,7 @@ struct drm_i915_gem_object * i915_gem_object_create_stolen(struct drm_i915_private *i915, resource_size_t size) { -return i915_gem_object_create_region (i915->mm.stolen_region, size,0 ); +return i915_gem_object_create_region (i915->mm.stolen_region, size,0 ,0 ); }static int init_stolen_smem (struct intel_memory_region *mem)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +10 -4
@@ -758,9 +758,6 @@ static u64 i915_gem_object_page_size(struct drm_i915_gem_object *obj)u64 page_size;int i; -if (!obj->mm.n_placements) -return obj->mm.region->min_page_size; - page_size =0 ;for (i =0 ; i < obj->mm.n_placements; i++) {struct intel_memory_region *mr = obj->mm.placements[i];
@@ -784,6 +781,7 @@ static u64 i915_gem_object_page_size(struct drm_i915_gem_object *obj)int __i915_gem_ttm_object_init (struct intel_memory_region *mem,struct drm_i915_gem_object *obj,resource_size_t size, +resource_size_t page_size,unsigned int flags) {static struct lock_class_key lock_class;
@@ -802,6 +800,14 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem, bo_type = (obj->flags &I915_BO_ALLOC_USER ) ? ttm_bo_type_device : ttm_bo_type_kernel; +GEM_BUG_ON (!page_size); + +if (obj->mm.n_placements) { +/* Forcing the page size is kernel internal only */ +GEM_BUG_ON (page_size != mem->min_page_size); + page_size =i915_gem_object_page_size (obj); + } +/* * If this function fails, it will call the destructor, but * our caller still owns the object. So no freeing in the
@@ -812,7 +818,7 @@ int __i915_gem_ttm_object_init(struct intel_memory_region *mem, obj->base.vma_node.driver_private =i915_gem_to_ttm (obj); ret =ttm_bo_init (&i915->bdev,i915_gem_to_ttm (obj), size, bo_type, &i915_sys_placement, -i915_gem_object_page_size (obj) >>PAGE_SHIFT , + page_size >>PAGE_SHIFT , true,NULL ,NULL , i915_ttm_bo_destroy);if (!ret) obj->ttm.created = true;
drivers/gpu/drm/i915/gem/i915_gem_ttm.h +1 -0
@@ -44,5 +44,6 @@ i915_ttm_to_gem(struct ttm_buffer_object *bo)int __i915_gem_ttm_object_init (struct intel_memory_region *mem,struct drm_i915_gem_object *obj,resource_size_t size, +resource_size_t page_size,unsigned int flags);#endif
drivers/gpu/drm/i915/gem/selftests/huge_pages.c +2 -1
@@ -497,7 +497,8 @@ static int igt_mock_memory_region_huge_pages(void *arg)int i;for (i =0 ; i <ARRAY_SIZE (flags); ++i) { - obj =i915_gem_object_create_region (mem, page_size, + obj =i915_gem_object_create_region (mem, + page_size, page_size, flags[i]);if (IS_ERR (obj)) { err =PTR_ERR (obj);
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +4 -4
@@ -955,7 +955,7 @@ static int igt_mmap(void *arg)struct drm_i915_gem_object *obj;int err; - obj =i915_gem_object_create_region (mr, sizes[i],I915_BO_ALLOC_USER ); + obj =i915_gem_object_create_region (mr, sizes[i],0 ,I915_BO_ALLOC_USER );if (obj ==ERR_PTR (-ENODEV ))continue ;
@@ -1075,7 +1075,7 @@ static int igt_mmap_access(void *arg)struct drm_i915_gem_object *obj;int err; - obj =i915_gem_object_create_region (mr,PAGE_SIZE ,I915_BO_ALLOC_USER ); + obj =i915_gem_object_create_region (mr,PAGE_SIZE ,0 ,I915_BO_ALLOC_USER );if (obj ==ERR_PTR (-ENODEV ))continue ;
@@ -1220,7 +1220,7 @@ static int igt_mmap_gpu(void *arg)struct drm_i915_gem_object *obj;int err; - obj =i915_gem_object_create_region (mr,PAGE_SIZE ,I915_BO_ALLOC_USER ); + obj =i915_gem_object_create_region (mr,PAGE_SIZE ,0 ,I915_BO_ALLOC_USER );if (obj ==ERR_PTR (-ENODEV ))continue ;
@@ -1375,7 +1375,7 @@ static int igt_mmap_revoke(void *arg)struct drm_i915_gem_object *obj;int err; - obj =i915_gem_object_create_region (mr,PAGE_SIZE ,I915_BO_ALLOC_USER ); + obj =i915_gem_object_create_region (mr,PAGE_SIZE ,0 ,I915_BO_ALLOC_USER );if (obj ==ERR_PTR (-ENODEV ))continue ;
drivers/gpu/drm/i915/intel_memory_region.h +1 -0
@@ -55,6 +55,7 @@ struct intel_memory_region_ops {int (*init_object)(struct intel_memory_region *mem,struct drm_i915_gem_object *obj,resource_size_t size, +resource_size_t page_size,unsigned int flags); };
drivers/gpu/drm/i915/selftests/intel_memory_region.c +60 -3
93 lines not on this page · raw message
drivers/gpu/drm/i915/selftests/mock_region.c +1 -0
@@ -63,6 +63,7 @@ static const struct drm_i915_gem_object_ops mock_region_obj_ops = {static int mock_object_init (struct intel_memory_region *mem,struct drm_i915_gem_object *obj,resource_size_t size, +resource_size_t page_size,unsigned int flags) {static struct lock_class_key lock_class;
Signature · 6 lines
2.26.3 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures
In reply to Matthew AuldQuoted 16 lines · Matthew Auld
The
min_page_sizeis only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore themin_page_sizerestrictions here, otherwise we might see some severe overallocation on some devices.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>--- drivers/gpu/drm/i915/gt/intel_gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_gtt.c +0
-0
drivers/gpu/drm/i915/gt/intel_gtt.c struct drm_i915_gem_object *alloc_pt_lmem(struct i915_address_space *vm, int sz) · line 22
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gtt.c +1
-1@@ -16,7 +16,7 @@ struct drm_i915_gem_object *alloc_pt_lmem(struct i915_address_space *vm, int sz) {struct drm_i915_gem_object *obj; - obj =i915_gem_object_create_lmem (vm->i915, sz,0 ); + obj =__i915_gem_object_create_lmem_with_ps (vm->i915, sz, sz,0 );/* * Ensure all paging structures for this vm share the same dma-resv * object underneath, with the idea that one object_lock() will lock
I think for this one the new gt migration code might break, because there we insert even PT pages into the GTT, so it might need a special interface? Ram is looking at supporter larger GPU PTE sizes with that code..
/Thomas
Re: [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures
Quoted 13 lines · Thomas Hellström
Quoted 11 lines · Matthew Auld
The
min_page_sizeis only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore themin_page_sizerestrictions here, otherwise we might see some severe overallocation on some devices.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gtt.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
drivers/gpu/drm/i915/gt/intel_gtt.c struct drm_i915_gem_object *alloc_pt_lmem(struct · line 22
Quoted 13 lines
drivers/gpu/drm/i915/gt/intel_gtt.c +1
-1@@ -16,7 +16,7 @@ struct drm_i915_gem_object *alloc_pt_lmem(struct i915_address_space *vm, int sz) { struct drm_i915_gem_object *obj; - obj = i915_gem_object_create_lmem(vm->i915, sz, 0); + obj = __i915_gem_object_create_lmem_with_ps(vm->i915, sz, sz, 0); /** Ensure all paging structures for this vm share the same dma-resv * object underneath, with the idea that one object_lock() will lock I think for this one the new gt migration code might break, because there we insert even PT pages into the GTT, so it might need a special interface? Ram is looking at supporter larger GPU PTE sizes with that code..
For DG1 at least we don't need this. But yeah we can always just pass along the page size when allocating the stash I guess, if we need something special for migration?
But when we need to support huge PTEs for stuff other than DG1, then it's still a pile of work I assume, since we still need all the special PTE insertion routines specifically for insert_pte() which will differ wildly between generations, also each has quite different restrictions wrt min physical alignment of lmem, whether you can mix 64K/4K PTEs in the same 2M va range, whether 4K PTEs are even supported for lmem etc.
Not sure if it's simpler to go with mapping all of lmem upfront with the flat-ppGTT? Maybe that sidesteps some of these issues? At least for the physical alignment of paging structures that would no longer be a concern.
Quoted 5 lines
/Thomas
Re: [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures
Quoted 60 lines · Matthew Auld
Quoted 34 lines · Thomas Hellström
Quoted 32 lines · Matthew Auld
The
min_page_sizeis only needed for pages inserted into the GTT, and
for our paging structures we only need at most 4K bytes, so simply
ignore themin_page_sizerestrictions here, otherwise we might see some
severe overallocation on some devices.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gtt.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_gtt.c +1
-1@@ -16,7 +16,7 @@ struct drm_i915_gem_object *alloc_pt_lmem(struct i915_address_space *vm, int sz) { struct drm_i915_gem_object *obj; - obj = i915_gem_object_create_lmem(vm->i915, sz, 0); + obj = __i915_gem_object_create_lmem_with_ps(vm->i915, sz, sz,0 ); /** Ensure all paging structures for this vm share the same dma-resv
* object underneath, with the idea that oneobject_lock()willQuoted 8 lines
Quoted 1 line
lock
I think for this one the new gt migration code might break, because there we insert even PT pages into the GTT, so it might need a special
interface? Ram is looking at supporter larger GPU PTE sizes with that
code..For DG1 at least we don't need this. But yeah we can always just pass along the page size when allocating the stash I guess, if we need something special for migration?
But when we need to support huge PTEs for stuff other than DG1, then it's still a pile of work I assume, since we still need all the special
PTE insertion routines specifically forinsert_pte()which will differ
wildly between generations, also each has quite different restrictions
wrt min physical alignment of lmem, whether you can mix 64K/4K PTEs in
the same 2M va range, whether 4K PTEs are even supported for lmem etc.
Quoted 6 lines
Not sure if it's simpler to go with mapping all of lmem upfront with the
flat-ppGTT? Maybe that sidesteps some of these issues? At least for the
physical alignment of paging structures that would no longer be a concern.
Yes, that might be the simplest way forward.
/Thomas
Quoted 6 lines
Quoted 6 lines
/Thomas
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 36 lines · Matthew Auld
Just checking the current region is not enough, if we later migrate the
object somewhere else. For example if the placements are {SMEM, LMEM},
then we might get this wrong. Another idea might be to make thepage_alignmentpart of thettm_place, instead of the BO.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>---
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 21 ++++++++++++++++++++-1 file changed, 20 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/gem/i915_gem_ttm.c +0
-0@@ -753,6 +753,25 @@ void i915_ttm_bo_destroy(struct ttm_buffer_object *bo) call_rcu(&obj->rcu, __i915_gem_free_object_rcu); }
+static u64i915_gem_object_page_size(struct drm_i915_gem_object *obj)drivers/gpu/drm/i915/gem/i915_gem_ttm.c +10
-0+{ + u64 page_size; + int i; + + if (!obj->mm.n_placements) + return obj->mm.region->min_page_size; + + page_size = 0; + for (i = 0; i < obj->mm.n_placements; i++) { + struct intel_memory_region *mr = obj-Quoted 1 line
mm.placements[i];
drivers/gpu/drm/i915/gem/i915_gem_ttm.c void i915_ttm_bo_destroy(struct ttm_buffer_object *bo) · line 774
Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +8
-0+ + page_size = max_t(u64, mr->min_page_size, page_size); + } + + GEM_BUG_ON(!page_size); + return page_size; +} +
I think if at all possible, we really should try to avoid the above. Could we, just like in your next patch, perhaps set alignment to 0, indicating that we don't care at the per-object level and something else, indicating that we care.
Then the manager could use its default if we don't care and the indicated alignment, even if it's less, if we care at the per object level?
/Thomas
Quoted 17 lines
/**
*__i915_gem_ttm_object_init- Initialize a ttm-backed i915 gem object
* @mem: The initial memory region for the object.drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1
-1@@ -793,7 +812,7 @@ int __i915_gem_ttm_object_init(structintel_memory_region *mem, obj->base.vma_node.driver_private = i915_gem_to_ttm(obj); ret = ttm_bo_init(&i915->bdev, i915_gem_to_ttm(obj), size, bo_type, &i915_sys_placement, - mem->min_page_size >> PAGE_SHIFT, + i915_gem_object_page_size(obj) >> PAGE_SHIFT,
Quoted 3 lines
true, NULL, NULL,
i915_ttm_bo_destroy); if (!ret)
obj->ttm.created = true;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/3] drm/i915: support forcing the page size with lmem
In reply to Matthew AuldQuoted 9 lines · Matthew Auld
For some specialised objects we might need something larger than the regions
min_page_sizedue to some hw restriction, and slightly more hairy is needing something smaller with the guarantee that such objects
will never be inserted into any GTT, which is the case for the paging structures.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>
Re: [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures
In reply to Matthew AuldQuoted 16 lines · Matthew Auld
The
min_page_sizeis only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore themin_page_sizerestrictions here, otherwise we might see some severe overallocation on some devices.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>--- drivers/gpu/drm/i915/gt/intel_gtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gt/intel_gtt.c +0
-0
drivers/gpu/drm/i915/gt/intel_gtt.c struct drm_i915_gem_object *alloc_pt_lmem(struct i915_address_space *vm, int sz) · line 19
Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_gtt.c +1
-1@@ -16,7 +16,7 @@ struct drm_i915_gem_object *alloc_pt_lmem(struct i915_address_space *vm, int sz) {struct drm_i915_gem_object *obj; - obj =i915_gem_object_create_lmem (vm->i915, sz,0 ); + obj =__i915_gem_object_create_lmem_with_ps (vm->i915, sz, sz,0 );
So is this memory always required to be size aligned? or should it say sz, PAGE_SIZE?
/Thomas
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures
Quoted 13 lines · Thomas Hellström
Quoted 11 lines · Matthew Auld
The
min_page_sizeis only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore themin_page_sizerestrictions here, otherwise we might see some severe overallocation on some devices.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gtt.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 12 lines
drivers/gpu/drm/i915/gt/intel_gtt.c struct drm_i915_gem_object *alloc_pt_lmem(struct · line 19
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_gtt.c +1
-1@@ -16,7 +16,7 @@ struct drm_i915_gem_object *alloc_pt_lmem(struct i915_address_space *vm, int sz) { struct drm_i915_gem_object *obj; - obj = i915_gem_object_create_lmem(vm->i915, sz, 0); + obj = __i915_gem_object_create_lmem_with_ps(vm->i915, sz, sz, 0);So is this memory always required to be size aligned? or should it say sz,
PAGE_SIZE?
The scratch page also hits this path, which is another can of worms. In terms of size it might need to be 64K(with proper physical alignment), which is why we can't force 4K here, and instead need to use the passed in size, where the returned page will have the same alignment.
Quoted 4 lines
/Thomas
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Thomas Hellström
Reviewed-byRe: [PATCH 3/3] drm/i915/gtt: ignore min_page_size for paging structures
Quoted 27 lines · Matthew Auld
Quoted 13 lines · Thomas Hellström
Quoted 11 lines · Matthew Auld
The
min_page_sizeis only needed for pages inserted into the GTT, and for our paging structures we only need at most 4K bytes, so simply ignore themin_page_sizerestrictions here, otherwise we might see some severe overallocation on some devices.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>---
drivers/gpu/drm/i915/gt/intel_gtt.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Quoted 12 lines
drivers/gpu/drm/i915/gt/intel_gtt.c struct drm_i915_gem_object *alloc_pt_lmem(struct · line 19
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_gtt.c +1
-1@@ -16,7 +16,7 @@ struct drm_i915_gem_object *alloc_pt_lmem(struct i915_address_space *vm, int sz) { struct drm_i915_gem_object *obj; - obj = i915_gem_object_create_lmem(vm->i915, sz, 0); + obj = __i915_gem_object_create_lmem_with_ps(vm->i915, sz, sz, 0);So is this memory always required to be size aligned? or should it say sz,
PAGE_SIZE?
Quoted 1 line
The scratch page also hits this path, which is another can of worms. In terms of size it might need to be 64K(with proper physical alignment), which is why we can't force 4K here, and instead need to use the passed in size, where the returned page will have the same alignment.
OK. Perhaps a comment to explain that?
Quoted 5 lines
Quoted 5 lines
/Thomas
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/ttm: consider all placements for the page alignment
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [1/3] drm/i915/ttm: consider all placements for the page alignment
URL : https://patchwork.freedesktop.org/series/91811/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_display.c:1893:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_display.c:1893:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_display.c:1893:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/i915_gem_ttm.c:733:38: warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static? +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1207:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/ttm: consider all placements for the page alignment
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [1/3] drm/i915/ttm: consider all placements for the page alignment
URL : https://patchwork.freedesktop.org/series/91811/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10268 -> Patchwork_20439
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20439 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_20439, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20439:
### CI changes ###
#### Possible regressions ####
* boot:
- fi-apl-guc: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-apl-guc/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-apl-guc/boot.html
- fi-kbl-8809g: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-kbl-8809g/boot.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-kbl-8809g/boot.html
- fi-snb-2520m: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-snb-2520m/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-snb-2520m/boot.html
- fi-bsw-nick: [PASS][7] -> [FAIL][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-bsw-nick/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-bsw-nick/boot.html
- fi-cfl-8109u: [PASS][9] -> [FAIL][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-cfl-8109u/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-cfl-8109u/boot.html
- fi-cfl-8700k: [PASS][11] -> [FAIL][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-cfl-8700k/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-cfl-8700k/boot.html
- fi-bxt-dsi: [PASS][13] -> [FAIL][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-bxt-dsi/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-bxt-dsi/boot.html
- fi-cml-u2: [PASS][15] -> [FAIL][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-cml-u2/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-cml-u2/boot.html
- fi-pnv-d510: [PASS][17] -> [FAIL][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-pnv-d510/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-pnv-d510/boot.html
- fi-ilk-650: [PASS][19] -> [FAIL][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-ilk-650/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-ilk-650/boot.html
- fi-bsw-n3050: [PASS][21] -> [FAIL][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-bsw-n3050/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-bsw-n3050/boot.html
- fi-hsw-4770: [PASS][23] -> [FAIL][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-hsw-4770/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-hsw-4770/boot.html
- fi-cfl-guc: [PASS][25] -> [FAIL][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-cfl-guc/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-cfl-guc/boot.html
- fi-kbl-soraka: [PASS][27] -> [FAIL][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-kbl-soraka/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-kbl-soraka/boot.html
- fi-cml-s: [PASS][29] -> [FAIL][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-cml-s/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-cml-s/boot.html
- fi-elk-e7500: [PASS][31] -> [FAIL][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-elk-e7500/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-elk-e7500/boot.html
- fi-glk-dsi: [PASS][33] -> [FAIL][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-glk-dsi/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-glk-dsi/boot.html
- fi-ivb-3770: [PASS][35] -> [FAIL][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-ivb-3770/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-ivb-3770/boot.html
- fi-snb-2600: [PASS][37] -> [FAIL][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-snb-2600/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-snb-2600/boot.html
- fi-kbl-guc: NOTRUN -> [FAIL][39]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-kbl-guc/boot.html
- fi-bsw-kefka: [PASS][40] -> [FAIL][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-bsw-kefka/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-bsw-kefka/boot.html
- fi-kbl-x1275: [PASS][42] -> [FAIL][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-kbl-x1275/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-kbl-x1275/boot.html
- fi-bdw-gvtdvm: [PASS][44] -> [FAIL][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-bdw-gvtdvm/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-bdw-gvtdvm/boot.html
- fi-bwr-2160: [PASS][46] -> [FAIL][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-bwr-2160/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-bwr-2160/boot.html
- fi-bdw-5557u: [PASS][48] -> [FAIL][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-bdw-5557u/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-bdw-5557u/boot.html
- fi-kbl-r: [PASS][50] -> [FAIL][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-kbl-r/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-kbl-r/boot.html
- fi-kbl-7567u: [PASS][52] -> [FAIL][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-kbl-7567u/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-kbl-7567u/boot.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* boot:
- {fi-tgl-dsi}: [PASS][54] -> [FAIL][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-tgl-dsi/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-tgl-dsi/boot.html
- {fi-tgl-1115g4}: [PASS][56] -> [FAIL][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-tgl-1115g4/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-tgl-1115g4/boot.html
- {fi-hsw-gt1}: [PASS][58] -> [FAIL][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-hsw-gt1/boot.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-hsw-gt1/boot.html
- {fi-jsl-1}: [PASS][60] -> [FAIL][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-jsl-1/boot.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-jsl-1/boot.html
- {fi-ehl-2}: [PASS][62] -> [FAIL][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-ehl-2/boot.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-ehl-2/boot.html
Known issues
------------
Here are the changes found in Patchwork_20439 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-icl-y: [PASS][64] -> [FAIL][65] ([i915#3521])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-icl-y/boot.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-icl-y/boot.html
- fi-icl-u2: [PASS][66] -> [FAIL][67] ([i915#3521])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-icl-u2/boot.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-icl-u2/boot.html
- fi-skl-6600u: [PASS][68] -> [FAIL][69] ([i915#3174])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-skl-6600u/boot.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-skl-6600u/boot.html
- fi-skl-6700k2: [PASS][70] -> [FAIL][71] ([i915#3174])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-skl-6700k2/boot.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-skl-6700k2/boot.html
- fi-skl-guc: [PASS][72] -> [FAIL][73] ([i915#3174])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10268/fi-skl-guc/boot.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/fi-skl-guc/boot.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#2788]: https://gitlab.freedesktop.org/drm/intel/issues/2788
[i915#3174]: https://gitlab.freedesktop.org/drm/intel/issues/3174
[i915#3521]: https://gitlab.freedesktop.org/drm/intel/issues/3521
Participating hosts (41 -> 38)
------------------------------
Additional (1): fi-kbl-guc
Missing (4): fi-ilk-m540 fi-bdw-samus fi-bsw-cyan bat-adlp-4
Build changes
-------------
* IGT: IGT_6117 -> None
* Linux: CI_DRM_10268 -> Patchwork_20439
CI-20190529: 20190529
CI_DRM_10268: 0e0529132a50160a0e8bd0aa9608226445a3299b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6117: 3ba0a02404f243d6d8f232c6215163cc4b0fd699 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20439: 4fbf426a3769570dca71baaae14985f6ea2a152d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
4fbf426a3769 drm/i915/gtt: ignore min_page_size for paging structures 7fd267210a65 drm/i915: support forcing the page size with lmem 04c6fc20483d drm/i915/ttm: consider all placements for the page alignment
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20439/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx