package/python-greenlet: enable as host package
PATCH 1/1 package/python-greenlet: enable as host package
--- package/python-greenlet/python-greenlet.mk | 1 + 1 file changed, 1 insertion(+)
package/python-greenlet/python-greenlet.mk +1 -0
@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package))
Signature · 1 line
2.32.0
Hello,
Le 23/06/2021 à 16:52, Cyril Bur a écrit :
Why?
There is not package using host-python-greenlet in the tree.
Best regards,
Romain
Quoted 11 lines
Signed-off-by Cyril Bur <[email protected]>--- package/python-greenlet/python-greenlet.mk | 1 + 1 file changed, 1 insertion(+)package/python-greenlet/python-greenlet.mk +0
-0
package/python-greenlet/python-greenlet.mk PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 · line 15
Quoted 4 lines
package/python-greenlet/python-greenlet.mk +1
-0@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package))
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Romain,
Thanks for your interest.
My employer has some custom packages which do depend on host python greenlet.
I'm keen to avoid any forks (however small) of buildroot internally, it just makes life easier.
Cyril
Quoted 24 lines · On Sat, 8 Jan 2022, 18:43 Romain Naour, <[email protected]> wrote:
Hello,
Le 23/06/2021 à 16:52, Cyril Bur a écrit :
Why?
There is not package using host-python-greenlet in the tree.
Best regards,
RomainReview
Quoted 6 lines
Signed-off-by Cyril Bur <[email protected]>--- package/python-greenlet/python-greenlet.mk | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/package/python-greenlet/python-greenlet.mkQuoted 6 lines
index
01d578a183..e90d1c0f56100644package/python-greenlet/python-greenlet.mk +0
-0@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF
Quoted 5 lines
package/python-greenlet/python-greenlet.mk PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 · line 15
Quoted 3 lines
package/python-greenlet/python-greenlet.mk +1
-0$(eval $(python-package)) +$(eval $(host-python-package))
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Hello Cyril,
Le 08/01/2022 à 20:03, Cyril Bur a écrit :
Quoted 9 lines
Hi Romain,
Thanks for your interest.
My employer has some custom packages which do depend on host python greenlet.
I'm keen to avoid any forks (however small) of buildroot internally, it just makes life easier.
I understand.
It seems there is an exception in the tree (host-python-lxml), but you have to add at least a Config.in.host:
https://git.buildroot.net/buildroot/commit/?id=4f147ae0a0f940dfc7ec93af8e70b6625821d91d
Also add a comment to explain why we don't have any package using it in the tree.
I have marked this patch as "Changes Requested".
Best regards,
Romain
Quoted 36 lines
Cyril
Quoted 29 lines · On Sat, 8 Jan 2022, 18:43 Romain Naour, <[email protected]> wrote:
Hello,
Le 23/06/2021 à 16:52, Cyril Bur a écrit :
Why?
There is not package using host-python-greenlet in the tree.
Best regards,
RomainReview
Quoted 6 lines
Signed-off-by Cyril Bur <[email protected]>--- package/python-greenlet/python-greenlet.mk | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/package/python-greenlet/python-greenlet.mkQuoted 9 lines
index
01d578a183..e90d1c0f56100644package/python-greenlet/python-greenlet.mk +1
-0@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package))
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 10 lines · On Sat, 8 Jan 2022, 19:13 Romain Naour, <[email protected]> wrote:
Hello Cyril,
Quoted 7 lines · Cyril Bur
Hi Romain,
Thanks for your interest.
My employer has some custom packages which do depend on host python greenlet.
Quoted 9 lines
Quoted 2 lines
I'm keen to avoid any forks (however small) of buildroot internally, it just makes life easier.
I understand.
It seems there is an exception in the tree (host-python-lxml), but you have to
add at least a Config.in.host:
Ah sorry! Yep will do.
Quoted 7 lines
https://git.buildroot.net/buildroot/commit/?id=4f147ae0a0f940dfc7ec93af8e70b6625821d91d
Also add a comment to explain why we don't have any package using it in the tree.
Perfect will do.
Thanks,
Cyril
Quoted 45 lines
I have marked this patch as "Changes Requested".
Best regards,
RomainQuoted 36 lines
Cyril
Quoted 29 lines · On Sat, 8 Jan 2022, 18:43 Romain Naour, <[email protected]> wrote:
Hello,
Le 23/06/2021 à 16:52, Cyril Bur a écrit :
Why?
There is not package using host-python-greenlet in the tree.
Best regards,
RomainReview
Quoted 6 lines
Signed-off-by Cyril Bur <[email protected]>--- package/python-greenlet/python-greenlet.mk | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/package/python-greenlet/python-greenlet.mkQuoted 9 lines
index
01d578a183..e90d1c0f56100644package/python-greenlet/python-greenlet.mk +1
-0@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package))
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v2 1/1 package/python-greenlet: enable as host package
In reply to Cyril BurWhile currently there is no in-tree Buildroot package which depends on host-python-lxml, we (Adder Technology) have some proprietary modules that use it as part of their builds.
I've tested python-greenlet as host package and confirmed that it builds and works correctly. Someone else might require it, so we are proposing its inclusion.
---
V2: Added Config.in.host and a better commit message
package/Config.in.host | 1 + package/python-greenlet/Config.in.host | 7 +++++++ package/python-greenlet/python-greenlet.mk | 1 + 3 files changed, 9 insertions(+) create mode 100644 package/python-greenlet/Config.in.host
package/Config.in.host +1 -0
@@ -69,6 +69,7 @@ menu "Host utilities" source "package/pwgen/Config.in.host" source "package/python/Config.in.host" source "package/python-cython/Config.in.host" + source "package/python-greenlet/Config.in.host" source "package/python-lxml/Config.in.host" source "package/python-six/Config.in.host" source "package/python-xlrd/Config.in.host"
package/python-greenlet/Config.in.host new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_HOST_PYTHON_GREENLET + bool "host python-greenlet" + help + Greenlets are lightweight coroutines for in-process concurrent + programming. + + https://greenlet.readthedocs.io/
package/python-greenlet/python-greenlet.mk +1 -0
@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package))
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Sorry ignore me, sent a version with mistakes. I'll send v3.
Quoted 56 lines · Cyril Bur
While currently there is no in-tree Buildroot package which depends on host-python-lxml, we (Adder Technology) have some proprietary modules that use it as part of their builds.
I've tested python-greenlet as host package and confirmed that it builds and works correctly. Someone else might require it, so we are proposing its inclusion.
Signed-off-by Cyril Bur <[email protected]>---
V2: Added Config.in.host and a better commit messagepackage/Config.in.host | 1 + package/python-greenlet/Config.in.host | 7 +++++++ package/python-greenlet/python-greenlet.mk | 1 + 3 files changed, 9 insertions(+) create mode 100644 package/python-greenlet/Config.in.hostpackage/Config.in.host +1
-0@@ -69,6 +69,7 @@ menu "Host utilities" source "package/pwgen/Config.in.host" source "package/python/Config.in.host" source "package/python-cython/Config.in.host" + source "package/python-greenlet/Config.in.host" source "package/python-lxml/Config.in.host" source "package/python-six/Config.in.host" source "package/python-xlrd/Config.in.host"package/python-greenlet/Config.in.host new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_HOST_PYTHON_GREENLET + bool "host python-greenlet" + help + Greenlets are lightweight coroutines for in-process concurrent + programming. + + https://greenlet.readthedocs.io/package/python-greenlet/python-greenlet.mk +1
-1@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package)) --2.34.1
Signature · 5 lines
Cyril _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v3 1/1 package/python-greenlet: enable as host package
In reply to Cyril BurWhile currently there is no in-tree Buildroot package which depends on host-python-greenlet, we (Adder Technology) have some proprietary modules that use it as part of their builds.
I've tested python-greenlet as host package and confirmed that it builds and works correctly. Someone else might require it, so I'm proposing its inclusion.
---
v2: Half completed commit message update - sorry
v3: Updated commit message and Config.in.host
package/Config.in.host | 1 + package/python-greenlet/Config.in.host | 7 +++++++ package/python-greenlet/python-greenlet.mk | 1 + 3 files changed, 9 insertions(+) create mode 100644 package/python-greenlet/Config.in.host
package/Config.in.host +1 -0
@@ -69,6 +69,7 @@ menu "Host utilities" source "package/pwgen/Config.in.host" source "package/python/Config.in.host" source "package/python-cython/Config.in.host" + source "package/python-greenlet/Config.in.host" source "package/python-lxml/Config.in.host" source "package/python-six/Config.in.host" source "package/python-xlrd/Config.in.host"
package/python-greenlet/Config.in.host new file +7 -0
@@ -0,0 +1,7 @@ +config BR2_PACKAGE_HOST_PYTHON_GREENLET + bool "host python-greenlet" + help + Greenlets are lightweight coroutines for in-process concurrent + programming. + + https://greenlet.readthedocs.io/
package/python-greenlet/python-greenlet.mk +1 -0
@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package))
Signature · 7 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Yann E. MORIN
AppliedCyril, All,
On 2022-01-10 14:11 +0000, Cyril Bur spake thusly:
Quoted 7 lines
While currently there is no in-tree Buildroot package which depends on host-python-greenlet, we (Adder Technology) have some proprietary modules that use it as part of their builds.
I've tested python-greenlet as host package and confirmed that it builds and works correctly. Someone else might require it, so I'm proposing its inclusion.
In all theory, host-python-greenlet should have the same dependencies toward the host that the target variant has toward the target:
config BR2_PACKAGE_PYTHON_GREENLET_ARCH_SUPPORTS
bool
default y if BR2_arm || BR2_armeb
default y if BR2_aarch64
default y if BR2_csky
default y if BR2_m68k
default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le
default y if BR2_riscv
default y if BR2_sparc || BR2_sparc64
default y if BR2_i386 || BR2_x86_64However, in practice, hosts that are commonly used to run Buildroot are virtually all in that list: x86 or x86_64, AArch64 (and maybe a very few arms just for the fun), PPC, and maybe a few adventurous on riscv.
So in practice, we do not care.
Quoted 1 line
Signed-off-by Cyril Bur <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 52 lines
---
v2: Half completed commit message update - sorry
v3: Updated commit message and Config.in.hostpackage/Config.in.host | 1 + package/python-greenlet/Config.in.host | 7 +++++++ package/python-greenlet/python-greenlet.mk | 1 + 3 files changed, 9 insertions(+) create mode 100644 package/python-greenlet/Config.in.hostpackage/Config.in.host +1
-0@@ -69,6 +69,7 @@ menu "Host utilities" source "package/pwgen/Config.in.host" source "package/python/Config.in.host" source "package/python-cython/Config.in.host" + source "package/python-greenlet/Config.in.host" source "package/python-lxml/Config.in.host" source "package/python-six/Config.in.host" source "package/python-xlrd/Config.in.host"package/python-greenlet/Config.in.host new file +7
-0@@ -0,0 +1,7 @@ +config BR2_PACKAGE_HOST_PYTHON_GREENLET + bool "host python-greenlet" + help + Greenlets are lightweight coroutines for in-process concurrent + programming. + + https://greenlet.readthedocs.io/package/python-greenlet/python-greenlet.mk +1
-0@@ -12,3 +12,4 @@ PYTHON_GREENLET_LICENSE = MIT, PSF-2.0 PYTHON_GREENLET_LICENSE_FILES = LICENSE LICENSE.PSF $(eval $(python-package)) +$(eval $(host-python-package))Signature · 7 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot