Deprecate struct drm_device.irq_enabled

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c +3 -3

index 32ce0e679dc7..7dad44e73cf6 100644
@@ -599,7 +599,7 @@ void amdgpu_irq_gpu_reset_resume_helper(struct amdgpu_device *adev)
 int amdgpu_irq_get(struct amdgpu_device *adev, struct amdgpu_irq_src *src,
 		   unsigned type)
 {
-	if (!adev_to_drm(adev)->irq_enabled)
+	if (!adev->irq.installed)
 		return -ENOENT;
 
 	if (type >= src->num_types)

@@ -629,7 +629,7 @@ int amdgpu_irq_get(struct amdgpu_device *adev, struct amdgpu_irq_src *src,
 int amdgpu_irq_put(struct amdgpu_device *adev, struct amdgpu_irq_src *src,
 		   unsigned type)
 {
-	if (!adev_to_drm(adev)->irq_enabled)
+	if (!adev->irq.installed)
 		return -ENOENT;
 
 	if (type >= src->num_types)

@@ -660,7 +660,7 @@ int amdgpu_irq_put(struct amdgpu_device *adev, struct amdgpu_irq_src *src,
 bool amdgpu_irq_enabled(struct amdgpu_device *adev, struct amdgpu_irq_src *src,
 			unsigned type)
 {
-	if (!adev_to_drm(adev)->irq_enabled)
+	if (!adev->irq.installed)
 		return false;
 
 	if (type >= src->num_types)

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #2 lore raw

PATCH v4 2/27 drm/hibmc: Call drm_irq_uninstall() unconditionally

Remove the check around drm_irq_uninstall(). The same test is done by the function internally. The tested state in irq_enabled is considered obsolete and should not be used by KMS drivers.

Signed-off-by Thomas Zimmermann <[email protected]>

Acked-by Tian Tao <[email protected]>

---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +1 -2

index f4bc5386574a..f8ef711bbe5d 100644
@@ -253,8 +253,7 @@ static int hibmc_unload(struct drm_device *dev)
 {
 	drm_atomic_helper_shutdown(dev);
 
-	if (dev->irq_enabled)
-		drm_irq_uninstall(dev);
+	drm_irq_uninstall(dev);
 
 	pci_disable_msi(to_pci_dev(dev->dev));

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #3 lore raw

PATCH v4 3/27 drm/radeon: Track IRQ state in local device state

Replace usage of struct drm_device.irq_enabled with the driver's own state field struct radeon_device.irq.installed. The field in the DRM device structure is considered legacy and should not be used by KMS drivers.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/radeon/radeon_fence.c   |  2 +-
 drivers/gpu/drm/radeon/radeon_irq_kms.c | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

drivers/gpu/drm/radeon/radeon_fence.c +1 -1

index 0d8ef2368adf..7ec581363e23 100644
@@ -288,7 +288,7 @@ static void radeon_fence_check_lockup(struct work_struct *work)
 		return;
 	}
 
-	if (fence_drv->delayed_irq && rdev->ddev->irq_enabled) {
+	if (fence_drv->delayed_irq && rdev->irq.installed) {
 		unsigned long irqflags;
 
 		fence_drv->delayed_irq = false;

drivers/gpu/drm/radeon/radeon_irq_kms.c +8 -8

index 84d0b1a3355f..a36ce826d0c0 100644
@@ -357,7 +357,7 @@ void radeon_irq_kms_sw_irq_get(struct radeon_device *rdev, int ring)
 {
 	unsigned long irqflags;
 
-	if (!rdev->ddev->irq_enabled)
+	if (!rdev->irq.installed)
 		return;
 
 	if (atomic_inc_return(&rdev->irq.ring_int[ring]) == 1) {

@@ -396,7 +396,7 @@ void radeon_irq_kms_sw_irq_put(struct radeon_device *rdev, int ring)
 {
 	unsigned long irqflags;
 
-	if (!rdev->ddev->irq_enabled)
+	if (!rdev->irq.installed)
 		return;
 
 	if (atomic_dec_and_test(&rdev->irq.ring_int[ring])) {

@@ -422,7 +422,7 @@ void radeon_irq_kms_pflip_irq_get(struct radeon_device *rdev, int crtc)
 	if (crtc < 0 || crtc >= rdev->num_crtc)
 		return;
 
-	if (!rdev->ddev->irq_enabled)
+	if (!rdev->irq.installed)
 		return;
 
 	if (atomic_inc_return(&rdev->irq.pflip[crtc]) == 1) {

@@ -448,7 +448,7 @@ void radeon_irq_kms_pflip_irq_put(struct radeon_device *rdev, int crtc)
 	if (crtc < 0 || crtc >= rdev->num_crtc)
 		return;
 
-	if (!rdev->ddev->irq_enabled)
+	if (!rdev->irq.installed)
 		return;
 
 	if (atomic_dec_and_test(&rdev->irq.pflip[crtc])) {

@@ -470,7 +470,7 @@ void radeon_irq_kms_enable_afmt(struct radeon_device *rdev, int block)
 {
 	unsigned long irqflags;
 
-	if (!rdev->ddev->irq_enabled)
+	if (!rdev->irq.installed)
 		return;
 
 	spin_lock_irqsave(&rdev->irq.lock, irqflags);

@@ -492,7 +492,7 @@ void radeon_irq_kms_disable_afmt(struct radeon_device *rdev, int block)
 {
 	unsigned long irqflags;
 
-	if (!rdev->ddev->irq_enabled)
+	if (!rdev->irq.installed)
 		return;
 
 	spin_lock_irqsave(&rdev->irq.lock, irqflags);

@@ -514,7 +514,7 @@ void radeon_irq_kms_enable_hpd(struct radeon_device *rdev, unsigned hpd_mask)
 	unsigned long irqflags;
 	int i;
 
-	if (!rdev->ddev->irq_enabled)
+	if (!rdev->irq.installed)
 		return;
 
 	spin_lock_irqsave(&rdev->irq.lock, irqflags);

@@ -537,7 +537,7 @@ void radeon_irq_kms_disable_hpd(struct radeon_device *rdev, unsigned hpd_mask)
 	unsigned long irqflags;
 	int i;
 
-	if (!rdev->ddev->irq_enabled)
+	if (!rdev->irq.installed)
 		return;
 
 	spin_lock_irqsave(&rdev->irq.lock, irqflags);

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #4 lore raw

PATCH v4 4/27 drm: Don't test for IRQ support in VBLANK ioctls

For KMS drivers, replace the IRQ check in VBLANK ioctls with a check for vblank support. IRQs might be enabled wthout vblanking being supported.

This change also removes the DRM framework's only dependency on IRQ state for non-legacy drivers. For legacy drivers with userspace modesetting, the original test remains in drm_wait_vblank_ioctl().

v4:
* avoid preprocessor ifdef in drm_wait_vblank_ioctl() (Jani, Thierry)
v3:
* optimize test in drm_wait_vblank_ioctl() for KMS case (Liviu)
* update docs for drm_irq_uninstall()
v2:
* keep the old test for legacy drivers in drm_wait_vblank_ioctl() (Daniel)

Signed-off-by Thomas Zimmermann <[email protected]>

Reviewed-by Liviu Dudau <[email protected]>

---
 drivers/gpu/drm/drm_irq.c    | 13 ++++---------
 drivers/gpu/drm/drm_vblank.c | 15 ++++++++++++---
 2 files changed, 16 insertions(+), 12 deletions(-)

drivers/gpu/drm/drm_irq.c +4 -9

index c3bd664ea733..945dd82e2ea3 100644
@@ -74,10 +74,8 @@
  * only supports devices with a single interrupt on the main device stored in
  * &drm_device.dev and set as the device paramter in drm_dev_alloc().
  *
- * These IRQ helpers are strictly optional. Drivers which roll their own only
- * need to set &drm_device.irq_enabled to signal the DRM core that vblank
- * interrupts are working. Since these helpers don't automatically clean up the
- * requested interrupt like e.g. devm_request_irq() they're not really
+ * These IRQ helpers are strictly optional. Since these helpers don't automatically
+ * clean up the requested interrupt like e.g. devm_request_irq() they're not really
  * recommended.
  */

@@ -91,9 +89,7 @@
  * and after the installation.
  *
  * This is the simplified helper interface provided for drivers with no special
- * needs. Drivers which need to install interrupt handlers for multiple
- * interrupts must instead set &drm_device.irq_enabled to signal the DRM core
- * that vblank interrupts are available.
+ * needs.
  *
  * @irq must match the interrupt number that would be passed to request_irq(),
  * if called directly instead of using this helper function.

@@ -156,8 +152,7 @@ EXPORT_SYMBOL(drm_irq_install);
  *
  * Calls the driver's &drm_driver.irq_uninstall function and unregisters the IRQ
  * handler.  This should only be called by drivers which used drm_irq_install()
- * to set up their interrupt handler. Other drivers must only reset
- * &drm_device.irq_enabled to false.
+ * to set up their interrupt handler.
  *
  * Note that for kernel modesetting drivers it is a bug if this function fails.
  * The sanity checks are only to catch buggy user modesetting drivers which call

drivers/gpu/drm/drm_vblank.c +12 -3

index 3417e1ac7918..bba6781cc48f 100644
@@ -1737,6 +1737,15 @@ static void drm_wait_vblank_reply(struct drm_device *dev, unsigned int pipe,
 	reply->tval_usec = ts.tv_nsec / 1000;
 }
 
+static bool drm_wait_vblank_supported(struct drm_device *dev)
+{
+	if  (IS_ENABLED(CONFIG_DRM_LEGACY)) {
+		if (unlikely(drm_core_check_feature(dev, DRIVER_LEGACY)))
+			return dev->irq_enabled;
+	}
+	return drm_dev_has_vblank(dev);
+}
+
 int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,
 			  struct drm_file *file_priv)
 {

@@ -1748,7 +1757,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,
 	unsigned int pipe_index;
 	unsigned int flags, pipe, high_pipe;
 
-	if (!dev->irq_enabled)
+	if (!drm_wait_vblank_supported(dev))
 		return -EOPNOTSUPP;
 
 	if (vblwait->request.type & _DRM_VBLANK_SIGNAL)

@@ -2023,7 +2032,7 @@ int drm_crtc_get_sequence_ioctl(struct drm_device *dev, void *data,
 	if (!drm_core_check_feature(dev, DRIVER_MODESET))
 		return -EOPNOTSUPP;
 
-	if (!dev->irq_enabled)
+	if (!drm_dev_has_vblank(dev))
 		return -EOPNOTSUPP;
 
 	crtc = drm_crtc_find(dev, file_priv, get_seq->crtc_id);

@@ -2082,7 +2091,7 @@ int drm_crtc_queue_sequence_ioctl(struct drm_device *dev, void *data,
 	if (!drm_core_check_feature(dev, DRIVER_MODESET))
 		return -EOPNOTSUPP;
 
-	if (!dev->irq_enabled)
+	if (!drm_dev_has_vblank(dev))
 		return -EOPNOTSUPP;
 
 	crtc = drm_crtc_find(dev, file_priv, queue_seq->crtc_id);

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #5 lore raw

PATCH v4 5/27 drm/armada: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in armada.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/armada/armada_drv.c | 2 --
 1 file changed, 2 deletions(-)

drivers/gpu/drm/armada/armada_drv.c +0 -2

index dab0a1f0983b..4a64f1b9ec4d 100644
@@ -130,8 +130,6 @@ static int armada_drm_bind(struct device *dev)
 	if (ret)
 		goto err_comp;
 
-	priv->drm.irq_enabled = true;
-
 	drm_mode_config_reset(&priv->drm);
 
 	ret = armada_fbdev_init(&priv->drm);

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-28 06:23 UTC #6 lore raw

Re: [PATCH v4 05/27] drm/armada: Don't set struct drm_device.irq_enabled

Am 25.06.21 um 10:22 schrieb Thomas Zimmermann:

Quoted 4 lines

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in armada.
Signed-off-by Thomas Zimmermann <[email protected]>

R-b'ed by Laurent via IRC

Quoted 18 lines

---
  drivers/gpu/drm/armada/armada_drv.c | 2 --
  1 file changed, 2 deletions(-)

drivers/gpu/drm/armada/armada_drv.c +0 -2

index dab0a1f0983b..4a64f1b9ec4d 100644
@@ -130,8 +130,6 @@ static int armada_drm_bind(struct device *dev)
  	if (ret)
  		goto err_comp;
 
-	priv->drm.irq_enabled = true;
-
  	drm_mode_config_reset(&priv->drm);
 
  	ret = armada_fbdev_init(&priv->drm);

Signature · 6 lines

Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #7 lore raw

PATCH v4 6/27 drm/i915: Track IRQ state in local device state

Replace usage of struct drm_device.irq_enabled with the driver's own state field struct drm_i915_private.irq_enabled. The field in the DRM device structure is considered legacy and should not be used by KMS drivers.

Signed-off-by Thomas Zimmermann <[email protected]>

Reviewed-by Jani Nikula <[email protected]>

---
 drivers/gpu/drm/i915/i915_drv.h | 2 ++
 drivers/gpu/drm/i915/i915_irq.c | 8 ++++----
 2 files changed, 6 insertions(+), 4 deletions(-)

drivers/gpu/drm/i915/i915_drv.h +2 -0

index 01e11fe38642..48c1835bd54b 100644
@@ -1134,6 +1134,8 @@ struct drm_i915_private {
 	/* For i915gm/i945gm vblank irq workaround */
 	u8 vblank_enabled;
 
+	bool irq_enabled;
+
 	/* perform PHY state sanity checks? */
 	bool chv_phy_assert[2];

drivers/gpu/drm/i915/i915_irq.c +4 -4

index a11bdb667241..987211f21761 100644
@@ -4488,14 +4488,14 @@ int intel_irq_install(struct drm_i915_private *dev_priv)
 	 */
 	dev_priv->runtime_pm.irqs_enabled = true;
 
-	dev_priv->drm.irq_enabled = true;
+	dev_priv->irq_enabled = true;
 
 	intel_irq_reset(dev_priv);
 
 	ret = request_irq(irq, intel_irq_handler(dev_priv),
 			  IRQF_SHARED, DRIVER_NAME, dev_priv);
 	if (ret < 0) {
-		dev_priv->drm.irq_enabled = false;
+		dev_priv->irq_enabled = false;
 		return ret;
 	}

@@ -4521,10 +4521,10 @@ void intel_irq_uninstall(struct drm_i915_private *dev_priv)
 	 * intel_modeset_driver_remove() calling us out of sequence.
 	 * Would be nice if it didn't do that...
 	 */
-	if (!dev_priv->drm.irq_enabled)
+	if (!dev_priv->irq_enabled)
 		return;
 
-	dev_priv->drm.irq_enabled = false;
+	dev_priv->irq_enabled = false;
 
 	intel_irq_reset(dev_priv);

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #8 lore raw

PATCH v4 7/27 drm/komeda: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in komeda.

Signed-off-by Thomas Zimmermann <[email protected]>

Acked-by Liviu Dudau <[email protected]>

---
 drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 ----
 1 file changed, 4 deletions(-)

drivers/gpu/drm/arm/display/komeda/komeda_kms.c +0 -4

index ff45f23f3d56..52a6db5707a3 100644
@@ -301,8 +301,6 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
 	if (err)
 		goto free_component_binding;
 
-	drm->irq_enabled = true;
-
 	drm_kms_helper_poll_init(drm);
 
 	err = drm_dev_register(drm, 0);

@@ -313,7 +311,6 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
 
 free_interrupts:
 	drm_kms_helper_poll_fini(drm);
-	drm->irq_enabled = false;
 free_component_binding:
 	component_unbind_all(mdev->dev, drm);
 cleanup_mode_config:

@@ -331,7 +328,6 @@ void komeda_kms_detach(struct komeda_kms_dev *kms)
 	drm_dev_unregister(drm);
 	drm_kms_helper_poll_fini(drm);
 	drm_atomic_helper_shutdown(drm);
-	drm->irq_enabled = false;
 	component_unbind_all(mdev->dev, drm);
 	drm_mode_config_cleanup(drm);
 	komeda_kms_cleanup_private_objs(kms);

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #9 lore raw

PATCH v4 8/27 drm/malidp: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in malidp.

Signed-off-by Thomas Zimmermann <[email protected]>

Acked-by Liviu Dudau <[email protected]>

---
 drivers/gpu/drm/arm/malidp_drv.c | 4 ----
 1 file changed, 4 deletions(-)

drivers/gpu/drm/arm/malidp_drv.c +0 -4

index de59f3302516..78d15b04b105 100644
@@ -847,8 +847,6 @@ static int malidp_bind(struct device *dev)
 	if (ret < 0)
 		goto irq_init_fail;
 
-	drm->irq_enabled = true;
-
 	ret = drm_vblank_init(drm, drm->mode_config.num_crtc);
 	if (ret < 0) {
 		DRM_ERROR("failed to initialise vblank\n");

@@ -874,7 +872,6 @@ static int malidp_bind(struct device *dev)
 vblank_fail:
 	malidp_se_irq_fini(hwdev);
 	malidp_de_irq_fini(hwdev);
-	drm->irq_enabled = false;
 irq_init_fail:
 	drm_atomic_helper_shutdown(drm);
 	component_unbind_all(dev, drm);

@@ -909,7 +906,6 @@ static void malidp_unbind(struct device *dev)
 	drm_atomic_helper_shutdown(drm);
 	malidp_se_irq_fini(hwdev);
 	malidp_de_irq_fini(hwdev);
-	drm->irq_enabled = false;
 	component_unbind_all(dev, drm);
 	of_node_put(malidp->crtc.port);
 	malidp->crtc.port = NULL;

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #10 lore raw

PATCH v4 9/27 drm/exynos: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in exynos.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/exynos/exynos_drm_drv.c | 10 ----------
 1 file changed, 10 deletions(-)

drivers/gpu/drm/exynos/exynos_drm_drv.c +0 ~~-10~~

index e60257f1f24b..d8f1cf4d6b69 100644
@@ -300,16 +300,6 @@ static int exynos_drm_bind(struct device *dev)
 
 	drm_mode_config_reset(drm);
 
-	/*
-	 * enable drm irq mode.
-	 * - with irq_enabled = true, we can use the vblank feature.
-	 *
-	 * P.S. note that we wouldn't use drm irq handler but
-	 *	just specific driver own one instead because
-	 *	drm framework supports only one irq handler.
-	 */
-	drm->irq_enabled = true;
-
 	/* init kms poll for handling hpd */
 	drm_kms_helper_poll_init(drm);

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #11 lore raw

PATCH v4 10/27 drm/kirin: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in kirin.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 2 --
 1 file changed, 2 deletions(-)

drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c +0 -2

index e590e19db657..98ae9a48f3fe 100644
@@ -185,8 +185,6 @@ static int kirin_drm_kms_init(struct drm_device *dev,
 		DRM_ERROR("failed to initialize vblank.\n");
 		goto err_unbind_all;
 	}
-	/* with irq_enabled = true, we can use the vblank feature. */
-	dev->irq_enabled = true;
 
 	/* reset all the states of crtc/plane/encoder/connector */
 	drm_mode_config_reset(dev);

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #12 lore raw

PATCH v4 11/27 drm/imx: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in imx.

v3:
* move dcss changes into separate patch (Laurentiu)

Signed-off-by Thomas Zimmermann <[email protected]>

Acked-by Philipp Zabel <[email protected]>

---
 drivers/gpu/drm/imx/imx-drm-core.c | 11 -----------
 1 file changed, 11 deletions(-)

drivers/gpu/drm/imx/imx-drm-core.c +0 ~~-11~~

index 76819a8ac37f..9558e9e1b431 100644
@@ -207,17 +207,6 @@ static int imx_drm_bind(struct device *dev)
 	if (IS_ERR(drm))
 		return PTR_ERR(drm);
 
-	/*
-	 * enable drm irq mode.
-	 * - with irq_enabled = true, we can use the vblank feature.
-	 *
-	 * P.S. note that we wouldn't use drm irq handler but
-	 *      just specific driver own one instead because
-	 *      drm framework supports only one irq handler and
-	 *      drivers can well take care of their interrupts
-	 */
-	drm->irq_enabled = true;
-
 	/*
 	 * set max width and height as default value(4096x4096).
 	 * this value would be used to check framebuffer size limitation

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #13 lore raw

PATCH v4 12/27 drm/imx/dcss: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in dcss.

Signed-off-by Thomas Zimmermann <[email protected]>

Acked-by Laurentiu Palcu <[email protected]>

---
 drivers/gpu/drm/imx/dcss/dcss-kms.c | 3 ---
 1 file changed, 3 deletions(-)

drivers/gpu/drm/imx/dcss/dcss-kms.c +0 -3

index 37ae68a7fba5..917834b1c80e 100644
@@ -133,8 +133,6 @@ struct dcss_kms_dev *dcss_kms_attach(struct dcss_dev *dcss)
 	if (ret)
 		goto cleanup_mode_config;
 
-	drm->irq_enabled = true;
-
 	ret = dcss_kms_bridge_connector_init(kms);
 	if (ret)
 		goto cleanup_mode_config;

@@ -178,7 +176,6 @@ void dcss_kms_detach(struct dcss_kms_dev *kms)
 	drm_kms_helper_poll_fini(drm);
 	drm_atomic_helper_shutdown(drm);
 	drm_crtc_vblank_off(&kms->crtc.base);
-	drm->irq_enabled = false;
 	drm_mode_config_cleanup(drm);
 	dcss_crtc_deinit(&kms->crtc, drm);
 	drm->dev_private = NULL;

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #14 lore raw

PATCH v4 13/27 drm/mediatek: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in mediatek.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ------
 1 file changed, 6 deletions(-)

drivers/gpu/drm/mediatek/mtk_drm_drv.c +0 -6

index b46bdb8985da..9b60bec33d3b 100644
@@ -270,12 +270,6 @@ static int mtk_drm_kms_init(struct drm_device *drm)
 		goto err_component_unbind;
 	}
 
-	/*
-	 * We don't use the drm_irq_install() helpers provided by the DRM
-	 * core, so we need to set this manually in order to allow the
-	 * DRM_IOCTL_WAIT_VBLANK to operate correctly.
-	 */
-	drm->irq_enabled = true;
 	ret = drm_vblank_init(drm, MAX_CRTC);
 	if (ret < 0)
 		goto err_component_unbind;

Signature · 1 line

2.32.0

Chun-Kuang Hu

maintainer Acked-by on v4 13/27

2021-08-09 13:09 UTC #15 lore raw

Re: [PATCH v4 13/27] drm/mediatek: Don't set struct drm_device.irq_enabled

Hi, Thomas:

Thomas Zimmermann <[email protected]> 於 2021年6月25日週五下午4:22寫道：

Quoted 4 lines

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in mediatek.

Acked-by Chun-Kuang Hu <[email protected]>

Quoted 27 lines

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 ------
 1 file changed, 6 deletions(-)

drivers/gpu/drm/mediatek/mtk_drm_drv.c +0 -7

index b46bdb8985da..9b60bec33d3b 100644
@@ -270,12 +270,6 @@ static int mtk_drm_kms_init(struct drm_device *drm)
                goto err_component_unbind;
        }
 
-       /*
-        * We don't use the drm_irq_install() helpers provided by the DRM
-        * core, so we need to set this manually in order to allow the
-        * DRM_IOCTL_WAIT_VBLANK to operate correctly.
-        */
-       drm->irq_enabled = true;
        ret = drm_vblank_init(drm, MAX_CRTC);
        if (ret < 0)
                goto err_component_unbind;
--

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #16 lore raw

PATCH v4 14/27 drm/nouveau: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in nouveau.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/nouveau/nouveau_drm.c | 3 ---
 1 file changed, 3 deletions(-)

drivers/gpu/drm/nouveau/nouveau_drm.c +0 -3

index a616cf4573b8..1cb14e99a60c 100644
@@ -553,8 +553,6 @@ nouveau_drm_device_init(struct drm_device *dev)
 	if (ret)
 		goto fail_master;
 
-	dev->irq_enabled = true;
-
 	nvxx_client(&drm->client.base)->debug =
 		nvkm_dbgopt(nouveau_debug, "DRM");

@@ -795,7 +793,6 @@ nouveau_drm_device_remove(struct drm_device *dev)
 
 	drm_dev_unregister(dev);
 
-	dev->irq_enabled = false;
 	client = nvxx_client(&drm->client.base);
 	device = nvkm_device_find(client->device);

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #17 lore raw

PATCH v4 15/27 drm/omapdrm: Track IRQ state in local device state

Replace usage of struct drm_device.irq_enabled with the driver's own state field struct omap_drm_device.irq_enabled. The field in the DRM device structure is considered legacy and should not be used by KMS drivers.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/omapdrm/omap_drv.h | 2 ++
 drivers/gpu/drm/omapdrm/omap_irq.c | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

drivers/gpu/drm/omapdrm/omap_drv.h +2 -0

index d6f136984da9..591d4c273f02 100644
@@ -48,6 +48,8 @@ struct omap_drm_private {
 	struct dss_device *dss;
 	struct dispc_device *dispc;
 
+	bool irq_enabled;
+
 	unsigned int num_pipes;
 	struct omap_drm_pipeline pipes[8];
 	struct omap_drm_pipeline *channels[8];

drivers/gpu/drm/omapdrm/omap_irq.c +3 -3

index 15148d4b35b5..bb6e3fc18204 100644
@@ -291,7 +291,7 @@ int omap_drm_irq_install(struct drm_device *dev)
 	if (ret < 0)
 		return ret;
 
-	dev->irq_enabled = true;
+	priv->irq_enabled = true;
 
 	return 0;
 }

@@ -300,10 +300,10 @@ void omap_drm_irq_uninstall(struct drm_device *dev)
 {
 	struct omap_drm_private *priv = dev->dev_private;
 
-	if (!dev->irq_enabled)
+	if (!priv->irq_enabled)
 		return;
 
-	dev->irq_enabled = false;
+	priv->irq_enabled = false;
 
 	dispc_free_irq(priv->dispc, dev);
 }

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #18 lore raw

PATCH v4 16/27 drm/rcar-du: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in rcar-du.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 --
 1 file changed, 2 deletions(-)

drivers/gpu/drm/rcar-du/rcar_du_drv.c +0 -2

index bfbff90588cb..e289a66594a7 100644
@@ -593,8 +593,6 @@ static int rcar_du_probe(struct platform_device *pdev)
 		goto error;
 	}
 
-	rcdu->ddev.irq_enabled = 1;
-
 	/*
 	 * Register the DRM device with the core and the connectors with
 	 * sysfs.

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #19 lore raw

PATCH v4 17/27 drm/rockchip: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in rockchip.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 6 ------
 1 file changed, 6 deletions(-)

drivers/gpu/drm/rockchip/rockchip_drm_drv.c +0 -6

index b730b8d5d949..c8e60fd9ff24 100644
@@ -162,12 +162,6 @@ static int rockchip_drm_bind(struct device *dev)
 
 	drm_mode_config_reset(drm_dev);
 
-	/*
-	 * enable drm irq mode.
-	 * - with irq_enabled = true, we can use the vblank feature.
-	 */
-	drm_dev->irq_enabled = true;
-
 	ret = rockchip_drm_fbdev_init(drm_dev);
 	if (ret)
 		goto err_unbind_all;

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #20 lore raw

PATCH v4 18/27 drm/sti: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in sti.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/sti/sti_compositor.c | 2 --
 1 file changed, 2 deletions(-)

drivers/gpu/drm/sti/sti_compositor.c +0 -2

index 319962a2c17b..9caaf3ccfabe 100644
@@ -145,8 +145,6 @@ static int sti_compositor_bind(struct device *dev,
 	}
 
 	drm_vblank_init(drm_dev, crtc_id);
-	/* Allow usage of vblank without having to call drm_irq_install */
-	drm_dev->irq_enabled = 1;
 
 	return 0;
 }

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #21 lore raw

PATCH v4 19/27 drm/stm: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in stm.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/stm/ltdc.c | 3 ---
 1 file changed, 3 deletions(-)

drivers/gpu/drm/stm/ltdc.c +0 -3

index 08b71248044d..e9c5a52f041a 100644
@@ -1339,9 +1339,6 @@ int ltdc_load(struct drm_device *ddev)
 		goto err;
 	}
 
-	/* Allow usage of vblank without having to call drm_irq_install */
-	ddev->irq_enabled = 1;
-
 	clk_disable_unprepare(ldev->pixel_clk);
 
 	pinctrl_pm_select_sleep_state(ddev->dev);

Signature · 1 line

2.32.0

yannick Fertre

maintainer Tested-by on v4 19/27

2021-06-29 09:19 UTC #22 lore raw

Re: [PATCH v4 19/27] drm/stm: Don't set struct drm_device.irq_enabled

Hello Thomas,
thanks for the patch.

Tested-by Yannick Fertre <[email protected]>

Best regards

Quoted 25 lines · Thomas Zimmermann

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in stm.
Signed-off-by Thomas Zimmermann <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Acked-by Daniel Vetter <[email protected]>
---
  drivers/gpu/drm/stm/ltdc.c | 3 ---
  1 file changed, 3 deletions(-)
drivers/gpu/drm/stm/ltdc.c +0 -3
index 08b71248044d..e9c5a52f041a 100644
@@ -1339,9 +1339,6 @@ int ltdc_load(struct drm_device *ddev)
  		goto err;
  	}
 
-	/* Allow usage of vblank without having to call drm_irq_install */
-	ddev->irq_enabled = 1;
-
  	clk_disable_unprepare(ldev->pixel_clk);
 
  	pinctrl_pm_select_sleep_state(ddev->dev);

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #23 lore raw

PATCH v4 20/27 drm/sun4i: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in sun4i.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/sun4i/sun4i_drv.c | 2 --
 1 file changed, 2 deletions(-)

drivers/gpu/drm/sun4i/sun4i_drv.c +0 -2

index af335f58bdfc..570f3af25e86 100644
@@ -97,8 +97,6 @@ static int sun4i_drv_bind(struct device *dev)
 	if (ret)
 		goto cleanup_mode_config;
 
-	drm->irq_enabled = true;
-
 	/* Remove early framebuffers (ie. simplefb) */
 	ret = drm_aperture_remove_framebuffers(false, "sun4i-drm-fb");
 	if (ret)

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #24 lore raw

PATCH v4 21/27 drm/tegra: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in tegra.

Signed-off-by Thomas Zimmermann <[email protected]>

Acked-by Thierry Reding <[email protected]>

---
 drivers/gpu/drm/tegra/drm.c | 7 -------
 1 file changed, 7 deletions(-)

drivers/gpu/drm/tegra/drm.c +0 -7

index f96c237b2242..8d27c21ddf48 100644
@@ -1188,13 +1188,6 @@ static int host1x_drm_probe(struct host1x_device *dev)
 			goto device;
 	}
 
-	/*
-	 * We don't use the drm_irq_install() helpers provided by the DRM
-	 * core, so we need to set this manually in order to allow the
-	 * DRM_IOCTL_WAIT_VBLANK to operate correctly.
-	 */
-	drm->irq_enabled = true;
-
 	/* syncpoints are used for full 32-bit hardware VBLANK counters */
 	drm->max_vblank_count = 0xffffffff;

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #25 lore raw

PATCH v4 22/27 drm/tidss: Don't use struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't use it in tidss.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/tidss/tidss_irq.c | 3 ---
 1 file changed, 3 deletions(-)

drivers/gpu/drm/tidss/tidss_irq.c +0 -3

index a5ec7931ef6b..2ed3e3296776 100644
@@ -57,9 +57,6 @@ irqreturn_t tidss_irq_handler(int irq, void *arg)
 	unsigned int id;
 	dispc_irq_t irqstatus;
 
-	if (WARN_ON(!ddev->irq_enabled))
-		return IRQ_NONE;
-
 	irqstatus = dispc_read_and_clear_irqstatus(tidss->dispc);
 
 	for (id = 0; id < tidss->num_crtcs; id++) {

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #26 lore raw

PATCH v4 23/27 drm/vc4: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in vc4.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/vc4/vc4_kms.c | 1 -
 1 file changed, 1 deletion(-)

drivers/gpu/drm/vc4/vc4_kms.c +0 -1

index 6a1a9e1d72ce..f0b3e4cf5bce 100644
@@ -880,7 +880,6 @@ int vc4_kms_load(struct drm_device *dev)
 	/* Set support for vblank irq fast disable, before drm_vblank_init() */
 	dev->vblank_disable_immediate = true;
 
-	dev->irq_enabled = true;
 	ret = drm_vblank_init(dev, dev->mode_config.num_crtc);
 	if (ret < 0) {
 		dev_err(dev->dev, "failed to initialize vblank\n");

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #27 lore raw

PATCH v4 24/27 drm/vkms: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in vkms.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/vkms/vkms_drv.c | 2 --
 1 file changed, 2 deletions(-)

drivers/gpu/drm/vkms/vkms_drv.c +0 -2

index 027ffe759440..496de38ad983 100644
@@ -163,8 +163,6 @@ static int vkms_create(struct vkms_config *config)
 		goto out_devres;
 	}
 
-	vkms_device->drm.irq_enabled = true;
-
 	ret = drm_vblank_init(&vkms_device->drm, 1);
 	if (ret) {
 		DRM_ERROR("Failed to vblank\n");

Signature · 1 line

2.32.0

Melissa Wen

reviewer Reviewed-by on v4 24/27

2021-06-26 08:55 UTC #28 lore raw

Re: [PATCH v4 24/27] drm/vkms: Don't set struct drm_device.irq_enabled

Quoted 5 lines · Thomas Zimmermann

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in vkms.
Signed-off-by Thomas Zimmermann <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>

I've also checked here, lgtm.

Reviewed-by Melissa Wen <[email protected]>

Quoted 20 lines

---
 drivers/gpu/drm/vkms/vkms_drv.c | 2 --
 1 file changed, 2 deletions(-)

drivers/gpu/drm/vkms/vkms_drv.c +0 -2

index 027ffe759440..496de38ad983 100644
@@ -163,8 +163,6 @@ static int vkms_create(struct vkms_config *config)
 		goto out_devres;
 	}
 
-	vkms_device->drm.irq_enabled = true;
-
 	ret = drm_vblank_init(&vkms_device->drm, 1);
 	if (ret) {
 		DRM_ERROR("Failed to vblank\n");

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #29 lore raw

PATCH v4 25/27 drm/vmwgfx: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in vmxgfx. All usage of the field within vmwgfx can safely be removed.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/vmwgfx/vmwgfx_irq.c | 8 --------
 1 file changed, 8 deletions(-)

drivers/gpu/drm/vmwgfx/vmwgfx_irq.c +0 -8

index b9a9b7ddadbd..4b82f5995452 100644
@@ -292,15 +292,11 @@ void vmw_irq_uninstall(struct drm_device *dev)
 	if (!(dev_priv->capabilities & SVGA_CAP_IRQMASK))
 		return;
 
-	if (!dev->irq_enabled)
-		return;
-
 	vmw_write(dev_priv, SVGA_REG_IRQMASK, 0);
 
 	status = vmw_irq_status_read(dev_priv);
 	vmw_irq_status_write(dev_priv, status);
 
-	dev->irq_enabled = false;
 	free_irq(dev->irq, dev);
 }

@@ -315,9 +311,6 @@ int vmw_irq_install(struct drm_device *dev, int irq)
 {
 	int ret;
 
-	if (dev->irq_enabled)
-		return -EBUSY;
-
 	vmw_irq_preinstall(dev);
 
 	ret = request_threaded_irq(irq, vmw_irq_handler, vmw_thread_fn,

@@ -325,7 +318,6 @@ int vmw_irq_install(struct drm_device *dev, int irq)
 	if (ret < 0)
 		return ret;
 
-	dev->irq_enabled = true;
 	dev->irq = irq;
 
 	return ret;

Signature · 1 line

2.32.0

Zack Rusin

Reviewed-by on v4 25/27

2021-06-26 02:41 UTC #30 lore raw

Re: [PATCH v4 25/27] drm/vmwgfx: Don't set struct drm_device.irq_enabled

Quoted 10 lines · Thomas Zimmermann

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in vmxgfx. All usage of the field within vmwgfx can safely be removed.
Signed-off-by Thomas Zimmermann <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Acked-by Daniel Vetter <[email protected]>

Looks good.

Reviewed-by Zack Rusin <[email protected]>

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #31 lore raw

PATCH v4 26/27 drm/xlnx: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in xlnx.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 2 --
 1 file changed, 2 deletions(-)

drivers/gpu/drm/xlnx/zynqmp_dpsub.c +0 -2

index 0c1c50271a88..ac37053412a1 100644
@@ -111,8 +111,6 @@ static int zynqmp_dpsub_drm_init(struct zynqmp_dpsub *dpsub)
 	if (ret)
 		return ret;
 
-	drm->irq_enabled = 1;
-
 	drm_kms_helper_poll_init(drm);
 
 	/*

Signature · 1 line

2.32.0

Thomas Zimmermann

author maintainer

2021-06-25 08:22 UTC #32 lore raw

PATCH v4 27/27 drm/zte: Don't set struct drm_device.irq_enabled

The field drm_device.irq_enabled is only used by legacy drivers with userspace modesetting. Don't set it in zte.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 drivers/gpu/drm/zte/zx_drm_drv.c | 6 ------
 1 file changed, 6 deletions(-)

drivers/gpu/drm/zte/zx_drm_drv.c +0 -6

index 5506336594e2..064056503ebb 100644
@@ -75,12 +75,6 @@ static int zx_drm_bind(struct device *dev)
 		goto out_unbind;
 	}
 
-	/*
-	 * We will manage irq handler on our own.  In this case, irq_enabled
-	 * need to be true for using vblank core support.
-	 */
-	drm->irq_enabled = true;
-
 	drm_mode_config_reset(drm);
 	drm_kms_helper_poll_init(drm);

Signature · 1 line

2.32.0

Patchwork

2021-06-25 08:50 UTC #33 lore raw

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Deprecate struct drm_device.irq_enabled (rev2)

== Series Details ==

Series: Deprecate struct drm_device.irq_enabled (rev2)
URL : https://patchwork.freedesktop.org/series/91845/
State : warning

== Summary ==

$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB"
+drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB"
+drivers/gpu/drm/i915/display/intel_display.c:1893:21:    expected struct i915_vma *[assigned] vma
+drivers/gpu/drm/i915/display/intel_display.c:1893:21:    got void [noderef] __iomem *[assigned] iomem
+drivers/gpu/drm/i915/display/intel_display.c:1893:21: warning: incorrect type in assignment (different address spaces)
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31
+drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block
+drivers/gpu/drm/i915/gt/intel_ring_submission.c:1207:24: warning: Using plain integer as NULL pointer
+drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216
+drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216
+./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080)
+./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080)
+./include/linux/seqlock.h:840:24: warning: trying to copy expression type 31
+./include/linux/seqlock.h:840:24: warning: trying to copy expression type 31
+./include/linux/seqlock.h:866:16: warning: trying to copy expression type 31
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block
+./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2021-06-25 09:19 UTC #34 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for Deprecate struct drm_device.irq_enabled (rev2)

== Series Details ==

Series: Deprecate struct drm_device.irq_enabled (rev2)
URL : https://patchwork.freedesktop.org/series/91845/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10279 -> Patchwork_20466
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20466/index.html

Known issues
------------

Here are the changes found in Patchwork_20466 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@runner@aborted:
- fi-bdw-5557u: NOTRUN -> [FAIL][1] ([i915#1602] / [i915#2029])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20466/fi-bdw-5557u/igt@[email protected]

#### Possible fixes ####

* igt@i915_module_load@reload:
- {fi-tgl-dsi}: [DMESG-WARN][2] ([i915#1982] / [k.org#205379]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10279/fi-tgl-dsi/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20466/fi-tgl-dsi/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379

Participating hosts (43 -> 37)
------------------------------

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bdw-gvtdvm fi-glk-dsi fi-bsw-cyan fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_10279 -> Patchwork_20466

CI-20190529: 20190529
CI_DRM_10279: a996e82cbdc77fc789d0a385602e02f7e2478a1e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6119: a306810ebbc8984bde38a57ef0c33eea394f4e18 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20466: e1c155287a51ea8b770c774b9f98b77656dc2acc @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

e1c155287a51 drm/zte: Don't set struct drm_device.irq_enabled 0d788773b4a2 drm/xlnx: Don't set struct drm_device.irq_enabled 6e0450487727 drm/vmwgfx: Don't set struct drm_device.irq_enabled 1a40222c9b06 drm/vkms: Don't set struct drm_device.irq_enabled 5a68258241ce drm/vc4: Don't set struct drm_device.irq_enabled a1667c37b77a drm/tidss: Don't use struct drm_device.irq_enabled cdf717450b9f drm/tegra: Don't set struct drm_device.irq_enabled ff36999c025e drm/sun4i: Don't set struct drm_device.irq_enabled aeb6c0b29a7e drm/stm: Don't set struct drm_device.irq_enabled 07c0db48dd80 drm/sti: Don't set struct drm_device.irq_enabled 0bc658b72ff7 drm/rockchip: Don't set struct drm_device.irq_enabled 6c146315f78b drm/rcar-du: Don't set struct drm_device.irq_enabled 5192f22d62d4 drm/omapdrm: Track IRQ state in local device state 75ab41cf85ba drm/nouveau: Don't set struct drm_device.irq_enabled 3397b281d304 drm/mediatek: Don't set struct drm_device.irq_enabled e6112f1649c3 drm/imx/dcss: Don't set struct drm_device.irq_enabled 2653cbdb30bb drm/imx: Don't set struct drm_device.irq_enabled 0e30c8dbb5d4 drm/kirin: Don't set struct drm_device.irq_enabled 55f896d83228 drm/exynos: Don't set struct drm_device.irq_enabled 5aec6c6f8fc4 drm/malidp: Don't set struct drm_device.irq_enabled 99ea1463f8fb drm/komeda: Don't set struct drm_device.irq_enabled fb1312913e45 drm/i915: Track IRQ state in local device state feeaf91e136a drm/armada: Don't set struct drm_device.irq_enabled 87185ebf5f0c drm: Don't test for IRQ support in VBLANK ioctls f1fa91fa0489 drm/radeon: Track IRQ state in local device state 67cea301f9df drm/hibmc: Call drm_irq_uninstall() unconditionally 3045cc2d3cf2 drm/amdgpu: Track IRQ state in local device state

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20466/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2021-06-25 10:47 UTC #35 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for Deprecate struct drm_device.irq_enabled (rev2)