net: sparx5: Do not use mac_addr uninitialized in mchp_sparx5_probe()
Subsystems (3)
PATCH 1/1 net: sparx5: Do not use mac_addr uninitialized in mchp_sparx5_probe()
Clang warns:
drivers/net/ethernet/microchip/sparx5/sparx5_main.c:760:29: warning:
variable 'mac_addr' is uninitialized when used here [-Wuninitialized]
if (of_get_mac_address(np, mac_addr)) {
^~~~~~~~
drivers/net/ethernet/microchip/sparx5/sparx5_main.c:669:14: note:
initialize the variable 'mac_addr' to silence this warning
u8 *mac_addr;
^
= NULL1 warning generated.
mac_addr is only used to store the value retrieved from of_get_mac_address(), which is then copied into the base_mac member of the sparx5 struct using ether_addr_copy(). It is easier to just use the base_mac address directly, which avoids the warning and the extra copy.
--- drivers/net/ethernet/microchip/sparx5/sparx5_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/net/ethernet/microchip/sparx5/sparx5_main.c +1 -4
@@ -666,7 +666,6 @@ static int mchp_sparx5_probe(struct platform_device *pdev)struct reset_control *reset;struct sparx5 *sparx5;int idx =0 , err =0 ; -u8 *mac_addr;if (!np && !pdev->dev.platform_data)return -ENODEV ;
@@ -757,12 +756,10 @@ static int mchp_sparx5_probe(struct platform_device *pdev)if (err) goto cleanup_config; -if (of_get_mac_address (np, mac_addr)) { +if (!of_get_mac_address (np, sparx5->base_mac)) {dev_info (sparx5->dev,"MAC addr was not set, use random MAC\n" );eth_random_addr (sparx5->base_mac); sparx5->base_mac[5 ] =0 ; - }else { -ether_addr_copy (sparx5->base_mac, mac_addr); } sparx5->xtr_irq =platform_get_irq_byname (sparx5->pdev,"xtr" );
base-commit: ff8744b5eb116fdf9b80a6ff774393afac7325bd
Signature · 1 line
2.32.0.93.g670b81a890
This patch was applied to netdev/net-next.git (refs/heads/master):
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
Quoted 11 lines · On Sun, 27 Jun 2021 11:45:43 -0700 you wrote:
Clang warns:
drivers/net/ethernet/microchip/sparx5/sparx5_main.c:760:29: warning:
variable 'mac_addr' is uninitialized when used here [-Wuninitialized]if (of_get_mac_address(np, mac_addr)) { ^~~~~~~~ drivers/net/ethernet/microchip/sparx5/sparx5_main.c:669:14: note: initialize the variable 'mac_addr' to silence this warning u8 *mac_addr; ^ = NULL
Quoted 3 lines
1 warning generated.
[...]
Here is the summary with links:
- [net-next] net: sparx5: Do not use mac_addr uninitialized in mchp_sparx5_probe()
https://git.kernel.org/netdev/net-next/c/b74ef9f9cb91
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html