Skip to contentSkip to conversation

<linux/dma-resv.h>: correct a function name in kernel-doc

PATCH In review Randy Dunlap 2 participants 4 messages Jun 28, 2021 – Jun 29, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 <linux/dma-resv.h>: correct a function name in kernel-doc

Fix kernel-doc function name warning:

../include/linux/dma-resv.h:227: warning: expecting prototype for dma_resv_exclusive(). Prototype was for dma_resv_excl_fence() instead

Fixes 6edbd6abb783d ("ma-buf: rename and cleanup dma_resv_get_excl v3")
Cc Sumit Semwal <[email protected]>
Cc Christian König <[email protected]>
---
 include/linux/dma-resv.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/dma-resv.h +1 -1
@@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struc
 }
 
 /**
- * dma_resv_exclusive - return the object's exclusive fence
+ * dma_resv_excl_fence - return the object's exclusive fence
  * @obj: the reservation object
  *
  * Returns the exclusive fence (if any). Caller must either hold the objects
#1 lore raw
Quoted 11 lines · Randy Dunlap

Fix kernel-doc function name warning:

../include/linux/dma-resv.h:227: warning: expecting prototype for dma_resv_exclusive(). Prototype was for dma_resv_excl_fence() instead

Fixes 6edbd6abb783d ("ma-buf: rename and cleanup dma_resv_get_excl v3")
Cc Sumit Semwal <[email protected]>
Cc Christian König <[email protected]>

Queued up, thanks for your patch (and the handy -next signifier in the patch tag). I think Christian had the fix for this already, but queued up in the next branch (for the 5.15 merge window, we're already prepping stuff there to avoid late feature additions for 5.14), so applied yours once more to the right tree.

Cheers, Daniel

Quoted 15 lines
---
 include/linux/dma-resv.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/dma-resv.h +1 -1
@@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struc
 }
 
 /**
- * dma_resv_exclusive - return the object's exclusive fence
+ * dma_resv_excl_fence - return the object's exclusive fence
  * @obj: the reservation object
  *
  * Returns the exclusive fence (if any). Caller must either hold the objects
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#2 lore raw
Quoted 6 lines · Daniel Vetter
Quoted 5 lines · Randy Dunlap

Fix kernel-doc function name warning:

../include/linux/dma-resv.h:227: warning: expecting prototype for dma_resv_exclusive(). Prototype was for dma_resv_excl_fence() instead

Fixes 6edbd6abb783d ("ma-buf: rename and cleanup dma_resv_get_excl v3")

Script caught a lost 'd' here, I fixed that up when applying.
-Daniel

Quoted 35 lines
Quoted 6 lines

Queued up, thanks for your patch (and the handy -next signifier in the patch tag). I think Christian had the fix for this already, but queued up in the next branch (for the 5.15 merge window, we're already prepping stuff there to avoid late feature additions for 5.14), so applied yours once more to the right tree.

Cheers, Daniel

Quoted 15 lines
---
 include/linux/dma-resv.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/dma-resv.h +1 -1
@@ -212,7 +212,7 @@ static inline void dma_resv_unlock(struc
 }
 
 /**
- * dma_resv_exclusive - return the object's exclusive fence
+ * dma_resv_excl_fence - return the object's exclusive fence
  * @obj: the reservation object
  *
  * Returns the exclusive fence (if any). Caller must either hold the objects
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
#3 lore raw
Quoted 10 lines · Daniel Vetter
Quoted 6 lines · Daniel Vetter
Quoted 5 lines · Randy Dunlap

Fix kernel-doc function name warning:

../include/linux/dma-resv.h:227: warning: expecting prototype for dma_resv_exclusive(). Prototype was for dma_resv_excl_fence() instead

Fixes 6edbd6abb783d ("ma-buf: rename and cleanup dma_resv_get_excl v3")

Script caught a lost 'd' here, I fixed that up when applying.
-Daniel

Oops. Thanks.

~Randy