Skip to contentSkip to conversation

drm/msm/dpu: Fix sm8250_mdp register length

PATCH In review Robert Foss 2 participants 2 messages Jun 28, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/dpu: Fix sm8250_mdp register length

The downstream dts lists this value as 0x494, and not 0x45c.

Fixes af776a3e1c30 ("drm/msm/dpu: add SM8250 to hw catalog")
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +1 -1
index 189f3533525c..5d30c7f33930 100644
@@ -244,7 +244,7 @@ static const struct dpu_mdp_cfg sc7180_mdp[] = {
 static const struct dpu_mdp_cfg sm8250_mdp[] = {
 	{
 	.name = "top_0", .id = MDP_TOP,
-	.base = 0x0, .len = 0x45C,
+	.base = 0x0, .len = 0x494,
 	.features = 0,
 	.highest_bank_bit = 0x3, /* TODO: 2 for LP_DDR4 */
 	.clk_ctrls[DPU_CLK_CTRL_VIG0] = {
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw

Il 28/06/21 10:50, Robert Foss ha scritto:

Quoted 16 lines

The downstream dts lists this value as 0x494, and not 0x45c.

Fixes af776a3e1c30 ("drm/msm/dpu: add SM8250 to hw catalog")
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +0 -0
index 189f3533525c..5d30c7f33930 100644

drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c static const struct dpu_mdp_cfg sc7180_mdp[] = { · line 250

Quoted 8 lines
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c +1 -1
@@ -244,7 +244,7 @@ static const struct dpu_mdp_cfg sc7180_mdp[] = {
  static const struct dpu_mdp_cfg sm8250_mdp[] = {
  	{
  	.name = "top_0", .id = MDP_TOP,
-	.base = 0x0, .len = 0x45C,
+	.base = 0x0, .len = 0x494,
  	.features = 0,
  	.highest_bank_bit = 0x3, /* TODO: 2 for LP_DDR4 */
  	.clk_ctrls[DPU_CLK_CTRL_VIG0] = {

OK on Xperia 5 II (SM8250)