Skip to contentSkip to conversation

fix cpuhotplug04 check last cpu error

PATCH New [email protected] 2 participants 4 messages Jun 28, 2021 – Jun 30, 2021

lore
Share & tools
lore
#1 lore raw

PATCH 1/1 fix cpuhotplug04 check last cpu error

Quoted 5 lines · On Mon, Jun 28, 2021 at 11:58 AM <[email protected]> wrote:

This change makes sense.

On my computer, the last CPU can't be offline, which causes the execution of this testcase to fail.

But the CPU0 on your system will always online, so the last one should be offline safely.
If it not, that might a kernel issue I guess.

Quoted 5 lines

However, the testcase makes special treatment to the last CPU. If the last CPU cannot be offline, the execution result of the testcase should not be affected.

Yes, but from cpuhotplug04.sh comment line#84:

# If all the CPUs are hotpluggable, we expect

# that the kernel will refuse to offline the last CPU.
# If only some of the CPUs are hotpluggable,
# they all can be offlined.

How do you think of this description? In your system, it obviously belongs to
the second scenario that the cpu0 is online and you should be able to offline
all the remaining hotplugged one, isn't it?

Quoted 4 lines

Therefore, if cpu0 does not have an online file, it will lead to an error in the judgment of the last CPU.

If cpu0 does not have an online file, that means the last CPU (hotplugged) can be offline as well.
To verify this assumption, you can try manually offline CPU one by one, this time I suggest you
try the last one first.

Signature · 5 lines
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210628/2b93ddcf/attachment.htm>
#3 lore raw

PATCH 1/1 fix cpuhotplug04 check last cpu error【Suspected phishing email, please pay attention to password security】

Hi Hao,

Quoted 8 lines · ??

Hi LiWang:

you are right.

Quoted 9 lines

I asked the CPU manufacturers and tried several kernel, which should be the problem of the kernel.

I don't understand the code right.

Thank you very much.

You're welcome, and no one can always right,
just like Petr said: we are all learning.

Signature · 5 lines
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20210630/e2d6773b/attachment.htm>