Skip to contentSkip to conversation

clk: lmk04832: Depend on SPI

PATCH In review Stephen Boyd 2 participants 4 messages Jun 29, 2021 Common clk

lore
Share & tools
lore

Stephen Boyd

author maintainer
#0 lore raw

PATCH 1/2 clk: lmk04832: Depend on SPI

This driver depends on SPI. Otherwise compilation fails

clk-lmk04832.c:(.text+0x1668): undefined reference to `spi_get_device_id'

Cc Liam Beguin <[email protected]>
Fixes 3bc61cfd6f4a ("clk: add support for the lmk04832")
---
 drivers/clk/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/Kconfig +1 -0
index ccf77849bdbd..d49cf3ae52aa 100644
@@ -57,6 +57,7 @@ config CLK_HSDK
 
 config LMK04832
 	tristate "Ti LMK04832 JESD204B Compliant Clock Jitter Cleaner"
+	depends on SPI
 	select REGMAP_SPI
 	help
 	  Say yes here to build support for Texas Instruments' LMK04832 Ultra
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
author maintainer
#1 lore raw

PATCH 2/2 clk: lmk04832: Use of match table

Presumably we want to use this match table so add a module device table and set the driver match pointer appropriately.

Cc Liam Beguin <[email protected]>
Fixes 3bc61cfd6f4a ("clk: add support for the lmk04832")
---
 drivers/clk/clk-lmk04832.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/clk/clk-lmk04832.c +4 -2
index 0cd76e626c3d..c1095e733220 100644
@@ -1573,18 +1573,20 @@ static int lmk04832_remove(struct spi_device *spi)
 }
 static const struct spi_device_id lmk04832_id[] = {
 	{ "lmk04832", LMK04832 },
-	{},
+	{}
 };
 MODULE_DEVICE_TABLE(spi, lmk04832_id);
 
 static const struct of_device_id lmk04832_of_id[] = {
 	{ .compatible = "ti,lmk04832" },
-	{},
+	{}
 };
+MODULE_DEVICE_TABLE(of, lmk04832_of_id);
 
 static struct spi_driver lmk04832_driver = {
 	.driver = {
 		.name	= "lmk04832",
+		.of_match_table = lmk04832_of_id,
 	},
 	.probe		= lmk04832_probe,
 	.remove		= lmk04832_remove,
Signature · 2 lines
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
Reviewed-by on v1 1/2
#3 lore raw
In reply to Stephen Boyd
Quoted 11 lines

-----Original Message-----
From: Stephen Boyd <[email protected]>
Sent: June 29, 2021 2:08 AM
To: Michael Turquette <[email protected]>; Stephen Boyd <[email protected]>
Cc: [email protected]; [email protected]; kernel test robot <[email protected]>; Liam Beguin <[email protected]>
Subject: [PATCH 1/2] clk: lmk04832: Depend on SPI

Quoted 8 lines

This driver depends on SPI. Otherwise compilation fails

clk-lmk04832.c:(.text+0x1668): undefined reference to `spi_get_device_id'

Cc Liam Beguin <[email protected]>
Fixes 3bc61cfd6f4a ("clk: add support for the lmk04832")
Quoted 20 lines
---
 drivers/clk/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/Kconfig +1 -0
index ccf77849bdbd..d49cf3ae52aa 100644
@@ -57,6 +57,7 @@ config CLK_HSDK
 
 config LMK04832
 	tristate "Ti LMK04832 JESD204B Compliant Clock Jitter Cleaner"
+	depends on SPI
 	select REGMAP_SPI
 	help
 	  Say yes here to build support for Texas Instruments' LMK04832

Ultra
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git

Reviewed-by on v1 2/2
#2 lore raw

RE: [PATCH 2/2] clk: lmk04832: Use of match table

In reply to Stephen Boyd
Quoted 11 lines

-----Original Message-----
From: Stephen Boyd <[email protected]>
Sent: June 29, 2021 2:08 AM
To: Michael Turquette <[email protected]>; Stephen Boyd <[email protected]>
Cc: [email protected]; [email protected]; kernel test robot <[email protected]>; Liam Beguin <[email protected]>
Subject: [PATCH 2/2] clk: lmk04832: Use of match table

Quoted 7 lines

Presumably we want to use this match table so add a module device table and set the driver match pointer appropriately.

Cc Liam Beguin <[email protected]>
Fixes 3bc61cfd6f4a ("clk: add support for the lmk04832")
Quoted 35 lines
---
 drivers/clk/clk-lmk04832.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/clk/clk-lmk04832.c +4 -2
index 0cd76e626c3d..c1095e733220 100644
@@ -1573,18 +1573,20 @@ static int lmk04832_remove(struct spi_device
 *spi)
 }
 static const struct spi_device_id lmk04832_id[] = {
 	{ "lmk04832", LMK04832 },
-	{},
+	{}
 };
 MODULE_DEVICE_TABLE(spi, lmk04832_id);
 
 static const struct of_device_id lmk04832_of_id[] = {
 	{ .compatible = "ti,lmk04832" },
-	{},
+	{}
 };
+MODULE_DEVICE_TABLE(of, lmk04832_of_id);
 
 static struct spi_driver lmk04832_driver = {
 	.driver = {
 		.name	= "lmk04832",
+		.of_match_table = lmk04832_of_id,
 	},
 	.probe		= lmk04832_probe,

.remove = lmk04832_remove,
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git