nds32: fix up stack guard gap
Greg Kroah-Hartman
maintainerPATCH 1/1 nds32: fix up stack guard gap
Commit 1be7107fbe18 ("mm: larger stack guard gap, between vmas") fixed up almost all architectures to deal with the stack guard gap, but forgit nds32.
Resolve this by properly fixing up the nsd32's version of arch_get_unmapped_area()
--- arch/nds32/mm/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/nds32/mm/mmap.c +1 -1
@@ -59,7 +59,7 @@ arch_get_unmapped_area(struct file *filp, unsigned long addr, vma =find_vma (mm, addr);if (TASK_SIZE - len >= addr && - (!vma || addr + len <= vma->vm_start)) + (!vma || addr + len <=vm_start_gap (vma)))return addr; }
Signature · 1 line
2.32.0
Quoted 7 lines · Greg Kroah-Hartman
Commit
1be7107fbe18("mm: larger stack guard gap, between vmas") fixed up almost all architectures to deal with the stack guard gap, but forgit nds32.Resolve this by properly fixing up the nsd32's version of
arch_get_unmapped_area()
Quoted 10 lines
Reported-by iLifetruth <[email protected]>Cc Nick Hu <[email protected]>Cc Greentime Hu <[email protected]>Cc Vincent Chen <[email protected]>Cc Michal Hocko <[email protected]>Cc Hugh Dickins <[email protected]>Cc Qiang Liu <[email protected]>Cc stable <[email protected]>Fixes 1be7107fbe18 ("mm: larger stack guard gap, between vmas")Signed-off-by Greg Kroah-Hartman <[email protected]>
but it's a bit unfair to say that commit forgot nds32:
nds32 came into the tree nearly a year later.
Quoted 21 lines
--- arch/nds32/mm/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/nds32/mm/mmap.c +1
-1@@ -59,7 +59,7 @@ arch_get_unmapped_area(struct file *filp, unsigned long addr, vma =find_vma (mm, addr);if (TASK_SIZE - len >= addr && - (!vma || addr + len <= vma->vm_start)) + (!vma || addr + len <=vm_start_gap (vma)))return addr; }Signature · 1 line
2.32.0
Hi,
Quoted 21 lines · Hugh Dickins
Quoted 7 lines · Greg Kroah-Hartman
Commit
1be7107fbe18("mm: larger stack guard gap, between vmas") fixed up almost all architectures to deal with the stack guard gap, but forgit nds32.Resolve this by properly fixing up the nsd32's version of
arch_get_unmapped_area()Quoted 10 lines
Reported-by iLifetruth <[email protected]>Cc Nick Hu <[email protected]>Cc Greentime Hu <[email protected]>Cc Vincent Chen <[email protected]>Cc Michal Hocko <[email protected]>Cc Hugh Dickins <[email protected]>Cc Qiang Liu <[email protected]>Cc stable <[email protected]>Fixes 1be7107fbe18 ("mm: larger stack guard gap, between vmas")Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 4 lines
Acked-by Hugh Dickins <[email protected]>but it's a bit unfair to say that commit forgot nds32:
nds32 came into the tree nearly a year later.
Could we use "not forward ported to"?
Quoted 22 lines
Quoted 22 lines
--- arch/nds32/mm/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/nds32/mm/mmap.c +1
-2@@ -59,7 +59,7 @@ arch_get_unmapped_area(struct file *filp, unsigned long addr, vma =find_vma (mm, addr);if (TASK_SIZE - len >= addr && - (!vma || addr + len <= vma->vm_start)) + (!vma || addr + len <=vm_start_gap (vma)))return addr; } --2.32.0
Greg Kroah-Hartman
maintainerQuoted 24 lines · Qiang Liu
Hi,
Quoted 21 lines · Hugh Dickins
Quoted 17 lines · Greg Kroah-Hartman
Commit
1be7107fbe18("mm: larger stack guard gap, between vmas") fixed up almost all architectures to deal with the stack guard gap, but forgit nds32.Resolve this by properly fixing up the nsd32's version of
arch_get_unmapped_area()Reported-by iLifetruth <[email protected]>Cc Nick Hu <[email protected]>Cc Greentime Hu <[email protected]>Cc Vincent Chen <[email protected]>Cc Michal Hocko <[email protected]>Cc Hugh Dickins <[email protected]>Cc Qiang Liu <[email protected]>Cc stable <[email protected]>Fixes 1be7107fbe18 ("mm: larger stack guard gap, between vmas")Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 5 lines
Quoted 4 lines
Acked-by Hugh Dickins <[email protected]>but it's a bit unfair to say that commit forgot nds32:
nds32 came into the tree nearly a year later.Could we use "not forward ported to"?
Nah, it was just a mistake in the nds32 implementation when it was submitted.
thanks,
greg k-h
Greg Kroah-Hartman
maintainerQuoted 20 lines · Hugh Dickins
Quoted 7 lines · Greg Kroah-Hartman
Commit
1be7107fbe18("mm: larger stack guard gap, between vmas") fixed up almost all architectures to deal with the stack guard gap, but forgit nds32.Resolve this by properly fixing up the nsd32's version of
arch_get_unmapped_area()Quoted 10 lines
Reported-by iLifetruth <[email protected]>Cc Nick Hu <[email protected]>Cc Greentime Hu <[email protected]>Cc Vincent Chen <[email protected]>Cc Michal Hocko <[email protected]>Cc Hugh Dickins <[email protected]>Cc Qiang Liu <[email protected]>Cc stable <[email protected]>Fixes 1be7107fbe18 ("mm: larger stack guard gap, between vmas")Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 4 lines
Acked-by Hugh Dickins <[email protected]>but it's a bit unfair to say that commit forgot nds32:
nds32 came into the tree nearly a year later.
Ah, missed that. I will change the text to say that.
greg k-h