arm: dts: meson: Fix the pwm regulator supply property in node
Subsystems (2)
PATCH 1/1 arm: dts: meson: Fix the pwm regulator supply property in node
On enable CONFIG_REGULATOR_DEBUG=y we observer below debug logs. Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
--- arch/arm/boot/dts/meson8b-odroidc1.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/meson8b-odroidc1.dts +2 -2
@@ -131,7 +131,7 @@ vcck: regulator-vcck { regulator-min-microvolt = <860000>; regulator-max-microvolt = <1140000>; - vin-supply = <&p5v0>; + pwm-supply = <&p5v0>; pwms = <&pwm_cd 0 12218 0>; pwm-dutycycle-range = <91 0>;
@@ -163,7 +163,7 @@ vddee: regulator-vddee { regulator-min-microvolt = <860000>; regulator-max-microvolt = <1140000>; - vin-supply = <&p5v0>; + pwm-supply = <&p5v0>; pwms = <&pwm_cd 1 12218 0>; pwm-dutycycle-range = <91 0>;
Signature · 1 line
2.31.1
Hi Anand,
Quoted 2 lines · Anand Moon
On enable
CONFIG_REGULATOR_DEBUG=ywe observer below debug logs.
I (as non-native english speaker) suggest rewording this to:
After enabling CONFIG_REGULATOR_DEBUG=y we observe below debug logs.
Quoted 13 lines
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
excellent catch, thanks for sending a patch!
Quoted 5 lines
Fixes 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")Fixes 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")Cc Martin Blumenstingl <[email protected]>Signed-off-by Anand Moon <[email protected]>
For the subject:
- patches for 32-bit ARM should start with upper-case ARM
- personally I also include the board name so the git history is easier to read
My suggestion for the subject line is:
ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
Are you also planning to send patches for the following 32-bit SoC boards?
- arch/arm/boot/dts/meson8b-mxq.dts
- arch/arm/boot/dts/meson8b-ec100.dts
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic
Hi Martin,
Thanks for your review comments.
Quoted 9 lines · Martin Blumenstingl
Hi Anand,
Quoted 2 lines · Anand Moon
On enable
CONFIG_REGULATOR_DEBUG=ywe observer below debug logs.I (as non-native english speaker) suggest rewording this to:
After enablingCONFIG_REGULATOR_DEBUG=ywe observe below debug logs.
Opps: I will fix this in the next version.
Quoted 13 lines
Quoted 13 lines
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Quoted 9 lines
excellent catch, thanks for sending a patch!
Quoted 5 lines
Fixes 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")Fixes 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")Cc Martin Blumenstingl <[email protected]>Signed-off-by Anand Moon <[email protected]>Tested-by Martin Blumenstingl <[email protected]>
Thanks
Quoted 7 lines
For the subject:
- patches for 32-bit ARM should start with upper-case ARM
- personally I also include the board name so the git history is easier to readMy suggestion for the subject line is:
ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
Ok I will try to incorporate your suggestion in the next version.
Quoted 4 lines
Are you also planning to send patches for the following 32-bit SoC boards?
-arch/arm/boot/dts/meson8b-mxq.dts
-arch/arm/boot/dts/meson8b-ec100.dts
Ok I will try to send all updates in the next series.
Quoted 3 lines
Best regards,
Martin