Resend the three patches
v3 cover Resend the three patches
Resend the three patches
Sun Ke (3):
generic/042: make a bigger img for f2fs
generic/103: special left calculation for f2fs
generic/260: f2fs is also special
tests/generic/042 | 6 ++++-- tests/generic/103 | 10 +++++++++- tests/generic/260 | 10 ++++++++-- 3 files changed, 21 insertions(+), 5 deletions(-)
Signature · 1 line
2.25.4
PATCH v3 1/3 generic/042: make a bigger img for f2fs
f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However, f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change again. So, just set it to 128M.
--- tests/generic/042 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
tests/generic/042 +4 -2
@@ -29,9 +29,11 @@ _crashtest() file=$mnt/file size=25M - # 25M is too small for f2fs. + # f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However, + # f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change + # again. So just set it 128M. if [ $FSTYP == "f2fs" ]; then - size=38M + size=128M fi # Create an fs on a small, initialized image. The pattern is written to
Signature · 1 line
2.25.4
Re: [PATCH v3 1/3] generic/042: make a bigger img for f2fs
Quoted 6 lines · Sun Ke
f2fs-utils 1.9.0 needs at least 38 MB space for f2fs image. However, f2fs-utils 1.14.0 needs at least 52 MB. Not sure if it will change again. So, just set it to 128M.
Suggested-by Chao Yu <[email protected]>Signed-off-by Sun Ke <[email protected]>
PATCH v3 2/3 generic/103: special left calculation for f2fs
In reply to Sun KeIt failed on f2fs:
QA output created by 103
+fallocate: No space left on device
Silence is golden.
...
f2fs uses index(radix) tree as mapping metadata, its space overhead is about one thousandth of the data.
--- tests/generic/103 | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
tests/generic/103 +9 -1
@@ -27,10 +27,18 @@ _require_xfs_io_command "falloc" _consume_freesp() { file=$1 + left=512 # consume nearly all available space (leave ~512kB) avail=`_get_available_space $SCRATCH_MNT` - filesizekb=$((avail / 1024 - 512)) + + # f2fs uses index(radix) tree as mapping metadata, its space overhead + # is about one thousandth of the data + if [ $FSTYP == "f2fs" ]; then + left=$((left + avail / 1024000)) + fi + + filesizekb=$((avail / 1024 - $left)) $XFS_IO_PROG -fc "falloc 0 ${filesizekb}k" $file }
Signature · 1 line
2.25.4
Re: [PATCH v3 2/3] generic/103: special left calculation for f2fs
Quoted 11 lines · Sun Ke
It failed on f2fs:
QA output created by 103
+fallocate: No space left on device
Silence is golden.
...f2fs uses index(radix) tree as mapping metadata, its space overhead is about one thousandth of the data.
Suggested-by Chao Yu <[email protected]>Signed-off-by Sun Ke <[email protected]>
PATCH v3 3/3 generic/260: f2fs is also special
In reply to Sun KeIt fail on f2fs:
[+] Default length with start set (should succeed)
[+] Length beyond the end of fs (should succeed)
[+] Length beyond the end of fs with start set (should succeed)
+After the full fs discard 0 bytes were discarded however the file system is 12882804736 bytes long. +It seems that fs logic handling len argument overflows
The root cause is f2fs can tag a special flag TRIMMED_FLAG to indicate the whole filesystem is trimmed, so after mkfs/fstrim(), following fstrim() won't trim any block.
--- tests/generic/260 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
tests/generic/260 +8 -2
@@ -95,7 +95,10 @@ fi # It is because btrfs does not have not-yet-used parts of the device # mapped and since we got here right after the mkfs, there is not # enough free extents in the root tree. -if [ $bytes -le $(_math "$fssize*512") ] && [ $FSTYP != "btrfs" ]; then +# F2fs is also special. F2fs can tag a special flag TRIMMED_FLAG to +# indicate the whole filesystem is trimmed, so after mkfs/fstrim(), +# following fstrim() won't trim any block. +if [ $bytes -le $(_math "$fssize*512") ] && [ $FSTYP != "btrfs" ] && [ $FSTYP != "f2fs" ]; then status=1 echo "After the full fs discard $bytes bytes were discarded"\ "however the file system is $(_math "$fssize*1024") bytes long."
@@ -154,8 +157,11 @@ _scratch_mount # It is because btrfs does not have not-yet-used parts of the device # mapped and since we got here right after the mkfs, there is not # enough free extents in the root tree. +# F2fs is also special. F2fs can tag a special flag TRIMMED_FLAG to +# indicate the whole filesystem is trimmed, so after mkfs/fstrim(), +# following fstrim() won't trim any block. bytes=$($FSTRIM_PROG -v -l$len $SCRATCH_MNT | _filter_fstrim) -if [ $bytes -le $(_math "$fssize*512") ] && [ $FSTYP != "btrfs" ]; then +if [ $bytes -le $(_math "$fssize*512") ] && [ $FSTYP != "btrfs" ] && [ $FSTYP != "f2fs" ]; then status=1 echo "It seems that fs logic handling len argument overflows" fi
Signature · 1 line
2.25.4
Re: [PATCH v3 3/3] generic/260: f2fs is also special
Quoted 8 lines · Sun Ke
It fail on f2fs:
[+] Default length with start set (should succeed) [+] Length beyond the end of fs (should succeed)
[+] Length beyond the end of fs with start set (should succeed)(quoted diff) +2
-0+After the full fs discard 0 bytes were discarded however the file system is 12882804736 bytes long. +It seems that fs logic handling len argument overflows
Quoted 7 lines
The root cause is f2fs can tag a special flag
TRIMMED_FLAGto indicate the whole filesystem is trimmed, so after mkfs/fstrim(), followingfstrim()won't trim any block.Suggested-by Chao Yu <[email protected]>Signed-off-by Sun Ke <[email protected]>---