habanalabs: use get_task_pid() to take PID
Subsystems (2)
PATCH 1/4 habanalabs: use get_task_pid() to take PID
The previous function we used, find_get_pid(), wasn't good in case the user process was run inside docker.
As a result, we didn't had the PID and we couldn't kill the user process in case the device got stuck and we needed to reset the device.
--- drivers/misc/habanalabs/common/device.c | 6 +++++- drivers/misc/habanalabs/common/habanalabs_drv.c | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-)
drivers/misc/habanalabs/common/device.c +5 -1
@@ -7,11 +7,11 @@#define pr_fmt (fmt) "habanalabs: " fmt +#include <uapi/misc/habanalabs.h> #include "habanalabs.h" #include <linux/pci.h> #include <linux/hwmon.h> -#include <uapi/misc/habanalabs.h> enum hl_device_status hl_device_status (struct hl_device *hdev) {
@@ -819,6 +819,10 @@ static int device_kill_open_processes(struct hl_device *hdev, u32 timeout)usleep_range (1000 ,10000 );put_task_struct (task); + }else { +dev_warn (hdev->dev, +"Can't get task struct for PID so giving up on killing process\n" ); +return -ETIME ; } }
drivers/misc/habanalabs/common/habanalabs_drv.c +1 -1
@@ -141,7 +141,7 @@ int hl_device_open(struct inode *inode, struct file *filp)hl_cb_mgr_init (&hpriv->cb_mgr);hl_ctx_mgr_init (&hpriv->ctx_mgr); - hpriv->taskpid =find_get_pid (current->pid); + hpriv->taskpid =get_task_pid (current,PIDTYPE_PID );mutex_lock (&hdev->fpriv_list_lock);
Signature · 1 line
2.25.1
PATCH 2/4 habanalabs: expose state dump
From: Yuri Nudelman <[email protected]>
To improve the user's ability to debug the case where a workload that is part of executing training/inference of a topology is getting stuck, we need to add a 'core dump' each time a CS times-out. The 'core dump' shall contain all relevant Sync Manager information and corresponding fence values.
The most recent dumps shall be accessible via debugfs, under 'state_dump' node. Reading from the node will provide the oldest dump available. Writing an integer value X will discard X dumps, starting with the oldest one, i.e. subsequent read will now return newer dumps.
--- .../ABI/testing/debugfs-driver-habanalabs | 11 + drivers/misc/habanalabs/common/Makefile | 3 +- .../habanalabs/common/command_submission.c | 4 + drivers/misc/habanalabs/common/debugfs.c | 93 ++++ drivers/misc/habanalabs/common/device.c | 2 + drivers/misc/habanalabs/common/habanalabs.h | 132 +++++ drivers/misc/habanalabs/common/state_dump.c | 451 ++++++++++++++++++ drivers/misc/habanalabs/gaudi/gaudi.c | 24 +- drivers/misc/habanalabs/goya/goya.c | 24 +- 9 files changed, 741 insertions(+), 3 deletions(-) create mode 100644 drivers/misc/habanalabs/common/state_dump.c
Documentation/ABI/testing/debugfs-driver-habanalabs +11 -0
@@ -215,6 +215,17 @@ Description: Sets the skip reset on timeout option for the device. Value of "0" means device will be reset in case some CS has timed out, otherwise it will not be reset. +What: /sys/kernel/debug/habanalabs/hl<n>/state_dump +Date: Oct 2021 +KernelVersion: 5.15 +Contact: [email protected] +Description: Gets the state dump occurring on a CS timeout or failure. + State dump is used for debug and is created each time in case of + a problem in a CS execution, before reset. + Reading from the node returns the newest state dump available. + Writing an integer X discards X state dumps, so that the + next read would return X+1-st newest state dump. + What: /sys/kernel/debug/habanalabs/hl<n>/stop_on_err Date: Mar 2020 KernelVersion: 5.6
drivers/misc/habanalabs/common/Makefile +2 -1
@@ -10,4 +10,5 @@ HL_COMMON_FILES := common/habanalabs_drv.o common/device.o common/context.o \ common/asid.o common/habanalabs_ioctl.o \ common/command_buffer.o common/hw_queue.o common/irq.o \ common/sysfs.o common/hwmon.o common/memory.o \ - common/command_submission.o common/firmware_if.o + common/command_submission.o common/firmware_if.o \ + common/state_dump.o
drivers/misc/habanalabs/common/command_submission.c +4 -0
@@ -621,6 +621,10 @@ static void cs_timedout(struct work_struct *work)break ; } + rc =hl_state_dump (hdev); +if (rc) +dev_err (hdev->dev,"Error during system state dump %d\n" , rc); +cs_put (cs);if (likely (!skip_reset_on_timeout)) {
drivers/misc/habanalabs/common/debugfs.c +93 -0
135 lines not on this page · raw message
drivers/misc/habanalabs/common/device.c +2 -0
@@ -1375,6 +1375,8 @@ int hl_device_init(struct hl_device *hdev, struct class *hclass) hdev->compute_ctx =NULL ; + hdev->asic_funcs->state_dump_init (hdev); +hl_debugfs_add_device (hdev);/* debugfs nodes are created in hl_ctx_init so it must be called after
drivers/misc/habanalabs/common/habanalabs.h +132 -0
209 lines not on this page · raw message
drivers/misc/habanalabs/common/state_dump.c new file +451 -0
451 lines not on this page · raw message
drivers/misc/habanalabs/gaudi/gaudi.c +23 -1
@@ -348,6 +348,8 @@ static enum hl_queue_type gaudi_queue_type[GAUDI_QUEUE_ID_SIZE] = { QUEUE_TYPE_INT, /* GAUDI_QUEUE_ID_NIC_9_3 */ }; +static s64 gaudi_state_dump_specs_props[SP_MAX ] = {0 }; +struct ecc_info_extract_params {u64 block_address;u32 num_memories;
@@ -8977,6 +8979,25 @@ static int gaudi_map_pll_idx_to_fw_idx(u32 pll_idx) } } +static int gaudi_gen_sync_to_engine_map (struct hl_device *hdev, +struct hl_sync_to_engine_map *map) +{ +/* Not implemented */ +return 0 ; +} + + +static struct hl_state_dump_specs_funcs gaudi_state_dump_funcs = { + .gen_sync_to_engine_map = gaudi_gen_sync_to_engine_map, +}; + +static void gaudi_state_dump_init (struct hl_device *hdev) +{ +/* Not implemented */ + hdev->state_dump_specs.props = gaudi_state_dump_specs_props; + hdev->state_dump_specs.funcs = gaudi_state_dump_funcs; +} +static const struct hl_asic_funcs gaudi_funcs = { .early_init = gaudi_early_init, .early_fini = gaudi_early_fini,
@@ -9062,7 +9083,8 @@ static const struct hl_asic_funcs gaudi_funcs = { .enable_events_from_fw = gaudi_enable_events_from_fw, .map_pll_idx_to_fw_idx = gaudi_map_pll_idx_to_fw_idx, .init_firmware_loader = gaudi_init_firmware_loader, - .init_cpu_scrambler_dram = gaudi_init_scrambler_hbm + .init_cpu_scrambler_dram = gaudi_init_scrambler_hbm, + .state_dump_init = gaudi_state_dump_init };/**
drivers/misc/habanalabs/goya/goya.c +23 -1
@@ -350,6 +350,8 @@ static u32 goya_all_events[] = { GOYA_ASYNC_EVENT_ID_FIX_THERMAL_ENV_E }; +static s64 goya_state_dump_specs_props[SP_MAX ] = {0 }; +static int goya_mmu_clear_pgt_range (struct hl_device *hdev);static int goya_mmu_set_dram_default_page (struct hl_device *hdev);static int goya_mmu_add_mappings_for_device_cpu (struct hl_device *hdev);
@@ -5524,6 +5526,25 @@ static int goya_map_pll_idx_to_fw_idx(u32 pll_idx) } } +static int goya_gen_sync_to_engine_map (struct hl_device *hdev, +struct hl_sync_to_engine_map *map) +{ +/* Not implemented */ +return 0 ; +} + + +static struct hl_state_dump_specs_funcs goya_state_dump_funcs = { + .gen_sync_to_engine_map = goya_gen_sync_to_engine_map, +}; + +static void goya_state_dump_init (struct hl_device *hdev) +{ +/* Not implemented */ + hdev->state_dump_specs.props = goya_state_dump_specs_props; + hdev->state_dump_specs.funcs = goya_state_dump_funcs; +} +static const struct hl_asic_funcs goya_funcs = { .early_init = goya_early_init, .early_fini = goya_early_fini,
@@ -5609,7 +5630,8 @@ static const struct hl_asic_funcs goya_funcs = { .enable_events_from_fw = goya_enable_events_from_fw, .map_pll_idx_to_fw_idx = goya_map_pll_idx_to_fw_idx, .init_firmware_loader = goya_init_firmware_loader, - .init_cpu_scrambler_dram = goya_cpu_init_scrambler_dram + .init_cpu_scrambler_dram = goya_cpu_init_scrambler_dram, + .state_dump_init = goya_state_dump_init, };/*
Signature · 1 line
2.25.1
PATCH 3/4 habanalabs: state dump monitors and fences infrastructure
In reply to Oded GabbayFrom: Yuri Nudelman <[email protected]>
With the infrastructure in place, monitors and fences dump shall be implemented.
--- drivers/misc/habanalabs/common/habanalabs.h | 33 +++ drivers/misc/habanalabs/common/state_dump.c | 311 ++++++++++++++++++-- drivers/misc/habanalabs/gaudi/gaudi.c | 27 ++ drivers/misc/habanalabs/goya/goya.c | 27 ++ 4 files changed, 375 insertions(+), 23 deletions(-)
drivers/misc/habanalabs/common/habanalabs.h +33 -0
@@ -1880,6 +1880,24 @@ enum hl_sync_engine_type { ENGINE_MME, }; +/** +* struct hl_mon_state_dump - represents a state dump of a single monitor +* @id: monitor id +* @wr_addr_low: address monitor will write to, low bits +* @wr_addr_high: address monitor will write to, high bits +* @wr_data: data monitor will write +* @arm_data: register value containing monitor configuration +* @status: monitor status +*/ +struct hl_mon_state_dump { +u32 id; +u32 wr_addr_low; +u32 wr_addr_high; +u32 wr_data; +u32 arm_data; +u32 status; +}; +/** * struct hl_sync_to_engine_map_entry - sync object id to engine mapping entry * @engine_type: type of the engine
@@ -1905,10 +1923,23 @@ struct hl_sync_to_engine_map {/** * struct hl_state_dump_specs_funcs - virtual functions used by the state dump * @gen_sync_to_engine_map: generate a hash map from sync obj id to its engine +* @print_single_monitor: format monitor data as string +* @monitor_valid: return true if given monitor dump is valid +* @print_fences_single_engine: format fences data as string */ struct hl_state_dump_specs_funcs {int (*gen_sync_to_engine_map)(struct hl_device *hdev,struct hl_sync_to_engine_map *map); +int (*print_single_monitor)(char **buf,size_t *size,size_t *offset, +struct hl_device *hdev, +struct hl_mon_state_dump *mon); +int (*monitor_valid)(struct hl_mon_state_dump *mon); +int (*print_fences_single_engine)(struct hl_device *hdev, +u64 base_offset, +u64 status_base_offset, +enum hl_sync_engine_type engine_type, +u32 engine_id,char **buf, +size_t *size,size_t *offset); };/**
@@ -2795,6 +2826,8 @@ int hl_cs_signal_sob_wraparound_handler(struct hl_device *hdev, u32 q_idx,int hl_state_dump (struct hl_device *hdev);const char *hl_state_dump_get_sync_name (struct hl_device *hdev,u32 sync_id); +const char *hl_state_dump_get_monitor_name (struct hl_device *hdev, +struct hl_mon_state_dump *mon);void hl_state_dump_free_sync_to_engine_map (struct hl_sync_to_engine_map *map); __printf(4, 5) int hl_snprintf_resize(char **buf, size_t *size, size_t *offset,const char *format, ...);
drivers/misc/habanalabs/common/state_dump.c +288 -23
369 lines not on this page · raw message
drivers/misc/habanalabs/gaudi/gaudi.c +27 -0
@@ -8986,9 +8986,36 @@ static int gaudi_gen_sync_to_engine_map(struct hl_device *hdev,return 0 ; } +static int gaudi_monitor_valid (struct hl_mon_state_dump *mon) +{ +/* Not implemented */ +return 0 ; +} + +static int gaudi_print_single_monitor (char **buf,size_t *size,size_t *offset, +struct hl_device *hdev, +struct hl_mon_state_dump *mon) +{ +/* Not implemented */ +return 0 ; +} + + +static int gaudi_print_fences_single_engine ( +struct hl_device *hdev,u64 base_offset,u64 status_base_offset, +enum hl_sync_engine_type engine_type,u32 engine_id,char **buf, +size_t *size,size_t *offset) +{ +/* Not implemented */ +return 0 ; +} +static struct hl_state_dump_specs_funcs gaudi_state_dump_funcs = { + .monitor_valid = gaudi_monitor_valid, + .print_single_monitor = gaudi_print_single_monitor, .gen_sync_to_engine_map = gaudi_gen_sync_to_engine_map, + .print_fences_single_engine = gaudi_print_fences_single_engine, };static void gaudi_state_dump_init (struct hl_device *hdev)
drivers/misc/habanalabs/goya/goya.c +27 -0
@@ -5533,9 +5533,36 @@ static int goya_gen_sync_to_engine_map(struct hl_device *hdev,return 0 ; } +static int goya_monitor_valid (struct hl_mon_state_dump *mon) +{ +/* Not implemented */ +return 0 ; +} + +static int goya_print_single_monitor (char **buf,size_t *size,size_t *offset, +struct hl_device *hdev, +struct hl_mon_state_dump *mon) +{ +/* Not implemented */ +return 0 ; +} + + +static int goya_print_fences_single_engine ( +struct hl_device *hdev,u64 base_offset,u64 status_base_offset, +enum hl_sync_engine_type engine_type,u32 engine_id,char **buf, +size_t *size,size_t *offset) +{ +/* Not implemented */ +return 0 ; +} +static struct hl_state_dump_specs_funcs goya_state_dump_funcs = { + .monitor_valid = goya_monitor_valid, + .print_single_monitor = goya_print_single_monitor, .gen_sync_to_engine_map = goya_gen_sync_to_engine_map, + .print_fences_single_engine = goya_print_fences_single_engine, };static void goya_state_dump_init (struct hl_device *hdev)
Signature · 1 line
2.25.1
PATCH 4/4 habanalabs/gaudi: implement state dump
In reply to Oded GabbayFrom: Yuri Nudelman <[email protected]>
At the first stage, only gaudi core dump shall be implemented, not including the status registers.
--- drivers/misc/habanalabs/gaudi/gaudi.c | 298 +++++++++++++++++- drivers/misc/habanalabs/gaudi/gaudiP.h | 12 + .../include/gaudi/asic_reg/gaudi_regs.h | 3 + .../habanalabs/include/gaudi/gaudi_masks.h | 17 + 4 files changed, 319 insertions(+), 11 deletions(-)
drivers/misc/habanalabs/gaudi/gaudi.c +287 -11
@@ -106,6 +106,8 @@#define GAUDI_PLL_MAX 10 +#define BIN_REG_STRING_SIZE sizeof("0b10101010101010101010101010101010") +static const char gaudi_irq_name[GAUDI_MSI_ENTRIES ][GAUDI_MAX_STRING_LEN ] = {"gaudi cq 0_0" ,"gaudi cq 0_1" ,"gaudi cq 0_2" ,"gaudi cq 0_3" ,"gaudi cq 1_0" ,"gaudi cq 1_1" ,"gaudi cq 1_2" ,"gaudi cq 1_3" ,
@@ -348,7 +350,90 @@ static enum hl_queue_type gaudi_queue_type[GAUDI_QUEUE_ID_SIZE] = { QUEUE_TYPE_INT, /* GAUDI_QUEUE_ID_NIC_9_3 */ }; -static s64 gaudi_state_dump_specs_props[SP_MAX ] = {0 }; +static struct hl_hw_obj_name_entry gaudi_so_id_to_str[] = { + { .id =0 , .name ="SYNC_OBJ_DMA_DOWN_FEEDBACK" }, + { .id =1 , .name ="SYNC_OBJ_DMA_UP_FEEDBACK" }, + { .id =2 , .name ="SYNC_OBJ_DMA_STATIC_DRAM_SRAM_FEEDBACK" }, + { .id =3 , .name ="SYNC_OBJ_DMA_SRAM_DRAM_FEEDBACK" }, + { .id =4 , .name ="SYNC_OBJ_FIRST_COMPUTE_FINISH" }, + { .id =5 , .name ="SYNC_OBJ_HOST_DRAM_DONE" }, + { .id =6 , .name ="SYNC_OBJ_DBG_CTR_DEPRECATED" }, + { .id =7 , .name ="SYNC_OBJ_DMA_ACTIVATIONS_DRAM_SRAM_FEEDBACK" }, + { .id =8 , .name ="SYNC_OBJ_ENGINE_SEM_MME_0" }, + { .id =9 , .name ="SYNC_OBJ_ENGINE_SEM_MME_1" }, + { .id =10 , .name ="SYNC_OBJ_ENGINE_SEM_TPC_0" }, + { .id =11 , .name ="SYNC_OBJ_ENGINE_SEM_TPC_1" }, + { .id =12 , .name ="SYNC_OBJ_ENGINE_SEM_TPC_2" }, + { .id =13 , .name ="SYNC_OBJ_ENGINE_SEM_TPC_3" }, + { .id =14 , .name ="SYNC_OBJ_ENGINE_SEM_TPC_4" }, + { .id =15 , .name ="SYNC_OBJ_ENGINE_SEM_TPC_5" }, + { .id =16 , .name ="SYNC_OBJ_ENGINE_SEM_TPC_6" }, + { .id =17 , .name ="SYNC_OBJ_ENGINE_SEM_TPC_7" }, + { .id =18 , .name ="SYNC_OBJ_ENGINE_SEM_DMA_1" }, + { .id =19 , .name ="SYNC_OBJ_ENGINE_SEM_DMA_2" }, + { .id =20 , .name ="SYNC_OBJ_ENGINE_SEM_DMA_3" }, + { .id =21 , .name ="SYNC_OBJ_ENGINE_SEM_DMA_4" }, + { .id =22 , .name ="SYNC_OBJ_ENGINE_SEM_DMA_5" }, + { .id =23 , .name ="SYNC_OBJ_ENGINE_SEM_DMA_6" }, + { .id =24 , .name ="SYNC_OBJ_ENGINE_SEM_DMA_7" }, + { .id =25 , .name ="SYNC_OBJ_DBG_CTR_0" }, + { .id =26 , .name ="SYNC_OBJ_DBG_CTR_1" }, +}; + +static struct hl_hw_obj_name_entry gaudi_monitor_id_to_str[] = { + { .id =200 , .name ="MON_OBJ_DMA_DOWN_FEEDBACK_RESET" }, + { .id =201 , .name ="MON_OBJ_DMA_UP_FEADBACK_RESET" }, + { .id =203 , .name ="MON_OBJ_DRAM_TO_SRAM_QUEUE_FENCE" }, + { .id =204 , .name ="MON_OBJ_TPC_0_CLK_GATE" }, + { .id =205 , .name ="MON_OBJ_TPC_1_CLK_GATE" }, + { .id =206 , .name ="MON_OBJ_TPC_2_CLK_GATE" }, + { .id =207 , .name ="MON_OBJ_TPC_3_CLK_GATE" }, + { .id =208 , .name ="MON_OBJ_TPC_4_CLK_GATE" }, + { .id =209 , .name ="MON_OBJ_TPC_5_CLK_GATE" }, + { .id =210 , .name ="MON_OBJ_TPC_6_CLK_GATE" }, + { .id =211 , .name ="MON_OBJ_TPC_7_CLK_GATE" }, +}; + +static s64 gaudi_state_dump_specs_props[] = { + [SP_SYNC_OBJ_BASE_ADDR ] = mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_SOB_OBJ_0, + [SP_NEXT_SYNC_OBJ_ADDR ] =NEXT_SYNC_OBJ_ADDR_INTERVAL , + [SP_SYNC_OBJ_AMOUNT ] =NUM_OF_SOB_IN_BLOCK , + [SP_MON_OBJ_WR_ADDR_LOW ] = + mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_PAY_ADDRL_0, + [SP_MON_OBJ_WR_ADDR_HIGH ] = + mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_PAY_ADDRH_0, + [SP_MON_OBJ_WR_DATA ] = mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_PAY_DATA_0, + [SP_MON_OBJ_ARM_DATA ] = mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_ARM_0, + [SP_MON_OBJ_STATUS ] = mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_STATUS_0, + [SP_MONITORS_AMOUNT ] =NUM_OF_MONITORS_IN_BLOCK , + [SP_TPC0_CMDQ ] = mmTPC0_QM_GLBL_CFG0, + [SP_TPC0_CFG_SO ] = mmTPC0_CFG_QM_SYNC_OBJECT_ADDR, + [SP_NEXT_TPC ] = mmTPC1_QM_GLBL_CFG0 - mmTPC0_QM_GLBL_CFG0, + [SP_MME_CMDQ ] = mmMME0_QM_GLBL_CFG0, + [SP_MME_CFG_SO ] = mmMME0_CTRL_ARCH_DESC_SYNC_OBJECT_ADDR_LOW_LOCAL, + [SP_NEXT_MME ] = mmMME2_QM_GLBL_CFG0 - mmMME0_QM_GLBL_CFG0, + [SP_DMA_CMDQ ] = mmDMA0_QM_GLBL_CFG0, + [SP_DMA_CFG_SO ] = mmDMA0_CORE_WR_COMP_ADDR_LO, + [SP_DMA_QUEUES_OFFSET ] = mmDMA1_QM_GLBL_CFG0 - mmDMA0_QM_GLBL_CFG0, + [SP_NUM_OF_MME_ENGINES ] =NUM_OF_MME_ENGINES , + [SP_SUB_MME_ENG_NUM ] =NUM_OF_MME_SUB_ENGINES , + [SP_NUM_OF_DMA_ENGINES ] =NUM_OF_DMA_ENGINES , + [SP_NUM_OF_TPC_ENGINES ] =NUM_OF_TPC_ENGINES , + [SP_ENGINE_NUM_OF_QUEUES ] =NUM_OF_QUEUES , + [SP_ENGINE_NUM_OF_STREAMS ] =NUM_OF_STREAMS , + [SP_ENGINE_NUM_OF_FENCES ] =NUM_OF_FENCES , + [SP_FENCE0_CNT_OFFSET ] = + mmDMA0_QM_CP_FENCE0_CNT_0 - mmDMA0_QM_GLBL_CFG0, + [SP_FENCE0_RDATA_OFFSET ] = + mmDMA0_QM_CP_FENCE0_RDATA_0 - mmDMA0_QM_GLBL_CFG0, + [SP_CP_STS_OFFSET ] = mmDMA0_QM_CP_STS_0 - mmDMA0_QM_GLBL_CFG0, + [SP_NUM_CORES ] =1 , +}; + +static const char *const gaudi_sync_manager_names[] = { +"SYNC_MGR_E_N" ,"SYNC_MGR_W_N" ,"SYNC_MGR_E_S" ,"SYNC_MGR_W_S" , +NULL +};struct ecc_info_extract_params {u64 block_address;
@@ -8979,25 +9064,141 @@ static int gaudi_map_pll_idx_to_fw_idx(u32 pll_idx) } } +static int gaudi_add_sync_to_engine_map_entry ( +struct hl_sync_to_engine_map *map,u32 reg_value, +enum hl_sync_engine_type engine_type,u32 engine_id) +{ +struct hl_sync_to_engine_map_entry *entry; + +/* Reg value represents a partial address of sync object, +* it is used as unique identifier. For this we need to +* clear the cutoff cfg base bits from the value. +*/ +if (reg_value ==0 || reg_value ==0xffffffff ) +return 0 ; + reg_value -= (u32 )CFG_BASE ; + +/* create a new hash entry */ + entry =kzalloc (sizeof (*entry),GFP_KERNEL ); +if (!entry) +return -ENOMEM ; + entry->engine_type = engine_type; + entry->engine_id = engine_id; + entry->sync_id = reg_value; +hash_add (map->tb, &entry->node, reg_value); + +return 0 ; +} +static int gaudi_gen_sync_to_engine_map (struct hl_device *hdev,struct hl_sync_to_engine_map *map) { -/* Not implemented */ +struct hl_state_dump_specs *sds = &hdev->state_dump_specs; +struct gaudi_device *gaudi = hdev->asic_specific; +int i, j, rc; +u32 reg_value; + +/* Iterate over TPC engines */ +for (i =0 ; i < sds->props[SP_NUM_OF_TPC_ENGINES ]; ++i) { +/* TPC registered must be accessed with clock gating disabled */ +mutex_lock (&gaudi->clk_gate_mutex); + hdev->asic_funcs->disable_clock_gating (hdev); + + reg_value =RREG32 (sds->props[SP_TPC0_CFG_SO ] + + sds->props[SP_NEXT_TPC ] * i); + +/* We can reenable clock_gating */ + hdev->asic_funcs->set_clock_gating (hdev); +mutex_unlock (&gaudi->clk_gate_mutex); + + rc =gaudi_add_sync_to_engine_map_entry (map, reg_value, +ENGINE_TPC , i); +if (rc) + goto free_sync_to_engine_map; + } + +/* Iterate over MME engines */ +for (i =0 ; i < sds->props[SP_NUM_OF_MME_ENGINES ]; ++i) { +for (j =0 ; j < sds->props[SP_SUB_MME_ENG_NUM ]; ++j) { +/* MME registered must be accessed with clock gating +* disabled +*/ +mutex_lock (&gaudi->clk_gate_mutex); + hdev->asic_funcs->disable_clock_gating (hdev); + + reg_value =RREG32 (sds->props[SP_MME_CFG_SO ] + + sds->props[SP_NEXT_MME ] * i + + j *sizeof (u32)); + +/* We can reenable clock_gating */ + hdev->asic_funcs->set_clock_gating (hdev); +mutex_unlock (&gaudi->clk_gate_mutex); + + rc =gaudi_add_sync_to_engine_map_entry ( + map, reg_value,ENGINE_MME , + i * sds->props[SP_SUB_MME_ENG_NUM ] + j); +if (rc) + goto free_sync_to_engine_map; + } + } + +/* Iterate over DMA engines */ +for (i =0 ; i < sds->props[SP_NUM_OF_DMA_ENGINES ]; ++i) { + reg_value =RREG32 (sds->props[SP_DMA_CFG_SO ] + + sds->props[SP_DMA_QUEUES_OFFSET ] * i); + rc =gaudi_add_sync_to_engine_map_entry (map, reg_value, +ENGINE_DMA , i); +if (rc) + goto free_sync_to_engine_map; + } +return 0 ; + +free_sync_to_engine_map: +hl_state_dump_free_sync_to_engine_map (map); + +return rc; }static int gaudi_monitor_valid (struct hl_mon_state_dump *mon) { -/* Not implemented */ -return 0 ; +return FIELD_GET ( +SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_STATUS_0_VALID_MASK , + mon->status); }static int gaudi_print_single_monitor (char **buf,size_t *size,size_t *offset,struct hl_device *hdev,struct hl_mon_state_dump *mon) { -/* Not implemented */ -return 0 ; +const char *name; +char scratch_buf1[BIN_REG_STRING_SIZE ], + scratch_buf2[BIN_REG_STRING_SIZE ]; + + name =hl_state_dump_get_monitor_name (hdev, mon); +if (!name) + name ="" ; + +return hl_snprintf_resize ( + buf, size, offset, +"Mon id: %u%s, wait for group id: %u mask %s to reach val: %u and write %u to address 0x%llx. Pending: %s" , + mon->id, name, +FIELD_GET (SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_SID_MASK , + mon->arm_data), +hl_format_as_binary ( + scratch_buf1,sizeof (scratch_buf1), +FIELD_GET ( +SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_MASK_MASK , + mon->arm_data)), +FIELD_GET (SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_SOD_MASK , + mon->arm_data), + mon->wr_data, + (((u64 )mon->wr_addr_high) <<32 ) | mon->wr_addr_low, +hl_format_as_binary ( + scratch_buf2,sizeof (scratch_buf2), +FIELD_GET ( +SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_STATUS_0_PENDING_MASK , + mon->status))); }
@@ -9006,8 +9207,68 @@ static int gaudi_print_fences_single_engine( enum hl_sync_engine_type engine_type, u32 engine_id, char **buf, size_t *size, size_t *offset) { - /* Not implemented */ - return 0; + struct hl_state_dump_specs *sds = &hdev->state_dump_specs; +int rc = -ENOMEM , i; +u32 *statuses, *fences; + + statuses =kcalloc (sds->props[SP_ENGINE_NUM_OF_QUEUES ], +sizeof (*statuses),GFP_KERNEL ); +if (!statuses) + goto out; + + fences =kcalloc (sds->props[SP_ENGINE_NUM_OF_FENCES ] * + sds->props[SP_ENGINE_NUM_OF_QUEUES ], +sizeof (*fences),GFP_KERNEL ); +if (!fences) + goto free_status; + +for (i =0 ; i < sds->props[SP_ENGINE_NUM_OF_FENCES ]; ++i) + statuses[i] =RREG32 (status_base_offset + i *sizeof (u32)); + +for (i =0 ; i < sds->props[SP_ENGINE_NUM_OF_FENCES ] * + sds->props[SP_ENGINE_NUM_OF_QUEUES ]; ++i) + fences[i] =RREG32 (base_offset + i *sizeof (u32)); + +/* The actual print */ +for (i =0 ; i < sds->props[SP_ENGINE_NUM_OF_QUEUES ]; ++i) { +u32 fence_id; +u64 fence_cnt, fence_rdata; +const char *engine_name; + +if (!FIELD_GET (TPC0_QM_CP_STS_0_FENCE_IN_PROGRESS_MASK , + statuses[i])) +continue ; + + fence_id = +FIELD_GET (TPC0_QM_CP_STS_0_FENCE_ID_MASK , statuses[i]); + fence_cnt = base_offset +CFG_BASE + +sizeof (u32) * + (i + fence_id * sds->props[SP_ENGINE_NUM_OF_QUEUES ]); + fence_rdata = fence_cnt - sds->props[SP_FENCE0_CNT_OFFSET ] + + sds->props[SP_FENCE0_RDATA_OFFSET ]; + engine_name =hl_sync_engine_to_string (engine_type); + + rc =hl_snprintf_resize ( + buf, size, offset, +"%s%u, stream %u: fence id %u cnt = 0x%llx (%s%u_QM.CP_FENCE%u_CNT_%u) rdata = 0x%llx (%s%u_QM.CP_FENCE%u_RDATA_%u) value = %u, cp_status = %u\n" , + engine_name, engine_id, + i, fence_id, + fence_cnt, engine_name, engine_id, fence_id, i, + fence_rdata, engine_name, engine_id, fence_id, i, + fences[fence_id], + statuses[i]); +if (rc) + goto free_fences; + } + + rc =0 ; + +free_fences: +kfree (fences); +free_status: +kfree (statuses); +out: +return rc; }
@@ -9020,9 +9281,24 @@ static struct hl_state_dump_specs_funcs gaudi_state_dump_funcs = {static void gaudi_state_dump_init (struct hl_device *hdev) { -/* Not implemented */ - hdev->state_dump_specs.props = gaudi_state_dump_specs_props; - hdev->state_dump_specs.funcs = gaudi_state_dump_funcs; +struct hl_state_dump_specs *sds = &hdev->state_dump_specs; +int i; + +for (i =0 ; i <ARRAY_SIZE (gaudi_so_id_to_str); ++i) +hash_add (sds->so_id_to_str_tb, + &gaudi_so_id_to_str[i].node, + gaudi_so_id_to_str[i].id); + +for (i =0 ; i <ARRAY_SIZE (gaudi_monitor_id_to_str); ++i) +hash_add (sds->monitor_id_to_str_tb, + &gaudi_monitor_id_to_str[i].node, + gaudi_monitor_id_to_str[i].id); + + sds->props = gaudi_state_dump_specs_props; + + sds->sync_namager_names = gaudi_sync_manager_names; + + sds->funcs = gaudi_state_dump_funcs; }static const struct hl_asic_funcs gaudi_funcs = {
drivers/misc/habanalabs/gaudi/gaudiP.h +12 -0
@@ -200,6 +200,18 @@#define HW_CAP_TPC_MASK GENMASK(31, 24)#define HW_CAP_TPC_SHIFT 24 +#define NEXT_SYNC_OBJ_ADDR_INTERVAL \ + (mmSYNC_MNGR_W_N_SYNC_MNGR_OBJS_SOB_OBJ_0 - \ + mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_SOB_OBJ_0) +#define NUM_OF_MME_ENGINES 2 +#define NUM_OF_MME_SUB_ENGINES 2 +#define NUM_OF_TPC_ENGINES 8 +#define NUM_OF_DMA_ENGINES 8 +#define NUM_OF_QUEUES 5 +#define NUM_OF_STREAMS 4 +#define NUM_OF_FENCES 4 + +#define GAUDI_CPU_PCI_MSB_ADDR (addr) (((addr) & GENMASK_ULL(49, 39)) >> 39)#define GAUDI_PCI_TO_CPU_ADDR (addr) \ do { \
drivers/misc/habanalabs/include/gaudi/asic_reg/gaudi_regs.h +3 -0
@@ -126,6 +126,9 @@#define mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_SOB_OBJ_1 0x4F2004#define mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_SOB_OBJ_2047 0x4F3FFC#define mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_PAY_ADDRL_0 0x4F4000 +#define mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_PAY_ADDRH_0 0x4F4800 +#define mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_PAY_DATA_0 0x4F5000 +#define mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_ARM_0 0x4F5800#define mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_STATUS_0 0x4F6000#define mmSYNC_MNGR_E_N_SYNC_MNGR_OBJS_MON_STATUS_511 0x4F67FC
drivers/misc/habanalabs/include/gaudi/gaudi_masks.h +17 -0
@@ -449,4 +449,21 @@ enum axi_id {#define PCIE_AUX_FLR_CTRL_HW_CTRL_MASK 0x1#define PCIE_AUX_FLR_CTRL_INT_MASK_MASK 0x2 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_STATUS_0_VALID_SHIFT 0 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_STATUS_0_VALID_MASK 0x1 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_STATUS_0_PENDING_SHIFT 1 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_STATUS_0_PENDING_MASK 0x1FE +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_SID_SHIFT 0 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_SID_MASK 0xFF +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_MASK_SHIFT 8 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_MASK_MASK 0xFF00 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_SOP_SHIFT 16 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_SOP_MASK 0x10000 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_SOD_SHIFT 17 +#define SYNC_MNGR_W_S_SYNC_MNGR_OBJS_MON_ARM_0_SOD_MASK 0xFFFE0000 +#define TPC0_QM_CP_STS_0_FENCE_ID_SHIFT 20 +#define TPC0_QM_CP_STS_0_FENCE_ID_MASK 0x300000 +#define TPC0_QM_CP_STS_0_FENCE_IN_PROGRESS_SHIFT 22 +#define TPC0_QM_CP_STS_0_FENCE_IN_PROGRESS_MASK 0x400000 +#endif /* GAUDI_MASKS_H_ */
Signature · 1 line
2.25.1
kernel test robot
build botRe: [PATCH 2/4] habanalabs: expose state dump
In reply to Oded GabbayThank you for the patch! Yet something to improve:
Hi Oded,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on next-20210701]
[cannot apply to linux/master linus/master v5.13]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Oded-Gabbay/habanalabs-use-get_task_pid-to-take-PID/20210704-195147 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 6f746d485fb9188dc67dce7de63d21f0c28a1f2e config: microblaze-randconfig-r026-20210704 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3e9619ac368f95ce2bc592e00383c21f2ce66365
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oded-Gabbay/habanalabs-use-get_task_pid-to-take-PID/20210704-195147 git checkout 3e9619ac368f95ce2bc592e00383c21f2ce66365
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
All error/warnings (new ones prefixed by >>):
microblaze-linux-ld: drivers/misc/habanalabs/common/mmu/mmu_v1.o: in function `hl_debugfs_set_state_dump':
>> (.text+0x4120): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/pci/pci.o: in function `hl_debugfs_set_state_dump':
(.text+0x220): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/habanalabs_drv.o: in function `hl_debugfs_set_state_dump':
(.text+0x140): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/device.o: in function `hl_debugfs_set_state_dump':
(.text+0xa00): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/context.o: in function `hl_debugfs_set_state_dump':
(.text+0x0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/asid.o: in function `hl_debugfs_set_state_dump':
(.text+0x0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/habanalabs_ioctl.o: in function `hl_debugfs_set_state_dump':
(.text+0x1a40): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/command_buffer.o: in function `hl_debugfs_set_state_dump':
(.text+0x700): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/hw_queue.o: in function `hl_debugfs_set_state_dump':
(.text+0x520): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/irq.o: in function `hl_debugfs_set_state_dump':
(.text+0xc0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/sysfs.o: in function `hl_debugfs_set_state_dump':
(.text+0x620): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/hwmon.o: in function `hl_debugfs_set_state_dump':
(.text+0xe0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/memory.o: in function `hl_debugfs_set_state_dump':
(.text+0x1dc0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/command_submission.o: in function `hl_debugfs_set_state_dump':
(.text+0x1f20): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/firmware_if.o: in function `hl_debugfs_set_state_dump':
(.text+0x1620): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/common/state_dump.o: in function `hl_debugfs_set_state_dump':
(.text+0x0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/goya/goya.o: in function `hl_debugfs_set_state_dump':
(.text+0xca00): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/goya/goya_security.o: in function `hl_debugfs_set_state_dump':
(.text+0x2880): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/goya/goya_hwmgr.o: in function `hl_debugfs_set_state_dump':
(.text+0x960): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/goya/goya_coresight.o: in function `hl_debugfs_set_state_dump':
(.text+0x1260): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/gaudi/gaudi.o: in function `hl_debugfs_set_state_dump':
(.text+0x15cc0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/gaudi/gaudi_hwmgr.o: in function `hl_debugfs_set_state_dump':
(.text+0x240): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/gaudi/gaudi_security.o: in function `hl_debugfs_set_state_dump':
(.text+0x5380): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
microblaze-linux-ld: drivers/misc/habanalabs/gaudi/gaudi_coresight.o: in function `hl_debugfs_set_state_dump':
(.text+0x13e0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:(.text+0x2e0): first defined here
--
In file included from drivers/misc/habanalabs/gaudi/gaudiP.h:12,
from drivers/misc/habanalabs/gaudi/gaudi.c:8:
>> drivers/misc/habanalabs/gaudi/../common/habanalabs.h:2876:6: warning: no previous prototype for 'hl_debugfs_set_state_dump' [-Wmissing-prototypes]
2876 | void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/misc/habanalabs/common/mmu/mmu_v1.c:8:
>> drivers/misc/habanalabs/common/mmu/../habanalabs.h:2876:6: warning: no previous prototype for 'hl_debugfs_set_state_dump' [-Wmissing-prototypes]
2876 | void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/misc/habanalabs/common/pci/pci.c:8:
>> drivers/misc/habanalabs/common/pci/../habanalabs.h:2876:6: warning: no previous prototype for 'hl_debugfs_set_state_dump' [-Wmissing-prototypes]
2876 | void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/misc/habanalabs/common/habanalabs_drv.c:11:
>> drivers/misc/habanalabs/common/habanalabs.h:2876:6: warning: no previous prototype for 'hl_debugfs_set_state_dump' [-Wmissing-prototypes]
2876 | void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/misc/habanalabs/common/state_dump.c:9:
>> drivers/misc/habanalabs/common/habanalabs.h:2876:6: warning: no previous prototype for 'hl_debugfs_set_state_dump' [-Wmissing-prototypes]
2876 | void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/kernel.h:15,
from include/linux/skbuff.h:13,
from include/linux/if_ether.h:19,
from drivers/misc/habanalabs/common/../include/common/cpucp_if.h:12,
from drivers/misc/habanalabs/common/habanalabs.h:11,
from drivers/misc/habanalabs/common/state_dump.c:9:
drivers/misc/habanalabs/common/state_dump.c: In function 'resize_to_fit':
include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast
20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
include/linux/minmax.h:26:4: note: in expansion of macro '__typecheck'
26 | (__typecheck(x, y) && __no_side_effects(x, y))
| ^~~~~~~~~~~
include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp'
36 | __builtin_choose_expr(__safe_cmp(x, y), \
| ^~~~~~~~~~
include/linux/minmax.h:52:19: note: in expansion of macro '__careful_cmp'
52 | #define max(x, y) __careful_cmp(x, y, >)
| ^~~~~~~~~~~~~
drivers/misc/habanalabs/common/state_dump.c:76:3: note: in expansion of macro 'max'
76 | max(PAGE_SIZE, round_up(desired_size, PAGE_SIZE));
| ^~~
--
In file included from drivers/misc/habanalabs/goya/goyaP.h:12,
from drivers/misc/habanalabs/goya/goya.c:8:
>> drivers/misc/habanalabs/goya/../common/habanalabs.h:2876:6: warning: no previous prototype for 'hl_debugfs_set_state_dump' [-Wmissing-prototypes] 2876 | void hl_debugfs_set_state_dump(struct hl_device *hdev, char *data,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kernel test robot
build botRe: [PATCH 3/4] habanalabs: state dump monitors and fences infrastructure
In reply to Oded GabbayThank you for the patch! Yet something to improve:
Hi Oded,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on next-20210701]
[cannot apply to linux/master linus/master v5.13]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Oded-Gabbay/habanalabs-use-get_task_pid-to-take-PID/20210704-195147 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 6f746d485fb9188dc67dce7de63d21f0c28a1f2e config: sparc64-randconfig-p002-20210704 (attached as .config) compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c0cb886fbd23b487ed30e21fa3418e95870f19b1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oded-Gabbay/habanalabs-use-get_task_pid-to-take-PID/20210704-195147 git checkout c0cb886fbd23b487ed30e21fa3418e95870f19b1
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=sparc64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
sparc64-linux-ld: drivers/misc/habanalabs/common/mmu/mmu_v1.o: in function `hl_debugfs_set_state_dump':
>> mmu_v1.c:(.text+0x2da0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/pci/pci.o: in function `hl_debugfs_set_state_dump':
pci.c:(.text+0x140): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/habanalabs_drv.o: in function `hl_debugfs_set_state_dump':
habanalabs_drv.c:(.text+0x180): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/device.o: in function `hl_debugfs_set_state_dump':
device.c:(.text+0x7c0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/context.o: in function `hl_debugfs_set_state_dump':
context.c:(.text+0x0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/asid.o: in function `hl_debugfs_set_state_dump':
asid.c:(.text+0x0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/habanalabs_ioctl.o: in function `hl_debugfs_set_state_dump':
habanalabs_ioctl.c:(.text+0x1340): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/command_buffer.o: in function `hl_debugfs_set_state_dump':
command_buffer.c:(.text+0x840): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/hw_queue.o: in function `hl_debugfs_set_state_dump':
hw_queue.c:(.text+0x320): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/irq.o: in function `hl_debugfs_set_state_dump':
irq.c:(.text+0xa0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/sysfs.o: in function `hl_debugfs_set_state_dump':
sysfs.c:(.text+0x5c0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/hwmon.o: in function `hl_debugfs_set_state_dump':
hwmon.c:(.text+0x1a0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/memory.o: in function `hl_debugfs_set_state_dump':
memory.c:(.text+0x1200): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/command_submission.o: in function `hl_debugfs_set_state_dump':
command_submission.c:(.text+0x1380): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/firmware_if.o: in function `hl_debugfs_set_state_dump':
firmware_if.c:(.text+0x1240): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/common/state_dump.o: in function `hl_debugfs_set_state_dump':
state_dump.c:(.text+0xe0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/goya/goya.o: in function `hl_debugfs_set_state_dump':
goya.c:(.text+0x8de0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/goya/goya_security.o: in function `hl_debugfs_set_state_dump':
goya_security.c:(.text+0x2b60): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/goya/goya_hwmgr.o: in function `hl_debugfs_set_state_dump':
goya_hwmgr.c:(.text+0x6a0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/goya/goya_coresight.o: in function `hl_debugfs_set_state_dump':
goya_coresight.c:(.text+0x1220): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/gaudi/gaudi.o: in function `hl_debugfs_set_state_dump':
gaudi.c:(.text+0x11060): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/gaudi/gaudi_hwmgr.o: in function `hl_debugfs_set_state_dump':
gaudi_hwmgr.c:(.text+0x160): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/gaudi/gaudi_security.o: in function `hl_debugfs_set_state_dump':
gaudi_security.c:(.text+0x4ea0): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
sparc64-linux-ld: drivers/misc/habanalabs/gaudi/gaudi_coresight.o: in function `hl_debugfs_set_state_dump':
gaudi_coresight.c:(.text+0x1300): multiple definition of `hl_debugfs_set_state_dump'; drivers/misc/habanalabs/common/mmu/mmu.o:mmu.c:(.text+0x100): first defined here
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for LOCKDEP
Depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && (FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86) Selected by
- PROVE_LOCKING && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
- DEBUG_LOCK_ALLOC && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
kernel test robot
build botRe: [PATCH 2/4] habanalabs: expose state dump
In reply to Oded GabbayThank you for the patch! Perhaps something to improve:
Hi Oded,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on next-20210701]
[cannot apply to linux/master linus/master v5.13]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Oded-Gabbay/habanalabs-use-get_task_pid-to-take-PID/20210704-195147 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 6f746d485fb9188dc67dce7de63d21f0c28a1f2e config: riscv-randconfig-r021-20210704 (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3e9619ac368f95ce2bc592e00383c21f2ce66365
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Oded-Gabbay/habanalabs-use-get_task_pid-to-take-PID/20210704-195147 git checkout 3e9619ac368f95ce2bc592e00383c21f2ce66365
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
All warnings (new ones prefixed by >>):
>> drivers/misc/habanalabs/common/state_dump.c:12: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* A helper function, format an integer as binary using supplied scratch buffer,
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for ERRATA_SIFIVE Depends on RISCV_ERRATA_ALTERNATIVE
Selected by
- SOC_SIFIVE
vim +12 drivers/misc/habanalabs/common/state_dump.c
10
11 /**
> 12 * A helper function, format an integer as binary using supplied scratch buffer,
13 * return the pointer to the buffer.
14 * @buf: the buffer to use
15 * @buf_len: buffer capacity
16 * @n: number to format
17 *
18 * Returns pointer to buf
19 */
20 char *hl_format_as_binary(char *buf, size_t buf_len, u32 n)
21 {
22 int i;
23 u32 bit;
24 bool leading0 = true;
25 char *wrptr = buf;
26
27 if (buf_len > 0 && buf_len < 3) {
28 *wrptr = '\0';
29 return buf;
30 }
31
32 wrptr[0] = '0';
33 wrptr[1] = 'b';
34 wrptr += 2;
35 /* Remove 3 characters from length for '0b' and '\0' termination */
36 buf_len -= 3;
37
38 for (i = 0; i < sizeof(n) * BITS_PER_BYTE && buf_len; ++i, n <<= 1) {
39 /* Writing bit calculation in one line would cause a false
40 * positive static code analysis error, so splitting.
41 */
42 bit = n & (1 << (sizeof(n) * BITS_PER_BYTE - 1));
43 bit = !!bit;
44 leading0 &= !bit;
45 if (!leading0) {
46 *wrptr = '0' + bit;
47 ++wrptr;
48 }
49 }
50
51 *wrptr = '\0';
52
53 return buf;
54 }
55 ---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]