gemalto: radio-setings driver
cover gemalto: radio-setings driver
Hi all,
This patch series includes Gemalto specific radio-settings driver and minor ussd fix.
Regards,
Sergey
Sergey Matyukevich (3):
gemalto: add radio-settings driver
plugins: gemalto: add radio-settings atom
plugins: gemalto: move ussd atom to post_online
Makefile.am | 1 + drivers/gemaltomodem/gemaltomodem.c | 2 + drivers/gemaltomodem/gemaltomodem.h | 3 + drivers/gemaltomodem/radio-settings.c | 267 ++++++++++++++++++++++++++ plugins/gemalto.c | 6 +- 5 files changed, 277 insertions(+), 2 deletions(-) create mode 100644 drivers/gemaltomodem/radio-settings.c
PATCH 1/3 gemalto: add radio-settings driver
Add support for Gemalto specific radio settings.
--- Makefile.am | 1 + drivers/gemaltomodem/gemaltomodem.c | 2 + drivers/gemaltomodem/gemaltomodem.h | 3 + drivers/gemaltomodem/radio-settings.c | 267 ++++++++++++++++++++++++++ 4 files changed, 273 insertions(+) create mode 100644 drivers/gemaltomodem/radio-settings.c
Makefile.am +1 -0
@@ -487,6 +487,7 @@ builtin_sources += drivers/atmodem/atutil.h \ drivers/gemaltomodem/location-reporting.c \ drivers/gemaltomodem/voicecall.c \ drivers/gemaltomodem/gprs-context.c \ + drivers/gemaltomodem/radio-settings.c \ drivers/gemaltomodem/netmon.c builtin_modules += xmm7modem
drivers/gemaltomodem/gemaltomodem.c +2 -0
@@ -36,6 +36,7 @@static int gemaltomodem_init (void ) {gemalto_location_reporting_init (); +gemalto_radio_settings_init ();gemalto_gprs_context_init ();gemalto_voicecall_init ();gemalto_netmon_init ();
@@ -46,6 +47,7 @@ static int gemaltomodem_init(void)static void gemaltomodem_exit (void ) {gemalto_location_reporting_exit (); +gemalto_radio_settings_exit ();gemalto_gprs_context_exit ();gemalto_voicecall_exit ();gemalto_netmon_exit ();
drivers/gemaltomodem/gemaltomodem.h +3 -0
@@ -33,3 +33,6 @@ extern void gemalto_gprs_context_exit();extern void gemalto_netmon_init (void );extern void gemalto_netmon_exit (void ); + +extern void gemalto_radio_settings_init (void ); +extern void gemalto_radio_settings_exit (void );
drivers/gemaltomodem/radio-settings.c new file +267 -0
267 lines not on this page · raw message
Re: [PATCH 1/3] gemalto: add radio-settings driver
Hi Sergey,
Quoted 10 lines · Sergey Matyukevich
Add support for Gemalto specific radio settings.
--- Makefile.am | 1 + drivers/gemaltomodem/gemaltomodem.c | 2 + drivers/gemaltomodem/gemaltomodem.h | 3 + drivers/gemaltomodem/radio-settings.c | 267 ++++++++++++++++++++++++++ 4 files changed, 273 insertions(+)create mode 100644
drivers/gemaltomodem/radio-settings.c
I went ahead and applied this with a 2 lines amended: changing 'enum ofono_access_mode' to 'unsigned int'. I recently updated all the drivers in commit 1d86dbc6 ("radio-settings: Do not use enum ofono_access_mode"). So I did a similar amend here for consistency.
Regards,
-Denis
Re: [PATCH 1/3] gemalto: add radio-settings driver
Hello Denis,
Quoted 11 lines
Quoted 10 lines
Add support for Gemalto specific radio settings.
--- Makefile.am | 1 + drivers/gemaltomodem/gemaltomodem.c | 2 + drivers/gemaltomodem/gemaltomodem.h | 3 + drivers/gemaltomodem/radio-settings.c | 267 ++++++++++++++++++++++++++ 4 files changed, 273 insertions(+)create mode 100644
drivers/gemaltomodem/radio-settings.c
Quoted 4 lines
I went ahead and applied this with a 2 lines amended: changing 'enum
ofono_access_mode' to 'unsigned int'. I recently updated all the drivers in commit1d86dbc6("radio-settings: Do not use enumofono_access_mode"). So I did a similar amend here for consistency.
Ok, thanks. After enum ofono_access_mode has been removed, it is possible to convert all the 'ifs' into 'switch' branches in the function gemalto_set_rat_mode. I will test and send a cleanup patch.
Regards,
Sergey
PATCH 2/3 plugins: gemalto: add radio-settings atom
In reply to Sergey MatyukevichInstantiate Gemalto radio-settings atom in post_sim.
--- plugins/gemalto.c | 2 ++ 1 file changed, 2 insertions(+)
plugins/gemalto.c +2 -0
@@ -49,6 +49,7 @@#include <ofono/gprs-context.h> #include <ofono/location-reporting.h> #include <ofono/netmon.h> +#include <ofono/radio-settings.h> #include <drivers/atmodem/atutil.h> #include <drivers/atmodem/vendor.h>
@@ -597,6 +598,7 @@ static void gemalto_post_sim(struct ofono_modem *modem)ofono_phonebook_create (modem,0 ,"atmodem" , data->app);ofono_sms_create (modem,OFONO_VENDOR_GEMALTO ,"atmodem" , data->app); +ofono_radio_settings_create (modem,0 ,"gemaltomodem" , data->app); gprs =ofono_gprs_create (modem,0 ,"atmodem" , data->app);
Re: [PATCH 2/3] plugins: gemalto: add radio-settings atom
Hi Sergey,
Quoted 6 lines · Sergey Matyukevich
Instantiate Gemalto radio-settings atom in
post_sim.--- plugins/gemalto.c | 2 ++ 1 file changed, 2 insertions(+)
Patch 2 & 3 applied, thanks.
Regards,
-Denis
PATCH 3/3 plugins: gemalto: move ussd atom to post_online
In reply to Sergey MatyukevichGemalto modem does not allow to enable Supplementary Service during post_sim stage. So move ussd atom to post_online stage.
--- plugins/gemalto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
plugins/gemalto.c +2 -2
@@ -614,8 +614,6 @@ static void gemalto_post_sim(struct ofono_modem *modem)if (gprs && gc)ofono_gprs_add_context (gprs, gc); -ofono_ussd_create (modem,0 ,"atmodem" , data->app); -if (!g_strcmp0 (model, GEMALTO_MODEL_ALS3_PLS8x) || !g_strcmp0 (model, GEMALTO_MODEL_ELS81x)) ofono_lte_create(modem, OFONO_VENDOR_GEMALTO,
@@ -639,6 +637,8 @@ static void gemalto_post_online(struct ofono_modem *modem)ofono_call_meter_create (modem,0 ,"atmodem" , data->app);ofono_call_barring_create (modem,0 ,"atmodem" , data->app); +ofono_ussd_create (modem,0 ,"atmodem" , data->app); +if (!g_strcmp0 (model, GEMALTO_MODEL_ELS81x))ofono_netmon_create (modem,OFONO_VENDOR_GEMALTO ,"gemaltomodem" , data->app);