misc: i2c_eeprom: Add atmel,24c01 to the list
PATCH 1/1 misc: i2c_eeprom: Add atmel,24c01 to the list
Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linux kernel binding.
--- drivers/misc/i2c_eeprom.c | 1 + 1 file changed, 1 insertion(+)
drivers/misc/i2c_eeprom.c +1 -0
@@ -262,6 +262,7 @@ static const struct i2c_eeprom_drv_data atmel24c512_data = {static const struct udevice_id i2c_eeprom_std_ids[] = { { .compatible ="i2c-eeprom" , (ulong)&eeprom_data }, { .compatible ="microchip,24aa02e48" , (ulong)&mc24aa02e48_data }, + { .compatible ="atmel,24c01" , (ulong)&atmel24c01a_data }, { .compatible ="atmel,24c01a" , (ulong)&atmel24c01a_data }, { .compatible ="atmel,24c02" , (ulong)&atmel24c02_data }, { .compatible ="atmel,24c04" , (ulong)&atmel24c04_data },
Signature · 1 line
2.30.2
Hello Marek,
Quoted 11 lines · Marek Vasut
Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linux kernel binding.
Signed-off-by Marek Vasut <[email protected]>Cc Heiko Schocher <[email protected]>Cc Michal Simek <[email protected]>--- drivers/misc/i2c_eeprom.c | 1 + 1 file changed, 1 insertion(+)
Hmm... may dummy remark ... if "atmel,24c01a" is not used in kernel, may we should remove it in U-Boot completly?
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
Quoted 15 lines · Heiko Schocher
Hello Marek,
Quoted 11 lines · Marek Vasut
Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linux kernel binding.
Signed-off-by Marek Vasut <[email protected]>Cc Heiko Schocher <[email protected]>Cc Michal Simek <[email protected]>--- drivers/misc/i2c_eeprom.c | 1 + 1 file changed, 1 insertion(+)
Quoted 4 lines
Reviewed-by Heiko Schocher <[email protected]>Hmm... may dummy remark ... if "atmel,24c01a" is not used in kernel, may we should remove it in U-Boot completly?
Sadly they are both used by the DTs, so we cannot. That's why we also have 24c08 and 24c08a in the compatibles, it's exactly the same change.
Quoted 9 lines · Marek Vasut
Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linux kernel binding.
Signed-off-by Marek Vasut <[email protected]>Cc Heiko Schocher <[email protected]>Cc Michal Simek <[email protected]>Reviewed-by Heiko Schocher <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom