Fix the pwm regulator supply properties
Subsystems (2)
v2 cover Fix the pwm regulator supply properties
Changes PWM supply properties help fix internal link of PWM to main 5V supply as per the shematics.
PATCHv1 below
[0] https://lore.kernel.org/linux-amlogic/CANAwSgRD9_B7f5UjPrxeL+x-eMMc2MAG3tXLQw36x0ho+ba_Uw@mail.gmail.com/T/#t
Thanks
-Anand
Anand Moon (3):
ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
arch/arm/boot/dts/meson8b-ec100.dts | 4 ++-- arch/arm/boot/dts/meson8b-mxq.dts | 4 +++- arch/arm/boot/dts/meson8b-odroidc1.dts | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-)
Signature · 1 line
2.32.0
PATCH v2 1/3 ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
After enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs. Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
---
V1 - Fix the commit subject and commit message
--- arch/arm/boot/dts/meson8b-odroidc1.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/meson8b-odroidc1.dts +2 -2
@@ -131,7 +131,7 @@ vcck: regulator-vcck { regulator-min-microvolt = <860000>; regulator-max-microvolt = <1140000>; - vin-supply = <&p5v0>; + pwm-supply = <&p5v0>; pwms = <&pwm_cd 0 12218 0>; pwm-dutycycle-range = <91 0>;
@@ -163,7 +163,7 @@ vddee: regulator-vddee { regulator-min-microvolt = <860000>; regulator-max-microvolt = <1140000>; - vin-supply = <&p5v0>; + pwm-supply = <&p5v0>; pwms = <&pwm_cd 1 12218 0>; pwm-dutycycle-range = <91 0>;
Signature · 1 line
2.32.0
Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
Quoted 2 lines · Anand Moon
After enabling
CONFIG_REGULATOR_DEBUG=ywe observer below debug logs.
I think there's a typo here: observer -> observe
maybe Kevin or Neil can fix this up (in this and the following two patches) while applying the patch so you don't have to re-spin a v3
Quoted 14 lines
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Quoted 6 lines
Fixes 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")Fixes 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")Tested-by Martin Blumenstingl <[email protected]>Cc Martin Blumenstingl <[email protected]>Signed-off-by Anand Moon <[email protected]>
Re: [PATCHv2 1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
Hi,
Quoted 6 lines · Martin Blumenstingl
Quoted 2 lines · Anand Moon
After enabling
CONFIG_REGULATOR_DEBUG=ywe observer below debug logs.I think there's a typo here: observer -> observe
maybe Kevin or Neil can fix this up (in this and the following two patches) while applying the patch so you don't have to re-spin a v3
Fixed while applying !
Quoted 15 lines
Quoted 15 lines
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Quoted 8 lines
Quoted 6 lines
Fixes 524d96083b66 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")Fixes 8bdf38be712d ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")Tested-by Martin Blumenstingl <[email protected]>Cc Martin Blumenstingl <[email protected]>Signed-off-by Anand Moon <[email protected]>Reviewed-by Martin Blumenstingl <[email protected]>
Neil
PATCH v2 2/3 ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
In reply to Anand MoonAfter enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs. Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.
Add missing pwm-supply for regulator-vcck regulator node.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
---
V1 - New patch in this series
--- arch/arm/boot/dts/meson8b-mxq.dts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
arch/arm/boot/dts/meson8b-mxq.dts +3 -1
@@ -34,6 +34,8 @@ vcck: regulator-vcck { regulator-min-microvolt = <860000>; regulator-max-microvolt = <1140000>; + pwm-supply = <&vcc_5v>; + pwms = <&pwm_cd 0 1148 0>; pwm-dutycycle-range = <100 0>;
@@ -79,7 +81,7 @@ vddee: regulator-vddee { regulator-min-microvolt = <860000>; regulator-max-microvolt = <1140000>; - vin-supply = <&vcc_5v>; + pwm-supply = <&vcc_5v>; pwms = <&pwm_cd 1 1148 0>; pwm-dutycycle-range = <100 0>;
Signature · 1 line
2.32.0
Re: [PATCHv2 2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties
Quoted 17 lines · Anand Moon
After enabling
CONFIG_REGULATOR_DEBUG=ywe observer below debug logs. Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.
Add missing pwm-supply for regulator-vcck regulator node.[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Quoted 5 lines
Fixes dee51cd0d2e8 ("ARM: dts: meson8b: mxq: add the VDDEE regulator")Fixes d94f60e3dfa0 ("ARM: dts: meson8b: mxq: improve support for the TRONFY MXQ S805")Cc Martin Blumenstingl <[email protected]>Signed-off-by Anand Moon <[email protected]>
PATCH v2 3/3 ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
In reply to Anand MoonAfter enabling CONFIG_REGULATOR_DEBUG=y we observer below debug logs. Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.
[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
---
V1 - New patch in this series
--- arch/arm/boot/dts/meson8b-ec100.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/meson8b-ec100.dts +2 -2
@@ -148,7 +148,7 @@ vcck: regulator-vcck { regulator-min-microvolt = <860000>; regulator-max-microvolt = <1140000>; - vin-supply = <&vcc_5v>; + pwm-supply = <&vcc_5v>; pwms = <&pwm_cd 0 1148 0>; pwm-dutycycle-range = <100 0>;
@@ -232,7 +232,7 @@ vddee: regulator-vddee { regulator-min-microvolt = <860000>; regulator-max-microvolt = <1140000>; - vin-supply = <&vcc_5v>; + pwm-supply = <&vcc_5v>; pwms = <&pwm_cd 1 1148 0>; pwm-dutycycle-range = <100 0>;
Signature · 1 line
2.32.0
Re: [PATCHv2 3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties
Quoted 16 lines · Anand Moon
After enabling
CONFIG_REGULATOR_DEBUG=ywe observer below debug logs. Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply instead of dummy regulator.[ 7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree [ 7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed [ 7.117184] VCCK: supplied by regulator-dummy [ 7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT [ 7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled [ 7.118498] VDDEE: will resolve supply early: pwm [ 7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree [ 7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed [ 7.118553] VDDEE: supplied by regulator-dummy [ 7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT
Quoted 5 lines
Fixes 087a1d8b4e4c ("ARM: dts: meson8b: ec100: add the VDDEE regulator")Fixes 3e7db1c1b7a3 ("ARM: dts: meson8b: ec100: improve the description of the regulators")Cc Martin Blumenstingl <[email protected]>Signed-off-by Anand Moon <[email protected]>
Neil Armstrong
AppliedHi,
Quoted 10 lines · Anand Moon
Changes PWM supply properties help fix internal link of PWM to main 5V supply as per the shematics.
PATCHv1 below
[0] https://lore.kernel.org/linux-amlogic/CANAwSgRD9_B7f5UjPrxeL+x-eMMc2MAG3tXLQw36x0ho+ba_Uw@mail.gmail.com/T/#tThanks
-Anand[...]
Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (for-next)
[1/3] ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
https://git.kernel.org/amlogic/c/876228e9f935f19c7afc7ba394d17e2ec9143b65 [2/3] ARM: dts: meson8b: mxq: Fix the pwm regulator supply properties https://git.kernel.org/amlogic/c/632062e540becbbcb067523ec8bcadb1239d9578 [3/3] ARM: dts: meson8b: ec100: Fix the pwm regulator supply properties https://git.kernel.org/amlogic/c/72ccc373b064ae3ac0c5b5f2306069b60ca118df
Signature · 1 line
Neil