Skip to contentSkip to conversation

drm/msm/dsi: do not use unintialized kms

PATCH Superseded David Heidelberg 1 participant 1 message Jul 5, 2021

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/dsi: do not use unintialized kms

Without this patch boot ends at NULL ptr exception at msm_dsi_manager_setup_encoder on devices like Nexus 7 with MDP4 version 4.4.

Fixes 5d0e97dc8c4c ("drm/msm/dsi: Move setup_encoder to modeset_init")
---
 drivers/gpu/drm/msm/dsi/dsi_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/dsi/dsi_manager.c +1 -1
index 4ebfedc4a9ac..8114612b34b0 100644
@@ -230,7 +230,7 @@ void msm_dsi_manager_setup_encoder(int id)
 	struct msm_kms *kms = priv->kms;
 	struct drm_encoder *encoder = msm_dsi_get_encoder(msm_dsi);
 
-	if (encoder && kms->funcs->set_encoder_mode)
+	if (encoder && kms && kms->funcs->set_encoder_mode)
 		kms->funcs->set_encoder_mode(kms, encoder,
 					     dsi_mgr_is_cmd_mode(msm_dsi));
 }
Signature · 1 line
2.30.2