Skip to contentSkip to conversation

s390: preempt: Fix preempt_count initialization

PATCH Guenter Roeck 1 participant 1 message Jul 7, 2021 s390

lore
Share & tools
lore

Guenter Roeck

author Tested-by
#0 lore raw
Quoted 11 lines · Valentin Schneider

S390's init_idle_preempt_count(p, cpu) doesn't actually let us initialize the preempt_count of the requested CPU's idle task: it unconditionally writes to the current CPU's. This clearly conflicts with idle_threads_init(), which intends to initialize *all* the idle tasks, including their preempt_count (or their CPU's, if the arch uses a per-CPU preempt_count).

Unfortunately, it seems the way s390 does things doesn't let us initialize every possible CPU's preempt_count early on, as the pages where this resides are only allocated when a CPU is brought up and are freed when it is brought down.

Quoted 6 lines

Let the arch-specific code set a CPU's preempt_count when its lowcore is allocated, and turn init_idle_preempt_count() into an empty stub.

Fixes f1a0a376ca0c ("sched/core: Initialize the idle task with preemption disabled")

Guenter