Skip to contentSkip to conversation

migration: fix typo in mig_throttle_guest_down comment

PATCH Applied Olaf Hering 4 participants 4 messages Jul 8, 2021 – Jul 9, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 migration: fix typo in mig_throttle_guest_down comment

Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update all functions comments")

---
 migration/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
migration/ram.c +1 -1
index 723af67c2e..88ff34f574 100644
@@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
 }
 
 /**
- * mig_throttle_guest_down: throotle down the guest
+ * mig_throttle_guest_down: throttle down the guest
  *
  * Reduce amount of guest cpu execution to hopefully slow down memory
  * writes. If guest dirty memory rate is reduced below the rate at
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · * Olaf Hering ([email protected]) wrote:

Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update all functions comments")

---
 migration/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
migration/ram.c +0 -0
index 723af67c2e..88ff34f574 100644

migration/ram.c static size_t save_page_header(RAMState *rs, QEMUFile *f, RAMBlock *block, · line 603

Quoted 5 lines
migration/ram.c +1 -1
@@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
 }
 
 /**
- * mig_throttle_guest_down: throotle down the guest
+ * mig_throttle_guest_down: throttle down the guest

Ah yes, Juan frequently throotles.

Quoted 4 lines
migration/ram.c +0 -0
  *
  * Reduce amount of guest cpu execution to hopefully slow down memory
  * writes. If guest dirty memory rate is reduced below the rate at
Signature · 1 line
Dr. David Alan Gilbert / [email protected] / Manchester, UK
#2 lore raw
Quoted 16 lines · Dr. David Alan Gilbert
Quoted 15 lines · * Olaf Hering ([email protected]) wrote:

Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update all functions comments")

---
 migration/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
migration/ram.c +0 -0
index 723af67c2e..88ff34f574 100644
@@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
 }
 
Quoted 5 lines

migration/ram.c static size_t save_page_header(RAMState *rs, QEMUFile *f, RAMBlock *block, · line 603

Quoted 3 lines
migration/ram.c +1 -1
 /**
- * mig_throttle_guest_down: throotle down the guest
+ * mig_throttle_guest_down: throttle down the guest

Ah yes, Juan frequently throotles.

=)

#3 lore raw
In reply to Olaf Hering

Le 08/07/2021 à 18:21, Olaf Hering a écrit :

Quoted 14 lines

Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update all functions comments")

---
 migration/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
migration/ram.c +0 -0
index 723af67c2e..88ff34f574 100644

migration/ram.c static size_t save_page_header(RAMState *rs, QEMUFile *f, RAMBlock *block, · line 606

Quoted 8 lines
migration/ram.c +1 -1
@@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
 }
 
 /**
- * mig_throttle_guest_down: throotle down the guest
+ * mig_throttle_guest_down: throttle down the guest
  *
  * Reduce amount of guest cpu execution to hopefully slow down memory
  * writes. If guest dirty memory rate is reduced below the rate at

Applied to my trivial-patches branch.

Thanks,
Laurent