Skip to contentSkip to conversation

drm/msm/dp: Remove unused variable

PATCH In review Souptick Joarder 3 participants 4 messages Jul 9, 2021 – Aug 2, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm/dp: Remove unused variable

Kernel test roobot throws below warning ->

drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
warning: variable 'drm' set but not used [-Wunused-but-set-variable]

Removed unused variable drm.

---
 drivers/gpu/drm/msm/dp/dp_display.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/msm/dp/dp_display.c +0 -2
index 051c1be1de7e..d42635a86d20 100644
@@ -1014,10 +1014,8 @@ int dp_display_get_test_bpp(struct msm_dp *dp)
 void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp *dp)
 {
 	struct dp_display_private *dp_display;
-	struct drm_device *drm;
 
 	dp_display = container_of(dp, struct dp_display_private, dp_display);
-	drm = dp->drm_dev;
 
 	/*
 	 * if we are reading registers we need the link clocks to be on
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Souptick Joarder

Kernel test roobot throws below warning ->

drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
warning: variable 'drm' set but not used [-Wunused-but-set-variable]

Removed unused variable drm.

Quoted 21 lines
---
 drivers/gpu/drm/msm/dp/dp_display.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/msm/dp/dp_display.c +0 -2
index 051c1be1de7e..d42635a86d20 100644
@@ -1014,10 +1014,8 @@ int dp_display_get_test_bpp(struct msm_dp *dp)
 void msm_dp_snapshot(struct msm_disp_state *disp_state, struct msm_dp 
 *dp)
 {
 	struct dp_display_private *dp_display;
-	struct drm_device *drm;
 
 	dp_display = container_of(dp, struct dp_display_private, dp_display);
-	drm = dp->drm_dev;
 
 	/*

* if we are reading registers we need the link clocks to be on

#3 lore raw
Quoted 9 lines · Stephen Boyd

Quoting Souptick Joarder (2021-07-08 19:48:34)

Quoted 7 lines

Kernel test roobot throws below warning ->

drivers/gpu/drm/msm/dp/dp_display.c:1017:21:
warning: variable 'drm' set but not used [-Wunused-but-set-variable]

Removed unused variable drm.

Can we get this in queue for 5.15, if no further comment ?

Quoted 5 lines
Quoted 3 lines

---