Skip to contentSkip to conversation

perf tool: Enable cpu list for hybrid

PATCH Superseded Jin Yao 2 participants 10 messages Jul 12, 2021 – Jul 23, 2021 perf events

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Jin Yao

author
#0 lore raw

v3 cover perf tool: Enable cpu list for hybrid

The perf-record and perf-stat have supported the option '-C/--cpus' to count or collect only on the list of CPUs provided. This option needs to be supported for hybrid as well.

v3:
---
Rebase to latest perf/core branch.

v2:
---
Automatically map to hybrid pmu.

For example,

If cpu0-7 are 'cpu_core' and cpu9-11 are 'cpu_atom',

  # perf stat -e cycles -C0,11 -- sleep 1
  WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.

Performance counter stats for 'CPU(s) 0,11':

           1,914,704      cpu_core/cycles/
           2,036,983      cpu_atom/cycles/

         1.005815641 seconds time elapsed

It automatically selects cpu0 for cpu_core/cycles/, selects cpu11 for cpu_atom/cycles/, also with some warnings output.

Jin Yao (3):
libperf: Add perf_cpu_map__default_new()
perf tools: Create hybrid flag in target
perf tools: Enable on a list of CPUs for hybrid

 tools/lib/perf/cpumap.c              |  5 +++
 tools/lib/perf/include/perf/cpumap.h |  1 +
 tools/perf/builtin-record.c          |  7 +++
 tools/perf/builtin-stat.c            |  6 +++
 tools/perf/util/evlist-hybrid.c      | 65 ++++++++++++++++++++++++++++
 tools/perf/util/evlist-hybrid.h      |  1 +
 tools/perf/util/evlist.c             |  3 +-
 tools/perf/util/pmu.c                | 35 +++++++++++++++
 tools/perf/util/pmu.h                |  4 ++
 tools/perf/util/target.h             |  1 +
 10 files changed, 127 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v3 1/3 libperf: Add perf_cpu_map__default_new()

The libperf already has a static function 'cpu_map__default_new()'. Add a new API perf_cpu_map__default_new() to export the function.

---
v3:
- No change.

v2:
- New in v2.

 tools/lib/perf/cpumap.c              | 5 +++++
 tools/lib/perf/include/perf/cpumap.h | 1 +
 2 files changed, 6 insertions(+)
tools/lib/perf/cpumap.c +5 -0
index ca0215047c32..51b6553912e0 100644
@@ -68,6 +68,11 @@ static struct perf_cpu_map *cpu_map__default_new(void)
 	return cpus;
 }
 
+struct perf_cpu_map *perf_cpu_map__default_new(void)
+{
+	return cpu_map__default_new();
+}
+
 static int cmp_int(const void *a, const void *b)
 {
 	return *(const int *)a - *(const int*)b;
tools/lib/perf/include/perf/cpumap.h +1 -0
index 6a17ad730cbc..7c27766ea0bf 100644
@@ -9,6 +9,7 @@
 struct perf_cpu_map;
 
 LIBPERF_API struct perf_cpu_map *perf_cpu_map__dummy_new(void);
+LIBPERF_API struct perf_cpu_map *perf_cpu_map__default_new(void);
 LIBPERF_API struct perf_cpu_map *perf_cpu_map__new(const char *cpu_list);
 LIBPERF_API struct perf_cpu_map *perf_cpu_map__read(FILE *file);
 LIBPERF_API struct perf_cpu_map *perf_cpu_map__get(struct perf_cpu_map *map);
Signature · 1 line
2.17.1
author
#2 lore raw

PATCH v3 2/3 perf tools: Create hybrid flag in target

In reply to Jin Yao

User may count or collect only on a cpu list via '-C/--cpus' option. Previously cpus for evsel was retrieved from pmu sysfs. But if the target cpu list is defined, the retrieved cpus are not kept and the target cpu list is used instead.

But for hybrid system, we can't directly use target cpu list. The cpu list may not available on hybrid pmu (e.g. cpu_core or cpu_atom). So we should not set 'has_user_cpus' flag for hybrid system.

The difficulity is that we can't call perf_pmu__has_hybrid() in evlist.c to check hybrid system otherwise 'perf test python' would be failed (undefined symbol for perf_pmu__has_hybrid). If we add pmu.c to python-ext-sources, too many symbol dependencies are hard to resolve.

We use an alternative method by using a new 'hybrid' flag in target for hybrid system checking.

---
v3:
- No change.

v2:
- New in v2.

 tools/perf/util/evlist.c | 2 +-
 tools/perf/util/target.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
tools/perf/util/evlist.c +1 -1
index 47581a237c7a..06f8890816c3 100644
@@ -1002,7 +1002,7 @@ int evlist__create_maps(struct evlist *evlist, struct target *target)
 	if (!cpus)
 		goto out_delete_threads;
 
-	evlist->core.has_user_cpus = !!target->cpu_list;
+	evlist->core.has_user_cpus = !!target->cpu_list && !target->hybrid;
 
 	perf_evlist__set_maps(&evlist->core, cpus, threads);
 
tools/perf/util/target.h +1 -0
index 4ff56217f2a6..daec6cba500d 100644
@@ -17,6 +17,7 @@ struct target {
 	bool	     default_per_cpu;
 	bool	     per_thread;
 	bool	     use_bpf;
+	bool	     hybrid;
 	const char   *attr_map;
 };
 
Signature · 1 line
2.17.1
author
#3 lore raw

PATCH v3 3/3 perf tools: Enable on a list of CPUs for hybrid

In reply to Jin Yao

The perf-record and perf-stat have supported the option '-C/--cpus' to count or collect only on the list of CPUs provided. This option needs to be supported for hybrid as well.

For hybrid support, it needs to check that the CPUs are available on hybrid PMU. One example for AlderLake, cpu0-7 is 'cpu_core', cpu8-11 is 'cpu_atom'.

Before:

  # perf stat -e cpu_core/cycles/ -C11 -- sleep 1

Performance counter stats for 'CPU(s) 11':

<not supported> cpu_core/cycles/

1.006179431 seconds time elapsed

The perf-stat silently returned "<not supported>" without any helpful information. It should error out that cpu11 was not 'cpu_core'.

After:

  # perf stat -e cpu_core/cycles/ -C11 -- sleep 1
  WARNING: 11 isn't a 'cpu_core', please use a CPU list in the 'cpu_core' range (0-7)
  failed to use cpu list 11

We also need to support the events without pmu prefix specified.

  # perf stat -e cycles -C11 -- sleep 1
  WARNING: 11 isn't a 'cpu_core', please use a CPU list in the 'cpu_core' range (0-7)

Performance counter stats for 'CPU(s) 11':

           1,067,373      cpu_atom/cycles/

         1.005544738 seconds time elapsed

The perf tool creates two cycles events automatically, cpu_core/cycles/ and cpu_atom/cycles/. It checks that cpu11 is not 'cpu_core', then shows a warning for cpu_core/cycles/ and only count the cpu_atom/cycles/.

If part of cpus are 'cpu_core' and part of cpus are 'cpu_atom', the example,

  # perf stat -e cycles -C0,11 -- sleep 1
  WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.

Performance counter stats for 'CPU(s) 0,11':

           1,914,704      cpu_core/cycles/
           2,036,983      cpu_atom/cycles/

         1.005815641 seconds time elapsed

It now automatically selects cpu0 for cpu_core/cycles/, selects cpu11 for cpu_atom/cycles/, and output with some warnings.

Some more complex examples,

  # perf stat -e cycles,instructions -C0,11 -- sleep 1
  WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.
  WARNING: use 0 in 'cpu_core' for 'instructions', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'instructions', skip other cpus in list.

Performance counter stats for 'CPU(s) 0,11':

           2,780,387      cpu_core/cycles/
           1,583,432      cpu_atom/cycles/
           3,957,277      cpu_core/instructions/
           1,167,089      cpu_atom/instructions/
         1.006005124 seconds time elapsed
  # perf stat -e cycles,cpu_atom/instructions/ -C0,11 -- sleep 1
  WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'cpu_atom/instructions/', skip other cpus in list.

Performance counter stats for 'CPU(s) 0,11':

           3,290,301      cpu_core/cycles/
           1,953,073      cpu_atom/cycles/
           1,407,869      cpu_atom/instructions/
         1.006260912 seconds time elapsed

---
v3:
- Rebase to perf/core.
- No functional change.

v2:
- Automatically map to hybrid pmu.

 tools/perf/builtin-record.c     |  7 ++++
 tools/perf/builtin-stat.c       |  6 +++
 tools/perf/util/evlist-hybrid.c | 65 +++++++++++++++++++++++++++++++++
 tools/perf/util/evlist-hybrid.h |  1 +
 tools/perf/util/evlist.c        |  1 +
 tools/perf/util/pmu.c           | 35 ++++++++++++++++++
 tools/perf/util/pmu.h           |  4 ++
 7 files changed, 119 insertions(+)
tools/perf/builtin-record.c +7 -0
index 671a21c9ee4d..9518b028b850 100644
@@ -2884,6 +2884,13 @@ int cmd_record(int argc, const char **argv)
 	/* Enable ignoring missing threads when -u/-p option is defined. */
 	rec->opts.ignore_missing_thread = rec->opts.target.uid != UINT_MAX || rec->opts.target.pid;
 
+	if (evlist__use_cpu_list(rec->evlist, rec->opts.target.cpu_list)) {
+		pr_err("failed to use cpu list %s\n",
+		       rec->opts.target.cpu_list);
+		goto out;
+	}
+
+	rec->opts.target.hybrid = perf_pmu__has_hybrid();
 	err = -ENOMEM;
 	if (evlist__create_maps(rec->evlist, &rec->opts.target) < 0)
 		usage_with_options(record_usage, record_options);
tools/perf/builtin-stat.c +6 -0
index d25cb8088e8c..f7067587008f 100644
@@ -2430,6 +2430,12 @@ int cmd_stat(int argc, const char **argv)
 	if ((stat_config.aggr_mode == AGGR_THREAD) && (target.system_wide))
 		target.per_thread = true;
 
+	if (evlist__use_cpu_list(evsel_list, target.cpu_list)) {
+		pr_err("failed to use cpu list %s\n", target.cpu_list);
+		goto out;
+	}
+
+	target.hybrid = perf_pmu__has_hybrid();
 	if (evlist__create_maps(evsel_list, &target) < 0) {
 		if (target__has_task(&target)) {
 			pr_err("Problems finding threads of monitor\n");
tools/perf/util/evlist-hybrid.c +65 -0

68 lines not on this page · raw message

tools/perf/util/evlist-hybrid.h +1 -0
index 19f74b4c340a..f33a4e8443a1 100644
@@ -10,5 +10,6 @@
 int evlist__add_default_hybrid(struct evlist *evlist, bool precise);
 void evlist__warn_hybrid_group(struct evlist *evlist);
 bool evlist__has_hybrid(struct evlist *evlist);
+int evlist__use_cpu_list(struct evlist *evlist, const char *cpu_list);
 
 #endif /* __PERF_EVLIST_HYBRID_H */
tools/perf/util/evlist.c +1 -0
index 06f8890816c3..5f92319ce258 100644
@@ -27,6 +27,7 @@
 #include "util/perf_api_probe.h"
 #include "util/evsel_fprintf.h"
 #include "util/evlist-hybrid.h"
+#include "util/pmu.h"
 #include <signal.h>
 #include <unistd.h>
 #include <sched.h>
tools/perf/util/pmu.c +35 -0
index 44b90d638ad5..229cb975c5d7 100644
@@ -1906,3 +1906,38 @@ int perf_pmu__match(char *pattern, char *name, char *tok)
 
 	return 0;
 }
+
+int perf_pmu__cpus_match(struct perf_pmu *pmu, struct perf_cpu_map *cpus,
+			 struct perf_cpu_map **mcpus_ptr,
+			 struct perf_cpu_map **ucpus_ptr)
+{
+	struct perf_cpu_map *pmu_cpus = pmu->cpus;
+	struct perf_cpu_map *matched_cpus, *unmatched_cpus;
+	int matched_nr = 0, unmatched_nr = 0;
+
+	matched_cpus = perf_cpu_map__default_new();
+	if (!matched_cpus)
+		return -1;
+
+	unmatched_cpus = perf_cpu_map__default_new();
+	if (!unmatched_cpus) {
+		perf_cpu_map__put(matched_cpus);
+		return -1;
+	}
+
+	for (int i = 0; i < cpus->nr; i++) {
+		int cpu;
+
+		cpu = perf_cpu_map__idx(pmu_cpus, cpus->map[i]);
+		if (cpu == -1)
+			unmatched_cpus->map[unmatched_nr++] = cpus->map[i];
+		else
+			matched_cpus->map[matched_nr++] = cpus->map[i];
+	}
+
+	unmatched_cpus->nr = unmatched_nr;
+	matched_cpus->nr = matched_nr;
+	*mcpus_ptr = matched_cpus;
+	*ucpus_ptr = unmatched_cpus;
+	return 0;
+}
tools/perf/util/pmu.h +4 -0
index 926da483a141..e05ee1906f65 100644
@@ -11,6 +11,7 @@
 #include "pmu-events/pmu-events.h"
 
 struct evsel_config_term;
+struct perf_cpu_map;
 
 enum {
 	PERF_PMU_FORMAT_VALUE_CONFIG,
@@ -135,4 +136,7 @@ void perf_pmu__warn_invalid_config(struct perf_pmu *pmu, __u64 config,
 bool perf_pmu__has_hybrid(void);
 int perf_pmu__match(char *pattern, char *name, char *tok);
 
+int perf_pmu__cpus_match(struct perf_pmu *pmu, struct perf_cpu_map *cpus,
+			 struct perf_cpu_map **mcpus_ptr,
+			 struct perf_cpu_map **ucpus_ptr);
 #endif /* __PMU_H */
Signature · 1 line
2.17.1
#4 lore raw

Re: [PATCH v3 3/3] perf tools: Enable on a list of CPUs for hybrid

Quoted 146 lines · Jin Yao

The perf-record and perf-stat have supported the option '-C/--cpus' to count or collect only on the list of CPUs provided. This option needs to be supported for hybrid as well.

For hybrid support, it needs to check that the CPUs are available on hybrid PMU. One example for AlderLake, cpu0-7 is 'cpu_core', cpu8-11 is 'cpu_atom'.

Before:

  # perf stat -e cpu_core/cycles/ -C11 -- sleep 1

Performance counter stats for 'CPU(s) 11':

<not supported> cpu_core/cycles/

1.006179431 seconds time elapsed

The perf-stat silently returned "<not supported>" without any helpful information. It should error out that cpu11 was not 'cpu_core'.

After:

  # perf stat -e cpu_core/cycles/ -C11 -- sleep 1
  WARNING: 11 isn't a 'cpu_core', please use a CPU list in the 'cpu_core' range (0-7)
  failed to use cpu list 11

We also need to support the events without pmu prefix specified.

  # perf stat -e cycles -C11 -- sleep 1
  WARNING: 11 isn't a 'cpu_core', please use a CPU list in the 'cpu_core' range (0-7)
   Performance counter stats for 'CPU(s) 11':

           1,067,373      cpu_atom/cycles/

         1.005544738 seconds time elapsed

The perf tool creates two cycles events automatically, cpu_core/cycles/ and cpu_atom/cycles/. It checks that cpu11 is not 'cpu_core', then shows a warning for cpu_core/cycles/ and only count the cpu_atom/cycles/.

If part of cpus are 'cpu_core' and part of cpus are 'cpu_atom', the example,

  # perf stat -e cycles -C0,11 -- sleep 1
  WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.
   Performance counter stats for 'CPU(s) 0,11':

           1,914,704      cpu_core/cycles/
           2,036,983      cpu_atom/cycles/

         1.005815641 seconds time elapsed

It now automatically selects cpu0 for cpu_core/cycles/, selects cpu11 for cpu_atom/cycles/, and output with some warnings.

Some more complex examples,

  # perf stat -e cycles,instructions -C0,11 -- sleep 1
  WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.
  WARNING: use 0 in 'cpu_core' for 'instructions', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'instructions', skip other cpus in list.
   Performance counter stats for 'CPU(s) 0,11':

           2,780,387      cpu_core/cycles/
           1,583,432      cpu_atom/cycles/
           3,957,277      cpu_core/instructions/
           1,167,089      cpu_atom/instructions/

         1.006005124 seconds time elapsed
  # perf stat -e cycles,cpu_atom/instructions/ -C0,11 -- sleep 1
  WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.
  WARNING: use 11 in 'cpu_atom' for 'cpu_atom/instructions/', skip other cpus in list.
   Performance counter stats for 'CPU(s) 0,11':

           3,290,301      cpu_core/cycles/
           1,953,073      cpu_atom/cycles/
           1,407,869      cpu_atom/instructions/

         1.006260912 seconds time elapsed

---
v3:
- Rebase to perf/core.
- No functional change.

v2:
- Automatically map to hybrid pmu.

 tools/perf/builtin-record.c     |  7 ++++
 tools/perf/builtin-stat.c       |  6 +++
 tools/perf/util/evlist-hybrid.c | 65 +++++++++++++++++++++++++++++++++
 tools/perf/util/evlist-hybrid.h |  1 +
 tools/perf/util/evlist.c        |  1 +
 tools/perf/util/pmu.c           | 35 ++++++++++++++++++
 tools/perf/util/pmu.h           |  4 ++
 7 files changed, 119 insertions(+)
tools/perf/builtin-record.c +7 -0
index 671a21c9ee4d..9518b028b850 100644
@@ -2884,6 +2884,13 @@ int cmd_record(int argc, const char **argv)
 	/* Enable ignoring missing threads when -u/-p option is defined. */
 	rec->opts.ignore_missing_thread = rec->opts.target.uid != UINT_MAX || rec->opts.target.pid;
 
+	if (evlist__use_cpu_list(rec->evlist, rec->opts.target.cpu_list)) {
+		pr_err("failed to use cpu list %s\n",
+		       rec->opts.target.cpu_list);
+		goto out;
+	}
+
+	rec->opts.target.hybrid = perf_pmu__has_hybrid();
 	err = -ENOMEM;
 	if (evlist__create_maps(rec->evlist, &rec->opts.target) < 0)
 		usage_with_options(record_usage, record_options);
tools/perf/builtin-stat.c +6 -0
index d25cb8088e8c..f7067587008f 100644
@@ -2430,6 +2430,12 @@ int cmd_stat(int argc, const char **argv)
 	if ((stat_config.aggr_mode == AGGR_THREAD) && (target.system_wide))
 		target.per_thread = true;
 
+	if (evlist__use_cpu_list(evsel_list, target.cpu_list)) {
+		pr_err("failed to use cpu list %s\n", target.cpu_list);
+		goto out;
+	}
+
+	target.hybrid = perf_pmu__has_hybrid();
 	if (evlist__create_maps(evsel_list, &target) < 0) {
 		if (target__has_task(&target)) {
 			pr_err("Problems finding threads of monitor\n");
tools/perf/util/evlist-hybrid.c +0 -0
index db3f5fbdebe1..13c9f3063dda 100644

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 90

Quoted 5 lines
tools/perf/util/evlist-hybrid.c +2 -0
@@ -86,3 +86,68 @@ bool evlist__has_hybrid(struct evlist *evlist)
 
 	return false;
 }
+
+int evlist__use_cpu_list(struct evlist *evlist, const char *cpu_list)

the name seems not to cover what it's doing, how about something like evlist__fix_cpus or such

Quoted 25 lines
tools/perf/util/evlist-hybrid.c +25 -0
+{
+	struct perf_cpu_map *cpus;
+	struct evsel *evsel, *tmp;
+	struct perf_pmu *pmu;
+	int ret, unmatched_count = 0, events_nr = 0;
+
+	if (!perf_pmu__has_hybrid() || !cpu_list)
+		return 0;
+
+	cpus = perf_cpu_map__new(cpu_list);
+	if (!cpus)
+		return -1;
+
+	evlist__for_each_entry_safe(evlist, tmp, evsel) {
+		struct perf_cpu_map *matched_cpus, *unmatched_cpus;
+		char buf1[128], buf2[128];
+
+		pmu = perf_pmu__find_hybrid_pmu(evsel->pmu_name);
+		if (!pmu)
+			continue;
+
+		ret = perf_pmu__cpus_match(pmu, cpus, &matched_cpus,
+					   &unmatched_cpus);
+		if (ret)
+			goto out;

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 125

Quoted 10 lines
tools/perf/util/evlist-hybrid.c +10 -0
+
+		events_nr++;
+
+		if (matched_cpus->nr > 0 && (unmatched_cpus->nr > 0 ||
+		    matched_cpus->nr < cpus->nr ||
+		    matched_cpus->nr < pmu->cpus->nr)) {
+			perf_cpu_map__put(evsel->core.cpus);
+			perf_cpu_map__put(evsel->core.own_cpus);
+			evsel->core.cpus = perf_cpu_map__get(matched_cpus);
+			evsel->core.own_cpus = perf_cpu_map__get(matched_cpus);

I'm bit confused in here.. AFAIUI there's 2 evsel objects create for hybrid 'cycles' ... should they have already proper cpus set?

Quoted 8 lines
tools/perf/util/evlist-hybrid.c +8 -0
+
+			if (unmatched_cpus->nr > 0) {
+				cpu_map__snprint(matched_cpus, buf1, sizeof(buf1));
+				pr_warning("WARNING: use %s in '%s' for '%s', skip other cpus in list.\n",
+					   buf1, pmu->name, evsel->name);
+			}
+		}
+

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 143

Quoted 10 lines
tools/perf/util/evlist-hybrid.c +10 -0
+		if (matched_cpus->nr == 0) {
+			evlist__remove(evlist, evsel);
+			evsel__delete(evsel);
+
+			cpu_map__snprint(cpus, buf1, sizeof(buf1));
+			cpu_map__snprint(pmu->cpus, buf2, sizeof(buf2));
+			pr_warning("WARNING: %s isn't a '%s', please use a CPU list in the '%s' range (%s)\n",
+				   buf1, pmu->name, pmu->name, buf2);
+			unmatched_count++;
+		}

hum, should we rather fail in here?

jirka

author
#5 lore raw

Re: [PATCH v3 3/3] perf tools: Enable on a list of CPUs for hybrid

Hi Jiri,

Quoted 148 lines · Jiri Olsa
Quoted 147 lines · Jin Yao

The perf-record and perf-stat have supported the option '-C/--cpus' to count or collect only on the list of CPUs provided. This option needs to be supported for hybrid as well.

For hybrid support, it needs to check that the CPUs are available on hybrid PMU. One example for AlderLake, cpu0-7 is 'cpu_core', cpu8-11 is 'cpu_atom'.

Before:

   # perf stat -e cpu_core/cycles/ -C11 -- sleep 1

Performance counter stats for 'CPU(s) 11':

<not supported> cpu_core/cycles/

1.006179431 seconds time elapsed

The perf-stat silently returned "<not supported>" without any helpful information. It should error out that cpu11 was not 'cpu_core'.

After:

   # perf stat -e cpu_core/cycles/ -C11 -- sleep 1
   WARNING: 11 isn't a 'cpu_core', please use a CPU list in the 'cpu_core' range (0-7)
   failed to use cpu list 11

We also need to support the events without pmu prefix specified.

   # perf stat -e cycles -C11 -- sleep 1
   WARNING: 11 isn't a 'cpu_core', please use a CPU list in the 'cpu_core' range (0-7)
    Performance counter stats for 'CPU(s) 11':

            1,067,373      cpu_atom/cycles/

          1.005544738 seconds time elapsed

The perf tool creates two cycles events automatically, cpu_core/cycles/ and cpu_atom/cycles/. It checks that cpu11 is not 'cpu_core', then shows a warning for cpu_core/cycles/ and only count the cpu_atom/cycles/.

If part of cpus are 'cpu_core' and part of cpus are 'cpu_atom', the example,

   # perf stat -e cycles -C0,11 -- sleep 1
   WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
   WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.
    Performance counter stats for 'CPU(s) 0,11':

            1,914,704      cpu_core/cycles/
            2,036,983      cpu_atom/cycles/

          1.005815641 seconds time elapsed

It now automatically selects cpu0 for cpu_core/cycles/, selects cpu11 for cpu_atom/cycles/, and output with some warnings.

Some more complex examples,

   # perf stat -e cycles,instructions -C0,11 -- sleep 1
   WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
   WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.
   WARNING: use 0 in 'cpu_core' for 'instructions', skip other cpus in list.
   WARNING: use 11 in 'cpu_atom' for 'instructions', skip other cpus in list.
    Performance counter stats for 'CPU(s) 0,11':

            2,780,387      cpu_core/cycles/
            1,583,432      cpu_atom/cycles/
            3,957,277      cpu_core/instructions/
            1,167,089      cpu_atom/instructions/

          1.006005124 seconds time elapsed
   # perf stat -e cycles,cpu_atom/instructions/ -C0,11 -- sleep 1
   WARNING: use 0 in 'cpu_core' for 'cycles', skip other cpus in list.
   WARNING: use 11 in 'cpu_atom' for 'cycles', skip other cpus in list.
   WARNING: use 11 in 'cpu_atom' for 'cpu_atom/instructions/', skip other cpus in list.
    Performance counter stats for 'CPU(s) 0,11':

            3,290,301      cpu_core/cycles/
            1,953,073      cpu_atom/cycles/
            1,407,869      cpu_atom/instructions/

          1.006260912 seconds time elapsed

---
v3:
- Rebase to perf/core.
- No functional change.

v2:
- Automatically map to hybrid pmu.

  tools/perf/builtin-record.c     |  7 ++++
  tools/perf/builtin-stat.c       |  6 +++
  tools/perf/util/evlist-hybrid.c | 65 +++++++++++++++++++++++++++++++++
  tools/perf/util/evlist-hybrid.h |  1 +
  tools/perf/util/evlist.c        |  1 +
  tools/perf/util/pmu.c           | 35 ++++++++++++++++++
  tools/perf/util/pmu.h           |  4 ++
  7 files changed, 119 insertions(+)
tools/perf/builtin-record.c +7 -0
index 671a21c9ee4d..9518b028b850 100644
@@ -2884,6 +2884,13 @@ int cmd_record(int argc, const char **argv)
  	/* Enable ignoring missing threads when -u/-p option is defined. */
  	rec->opts.ignore_missing_thread = rec->opts.target.uid != UINT_MAX || rec->opts.target.pid;
 
+	if (evlist__use_cpu_list(rec->evlist, rec->opts.target.cpu_list)) {
+		pr_err("failed to use cpu list %s\n",
+		       rec->opts.target.cpu_list);
+		goto out;
+	}
+
+	rec->opts.target.hybrid = perf_pmu__has_hybrid();
  	err = -ENOMEM;
  	if (evlist__create_maps(rec->evlist, &rec->opts.target) < 0)
  		usage_with_options(record_usage, record_options);
tools/perf/builtin-stat.c +6 -0
index d25cb8088e8c..f7067587008f 100644
@@ -2430,6 +2430,12 @@ int cmd_stat(int argc, const char **argv)
  	if ((stat_config.aggr_mode == AGGR_THREAD) && (target.system_wide))
  		target.per_thread = true;
 
+	if (evlist__use_cpu_list(evsel_list, target.cpu_list)) {
+		pr_err("failed to use cpu list %s\n", target.cpu_list);
+		goto out;
+	}
+
+	target.hybrid = perf_pmu__has_hybrid();
  	if (evlist__create_maps(evsel_list, &target) < 0) {
  		if (target__has_task(&target)) {
  			pr_err("Problems finding threads of monitor\n");
tools/perf/util/evlist-hybrid.c +0 -0
index db3f5fbdebe1..13c9f3063dda 100644
@@ -86,3 +86,68 @@ bool evlist__has_hybrid(struct evlist *evlist)
 
Quoted 9 lines

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 90

Quoted 4 lines
tools/perf/util/evlist-hybrid.c +2 -0
  	return false;
  }
+
+int evlist__use_cpu_list(struct evlist *evlist, const char *cpu_list)

the name seems not to cover what it's doing, how about something like evlist__fix_cpus or such

OK, evlist__fix_cpus() is better, use this name in v4.

Quoted 30 lines
Quoted 30 lines
tools/perf/util/evlist-hybrid.c +30 -0
+{
+	struct perf_cpu_map *cpus;
+	struct evsel *evsel, *tmp;
+	struct perf_pmu *pmu;
+	int ret, unmatched_count = 0, events_nr = 0;
+
+	if (!perf_pmu__has_hybrid() || !cpu_list)
+		return 0;
+
+	cpus = perf_cpu_map__new(cpu_list);
+	if (!cpus)
+		return -1;
+
+	evlist__for_each_entry_safe(evlist, tmp, evsel) {
+		struct perf_cpu_map *matched_cpus, *unmatched_cpus;
+		char buf1[128], buf2[128];
+
+		pmu = perf_pmu__find_hybrid_pmu(evsel->pmu_name);
+		if (!pmu)
+			continue;
+
+		ret = perf_pmu__cpus_match(pmu, cpus, &matched_cpus,
+					   &unmatched_cpus);
+		if (ret)
+			goto out;
+
+		events_nr++;
+
+		if (matched_cpus->nr > 0 && (unmatched_cpus->nr > 0 ||
+		    matched_cpus->nr < cpus->nr ||
Quoted 9 lines

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 125

Quoted 5 lines
tools/perf/util/evlist-hybrid.c +5 -0
+		    matched_cpus->nr < pmu->cpus->nr)) {
+			perf_cpu_map__put(evsel->core.cpus);
+			perf_cpu_map__put(evsel->core.own_cpus);
+			evsel->core.cpus = perf_cpu_map__get(matched_cpus);
+			evsel->core.own_cpus = perf_cpu_map__get(matched_cpus);

I'm bit confused in here.. AFAIUI there's 2 evsel objects create for hybrid 'cycles' ... should they have already proper cpus set?

For 'cycles', yes two evsels are created automatically. One is for atom CPU (e.g. 8-11), the other is for core CPU (e.g. 0-7). In this example, these 2 evsels have already the cpus set.

While the 'cpus' here is just the user specified cpu list. cpus = perf_cpu_map__new(cpu_list);

We need to check that the cpu in 'cpus' is available on hybrid pmu or not and adjust the evsel->core.cpus according the matching results.

Quoted 12 lines
Quoted 12 lines
tools/perf/util/evlist-hybrid.c +12 -0
+
+			if (unmatched_cpus->nr > 0) {
+				cpu_map__snprint(matched_cpus, buf1, sizeof(buf1));
+				pr_warning("WARNING: use %s in '%s' for '%s', skip other cpus in list.\n",
+					   buf1, pmu->name, evsel->name);
+			}
+		}
+
+		if (matched_cpus->nr == 0) {
+			evlist__remove(evlist, evsel);
+			evsel__delete(evsel);
+
Quoted 9 lines

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 143

Quoted 6 lines
tools/perf/util/evlist-hybrid.c +6 -0
+			cpu_map__snprint(cpus, buf1, sizeof(buf1));
+			cpu_map__snprint(pmu->cpus, buf2, sizeof(buf2));
+			pr_warning("WARNING: %s isn't a '%s', please use a CPU list in the '%s' range (%s)\n",
+				   buf1, pmu->name, pmu->name, buf2);
+			unmatched_count++;
+		}

hum, should we rather fail in here?

perf stat -e cpu_core/cycles/,cpu_atom/instructions/ -C11

CPU11 is atom CPU so the evsel 'cpu_core/cycles/' is failed but cpu_atom/instructions/ is OK.

Don't we report the partially successful event?

Thanks
Jin Yao

Quoted 2 lines

jirka

#6 lore raw

Re: [PATCH v3 3/3] perf tools: Enable on a list of CPUs for hybrid

On Tue, Jul 20, 2021 at 03:07:02PM +0800, Jin, Yao wrote:

SNIP

Quoted 43 lines

OK, evlist__fix_cpus() is better, use this name in v4.

Quoted 30 lines
Quoted 30 lines
tools/perf/util/evlist-hybrid.c +30 -0
+{
+	struct perf_cpu_map *cpus;
+	struct evsel *evsel, *tmp;
+	struct perf_pmu *pmu;
+	int ret, unmatched_count = 0, events_nr = 0;
+
+	if (!perf_pmu__has_hybrid() || !cpu_list)
+		return 0;
+
+	cpus = perf_cpu_map__new(cpu_list);
+	if (!cpus)
+		return -1;
+
+	evlist__for_each_entry_safe(evlist, tmp, evsel) {
+		struct perf_cpu_map *matched_cpus, *unmatched_cpus;
+		char buf1[128], buf2[128];
+
+		pmu = perf_pmu__find_hybrid_pmu(evsel->pmu_name);
+		if (!pmu)
+			continue;
+
+		ret = perf_pmu__cpus_match(pmu, cpus, &matched_cpus,
+					   &unmatched_cpus);
+		if (ret)
+			goto out;
+
+		events_nr++;
+
+		if (matched_cpus->nr > 0 && (unmatched_cpus->nr > 0 ||
+		    matched_cpus->nr < cpus->nr ||
Quoted 9 lines

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 125

Quoted 5 lines
tools/perf/util/evlist-hybrid.c +5 -0
+		    matched_cpus->nr < pmu->cpus->nr)) {
+			perf_cpu_map__put(evsel->core.cpus);
+			perf_cpu_map__put(evsel->core.own_cpus);
+			evsel->core.cpus = perf_cpu_map__get(matched_cpus);
+			evsel->core.own_cpus = perf_cpu_map__get(matched_cpus);

I'm bit confused in here.. AFAIUI there's 2 evsel objects create for hybrid 'cycles' ... should they have already proper cpus set?

Quoted 3 lines

For 'cycles', yes two evsels are created automatically. One is for atom CPU (e.g. 8-11), the other is for core CPU (e.g. 0-7). In this example, these 2 evsels have already the cpus set.

hum, so those evsels are created with pmu's cpus, right?

Quoted 3 lines

While the 'cpus' here is just the user specified cpu list. cpus = perf_cpu_map__new(cpu_list);

then I think they will be changed by evlist__create_maps with whatever user wants?

could we just change __perf_evlist__propagate_maps to follow pmu's cpus?

jirka

Quoted 38 lines

We need to check that the cpu in 'cpus' is available on hybrid pmu or not and adjust the evsel->core.cpus according the matching results.

Quoted 12 lines
Quoted 12 lines
tools/perf/util/evlist-hybrid.c +12 -0
+
+			if (unmatched_cpus->nr > 0) {
+				cpu_map__snprint(matched_cpus, buf1, sizeof(buf1));
+				pr_warning("WARNING: use %s in '%s' for '%s', skip other cpus in list.\n",
+					   buf1, pmu->name, evsel->name);
+			}
+		}
+
+		if (matched_cpus->nr == 0) {
+			evlist__remove(evlist, evsel);
+			evsel__delete(evsel);
+
Quoted 9 lines

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 143

Quoted 6 lines
tools/perf/util/evlist-hybrid.c +6 -0
+			cpu_map__snprint(cpus, buf1, sizeof(buf1));
+			cpu_map__snprint(pmu->cpus, buf2, sizeof(buf2));
+			pr_warning("WARNING: %s isn't a '%s', please use a CPU list in the '%s' range (%s)\n",
+				   buf1, pmu->name, pmu->name, buf2);
+			unmatched_count++;
+		}

hum, should we rather fail in here?

perf stat -e cpu_core/cycles/,cpu_atom/instructions/ -C11

CPU11 is atom CPU so the evsel 'cpu_core/cycles/' is failed but cpu_atom/instructions/ is OK.

Don't we report the partially successful event?

Thanks
Jin Yao

Quoted 2 lines

jirka

author
#7 lore raw

Re: [PATCH v3 3/3] perf tools: Enable on a list of CPUs for hybrid

Hi Jiri,

Quoted 47 lines · Jiri Olsa

On Tue, Jul 20, 2021 at 03:07:02PM +0800, Jin, Yao wrote:

SNIP

Quoted 43 lines

OK, evlist__fix_cpus() is better, use this name in v4.

Quoted 39 lines
Quoted 25 lines
tools/perf/util/evlist-hybrid.c +25 -0
+{
+	struct perf_cpu_map *cpus;
+	struct evsel *evsel, *tmp;
+	struct perf_pmu *pmu;
+	int ret, unmatched_count = 0, events_nr = 0;
+
+	if (!perf_pmu__has_hybrid() || !cpu_list)
+		return 0;
+
+	cpus = perf_cpu_map__new(cpu_list);
+	if (!cpus)
+		return -1;
+
+	evlist__for_each_entry_safe(evlist, tmp, evsel) {
+		struct perf_cpu_map *matched_cpus, *unmatched_cpus;
+		char buf1[128], buf2[128];
+
+		pmu = perf_pmu__find_hybrid_pmu(evsel->pmu_name);
+		if (!pmu)
+			continue;
+
+		ret = perf_pmu__cpus_match(pmu, cpus, &matched_cpus,
+					   &unmatched_cpus);
+		if (ret)
+			goto out;

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 125

Quoted 10 lines
tools/perf/util/evlist-hybrid.c +10 -0
+
+		events_nr++;
+
+		if (matched_cpus->nr > 0 && (unmatched_cpus->nr > 0 ||
+		    matched_cpus->nr < cpus->nr ||
+		    matched_cpus->nr < pmu->cpus->nr)) {
+			perf_cpu_map__put(evsel->core.cpus);
+			perf_cpu_map__put(evsel->core.own_cpus);
+			evsel->core.cpus = perf_cpu_map__get(matched_cpus);
+			evsel->core.own_cpus = perf_cpu_map__get(matched_cpus);

I'm bit confused in here.. AFAIUI there's 2 evsel objects create for hybrid 'cycles' ... should they have already proper cpus set?

Quoted 6 lines
Quoted 3 lines

For 'cycles', yes two evsels are created automatically. One is for atom CPU (e.g. 8-11), the other is for core CPU (e.g. 0-7). In this example, these 2 evsels have already the cpus set.

hum, so those evsels are created with pmu's cpus, right?

Yes, that's right. But we also check and adjust the evsel->cpus by using user's cpu list on hybrid (what the evlist__use_cpu_list() does).

Quoted 7 lines
Quoted 3 lines

While the 'cpus' here is just the user specified cpu list. cpus = perf_cpu_map__new(cpu_list);

then I think they will be changed by evlist__create_maps with whatever user wants?

No, it will not be changed by evlist__create_maps.

In evlist__create_maps(),
evlist->core.has_user_cpus = !!target->cpu_list && !target->hybrid;

It disables has_user_cpus for hybrid.

So in __perf_evlist__propagate_maps, they will not be changed by evlist->cpus.

if (!evsel->own_cpus || evlist->has_user_cpus) {
	perf_cpu_map__put(evsel->cpus);
	evsel->cpus = perf_cpu_map__get(evlist->cpus);
Quoted 3 lines

could we just change __perf_evlist__propagate_maps to follow pmu's cpus?

In __perf_evlist__propagate_maps, it has already followed pmu's cpus because the evlist->has_user_cpus is false for hybrid.

Thanks
Jin Yao

Quoted 41 lines

jirka

Quoted 38 lines

We need to check that the cpu in 'cpus' is available on hybrid pmu or not and adjust the evsel->core.cpus according the matching results.

Quoted 12 lines
Quoted 12 lines
tools/perf/util/evlist-hybrid.c +12 -0
+
+			if (unmatched_cpus->nr > 0) {
+				cpu_map__snprint(matched_cpus, buf1, sizeof(buf1));
+				pr_warning("WARNING: use %s in '%s' for '%s', skip other cpus in list.\n",
+					   buf1, pmu->name, evsel->name);
+			}
+		}
+
+		if (matched_cpus->nr == 0) {
+			evlist__remove(evlist, evsel);
+			evsel__delete(evsel);
+
Quoted 9 lines

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 143

Quoted 6 lines
tools/perf/util/evlist-hybrid.c +6 -0
+			cpu_map__snprint(cpus, buf1, sizeof(buf1));
+			cpu_map__snprint(pmu->cpus, buf2, sizeof(buf2));
+			pr_warning("WARNING: %s isn't a '%s', please use a CPU list in the '%s' range (%s)\n",
+				   buf1, pmu->name, pmu->name, buf2);
+			unmatched_count++;
+		}

hum, should we rather fail in here?

perf stat -e cpu_core/cycles/,cpu_atom/instructions/ -C11

CPU11 is atom CPU so the evsel 'cpu_core/cycles/' is failed but cpu_atom/instructions/ is OK.

Don't we report the partially successful event?

Thanks
Jin Yao

Quoted 2 lines

jirka

#8 lore raw

Re: [PATCH v3 3/3] perf tools: Enable on a list of CPUs for hybrid

Quoted 81 lines · Yao

Hi Jiri,

Quoted 47 lines · Jiri Olsa

On Tue, Jul 20, 2021 at 03:07:02PM +0800, Jin, Yao wrote:

SNIP

Quoted 43 lines

OK, evlist__fix_cpus() is better, use this name in v4.

Quoted 39 lines
Quoted 25 lines
tools/perf/util/evlist-hybrid.c +25 -0
+{
+	struct perf_cpu_map *cpus;
+	struct evsel *evsel, *tmp;
+	struct perf_pmu *pmu;
+	int ret, unmatched_count = 0, events_nr = 0;
+
+	if (!perf_pmu__has_hybrid() || !cpu_list)
+		return 0;
+
+	cpus = perf_cpu_map__new(cpu_list);
+	if (!cpus)
+		return -1;
+
+	evlist__for_each_entry_safe(evlist, tmp, evsel) {
+		struct perf_cpu_map *matched_cpus, *unmatched_cpus;
+		char buf1[128], buf2[128];
+
+		pmu = perf_pmu__find_hybrid_pmu(evsel->pmu_name);
+		if (!pmu)
+			continue;
+
+		ret = perf_pmu__cpus_match(pmu, cpus, &matched_cpus,
+					   &unmatched_cpus);
+		if (ret)
+			goto out;

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 125

Quoted 10 lines
tools/perf/util/evlist-hybrid.c +10 -0
+
+		events_nr++;
+
+		if (matched_cpus->nr > 0 && (unmatched_cpus->nr > 0 ||
+		    matched_cpus->nr < cpus->nr ||
+		    matched_cpus->nr < pmu->cpus->nr)) {
+			perf_cpu_map__put(evsel->core.cpus);
+			perf_cpu_map__put(evsel->core.own_cpus);
+			evsel->core.cpus = perf_cpu_map__get(matched_cpus);
+			evsel->core.own_cpus = perf_cpu_map__get(matched_cpus);

I'm bit confused in here.. AFAIUI there's 2 evsel objects create for hybrid 'cycles' ... should they have already proper cpus set?

Quoted 6 lines
Quoted 3 lines

For 'cycles', yes two evsels are created automatically. One is for atom CPU (e.g. 8-11), the other is for core CPU (e.g. 0-7). In this example, these 2 evsels have already the cpus set.

hum, so those evsels are created with pmu's cpus, right?

Yes, that's right. But we also check and adjust the evsel->cpus by using user's cpu list on hybrid (what the evlist__use_cpu_list() does).

Quoted 7 lines
Quoted 3 lines

While the 'cpus' here is just the user specified cpu list. cpus = perf_cpu_map__new(cpu_list);

then I think they will be changed by evlist__create_maps with whatever user wants?

No, it will not be changed by evlist__create_maps.

In evlist__create_maps(),
evlist->core.has_user_cpus = !!target->cpu_list && !target->hybrid;

It disables has_user_cpus for hybrid.

So in __perf_evlist__propagate_maps, they will not be changed by evlist->cpus.

if (!evsel->own_cpus || evlist->has_user_cpus) {
	perf_cpu_map__put(evsel->cpus);
	evsel->cpus = perf_cpu_map__get(evlist->cpus);
Quoted 6 lines
Quoted 3 lines

could we just change __perf_evlist__propagate_maps to follow pmu's cpus?

In __perf_evlist__propagate_maps, it has already followed pmu's cpus because the evlist->has_user_cpus is false for hybrid.

sorry for delay

ok, so we first fix the cpus on hybrid events and then propagate maps.. I guess it's ok, because it's in libperf and that has no notion of hybrid so far

could you please rename that function so it's also obvious it's for hybrid only

evlist__fix_hybrid_cpus ? not sure ;-)

and add some comment with example to explain what the function is doing

thanks,
jirka

author
#9 lore raw

Re: [PATCH v3 3/3] perf tools: Enable on a list of CPUs for hybrid

Hi Jiri,

Quoted 82 lines · Jiri Olsa
Quoted 81 lines · Yao

Hi Jiri,

Quoted 47 lines · Jiri Olsa

On Tue, Jul 20, 2021 at 03:07:02PM +0800, Jin, Yao wrote:

SNIP

Quoted 43 lines

OK, evlist__fix_cpus() is better, use this name in v4.

Quoted 39 lines
Quoted 25 lines
tools/perf/util/evlist-hybrid.c +25 -0
+{
+	struct perf_cpu_map *cpus;
+	struct evsel *evsel, *tmp;
+	struct perf_pmu *pmu;
+	int ret, unmatched_count = 0, events_nr = 0;
+
+	if (!perf_pmu__has_hybrid() || !cpu_list)
+		return 0;
+
+	cpus = perf_cpu_map__new(cpu_list);
+	if (!cpus)
+		return -1;
+
+	evlist__for_each_entry_safe(evlist, tmp, evsel) {
+		struct perf_cpu_map *matched_cpus, *unmatched_cpus;
+		char buf1[128], buf2[128];
+
+		pmu = perf_pmu__find_hybrid_pmu(evsel->pmu_name);
+		if (!pmu)
+			continue;
+
+		ret = perf_pmu__cpus_match(pmu, cpus, &matched_cpus,
+					   &unmatched_cpus);
+		if (ret)
+			goto out;

tools/perf/util/evlist-hybrid.c bool evlist__has_hybrid(struct evlist *evlist) · line 125

Quoted 10 lines
tools/perf/util/evlist-hybrid.c +10 -0
+
+		events_nr++;
+
+		if (matched_cpus->nr > 0 && (unmatched_cpus->nr > 0 ||
+		    matched_cpus->nr < cpus->nr ||
+		    matched_cpus->nr < pmu->cpus->nr)) {
+			perf_cpu_map__put(evsel->core.cpus);
+			perf_cpu_map__put(evsel->core.own_cpus);
+			evsel->core.cpus = perf_cpu_map__get(matched_cpus);
+			evsel->core.own_cpus = perf_cpu_map__get(matched_cpus);

I'm bit confused in here.. AFAIUI there's 2 evsel objects create for hybrid 'cycles' ... should they have already proper cpus set?

Quoted 6 lines
Quoted 3 lines

For 'cycles', yes two evsels are created automatically. One is for atom CPU (e.g. 8-11), the other is for core CPU (e.g. 0-7). In this example, these 2 evsels have already the cpus set.

hum, so those evsels are created with pmu's cpus, right?

Yes, that's right. But we also check and adjust the evsel->cpus by using user's cpu list on hybrid (what the evlist__use_cpu_list() does).

Quoted 7 lines
Quoted 3 lines

While the 'cpus' here is just the user specified cpu list. cpus = perf_cpu_map__new(cpu_list);

then I think they will be changed by evlist__create_maps with whatever user wants?

No, it will not be changed by evlist__create_maps.

In evlist__create_maps(),
evlist->core.has_user_cpus = !!target->cpu_list && !target->hybrid;

It disables has_user_cpus for hybrid.

So in __perf_evlist__propagate_maps, they will not be changed by evlist->cpus.

if (!evsel->own_cpus || evlist->has_user_cpus) {
	perf_cpu_map__put(evsel->cpus);
	evsel->cpus = perf_cpu_map__get(evlist->cpus);
Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

could we just change __perf_evlist__propagate_maps to follow pmu's cpus?

In __perf_evlist__propagate_maps, it has already followed pmu's cpus because the evlist->has_user_cpus is false for hybrid.

sorry for delay

Never mind. :)

Quoted 4 lines

ok, so we first fix the cpus on hybrid events and then propagate maps.. I guess it's ok, because it's in libperf and that has no notion of hybrid so far

Yes. If we want the libperf to be hybrid aware, the interface has to be modified but actually we need to avoid modifying the libperf interface. So I finally decide to adjust the evsel->cpus first and then propatate maps.

Quoted 5 lines

could you please rename that function so it's also obvious it's for hybrid only

evlist__fix_hybrid_cpus ? not sure ;-)

Sure, I will rename the funciton in v4.

Quoted 3 lines

and add some comment with example to explain what the function is doing

Got it!

Thanks
Jin Yao

Quoted 3 lines

thanks,
jirka