Skip to contentSkip to conversation

delete useless for loop

PATCH In review Salah Triki 2 participants 2 messages Jul 12, 2021 – Jul 13, 2021

Subsystems (3)
Networking Network drivers Farsync synchronous driver
lore
Share & tools
lore

Salah Triki

author
#0 lore raw

PATCH 1/1 delete useless for loop

Delete useless initialization of fst_card_array since the default initialization is NULL.

Signed-off-by Salah Triki <[email protected]>
---
 drivers/net/wan/farsync.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/wan/farsync.c +0 -4
index b3466e084e84..0b3f561d5d5e 100644
@@ -2565,10 +2565,6 @@ static struct pci_driver fst_driver = {
 static int __init
 fst_init(void)
 {
-	int i;
-
-	for (i = 0; i < FST_MAX_CARDS; i++)
-		fst_card_array[i] = NULL;
 	return pci_register_driver(&fst_driver);
 }
Signature · 1 line
2.25.1
#1 lore raw

Hello Salah,

Quoted 13 lines · Salah Triki

Delete useless initialization of fst_card_array since the default initialization is NULL.

Signed-off-by Salah Triki <[email protected]>
---
 drivers/net/wan/farsync.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/wan/farsync.c +0 -0
index b3466e084e84..0b3f561d5d5e 100644

drivers/net/wan/farsync.c static struct pci_driver fst_driver = { · line 2569

Quoted 9 lines
drivers/net/wan/farsync.c +0 -4
@@ -2565,10 +2565,6 @@ static struct pci_driver fst_driver = {
 static int __init
 fst_init(void)
 {
-	int i;
-
-	for (i = 0; i < FST_MAX_CARDS; i++)
-		fst_card_array[i] = NULL;
 	return pci_register_driver(&fst_driver);
 }

Looks right. I wonder if it makes sense to go even further and let farsync.c use module_pci_driver.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |