Skip to contentSkip to conversation

use swap()

PATCH In review Salah Triki 2 participants 2 messages Jul 12, 2021 – Jul 13, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 use swap()

Use swap() instead of implementing it since it makes code more clean.

---
 drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/ipu-v3/ipu-image-convert.c +2 -5
index aa1d4b6d278f..5f730cd6009d 100644
@@ -1021,11 +1021,8 @@ static int calc_tile_offsets_planar(struct ipu_image_convert_ctx *ctx,
 
 			u_off = y_size - y_off + uv_off;
 			v_off = (fmt->uv_packed) ? 0 : u_off + uv_size;
-			if (fmt->uv_swapped) {
-				tmp = u_off;
-				u_off = v_off;
-				v_off = tmp;
-			}
+			if (fmt->uv_swapped)
+				swap(u_off, v_off);
 
 			image->tile[tile].offset = y_off;
 			image->tile[tile].u_off = u_off;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 4 lines · Salah Triki

Use swap() instead of implementing it since it makes code more clean.

Patches for this driver generally have the following prefix in the subject:
gpu: ipu-v3:

Alex

Quoted 25 lines
---
 drivers/gpu/ipu-v3/ipu-image-convert.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/gpu/ipu-v3/ipu-image-convert.c +2 -6
index aa1d4b6d278f..5f730cd6009d 100644
@@ -1021,11 +1021,8 @@ static int calc_tile_offsets_planar(struct ipu_image_convert_ctx *ctx,
 
                        u_off = y_size - y_off + uv_off;
                        v_off = (fmt->uv_packed) ? 0 : u_off + uv_size;
-                       if (fmt->uv_swapped) {
-                               tmp = u_off;
-                               u_off = v_off;
-                               v_off = tmp;
-                       }
+                       if (fmt->uv_swapped)
+                               swap(u_off, v_off);
 
                        image->tile[tile].offset = y_off;
                        image->tile[tile].u_off = u_off;
--

2.25.1