libsepol/cil: move the fuzz target and build script to the selinux repository
PATCH 1/1 libsepol/cil: move the fuzz target and build script to the selinux repository
It should make it easier to reproduce bugs found by OSS-Fuzz locally without docker. The fuzz target can be built and run with the corpus OSS-Fuzz has accumulated so far by running the following commands:
``` ./scripts/oss-fuzz.sh wget https://storage.googleapis.com/selinux-backup.clusterfuzz-external.appspot.com/corpus/libFuzzer/selinux_secilc-fuzzer/public.zip unzip -d CORPUS public.zip ./out/secilc-fuzzer CORPUS/ ```
It was tested in https://github.com/google/oss-fuzz/pull/6026
by pointing OSS-Fuzz to the branch containing the patch and running all the tests with all the sanitizers and fuzzing engines
there: https://github.com/google/oss-fuzz/actions/runs/1024673143
--- libsepol/fuzz/secilc-fuzzer.c | 69 +++++++++++++++++++++++++++++++++++ scripts/oss-fuzz.sh | 28 ++++++++++++++ 2 files changed, 97 insertions(+) create mode 100644 libsepol/fuzz/secilc-fuzzer.c create mode 100755 scripts/oss-fuzz.sh
libsepol/fuzz/secilc-fuzzer.c new file +69 -0
@@ -0,0 +1,69 @@ +#include <stdlib.h> +#include <stdio.h> +#include <stdint.h> +#include <string.h> +#include <getopt.h> +#include <sys/stat.h> + +#include <sepol/cil/cil.h> +#include <sepol/policydb.h> + +int LLVMFuzzerTestOneInput (const uint8_t *data,size_t size) { +enum cil_log_level log_level =CIL_ERR ; +struct sepol_policy_file *pf =NULL ; +FILE *dev_null =NULL ; +int target =SEPOL_TARGET_SELINUX ; +int disable_dontaudit =0 ; +int multiple_decls =0 ; +int disable_neverallow =0 ; +int preserve_tunables =0 ; +int policyvers =POLICYDB_VERSION_MAX ; +int mls =-1 ; +int attrs_expand_generated =0 ; +struct cil_db *db =NULL ; +sepol_policydb_t *pdb =NULL ; + +cil_set_log_level (log_level); + +cil_db_init (&db); +cil_set_disable_dontaudit (db, disable_dontaudit); +cil_set_multiple_decls (db, multiple_decls); +cil_set_disable_neverallow (db, disable_neverallow); +cil_set_preserve_tunables (db, preserve_tunables); +cil_set_mls (db, mls); +cil_set_target_platform (db, target); +cil_set_policy_version (db, policyvers); +cil_set_attrs_expand_generated (db, attrs_expand_generated); + +if (cil_add_file (db,"fuzz" , (const char *)data, size) !=SEPOL_OK ) + goto exit; + +if (cil_compile (db) !=SEPOL_OK ) + goto exit; + +if (cil_build_policydb (db, &pdb) !=SEPOL_OK ) + goto exit; + +if (sepol_policydb_optimize (pdb) !=SEPOL_OK ) + goto exit; + + dev_null =fopen ("/dev/null" ,"w" ); +if (dev_null ==NULL ) + goto exit; + +if (sepol_policy_file_create (&pf) !=0 ) + goto exit; + +sepol_policy_file_set_fp (pf, dev_null); + +if (sepol_policydb_write (pdb, pf) !=0 ) + goto exit; +exit: +if (dev_null !=NULL ) +fclose (dev_null); + +cil_db_destroy (&db); +sepol_policydb_free (pdb); +sepol_policy_file_free (pf); +return 0 ; +}
scripts/oss-fuzz.sh new file +28 -0
@@ -0,0 +1,28 @@ +#!/bin/bash + +set -eux + +export DESTDIR=$(pwd)/DESTDIR + +SANITIZER=${SANITIZER:-address} +flags="-O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=$SANITIZER -fsanitize=fuzzer-no-link" + +export CC=${CC:-clang} +export CFLAGS=${CFLAGS:-$flags} + +export CXX=${CXX:-clang++} +export CXXFLAGS=${CXXFLAGS:-$flags} + +export LDFLAGS="${LDFLAGS:-} $CFLAGS" + +export OUT=${OUT:-$(pwd)/out} +mkdir -p $OUT + +export LIB_FUZZING_ENGINE=${LIB_FUZZING_ENGINE:--fsanitize=fuzzer} + +find -name Makefile | xargs sed -i 's/,-z,defs//' +make V=1 -j$(nproc) install + +$CC $CFLAGS -I$DESTDIR/usr/include -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -c -o secilc-fuzzer.o libsepol/fuzz/secilc-fuzzer.c +$CXX $CXXFLAGS $LIB_FUZZING_ENGINE secilc-fuzzer.o $DESTDIR/usr/lib/libsepol.a -o $OUT/secilc-fuzzer +zip -r $OUT/secilc-fuzzer_seed_corpus.zip secilc/test
Signature · 1 line
2.31.1
Quoted 10 lines · Evgeny Vereshchagin
It should make it easier to reproduce bugs found by OSS-Fuzz locally without docker. The fuzz target can be built and run with the corpus OSS-Fuzz has accumulated so far by running the following commands:
``` ./scripts/oss-fuzz.sh wget https://storage.googleapis.com/selinux-backup.clusterfuzz-external.appspot.com/corpus/libFuzzer/selinux_secilc-fuzzer/public.zip unzip -d CORPUS public.zip ./out/secilc-fuzzer CORPUS/ ```
Hello,
Thanks for this patch! I have a couple of comments to improve it.
First, the instructions you gave (with wget + unzip) are useful and in my humble opinion, they could be documented for example in a comment at the beginning of scripts/oss-fuzz.sh ("# Usage: ...").
Second, shellcheck (https://www.shellcheck.net/) reports many warnings, such as missing quotes:
In scripts/oss-fuzz.sh line 19:
mkdir -p $OUT
^--^ SC2086: Double quote to prevent globbing and word splitting.
Even though naming directories with spaces breaks many tools, it is good practice to avoid introducing more breakage, which is why quoting paths is required. Could you please take a look at shellcheck output and fix the issues it identifies?
More comments below...
Quoted 94 lines
It was tested in https://github.com/google/oss-fuzz/pull/6026
by pointing OSS-Fuzz to the branch containing the patch and running all the tests with all the sanitizers and fuzzing engines
there: https://github.com/google/oss-fuzz/actions/runs/1024673143Signed-off-by Evgeny Vereshchagin <[email protected]>--- libsepol/fuzz/secilc-fuzzer.c | 69 +++++++++++++++++++++++++++++++++++ scripts/oss-fuzz.sh | 28 ++++++++++++++ 2 files changed, 97 insertions(+) create mode 100644 libsepol/fuzz/secilc-fuzzer.c create mode 100755 scripts/oss-fuzz.shlibsepol/fuzz/secilc-fuzzer.c new file +69
-0@@ -0,0 +1,69 @@ +#include <stdlib.h> +#include <stdio.h> +#include <stdint.h> +#include <string.h> +#include <getopt.h> +#include <sys/stat.h> + +#include <sepol/cil/cil.h> +#include <sepol/policydb.h> + +int LLVMFuzzerTestOneInput (const uint8_t *data,size_t size) { +enum cil_log_level log_level =CIL_ERR ; +struct sepol_policy_file *pf =NULL ; +FILE *dev_null =NULL ; +int target =SEPOL_TARGET_SELINUX ; +int disable_dontaudit =0 ; +int multiple_decls =0 ; +int disable_neverallow =0 ; +int preserve_tunables =0 ; +int policyvers =POLICYDB_VERSION_MAX ; +int mls =-1 ; +int attrs_expand_generated =0 ; +struct cil_db *db =NULL ; +sepol_policydb_t *pdb =NULL ; + +cil_set_log_level (log_level); + +cil_db_init (&db); +cil_set_disable_dontaudit (db, disable_dontaudit); +cil_set_multiple_decls (db, multiple_decls); +cil_set_disable_neverallow (db, disable_neverallow); +cil_set_preserve_tunables (db, preserve_tunables); +cil_set_mls (db, mls); +cil_set_target_platform (db, target); +cil_set_policy_version (db, policyvers); +cil_set_attrs_expand_generated (db, attrs_expand_generated); + +if (cil_add_file (db,"fuzz" , (const char *)data, size) !=SEPOL_OK ) + goto exit; + +if (cil_compile (db) !=SEPOL_OK ) + goto exit; + +if (cil_build_policydb (db, &pdb) !=SEPOL_OK ) + goto exit; + +if (sepol_policydb_optimize (pdb) !=SEPOL_OK ) + goto exit; + + dev_null =fopen ("/dev/null" ,"w" ); +if (dev_null ==NULL ) + goto exit; + +if (sepol_policy_file_create (&pf) !=0 ) + goto exit; + +sepol_policy_file_set_fp (pf, dev_null); + +if (sepol_policydb_write (pdb, pf) !=0 ) + goto exit; +exit: +if (dev_null !=NULL ) +fclose (dev_null); + +cil_db_destroy (&db); +sepol_policydb_free (pdb); +sepol_policy_file_free (pf); +return 0 ; +}scripts/oss-fuzz.sh new file +0
-0
scripts/oss-fuzz.sh line 5
Quoted 5 lines
scripts/oss-fuzz.sh new file +5
-0@@ -0,0 +1,28 @@ +#!/bin/bash + +set -eux + +export DESTDIR=$(pwd)/DESTDIR
It is strange that $OUT is configurable but not $DESTDIR. Please add a way to specify DESTDIR too.
scripts/oss-fuzz.sh line 16
Quoted 11 lines
scripts/oss-fuzz.sh new file +11
-0+ +SANITIZER=${SANITIZER:-address} +flags="-O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=$SANITIZER -fsanitize=fuzzer-no-link" + +export CC=${CC:-clang} +export CFLAGS=${CFLAGS:-$flags} + +export CXX=${CXX:-clang++} +export CXXFLAGS=${CXXFLAGS:-$flags} + +export LDFLAGS="${LDFLAGS:-} $CFLAGS"
Why do you need to include CFLAGS in LDFLAGS?
scripts/oss-fuzz.sh line 23
Quoted 7 lines
scripts/oss-fuzz.sh new file +7
-0+ +export OUT=${OUT:-$(pwd)/out} +mkdir -p $OUT + +export LIB_FUZZING_ENGINE=${LIB_FUZZING_ENGINE:--fsanitize=fuzzer} + +find -name Makefile | xargs sed -i 's/,-z,defs//'
This is horrible for two reasons: it touches libsemanage/src/Makefile even though the fuzzer only needs libsepol, and it modifies in-place files which are versionned (with git).
I understand the issue you are trying to fix here is that building with sanitizers leads to undefined symbols, but there are other options:
* The most straightforward one is to prevent make from setting the variable which adds "-z,defs", by building with "make ... LD_SONAME_FLAGS="
* Another one consists in introducing a new Makefile variable, for example named "ALLOW_UNDEFINED_SYMBOLS" and to modify the Makefiles to only add -z,defs when this option is not defined.
scripts/oss-fuzz.sh line 24
Quoted 1 line
scripts/oss-fuzz.sh new file +1
-0+make V=1 -j$(nproc) install
You do not need to build every sub-project. You can restrict the build to libsepol with "make -C libsepol ...".
Moreover if the script is being launched from scripts/ ("cd scripts && ./oss-fuzz.sh") this does not work. If you intend to be run from the root directory, please insert a command which changes to the root directory somewhere, like:
cd "$(dirname -- "$0")/.."
Or (if you do not want to chdir) please use a reference to this base directory when you are using make and when you are compiling files.
Moreover if libsepol was already built, "make" will not rebuild it even if the compiling option changed. Adding "make -C libsepol clean" before invoking make could be useful.
scripts/oss-fuzz.sh line 27
Quoted 3 lines
scripts/oss-fuzz.sh new file +3
-0+ +$CC $CFLAGS -I$DESTDIR/usr/include -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -c -o secilc-fuzzer.o libsepol/fuzz/secilc-fuzzer.c +$CXX $CXXFLAGS $LIB_FUZZING_ENGINE secilc-fuzzer.o $DESTDIR/usr/lib/libsepol.a -o $OUT/secilc-fuzzer
Why are you using a C++ compiler to link the files? To my knowledge, the fuzzing/sanitizing options available to clang++ linker are the same as with clang. It would make the script easier to use if only one compiler was used, but you have a reason to prefer using clang++, please add a comment (in the script) about this.
Quoted 4 lines
scripts/oss-fuzz.sh new file +1
-1+zip -r $OUT/secilc-fuzzer_seed_corpus.zip secilc/test --2.31.1
So I believe there are few things to improve in your patch. If you have questions or if you disagree with some of my comments, feel free to discuss. (And if other SELinux maintainers/members want to comment, feel free to do so too ;) ).
Thanks,
Nicolas
PATCH v2 1/1 libsepol/cil: move the fuzz target and build script to the selinux repository
It should make it easier to reproduce bugs found by OSS-Fuzz locally without docker. The fuzz target can be built and run with the corpus OSS-Fuzz has accumulated so far by running the following commands:
``` ./scripts/oss-fuzz.sh wget https://storage.googleapis.com/selinux-backup.clusterfuzz-external.appspot.com/corpus/libFuzzer/selinux_secilc-fuzzer/public.zip unzip -d CORPUS public.zip ./out/secilc-fuzzer CORPUS/ ```
It was tested in https://github.com/google/oss-fuzz/pull/6026
by pointing OSS-Fuzz to the branch containing the patch and running all the tests with all the sanitizers and fuzzing engines
there: https://github.com/google/oss-fuzz/actions/runs/1024673143
[v2]
[1] oss-fuzz: make shellcheck happy
[2] oss-fuzz: build libsepol only
The fuzz target covers libsepol so it's unnecessary to build everything else. Apart from that, the "LDFLAGS" kludge was removed since libsepol is compatible with the sanitizers flags passed via CFLAGS only. It should be brought back one way or another eventually though to fix build failures like
``` clang -L/home/vagrant/selinux/selinux/DESTDIR/usr/lib -L/home/vagrant/selinux/selinux/DESTDIR/usr/lib -L../src sefcontext_compile.o ../src/regex.o -lselinux -lpcre ../src/libselinux.a -lsepol -o sefcontext_compile /usr/bin/ld: sefcontext_compile.o: in function `usage': /home/vagrant/selinux/selinux/libselinux/utils/sefcontext_compile.c:271: undefined reference to `__asan_report_load8' /usr/bin/ld: /home/vagrant/selinux/selinux/libselinux/utils/sefcontext_compile.c:292: undefined reference to `__asan_handle_no_return' /usr/bin/ld: sefcontext_compile.o: in function `asan.module_ctor': ```
[3] oss-fuzz: make it possible to run the script more than once by removing various build artifacts
[4] oss-fuzz: make it possible to run the script from any directory
[5] oss-fuzz: be a little bit more specific about what the script does
[6] oss-fuzz: stop overwriting all the Makefiles
--- libsepol/fuzz/secilc-fuzzer.c | 69 +++++++++++++++++++++++++++++++++++ scripts/oss-fuzz.sh | 59 ++++++++++++++++++++++++++++++ 2 files changed, 128 insertions(+) create mode 100644 libsepol/fuzz/secilc-fuzzer.c create mode 100755 scripts/oss-fuzz.sh
libsepol/fuzz/secilc-fuzzer.c new file +69 -0
@@ -0,0 +1,69 @@ +#include <stdlib.h> +#include <stdio.h> +#include <stdint.h> +#include <string.h> +#include <getopt.h> +#include <sys/stat.h> + +#include <sepol/cil/cil.h> +#include <sepol/policydb.h> + +int LLVMFuzzerTestOneInput (const uint8_t *data,size_t size) { +enum cil_log_level log_level =CIL_ERR ; +struct sepol_policy_file *pf =NULL ; +FILE *dev_null =NULL ; +int target =SEPOL_TARGET_SELINUX ; +int disable_dontaudit =0 ; +int multiple_decls =0 ; +int disable_neverallow =0 ; +int preserve_tunables =0 ; +int policyvers =POLICYDB_VERSION_MAX ; +int mls =-1 ; +int attrs_expand_generated =0 ; +struct cil_db *db =NULL ; +sepol_policydb_t *pdb =NULL ; + +cil_set_log_level (log_level); + +cil_db_init (&db); +cil_set_disable_dontaudit (db, disable_dontaudit); +cil_set_multiple_decls (db, multiple_decls); +cil_set_disable_neverallow (db, disable_neverallow); +cil_set_preserve_tunables (db, preserve_tunables); +cil_set_mls (db, mls); +cil_set_target_platform (db, target); +cil_set_policy_version (db, policyvers); +cil_set_attrs_expand_generated (db, attrs_expand_generated); + +if (cil_add_file (db,"fuzz" , (const char *)data, size) !=SEPOL_OK ) + goto exit; + +if (cil_compile (db) !=SEPOL_OK ) + goto exit; + +if (cil_build_policydb (db, &pdb) !=SEPOL_OK ) + goto exit; + +if (sepol_policydb_optimize (pdb) !=SEPOL_OK ) + goto exit; + + dev_null =fopen ("/dev/null" ,"w" ); +if (dev_null ==NULL ) + goto exit; + +if (sepol_policy_file_create (&pf) !=0 ) + goto exit; + +sepol_policy_file_set_fp (pf, dev_null); + +if (sepol_policydb_write (pdb, pf) !=0 ) + goto exit; +exit: +if (dev_null !=NULL ) +fclose (dev_null); + +cil_db_destroy (&db); +sepol_policydb_free (pdb); +sepol_policy_file_free (pf); +return 0 ; +}
scripts/oss-fuzz.sh new file +59 -0
59 lines not on this page · raw message
Signature · 1 line
2.31.1
Quoted 37 lines · Evgeny Vereshchagin
It should make it easier to reproduce bugs found by OSS-Fuzz locally without docker. The fuzz target can be built and run with the corpus OSS-Fuzz has accumulated so far by running the following commands:
``` ./scripts/oss-fuzz.sh wget https://storage.googleapis.com/selinux-backup.clusterfuzz-external.appspot.com/corpus/libFuzzer/selinux_secilc-fuzzer/public.zip unzip -d CORPUS public.zip ./out/secilc-fuzzer CORPUS/ ```It was tested in https://github.com/google/oss-fuzz/pull/6026
by pointing OSS-Fuzz to the branch containing the patch and running all the tests with all the sanitizers and fuzzing engines
there: https://github.com/google/oss-fuzz/actions/runs/1024673143[v2]
[1] oss-fuzz: make shellcheck happy[2] oss-fuzz: build libsepol only
The fuzz target covers libsepol so it's unnecessary to build everything else. Apart from that, the "LDFLAGS" kludge was removed since libsepol is compatible with the sanitizers flags passed via CFLAGS only. It should be brought back one way or another eventually though to fix build failures like
``` clang -L/home/vagrant/selinux/selinux/DESTDIR/usr/lib -L/home/vagrant/selinux/selinux/DESTDIR/usr/lib -L../src sefcontext_compile.o ../src/regex.o -lselinux -lpcre ../src/libselinux.a -lsepol -o sefcontext_compile /usr/bin/ld: sefcontext_compile.o: in function `usage': /home/vagrant/selinux/selinux/libselinux/utils/sefcontext_compile.c:271: undefined reference to `__asan_report_load8' /usr/bin/ld: /home/vagrant/selinux/selinux/libselinux/utils/sefcontext_compile.c:292: undefined reference to `__asan_handle_no_return' /usr/bin/ld: sefcontext_compile.o: in function `asan.module_ctor': ```[3] oss-fuzz: make it possible to run the script more than once by removing various build artifacts
Quoted 7 lines
[4] oss-fuzz: make it possible to run the script from any directory
[5] oss-fuzz: be a little bit more specific about what the script does
[6] oss-fuzz: stop overwriting all the Makefiles
Signed-off-by Evgeny Vereshchagin <[email protected]>
Sorry for the delay. I have now been able to review and test your script and it seems to work perfectly. Thanks!
Thanks,
Nicolas
Quoted 150 lines
--- libsepol/fuzz/secilc-fuzzer.c | 69 +++++++++++++++++++++++++++++++++++ scripts/oss-fuzz.sh | 59 ++++++++++++++++++++++++++++++ 2 files changed, 128 insertions(+) create mode 100644 libsepol/fuzz/secilc-fuzzer.c create mode 100755 scripts/oss-fuzz.shlibsepol/fuzz/secilc-fuzzer.c new file +69
-0@@ -0,0 +1,69 @@ +#include <stdlib.h> +#include <stdio.h> +#include <stdint.h> +#include <string.h> +#include <getopt.h> +#include <sys/stat.h> + +#include <sepol/cil/cil.h> +#include <sepol/policydb.h> + +int LLVMFuzzerTestOneInput (const uint8_t *data,size_t size) { +enum cil_log_level log_level =CIL_ERR ; +struct sepol_policy_file *pf =NULL ; +FILE *dev_null =NULL ; +int target =SEPOL_TARGET_SELINUX ; +int disable_dontaudit =0 ; +int multiple_decls =0 ; +int disable_neverallow =0 ; +int preserve_tunables =0 ; +int policyvers =POLICYDB_VERSION_MAX ; +int mls =-1 ; +int attrs_expand_generated =0 ; +struct cil_db *db =NULL ; +sepol_policydb_t *pdb =NULL ; + +cil_set_log_level (log_level); + +cil_db_init (&db); +cil_set_disable_dontaudit (db, disable_dontaudit); +cil_set_multiple_decls (db, multiple_decls); +cil_set_disable_neverallow (db, disable_neverallow); +cil_set_preserve_tunables (db, preserve_tunables); +cil_set_mls (db, mls); +cil_set_target_platform (db, target); +cil_set_policy_version (db, policyvers); +cil_set_attrs_expand_generated (db, attrs_expand_generated); + +if (cil_add_file (db,"fuzz" , (const char *)data, size) !=SEPOL_OK ) + goto exit; + +if (cil_compile (db) !=SEPOL_OK ) + goto exit; + +if (cil_build_policydb (db, &pdb) !=SEPOL_OK ) + goto exit; + +if (sepol_policydb_optimize (pdb) !=SEPOL_OK ) + goto exit; + + dev_null =fopen ("/dev/null" ,"w" ); +if (dev_null ==NULL ) + goto exit; + +if (sepol_policy_file_create (&pf) !=0 ) + goto exit; + +sepol_policy_file_set_fp (pf, dev_null); + +if (sepol_policydb_write (pdb, pf) !=0 ) + goto exit; +exit: +if (dev_null !=NULL ) +fclose (dev_null); + +cil_db_destroy (&db); +sepol_policydb_free (pdb); +sepol_policy_file_free (pf); +return 0 ; +}scripts/oss-fuzz.sh new file +59
-1@@ -0,0 +1,59 @@ +#!/bin/bash + +# The script is used to build the fuzz targets run on ClusterFuzz. It has to be +# compatible with the "build.sh" script described at +# https://google.github.io/oss-fuzz/getting-started/new-project-guide/#buildsh +# More precisely, it should use environment variables like OUT, LIB_FUZZING_ENGINE +# and so on (https://google.github.io/oss-fuzz/getting-started/new-project-guide/#buildsh-script-environment), +# and the fuzz targets have to be linked with $CXX even though the project is written +# in C: https://google.github.io/oss-fuzz/getting-started/new-project-guide/#Requirements + +# To make it easier to build the fuzz targets locally, the script can also work in "local" +# mode. To run secilc-fuzzer against a test case (named, say, CRASH) triggering an issue +# the following commands should be run +# +# $ ./scripts/oss-fuzz.sh +# $ ./out/secilc-fuzzer CRASH + +# To run the fuzzer against the corpus OSS-Fuzz has accumulated so far it should be +# downloaded, unpacked and passed to the fuzzer: +# +# $ wget https://storage.googleapis.com/selinux-backup.clusterfuzz-external.appspot.com/corpus/libFuzzer/selinux_secilc-fuzzer/public.zip +# $ unzip -d CORPUS public.zip +# $ ./out/secilc-fuzzer CORPUS/ + +set -eux + +cd "$(dirname -- "$0")/.." + +export DESTDIR=${DESTDIR:-$(pwd)/DESTDIR} + +SANITIZER=${SANITIZER:-address} +flags="-O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=$SANITIZER -fsanitize=fuzzer-no-link" + +export CC=${CC:-clang} +export CFLAGS=${CFLAGS:-$flags} + +export CXX=${CXX:-clang++} +export CXXFLAGS=${CXXFLAGS:-$flags} + +export OUT=${OUT:-$(pwd)/out} +mkdir -p "$OUT" + +export LIB_FUZZING_ENGINE=${LIB_FUZZING_ENGINE:--fsanitize=fuzzer} + +rm -rf "$DESTDIR" +make -C libsepol clean +# LIBSO and LIBMAP shouldn't be expanded here because their values are unknown until Makefile +# has been read by make +# shellcheck disable=SC2016 +make -C libsepol V=1 LD_SONAME_FLAGS='-soname,$(LIBSO),--version-script=$(LIBMAP)' -j"$(nproc)" install + +# CFLAGS, CXXFLAGS and LIB_FUZZING_ENGINE have to be split to be accepted by +# the compiler/linker so they shouldn't be quoted +# shellcheck disable=SC2086 +$CC $CFLAGS -I"$DESTDIR/usr/include" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -c -o secilc-fuzzer.o libsepol/fuzz/secilc-fuzzer.c +# shellcheck disable=SC2086 +$CXX $CXXFLAGS $LIB_FUZZING_ENGINE secilc-fuzzer.o "$DESTDIR/usr/lib/libsepol.a" -o "$OUT/secilc-fuzzer" + +zip -r "$OUT/secilc-fuzzer_seed_corpus.zip" secilc/test --2.31.1
Quoted 43 lines · Nicolas Iooss
Quoted 41 lines · Evgeny Vereshchagin
It should make it easier to reproduce bugs found by OSS-Fuzz locally without docker. The fuzz target can be built and run with the corpus OSS-Fuzz has accumulated so far by running the following commands:
``` ./scripts/oss-fuzz.sh wget https://storage.googleapis.com/selinux-backup.clusterfuzz-external.appspot.com/corpus/libFuzzer/selinux_secilc-fuzzer/public.zip unzip -d CORPUS public.zip ./out/secilc-fuzzer CORPUS/ ```It was tested in https://github.com/google/oss-fuzz/pull/6026
by pointing OSS-Fuzz to the branch containing the patch and running all the tests with all the sanitizers and fuzzing engines
there: https://github.com/google/oss-fuzz/actions/runs/1024673143[v2]
[1] oss-fuzz: make shellcheck happy[2] oss-fuzz: build libsepol only
The fuzz target covers libsepol so it's unnecessary to build everything else. Apart from that, the "LDFLAGS" kludge was removed since libsepol is compatible with the sanitizers flags passed via CFLAGS only. It should be brought back one way or another eventually though to fix build failures like
``` clang -L/home/vagrant/selinux/selinux/DESTDIR/usr/lib -L/home/vagrant/selinux/selinux/DESTDIR/usr/lib -L../src sefcontext_compile.o ../src/regex.o -lselinux -lpcre ../src/libselinux.a -lsepol -o sefcontext_compile /usr/bin/ld: sefcontext_compile.o: in function `usage': /home/vagrant/selinux/selinux/libselinux/utils/sefcontext_compile.c:271: undefined reference to `__asan_report_load8' /usr/bin/ld: /home/vagrant/selinux/selinux/libselinux/utils/sefcontext_compile.c:292: undefined reference to `__asan_handle_no_return' /usr/bin/ld: sefcontext_compile.o: in function `asan.module_ctor': ```[3] oss-fuzz: make it possible to run the script more than once by removing various build artifacts
[4] oss-fuzz: make it possible to run the script from any directory
[5] oss-fuzz: be a little bit more specific about what the script does
Quoted 9 lines
Quoted 3 lines
[6] oss-fuzz: stop overwriting all the Makefiles
Signed-off-by Evgeny Vereshchagin <[email protected]>Sorry for the delay. I have now been able to review and test your script and it seems to work perfectly. Thanks!
Acked-by Nicolas Iooss <[email protected]>
Merged.
Thanks,
Jim
Quoted 154 lines
Thanks,
NicolasQuoted 150 lines
--- libsepol/fuzz/secilc-fuzzer.c | 69 +++++++++++++++++++++++++++++++++++ scripts/oss-fuzz.sh | 59 ++++++++++++++++++++++++++++++ 2 files changed, 128 insertions(+) create mode 100644 libsepol/fuzz/secilc-fuzzer.c create mode 100755 scripts/oss-fuzz.shlibsepol/fuzz/secilc-fuzzer.c new file +69
-0@@ -0,0 +1,69 @@ +#include <stdlib.h> +#include <stdio.h> +#include <stdint.h> +#include <string.h> +#include <getopt.h> +#include <sys/stat.h> + +#include <sepol/cil/cil.h> +#include <sepol/policydb.h> + +int LLVMFuzzerTestOneInput (const uint8_t *data,size_t size) { +enum cil_log_level log_level =CIL_ERR ; +struct sepol_policy_file *pf =NULL ; +FILE *dev_null =NULL ; +int target =SEPOL_TARGET_SELINUX ; +int disable_dontaudit =0 ; +int multiple_decls =0 ; +int disable_neverallow =0 ; +int preserve_tunables =0 ; +int policyvers =POLICYDB_VERSION_MAX ; +int mls =-1 ; +int attrs_expand_generated =0 ; +struct cil_db *db =NULL ; +sepol_policydb_t *pdb =NULL ; + +cil_set_log_level (log_level); + +cil_db_init (&db); +cil_set_disable_dontaudit (db, disable_dontaudit); +cil_set_multiple_decls (db, multiple_decls); +cil_set_disable_neverallow (db, disable_neverallow); +cil_set_preserve_tunables (db, preserve_tunables); +cil_set_mls (db, mls); +cil_set_target_platform (db, target); +cil_set_policy_version (db, policyvers); +cil_set_attrs_expand_generated (db, attrs_expand_generated); + +if (cil_add_file (db,"fuzz" , (const char *)data, size) !=SEPOL_OK ) + goto exit; + +if (cil_compile (db) !=SEPOL_OK ) + goto exit; + +if (cil_build_policydb (db, &pdb) !=SEPOL_OK ) + goto exit; + +if (sepol_policydb_optimize (pdb) !=SEPOL_OK ) + goto exit; + + dev_null =fopen ("/dev/null" ,"w" ); +if (dev_null ==NULL ) + goto exit; + +if (sepol_policy_file_create (&pf) !=0 ) + goto exit; + +sepol_policy_file_set_fp (pf, dev_null); + +if (sepol_policydb_write (pdb, pf) !=0 ) + goto exit; +exit: +if (dev_null !=NULL ) +fclose (dev_null); + +cil_db_destroy (&db); +sepol_policydb_free (pdb); +sepol_policy_file_free (pf); +return 0 ; +}scripts/oss-fuzz.sh new file +59
-1@@ -0,0 +1,59 @@ +#!/bin/bash + +# The script is used to build the fuzz targets run on ClusterFuzz. It has to be +# compatible with the "build.sh" script described at +# https://google.github.io/oss-fuzz/getting-started/new-project-guide/#buildsh +# More precisely, it should use environment variables like OUT, LIB_FUZZING_ENGINE +# and so on (https://google.github.io/oss-fuzz/getting-started/new-project-guide/#buildsh-script-environment), +# and the fuzz targets have to be linked with $CXX even though the project is written +# in C: https://google.github.io/oss-fuzz/getting-started/new-project-guide/#Requirements + +# To make it easier to build the fuzz targets locally, the script can also work in "local" +# mode. To run secilc-fuzzer against a test case (named, say, CRASH) triggering an issue +# the following commands should be run +# +# $ ./scripts/oss-fuzz.sh +# $ ./out/secilc-fuzzer CRASH + +# To run the fuzzer against the corpus OSS-Fuzz has accumulated so far it should be +# downloaded, unpacked and passed to the fuzzer: +# +# $ wget https://storage.googleapis.com/selinux-backup.clusterfuzz-external.appspot.com/corpus/libFuzzer/selinux_secilc-fuzzer/public.zip +# $ unzip -d CORPUS public.zip +# $ ./out/secilc-fuzzer CORPUS/ + +set -eux + +cd "$(dirname -- "$0")/.." + +export DESTDIR=${DESTDIR:-$(pwd)/DESTDIR} + +SANITIZER=${SANITIZER:-address} +flags="-O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=$SANITIZER -fsanitize=fuzzer-no-link" + +export CC=${CC:-clang} +export CFLAGS=${CFLAGS:-$flags} + +export CXX=${CXX:-clang++} +export CXXFLAGS=${CXXFLAGS:-$flags} + +export OUT=${OUT:-$(pwd)/out} +mkdir -p "$OUT" + +export LIB_FUZZING_ENGINE=${LIB_FUZZING_ENGINE:--fsanitize=fuzzer} + +rm -rf "$DESTDIR" +make -C libsepol clean +# LIBSO and LIBMAP shouldn't be expanded here because their values are unknown until Makefile +# has been read by make +# shellcheck disable=SC2016 +make -C libsepol V=1 LD_SONAME_FLAGS='-soname,$(LIBSO),--version-script=$(LIBMAP)' -j"$(nproc)" install + +# CFLAGS, CXXFLAGS and LIB_FUZZING_ENGINE have to be split to be accepted by +# the compiler/linker so they shouldn't be quoted +# shellcheck disable=SC2086 +$CC $CFLAGS -I"$DESTDIR/usr/include" -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -c -o secilc-fuzzer.o libsepol/fuzz/secilc-fuzzer.c +# shellcheck disable=SC2086 +$CXX $CXXFLAGS $LIB_FUZZING_ENGINE secilc-fuzzer.o "$DESTDIR/usr/lib/libsepol.a" -o "$OUT/secilc-fuzzer" + +zip -r "$OUT/secilc-fuzzer_seed_corpus.zip" secilc/test --2.31.1